From patchwork Sat Jan 28 00:37:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Srivatsa S. Bhat" X-Patchwork-Id: 49760 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1125447wrn; Fri, 27 Jan 2023 16:57:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXs/cDPD7lyNFc8MgZXFSzoNTbVoKuL7oueDXp0ByCazIm30BtKcdUQZ005P5mlrwvcd4LGp X-Received: by 2002:a05:6a20:2d12:b0:b5:97de:d7e7 with SMTP id g18-20020a056a202d1200b000b597ded7e7mr44954074pzl.18.1674867459858; Fri, 27 Jan 2023 16:57:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674867459; cv=none; d=google.com; s=arc-20160816; b=A/Lb54u5AJCQrb72M22L4OUZpNtxAvZB0SFLarz+P5TVF5XY9elOZ1hvtk9rx4uPzk hJjpxqPNlkM+8nbYit628oMrEiJA9uvic6szDHufhQPSABLL1bJm8+vUDAKV88sm7i+2 bVdgf/Stdqo60+ke6sKBNcnShsjSsIVMvxedkEKqWuVhFm1WeQG/jMGehTaCNBN60U9X 6wZcxSTTyUE243UnemMhp7SAtgV0P+qRJjrK2OtWwa5hjWUTO3kjPHTfiejVXpXSH1nk oKnOTWIqW4r5bJEg7OXDVydJrPmGcrHbU5tj17B9lfjdlHiDxmwk4UEQBYum8vnpi2Dr 4y8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=kQDvEk/GoAvlgKnLGkMIM3gemxoWsZ3ASDD2QUoW62Q=; b=q/Mmj2NS5IOF5WZd6DN1ceBUgJf+PyLZ2xUqVjpn2KQHQ2dxNGJVOVTkZfL42fN2mF rzeb9HKiKu7h1FIKYdjPmygJ3cfSZOEx+Uci5xRW8OPj124ho/5PeBdPiJjLOyPyZzXq DDxhyfnS4+BdQFiJZPlppILFMXkjPz827eoa2tDgoNk5s/ALP/USwRzhqSjNf7msXxAu XJDPzBdn+tUL54St568WHsU/cWBNWghJVj4vDfw4tzbSdnH9zXE+sRLLdqCfZiKmaypR 0oYXcvk2nWCp7DQmdqgRc3Mpn8y7SBxMET11KqJesBIlSHJ+Gz4mcTnnTVFHDIPQFrYh 9hXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v17-20020a63b951000000b004a77afad410si6396398pgo.487.2023.01.27.16.57.27; Fri, 27 Jan 2023 16:57:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233144AbjA1Aip (ORCPT + 99 others); Fri, 27 Jan 2023 19:38:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbjA1Aio (ORCPT ); Fri, 27 Jan 2023 19:38:44 -0500 Received: from outgoing2021.csail.mit.edu (outgoing2021.csail.mit.edu [128.30.2.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AE8C10A; Fri, 27 Jan 2023 16:38:43 -0800 (PST) Received: from [64.186.27.43] (helo=srivatsa-dev.eng.vmware.com) by outgoing2021.csail.mit.edu with esmtpa (Exim 4.95) (envelope-from ) id 1pLZER-000elb-VP; Fri, 27 Jan 2023 19:38:12 -0500 From: "Srivatsa S. Bhat" To: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, peterz@infradead.org, hpa@zytor.com Cc: bp@alien8.de, dave.hansen@linux.intel.com, rafael.j.wysocki@intel.com, paulmck@kernel.org, jgross@suse.com, seanjc@google.com, thomas.lendacky@amd.com, linux-kernel@vger.kernel.org, imammedo@redhat.com, amakhalov@vmware.com, ganb@vmware.com, ankitja@vmware.com, bordoloih@vmware.com, keerthanak@vmware.com, blamoreaux@vmware.com, namit@vmware.com, wyes.karny@amd.com, lewis.carroll@amd.com, pv-drivers@vmware.com, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, srivatsa@csail.mit.edu Subject: [PATCH] x86/hotplug: Remove incorrect comment about mwait_play_dead() Date: Fri, 27 Jan 2023 16:37:51 -0800 Message-Id: <20230128003751.141317-1-srivatsa@csail.mit.edu> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756225821495778393?= X-GMAIL-MSGID: =?utf-8?q?1756225821495778393?= From: "Srivatsa S. Bhat (VMware)" The comment that says mwait_play_dead() returns only on failure is a bit misleading because mwait_play_dead() could actually return for valid reasons (such as mwait not being supported by the platform) that do not indicate a failure of the CPU offline operation. So, remove the comment. Suggested-by: Thomas Gleixner Signed-off-by: Srivatsa S. Bhat (VMware) --- arch/x86/kernel/smpboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 55cad72715d9..9013bb28255a 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1833,7 +1833,7 @@ void native_play_dead(void) play_dead_common(); tboot_shutdown(TB_SHUTDOWN_WFS); - mwait_play_dead(); /* Only returns on failure */ + mwait_play_dead(); if (cpuidle_play_dead()) hlt_play_dead(); }