From patchwork Fri Jan 27 21:27:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 49698 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1052563wrn; Fri, 27 Jan 2023 13:30:11 -0800 (PST) X-Google-Smtp-Source: AK7set+G3sQpMBaDQTux8avdJZek1kh/sCtDCxHubOr13zOSD06u/b9y2/6TBqPfJCoqfZgC8XKF X-Received: by 2002:a17:906:1945:b0:878:625c:c8ff with SMTP id b5-20020a170906194500b00878625cc8ffmr6864777eje.54.1674855011614; Fri, 27 Jan 2023 13:30:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674855011; cv=none; d=google.com; s=arc-20160816; b=IdMz6Tbmb9xMqAJw8xFSidXIJ460T8cblI+vD7NwEZqBVWBtSbo1HAN5bM/twgs2XI kjbllhv3Gx3AYtc9UzohxjePC8RO/R8XaGHXuij6MjWnxM8W/ynqPOB/yfqSYo3h9fyy GSOjhxUeHjptckzo2OkJhZ6dQuOe8reV3P7gN6SGl4QRQLqqcfp4wd5Mvm3JZ9qFiKPB 81V4c5fi3sf+BdAvL08/R7aab9UDXWPmWjqZqkwcVJvkGpsHnHMGG93nhoCrzvsnAqSM URqeD5y/pUWjk8RnjnBmf0Up76RXplx+GmvB5x5eWv7G8hHDm6A97l4ud8TMiFLVORtF kHpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=smuQo4geAWNJOxGHerqBUE4luc859AqeHaJfREjKn6k=; b=uHkAe1WNkQy/v97StTNkYn2xE2fm58PaMTUj6F98GdmSIxx28kfCUnV04JbizaiQtZ W45AwLMIHGhIbzphlmgipWBPr+RK1OXfroWBz1Q8s0PDLSyCLvF3xB6FAPnMiFWXAv1I 3+YqZfyBfvZGapLOCmB4N0Utuo66B3Nv8bM64EDw2uV7O3DGtFuHbSiiuOdYmmgDduhE Qanq2bx1CBAwuhOmssbZHIQWu1Hvc1NuhBohtPFvtvyEENNTTZzYo06TavfTiA/FLBEu Wj6Q85ViWhENiR9p3fiVpgDkQQc9L8iUypRO/FIFJudXU4SpfwbfY3PoJmqdlZEswRrT qYfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YgKFG9jY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r5-20020a170906a20500b0084d43aadb70si6239513ejy.127.2023.01.27.13.29.47; Fri, 27 Jan 2023 13:30:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YgKFG9jY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229731AbjA0V12 (ORCPT + 99 others); Fri, 27 Jan 2023 16:27:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbjA0V10 (ORCPT ); Fri, 27 Jan 2023 16:27:26 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DECC41F930 for ; Fri, 27 Jan 2023 13:27:24 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so6254662wmb.2 for ; Fri, 27 Jan 2023 13:27:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=smuQo4geAWNJOxGHerqBUE4luc859AqeHaJfREjKn6k=; b=YgKFG9jY7x3+04njsrvCicDj6oHs+G5HsblgQCn+sHNibQ60jhn6aQ4BQ0mO9+MIHQ j7ybROVnewB5v0CP99a1dioAZYnIxBpu5IfrtOpZzWbg5TIJnepROS5br8Uc2JwleCvV 1E54MPBd74WQMPkvCfVXqjCBN8CZJgPZMf88oEQ5ytfbETfybFXFw+kFHKoSMNyCUokd BRRJIn3CurAaVkbi6KKWIaQjVCCE8zP3Z5Gu8j0L6RiujPjsUh5wvGhY5duO9Ms6vQsS IbP3MLp4rV0Ju27EDX+Ia+8JJ1C1EoGZydgPHYy1zvcs5GcW7q+2UA6O/tXmj0J2wBqf zIxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=smuQo4geAWNJOxGHerqBUE4luc859AqeHaJfREjKn6k=; b=uv5MGhzu8LU7fGu70Bdf6kAkmFKjVUMJ6Cj3ediry/oIPH4CGLnc+A3KX/rQBhhp3F FI6jHM5eEXbvgLpr20GNnVc4ImQ10zcfCgs+c99c5s0pmAk+Tf7p6S8fqznMqIwCclyD zHIuJKY8F/NPv6TwpAD3hq/Q3atxkcLTggPWdEQZCur/6LY6GUXgx+jJWwzFzdW+YY04 PkVhDChYvLc+oCr5W5EjOOQl310R3xPHdWk09yKi8Uq/Wc5NVQhIwZddK52xsp/IcOl2 y5gHO+n0JRT+EtaGSj+S3WKCR1lMMk3HcwK0zPlZftNTOxkbhmeHSjySflg6HPDh3FNS wlVA== X-Gm-Message-State: AFqh2kplQ7k9j9sxJVx0pIohXP6bYhvDi+NGryrh5jqMBISgSaVI26Ff hu11c17GOScVV5eFUhwsdjO69A== X-Received: by 2002:a7b:c5c4:0:b0:3d7:889:7496 with SMTP id n4-20020a7bc5c4000000b003d708897496mr39599663wmk.17.1674854843408; Fri, 27 Jan 2023 13:27:23 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id d11-20020a05600c3acb00b003db30be4a54sm8645303wms.38.2023.01.27.13.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 13:27:22 -0800 (PST) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: replicant@osuosl.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, =?utf-8?q?Martin_J=C3=BCcker?= , Henrik Grimler , Sam Protsenko , Chanho Park , Marek Szyprowski , Chanwoo Choi , Krzysztof Kozlowski Subject: [RFT PATCH v3 1/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos5250 Date: Fri, 27 Jan 2023 22:27:10 +0100 Message-Id: <20230127212713.267014-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756211950159950353?= X-GMAIL-MSGID: =?utf-8?q?1756212768587864941?= Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node which do not have unit address. Therefore usethe address space of child device (actual DWC3 Controller) as the wrapper's address to fix: exynos5250-smdk5250.dtb: soc: usb3: {'compatible': ['samsung,exynos5250-dwusb3'], ... } should not be valid under {'type': 'object'} exynos5250.dtsi:638.16-653.5: Warning (simple_bus_reg): /soc/usb3: missing or empty reg/ranges property Signed-off-by: Krzysztof Kozlowski Tested-by: Marek Szyprowski --- Changes since v1: 1. Use ranges with values and drop reg from usb-wrapper node. 2. Keep "usb" as wrapper's node name. --- arch/arm/boot/dts/exynos5250.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 97e89859ba3d..a5db4ac213d5 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -635,17 +635,17 @@ i2s2: i2s@12d70000 { #sound-dai-cells = <1>; }; - usbdrd: usb3 { + usbdrd: usb@12000000 { compatible = "samsung,exynos5250-dwusb3"; clocks = <&clock CLK_USB3>; clock-names = "usbdrd30"; #address-cells = <1>; #size-cells = <1>; - ranges; + ranges = <0x0 0x12000000 0x10000>; - usbdrd_dwc3: usb@12000000 { + usbdrd_dwc3: usb@0 { compatible = "snps,dwc3"; - reg = <0x12000000 0x10000>; + reg = <0x0 0x10000>; interrupts = ; phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>; phy-names = "usb2-phy", "usb3-phy"; From patchwork Fri Jan 27 21:27:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 49697 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1052521wrn; Fri, 27 Jan 2023 13:30:05 -0800 (PST) X-Google-Smtp-Source: AK7set+c0WoUSxL7FL9twXI8tGtSw0bNaRJrd7dyIUNEu6zQiPXZd2uUFEC3Tc8cUfdAIXYx/UAX X-Received: by 2002:a17:907:cc9c:b0:87b:d636:c26d with SMTP id up28-20020a170907cc9c00b0087bd636c26dmr2488109ejc.58.1674855005093; Fri, 27 Jan 2023 13:30:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674855005; cv=none; d=google.com; s=arc-20160816; b=Gbnl+PSDpO+O9yzlE8K8fg0KrM8nQCniBiZgR7qAI70sTunSLE+ffNoV2BejwDXmmT r4kC0C9ewpDAtGEwyjqWnpAOApsLWrTuE2bGjgIhHig9yiy5eXXzs5T7NOGu1UHS6p/o 6JAF1gcukmzQyzoEGtL5QVnf8TEZspwdRgLdsqsN0C4qzWPo2e4DNwVVoplmezJI5rEZ DbGrFNenKrjShLmC2TvGtJTg6sWcrJY3VdSaVbVy3jOUQYXyJ5mNfABxUdRQFO2u8Qeo cmt+aIXJynOHCX0WCnsa3kGIkirLIaqr2ZR/NeNXKqOe2cExukeJf4GJCVC5WRHRTKoa ILew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FziN2ciblGO11V/qPlwYKnDFHaO/t/ie6w/sKp8lvIY=; b=j6I3p4/7/fk7y0LhJrNG217gPKZl3IK07dcnjtr5n66nV+kSpY/0ieQDTaXbp6uceh 2YLhuCd3YwFRa1vEiOOeeCdSRz6SLZ7VfSZZ2XY03Bu3dLkSXkqUzVdB8U9sev/cY6QO rnw9hzD+9nw4ypvGWu72MllwWxlj1zhWeolcuemg7Wopy5mC1Ib/Asjhfs8zfkvln7mv h/pjZOjNd81O84wbjciWmeM/rqxk5KgCS61xQ8BX9xFFgvWsvUqELlx50PrmnXdgZfSh 4J3y1AuvnNXQomq4+7S1VCLmBT+FRxniQCVHxaZ0A4Can4V40D3xwPe6qeplAm1u6LPi CQuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=N5guwWJW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id up21-20020a170907cc9500b008650ce2979asi5274714ejc.544.2023.01.27.13.29.41; Fri, 27 Jan 2023 13:30:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=N5guwWJW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230058AbjA0V2A (ORCPT + 99 others); Fri, 27 Jan 2023 16:28:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229757AbjA0V12 (ORCPT ); Fri, 27 Jan 2023 16:27:28 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2CD45254 for ; Fri, 27 Jan 2023 13:27:26 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id j17so4358330wms.0 for ; Fri, 27 Jan 2023 13:27:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FziN2ciblGO11V/qPlwYKnDFHaO/t/ie6w/sKp8lvIY=; b=N5guwWJWen5Q4oVKz/GeT/1TUE+Jw+G7ivy4U93zxbKSKQsjWYIXROOYJMrBIpL5gV SCuvyT0uP4C9iDazVP2GA17mpH08l/fOfm79q8a3qhBYxQzfiS6wWsEzP4Xj6XLq9SJt BFKJd5n6qm3TFZuVu7pjo5e6YjT3CfvU3u7aUXNzInJU0MYOmGLAKH/DFdDvTCqDuB/Z NY4/3J7Ox3ZG53XJxbGvn/+AlkOYZR1SE7OaBtbDGTS/U1NqHzqGSZ0LY9s6VrCk23ht gSyt9CfU6frLCV04WEkyqC+9JrDcj9H5JqujC70oA7sNX+glF90CCZjJ/ne1d0I7AqMB l1cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FziN2ciblGO11V/qPlwYKnDFHaO/t/ie6w/sKp8lvIY=; b=3/iIGOKuhPAkHDWRkDVQh+xrikTANvXEaTWTneXTLUHPwivdc5XK0peKLEL5wjdp9A hSciI8UsVdJ4bVRpqbvDd6FLHxg1nPY4pFHE1rgLxk6AXB8pF/KGI4puvc/jh4zyb8cl E9CApmy7nA57RSI9TOgIb6RwnpWSX4vmSGG6zrlF+2upEdDt6UNtigzMUBtMYZxo720J b8Regg0ZBfNOKJG0HQhaZDaGkhKJXgrUKeAyCCoeYzoZHXtSIyzqQ0DKUsGN6/wi+cVL BFxeMe903gj4fe3gtMXjcntf2s6fDNsU/4jY0DtTvhxxrH5E8tNNyg6HpqJRv+PqceHZ Xiqg== X-Gm-Message-State: AFqh2kqwsPKczyg3zoe+FAgN9WQRQB+yzGr6NcE78QUb3Y6qPnpsKLu2 4u/ClqP6JhBMLIvzxN4DE2/UGw== X-Received: by 2002:a05:600c:1695:b0:3cf:9d32:db67 with SMTP id k21-20020a05600c169500b003cf9d32db67mr41159228wmn.3.1674854845576; Fri, 27 Jan 2023 13:27:25 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id d11-20020a05600c3acb00b003db30be4a54sm8645303wms.38.2023.01.27.13.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 13:27:25 -0800 (PST) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: replicant@osuosl.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, =?utf-8?q?Martin_J=C3=BCcker?= , Henrik Grimler , Sam Protsenko , Chanho Park , Marek Szyprowski , Chanwoo Choi , Krzysztof Kozlowski Subject: [RFT PATCH v3 2/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos54xx Date: Fri, 27 Jan 2023 22:27:11 +0100 Message-Id: <20230127212713.267014-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230127212713.267014-1-krzysztof.kozlowski@linaro.org> References: <20230127212713.267014-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756212761389860763?= X-GMAIL-MSGID: =?utf-8?q?1756212761389860763?= Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node which do not have unit address. Therefore usethe address space of child device (actual DWC3 Controller) as the wrapper's address to fix: exynos5422-odroidhc1.dtb: soc: usb3-0: {'compatible': ['samsung,exynos5250-dwusb3'], ... } should not be valid under {'type': 'object'} exynos54xx.dtsi:145.21-159.5: Warning (simple_bus_reg): /soc/usb3-0: missing or empty reg/ranges property Signed-off-by: Krzysztof Kozlowski Tested-by: Marek Szyprowski --- Changes since v1: 1. Use ranges with values and drop reg from usb-wrapper node. 2. Keep "usb" as wrapper's node name. --- arch/arm/boot/dts/exynos54xx.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi index 3ec43761d8b9..5c799886c275 100644 --- a/arch/arm/boot/dts/exynos54xx.dtsi +++ b/arch/arm/boot/dts/exynos54xx.dtsi @@ -142,15 +142,15 @@ hsi2c_7: i2c@12cd0000 { status = "disabled"; }; - usbdrd3_0: usb3-0 { + usbdrd3_0: usb@12000000 { compatible = "samsung,exynos5250-dwusb3"; #address-cells = <1>; #size-cells = <1>; - ranges; + ranges = <0x0 0x12000000 0x10000>; - usbdrd_dwc3_0: usb@12000000 { + usbdrd_dwc3_0: usb@0 { compatible = "snps,dwc3"; - reg = <0x12000000 0x10000>; + reg = <0x0 0x10000>; interrupts = ; phys = <&usbdrd_phy0 0>, <&usbdrd_phy0 1>; phy-names = "usb2-phy", "usb3-phy"; @@ -164,15 +164,15 @@ usbdrd_phy0: phy@12100000 { #phy-cells = <1>; }; - usbdrd3_1: usb3-1 { + usbdrd3_1: usb@12400000 { compatible = "samsung,exynos5250-dwusb3"; #address-cells = <1>; #size-cells = <1>; - ranges; + ranges = <0x0 0x12400000 0x10000>; - usbdrd_dwc3_1: usb@12400000 { + usbdrd_dwc3_1: usb@0 { compatible = "snps,dwc3"; - reg = <0x12400000 0x10000>; + reg = <0x0 0x10000>; phys = <&usbdrd_phy1 0>, <&usbdrd_phy1 1>; phy-names = "usb2-phy", "usb3-phy"; snps,dis_u3_susphy_quirk; From patchwork Fri Jan 27 21:27:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 49696 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1052472wrn; Fri, 27 Jan 2023 13:29:58 -0800 (PST) X-Google-Smtp-Source: AK7set+qqVqkQStfl7o7y/8UqdPDuLN1F7eQ/GBa34ekHJGiQDqkJmP7AqxogLyCBpuzG3wXENHj X-Received: by 2002:a17:906:8d86:b0:878:5a35:c83b with SMTP id ry6-20020a1709068d8600b008785a35c83bmr7952592ejc.15.1674854998662; Fri, 27 Jan 2023 13:29:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674854998; cv=none; d=google.com; s=arc-20160816; b=ajjlErLh3pZoDnvzoqcfTTrM8waqTQ8B2UJ6lBbl/l6kPAuq0KmHZx4mmC6xOr4aIe AnLuiI8Ll0p7cL/jJPeI9zAj/ms08j5UM6FUD6GBKMUk8u/Zcp+LEiv2NC4gGt2Sz4DH 3NnISqO1w/K1sAGjBvLlcBzFXyxFjM/ZzD9GOisBV4L9qxHkAUpSJO2Kgr/Q6er1IRiR imBbpWKlRYyp2+0GEPAx0Bo71PYcvinx2VJOM6UbFGCJi6QAC6XnvrL0eq71A00e/CjR 1A+KKRBz5N3EzdhkryGVyID9xwA2woizzj3u3DuBNs8U1HlTGjaNFww8pPo2DJQI3SIk rjyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LW3LDw7FGTqoQX2IoeX7+zasLLbTbzH7aQ5hccH1lSE=; b=o0Mz0YjasPnhh+I/qPwFl4aHVnm5Kl0RM8kgP18X53EgnyHT5s7MzA/24drOIdtfM9 +uCVRNOO2MGbtH7tCCsCdyyjsktATDWA43u9gKZQ7GOXSa57gGiMBrG7PpZI98spReLH X2MAUf0s313hqTLOAQh5eSzpjS5mfZ3FWhdPinMMq1sxKv8/jzv7uzCaZjypmnShRQP3 5C4fKkKj4Sxuchxxx+ZzGerZsVoHSG2mYtztRejFEVqQSPRvTf3DCf2i2Dg7zqLJhGBR iRevxgff76CTYMKgVoiXycPsFt+I4+9zkI/IektqShwvt6PfZklynPVHodRuVkiHFCxy ab0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Xo1ER8zi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fg16-20020a1709069c5000b00878507d1764si4922433ejc.929.2023.01.27.13.29.35; Fri, 27 Jan 2023 13:29:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Xo1ER8zi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231588AbjA0V2C (ORCPT + 99 others); Fri, 27 Jan 2023 16:28:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229933AbjA0V13 (ORCPT ); Fri, 27 Jan 2023 16:27:29 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0699828D25 for ; Fri, 27 Jan 2023 13:27:28 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id e19-20020a05600c439300b003db1cac0c1fso6235077wmn.5 for ; Fri, 27 Jan 2023 13:27:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LW3LDw7FGTqoQX2IoeX7+zasLLbTbzH7aQ5hccH1lSE=; b=Xo1ER8zi+03jkZmbTf+qcFtfNTwjewlVDtni+l3Lax5osgm9kzf7nwrDqRguJ7AGgy kXmJqfOBHbwT5iWVVKJN9LwM8ng+cG47Qu8Fw2fRZg8814xKuPxB+Tla7NKkvLPqFvLq /8RxvxP+yHpeSwrO7IwdnE1tdAORhnVDJBEo5EgOjQJenA0/DpYcVT4YfFu8lPLAowao kJk1YzxeEG9k4Obmp90TWxvkPUwBwLGf+BNndb8D5n7vtwbGBIch1Pkd3++WmCqpaNBd xjsmJ6tBkGoNYWaa1RYD4PvV3ZTSBv/TIDTANS+7MBuuOjyVUPzUfea+rQnyhl//FC8o A9JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LW3LDw7FGTqoQX2IoeX7+zasLLbTbzH7aQ5hccH1lSE=; b=tj1s+OZMAt7PEBoA8pJIC/3uWW2JZF0oI8iyBrKIjBAA5YztS/86DyElH5PUe9Ueou eDDY8DZPiLwTGxU4gPoMV4jWnvnTYT/5JcwQ4/r3JfSWqb2GyoyPCiuns5OqfORCpkel 4eZrg0WqpaqAQIcO3JZJ0YN1fRxUKE6dchWClVnvAaKLxBbcMpGq/5Mia25YhJ62ixYW Lj4cqJ5p5faXdVKR9N/MXoPbvCzWIt1aZ8gKGkRzG8LPyOM+H74q4Kxq3CofCYeGS9qJ psDXZetl+jaE4BxN5R7BlNYKBVnaQ68d320PjQcKtwERrrM9p7WRL3q4xeeB6nPf9JM2 nfAg== X-Gm-Message-State: AFqh2kpDkMYUAN9w+YQOhHraKz1WqkGhhqgz44Qe2dt5Y4ZfNcLWoZom JImL5cnQooAVElaNgf08873QUQ== X-Received: by 2002:a05:600c:2d84:b0:3d9:e8b3:57f9 with SMTP id i4-20020a05600c2d8400b003d9e8b357f9mr42431967wmg.8.1674854847608; Fri, 27 Jan 2023 13:27:27 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id d11-20020a05600c3acb00b003db30be4a54sm8645303wms.38.2023.01.27.13.27.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 13:27:27 -0800 (PST) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: replicant@osuosl.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, =?utf-8?q?Martin_J=C3=BCcker?= , Henrik Grimler , Sam Protsenko , Chanho Park , Marek Szyprowski , Chanwoo Choi , Krzysztof Kozlowski Subject: [RFT PATCH v3 3/4] arm64: dts: exynos: add unit address to DWC3 node wrapper in Exynos5433 Date: Fri, 27 Jan 2023 22:27:12 +0100 Message-Id: <20230127212713.267014-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230127212713.267014-1-krzysztof.kozlowski@linaro.org> References: <20230127212713.267014-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756212755065730725?= X-GMAIL-MSGID: =?utf-8?q?1756212755065730725?= Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node which do not have unit address. Therefore usethe address space of child device (actual DWC3 Controller) as the wrapper's address to fix: exynos5433-tm2e.dtb: soc@0: usbdrd: {'compatible': ['samsung,exynos5433-dwusb3'], ... should not be valid under {'type': 'object'} Signed-off-by: Krzysztof Kozlowski Tested-by: Marek Szyprowski --- Changes since v2: 1. Fix typo/build error. Changes since v1: 1. New patch --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 9da24fe958a3..5519a80576c5 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -1742,7 +1742,7 @@ hsi2c_11: i2c@14df0000 { status = "disabled"; }; - usbdrd30: usbdrd { + usbdrd30: usb@15400000 { compatible = "samsung,exynos5433-dwusb3"; clocks = <&cmu_fsys CLK_ACLK_USBDRD30>, <&cmu_fsys CLK_SCLK_USBDRD30>, @@ -1751,16 +1751,16 @@ usbdrd30: usbdrd { clock-names = "aclk", "susp_clk", "phyclk", "pipe_pclk"; #address-cells = <1>; #size-cells = <1>; - ranges; + ranges = <0x0 0x15400000 0x10000>; status = "disabled"; - usbdrd_dwc3: usb@15400000 { + usbdrd_dwc3: usb@0 { compatible = "snps,dwc3"; clocks = <&cmu_fsys CLK_SCLK_USBDRD30>, <&cmu_fsys CLK_ACLK_USBDRD30>, <&cmu_fsys CLK_SCLK_USBDRD30>; clock-names = "ref", "bus_early", "suspend"; - reg = <0x15400000 0x10000>; + reg = <0x0 0x10000>; interrupts = ; phys = <&usbdrd30_phy 0>, <&usbdrd30_phy 1>; phy-names = "usb2-phy", "usb3-phy"; @@ -1795,7 +1795,7 @@ usbhost30_phy: phy@15580000 { status = "disabled"; }; - usbhost30: usbhost { + usbhost30: usb@15a00000 { compatible = "samsung,exynos5433-dwusb3"; clocks = <&cmu_fsys CLK_ACLK_USBHOST30>, <&cmu_fsys CLK_SCLK_USBHOST30>, @@ -1804,16 +1804,16 @@ usbhost30: usbhost { clock-names = "aclk", "susp_clk", "phyclk", "pipe_pclk"; #address-cells = <1>; #size-cells = <1>; - ranges; + ranges = <0x0 0x15a00000 0x10000>; status = "disabled"; - usbhost_dwc3: usb@15a00000 { + usbhost_dwc3: usb@0 { compatible = "snps,dwc3"; clocks = <&cmu_fsys CLK_SCLK_USBHOST30>, <&cmu_fsys CLK_ACLK_USBHOST30>, <&cmu_fsys CLK_SCLK_USBHOST30>; clock-names = "ref", "bus_early", "suspend"; - reg = <0x15a00000 0x10000>; + reg = <0x0 0x10000>; interrupts = ; phys = <&usbhost30_phy 0>, <&usbhost30_phy 1>; phy-names = "usb2-phy", "usb3-phy"; From patchwork Fri Jan 27 21:27:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 49699 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1052593wrn; Fri, 27 Jan 2023 13:30:17 -0800 (PST) X-Google-Smtp-Source: AMrXdXsZEVq4AbLHKPcM1pVPMQq89xF8WvOEJ1MMCzhz5XeLyL6Isq2n7Ai9HP8PO+VTjmmJUsvB X-Received: by 2002:a17:906:b806:b0:84d:430a:5e63 with SMTP id dv6-20020a170906b80600b0084d430a5e63mr40946694ejb.27.1674855017518; Fri, 27 Jan 2023 13:30:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674855017; cv=none; d=google.com; s=arc-20160816; b=CwQaQuPZ8H58fd0NwTL0t1fW6n3++Ax4MAYwJKZ4M/MzOJGHrS+6A7+TTh9jcuRznh oKpLScMIwWizblAyVIMqakMznQYt6qIgr1eIhS0JgI8bJqqK59I9AarucgfX1lpkFcX3 6N5CuH+3ovvl+jIOt3a8urZuINqTa5bo3OV1eI33dD/H0pfgAI6NiQ9vBUQEdw5wkQ1A 91wLUAzLlbeJ0utJydCL7rUjBOKx37vsyPMJ8Q6zwf4GiZZktlLlLkqhfgqFkajOGz0f T45jZi9Jb6fBU9eBOOoPkbOP+KXjHez3HA5mg8d+7edJrQdLLWvymkUJz1wDQB3rHjNQ 7Jxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wufxP51EWGGk9HXvgWg83TOisM7XYlAWLVo728uV5hA=; b=y+ImdCAmvaVxD0zwxxZk84iHNcXuzpTAsy3O0Apw0/HzxkPg+z2Ir/fdQN1SdfCBB3 t/b9eLqF0Q/wI1oCKF5+lzcO0MxA5rBIqQVfPunG+bxCvWhj+vhnUemhk699YCH0Tlcr 9Y2SEv6ouGluEpTmVx6OIpjr+Tv/2VViwoJQyvedaErpv2UwqfFYJ8dJO+s+kgXI3uEt RryrxgEsk0EMT9rEwo27/CM/wRjYv46jWUpqNpDJ9RNtMx7o2fP6UzqNwIq1nPXA1czh R3BuGPKrSq/QzXk+OXbxIVYE20j6/qcNubpeonF6UeS+o01IvC5VNBp6ESHbzP14tFKt ovAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TNh0kQVq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ge16-20020a170907909000b0087cc469b194si1984159ejb.795.2023.01.27.13.29.54; Fri, 27 Jan 2023 13:30:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TNh0kQVq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232064AbjA0V2E (ORCPT + 99 others); Fri, 27 Jan 2023 16:28:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231700AbjA0V1b (ORCPT ); Fri, 27 Jan 2023 16:27:31 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1700A3A87C for ; Fri, 27 Jan 2023 13:27:30 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id j17so4358489wms.0 for ; Fri, 27 Jan 2023 13:27:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wufxP51EWGGk9HXvgWg83TOisM7XYlAWLVo728uV5hA=; b=TNh0kQVqhFnNqu+G4pM9Oc4M6cePC/63S8gdsyMqkTslrWbQDlS/J9kJFWBMD1uYQq GC8WJIGE+wIbDdmM20nqVIGiSx2tV1fXN9W0yoVcq18u46qVw/Y1aIxbkPjlL8CV2gbP X7UfnZFWSCxDk8Z5VmyGvbZ0HnT+9b2idsd3AvkP3853iFpWojQFHF4njPIeOdDQp0nz zJFF1xQWjcZ5Sqfw0KQCRzwFvmndDMTDTVrExJt7qMNa+Z6/DAONPWkeCzaIoVCs0bZ0 IaKQzSVcBq0jXX5ckuKrSgK3YPg5bUb8I/W0u5zWZliCUxuOWJN0ApMETnFd9MrV++Z6 8meQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wufxP51EWGGk9HXvgWg83TOisM7XYlAWLVo728uV5hA=; b=JdasFvsTlVeEVvC5t3Ttp64YonxSruuSBe761+UzxKVAxUuCFcG8vfe6YAs5baCOVV 2qZtTcYYaVUX3PiQeDFaa2O0BJgBfahI2FvJTr3CkkJGUgJ1dW2L3NADOEHkPmgKjWwG 5GY0S0Mn1CllXaE7bGHXFGWOsCBGOxR5V2AAwW6KGBt0qM/e1pN/ijIgT7HsjLn1m7qZ fmtG7p/gGKJUH7ETRP7Q0JfQmGIOS2YNXFy/8EBYxh5lvHxt5kyQ53nKWnHTmQrxWIRm n9fiSak97d5/8c6qcwG0U1MMS1+nfEuQM4+IYui8i1a78TAeq2GRrdQ+N8N74KGG97ZU VUmg== X-Gm-Message-State: AFqh2kpWxr3+VEbrWSxy4sPK7YecOufObUfSkrfLFinZgyP4HfToQkOl l6o9FAV+4FvsYWGLCfN3JUjv0Q== X-Received: by 2002:a05:600c:35d0:b0:3db:c4c:9224 with SMTP id r16-20020a05600c35d000b003db0c4c9224mr40221166wmq.3.1674854849674; Fri, 27 Jan 2023 13:27:29 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id d11-20020a05600c3acb00b003db30be4a54sm8645303wms.38.2023.01.27.13.27.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 13:27:29 -0800 (PST) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: replicant@osuosl.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, =?utf-8?q?Martin_J=C3=BCcker?= , Henrik Grimler , Sam Protsenko , Chanho Park , Marek Szyprowski , Chanwoo Choi , Krzysztof Kozlowski Subject: [RFT PATCH v3 4/4] arm64: dts: exynos: add unit address to DWC3 node wrapper in Exynos7 Date: Fri, 27 Jan 2023 22:27:13 +0100 Message-Id: <20230127212713.267014-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230127212713.267014-1-krzysztof.kozlowski@linaro.org> References: <20230127212713.267014-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756212775112402958?= X-GMAIL-MSGID: =?utf-8?q?1756212775112402958?= Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node which do not have unit address. Therefore usethe address space of child device (actual DWC3 Controller) as the wrapper's address to fix: exynos7-espresso.dtb: soc@0: usb: {'compatible': ['samsung,exynos7-dwusb3'], ... should not be valid under {'type': 'object'} Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar Tested-by: Alim Akhtar --- Changes since v1: 1. New patch --- arch/arm64/boot/dts/exynos/exynos7.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi index 82fee1b7caab..b1fa68835b09 100644 --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi @@ -690,7 +690,7 @@ usbdrd_phy: phy@15500000 { #phy-cells = <1>; }; - usbdrd: usb { + usbdrd: usb@15400000 { compatible = "samsung,exynos7-dwusb3"; clocks = <&clock_fsys0 ACLK_USBDRD300>, <&clock_fsys0 SCLK_USBDRD300_SUSPENDCLK>, @@ -699,11 +699,11 @@ usbdrd: usb { "usbdrd30_axius_clk"; #address-cells = <1>; #size-cells = <1>; - ranges; + ranges = <0x0 0x15400000 0x10000>; - usb@15400000 { + usb@0 { compatible = "snps,dwc3"; - reg = <0x15400000 0x10000>; + reg = <0x0 0x10000>; interrupts = ; phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>; phy-names = "usb2-phy", "usb3-phy";