From patchwork Thu Jan 26 22:32:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cormier X-Patchwork-Id: 48938 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp521345wrn; Thu, 26 Jan 2023 14:35:16 -0800 (PST) X-Google-Smtp-Source: AK7set9MlELsUoXr24mmWb0VU0ZAEnRHjJ+mmBddnBCLmVWldedR4I6ef73TzvdOnezFy/cXTgJn X-Received: by 2002:a17:903:41c6:b0:196:519d:8655 with SMTP id u6-20020a17090341c600b00196519d8655mr1114653ple.5.1674772516556; Thu, 26 Jan 2023 14:35:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674772516; cv=none; d=google.com; s=arc-20160816; b=af7EJYtBANkEVb2fgvoJ79Q7jDEDUKBLfqLEwToTtL5xME6sEfeILsKO6gnTbPvmd+ IpbACC40vunqG7NjE4Xa5tAucd0DAcCdfA8XfATOTmUrLGuVJR/w5C1CGdKta9aLbP6i yMBI+4MiRRam2Rioj+zUilRIKS5Shegel7Il45EdNO+UxAjZ0/8YpjojTAtH1ziaxgS3 /fUmcdUaAZ3y9LcZzJ537+xQaUx/hm+MzDC42JZXgPFPSaE+z6S/2qt8Tb9wZcV1ttyw pjPl1sJZbOPNNwUs90X9uhAEqU0SGkxRT5LSrFqtKo+e8DIcqEfU7nxMXUBYId8F2utt JvXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=3zFvxOAC0q2c06nWzVmCaxdWpCqkl5RVXm0xsv73DMs=; b=alSR5dHCtqZ+PPMFl5wF0FBG52oiD2okWCeXG5Nsf1i+19hv4cWQpT4UIMQNe8XWfM 7UleKpPBKNpS/h6FbHWzM/rNLtoCHld+B61AAmm1FlCdafhIQwtYC4obU2V//41hiKgV +EWKKYyQOifzhDnvZJFz9KJ1kvxcwtp2bmn0gWi3QBQK9ZFr4V7Yw/WdFQYv5o2I1rcr nT6wTcqbF201CIJ9KudWn3pIZsk+W1lx3Bvot5IzcY/2RxRkmMD1Ss3C7INcX79xM991 3xt2M2XVj1YK4CSfVcJ7o6h2iaXUop3FX/JrylVjR8JPKHtkJcu0BRJhASxnPK81RsHg Ietw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@criticallink.com header.s=google header.b=o7lK4z8o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=criticallink.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l8-20020a170902f68800b00186c37272a6si2958441plg.178.2023.01.26.14.35.04; Thu, 26 Jan 2023 14:35:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@criticallink.com header.s=google header.b=o7lK4z8o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=criticallink.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230109AbjAZWdZ (ORCPT + 99 others); Thu, 26 Jan 2023 17:33:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233175AbjAZWcw (ORCPT ); Thu, 26 Jan 2023 17:32:52 -0500 Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A93C371647 for ; Thu, 26 Jan 2023 14:32:29 -0800 (PST) Received: by mail-qt1-x82b.google.com with SMTP id jr19so2620090qtb.7 for ; Thu, 26 Jan 2023 14:32:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=criticallink.com; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3zFvxOAC0q2c06nWzVmCaxdWpCqkl5RVXm0xsv73DMs=; b=o7lK4z8o7B55iaeb/QVxMD9CSLSJVLJ+w6AHvvYrEztgbkkhfDpccJL5XYVNWY5yui +n0LYYi+DDKn9qEfjUU1fed+Owwzbpf431Fleqr10EISUzsNi/sYpeoW4JW0EdyTnLtA mN4zxcQwsQi+LujmWk6kqP5n6TnS4IdRoZidGWsoJuBNKxkooKtpibgK5X67u2OPXYnE 5aCgFsC39nIysvoepqn5YPwDt3Ba+Mk+ozWkw1JaJ5H5YHRPlouCaLKD/EOIbluy7VQ6 xHsqrviK+JXTKv8fC6fUqXrOHDIFvipPMtwKDJ7aHmziSOxO6aKbOBnhANESRq/3xpyI ejBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3zFvxOAC0q2c06nWzVmCaxdWpCqkl5RVXm0xsv73DMs=; b=eOVu8Io6lFaAP0Bz2+cNVH/aeDuXMcVY6Abntyhdnj6ySWD9CgvbwJPsD+yMGKx7Jz vux9mD/wtXnkwuaLlUyny3a0Ws9uCuqRYy4xNUJbIqSCPYOauuGpGjHAKQ8l/E46Q4dK X96wqdDXmYJvA6Rop4Pa0pyvHnrh3Bu19NRlUjsXRMhcOeqsXt1TRwcnDZTKlRMdA5/m OGoXpAv/jrsBYZj2CDVWRKbtxWZsCBkBScdbOR7WToa26GaeIvULao4kWHqJemA5fSaP Cu38U/czehVHNHgS7ZJ3UW5nE4PeaZfr/PLvR0VCeBks5Uvdj/dBq3vUWeNN5LpyNs/4 V/pg== X-Gm-Message-State: AFqh2kqopmlCHQVnsOT5BpArTgmcSHLtlyNqeOl1k5xkWH0ov3B0swbh ZFQd95zH/W4EGYMD/SAZkTRSag== X-Received: by 2002:a05:622a:1995:b0:3b2:4309:99e with SMTP id u21-20020a05622a199500b003b24309099emr73641310qtc.54.1674772348797; Thu, 26 Jan 2023 14:32:28 -0800 (PST) Received: from [127.0.1.1] (static-72-90-70-109.syrcny.fios.verizon.net. [72.90.70.109]) by smtp.gmail.com with ESMTPSA id m7-20020a05620a220700b006ff8a122a1asm1723091qkh.78.2023.01.26.14.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 14:32:28 -0800 (PST) From: Jonathan Cormier Date: Thu, 26 Jan 2023 17:32:23 -0500 Subject: [PATCH v4 1/5] dt-bindings: hwmon: adi,ltc2945: Add binding MIME-Version: 1.0 Message-Id: <20230126-b4-ltc2945_shunt_resistor-v4-1-bb913470d8da@criticallink.com> References: <20230126-b4-ltc2945_shunt_resistor-v4-0-bb913470d8da@criticallink.com> In-Reply-To: <20230126-b4-ltc2945_shunt_resistor-v4-0-bb913470d8da@criticallink.com> To: Jean Delvare , Guenter Roeck , Rob Herring , Krzysztof Kozlowski Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bob Duke , John Pruitt , Jonathan Cormier , Krzysztof Kozlowski X-Mailer: b4 0.12.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1715; i=jcormier@criticallink.com; h=from:subject:message-id; bh=zommGdK1AE/P2wkRC+Wfs7Ff5ewrg2oHpdh2GCpmvb4=; b=owEBbQKS/ZANAwAKAdzX/S4LNuuqAcsmYgBj0v96zdNvjLqjJDJT6uP55wg3FfQKjVKHekgLyJ/H g9+UYSiJAjMEAAEKAB0WIQT/MozqCeZtYxNnVN/c1/0uCzbrqgUCY9L/egAKCRDc1/0uCzbrqm5FEA CGCashV5T/gehXbDpyC6N+qeRK93QJKBK3yy4ryoch6+CQLU1jV1e2Nm2Lget6jA7r8WvFD/JYiktZ EA1YE0dvxdntUT5l92NeBnRsnvF/osVZOWiy//mp363XuQ1XmqWSjdV49lmiEV8U3MtR7T6v3Un3pf +qHaF6h9BkSCjoZDuo4yi3ZrWHTHQz7YHPhcRnwo1hJ81wVt0K1+L0Pvch2cK3oWgrqQzto4f2JeBe vWuMn528NyfLnC5HJMOc5fjbDUoADlE7dcEmnyitrRTx4xZOHL0V+Y1WeZsdV2OhYLCeHZd2bTS2I0 1PRBgpUMfDI51vJftqm4DH6BNTDRYF2n0ar9J/7KEA+L32eU+/GhejGGzSONu2rW1/6rQXBxcAJXiE OKec5CU7dcXLN0j2RU2qSD6cZpTSRsRlh8aGO6o3lNiBD2rDz0+9+OeN9rDxz0mCBdKVu94zBNdJG3 VpiUkoaolGWhqWvje6zIb1VCY9u/0i//+6NB/+pofpwFR8XqrDyf0OvRsjIXFH3svI0Y78wwhBpops egwbN3FeiEMaa2z5KRrO1iuR46IAoBYDzDsbPiREr4fi7RRMqVHxe3GvlhxMIQu+wtolpWq0U3cVMg TUOxQXklybtJEvajU54xYWmzKoC850y9iYg/ZjT2dYI7V9Uu3PV2/+y3ZA2Q== X-Developer-Key: i=jcormier@criticallink.com; a=openpgp; fpr=FF328CEA09E66D63136754DFDCD7FD2E0B36EBAA X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756126266514272918?= X-GMAIL-MSGID: =?utf-8?q?1756126266514272918?= Create initial binding for the LTC2945 I2C power monitor. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Jonathan Cormier --- .../devicetree/bindings/hwmon/adi,ltc2945.yaml | 49 ++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml new file mode 100644 index 000000000000..5cb66e97e816 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/adi,ltc2945.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices LTC2945 wide range i2c power monitor + +maintainers: + - Guenter Roeck + +description: | + Analog Devices LTC2945 wide range i2c power monitor over I2C. + + https://www.analog.com/media/en/technical-documentation/data-sheets/LTC2945.pdf + +properties: + compatible: + enum: + - adi,ltc2945 + + reg: + maxItems: 1 + + shunt-resistor-micro-ohms: + description: + Shunt resistor value in micro-Ohms + default: 1000 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + power-monitor@6e { + compatible = "adi,ltc2945"; + reg = <0x6e>; + /* 10 milli-Ohm shunt resistor */ + shunt-resistor-micro-ohms = <10000>; + }; + }; +... From patchwork Thu Jan 26 22:32:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cormier X-Patchwork-Id: 48940 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp521599wrn; Thu, 26 Jan 2023 14:35:58 -0800 (PST) X-Google-Smtp-Source: AMrXdXtbXfvGokc6rvkB+qjS7cz1AK5BjulaHwgMw3NUKllMTxDxUv0OTv6YQx4Ew69lCAU6uY4I X-Received: by 2002:a05:6a21:6d8c:b0:b1:e8da:d5bc with SMTP id wl12-20020a056a216d8c00b000b1e8dad5bcmr50341822pzb.56.1674772558177; Thu, 26 Jan 2023 14:35:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674772558; cv=none; d=google.com; s=arc-20160816; b=UwtsoYQEt6yqXOirlfX5oHGs1/jbfoi5WFqD3z9UwBDmj5pjT4Ui8UMTRW3aTsBcBT yqi6lYF9pBKnn7Q8Vb91ldsV4I5RRG86UHinLEL1yfoWVN3b8qtns8e9KYbyA0na1qvP rHQbnLW924Br49JXfFMv2RR+3Av94xCKxCB5u0/ZFxND0KUxwyXuS973/UjWQ+Q8/fil I+e0cBEUU+Bv+5t5810e7F201A138JGvqQ96iFEGfEEb4k1G99sKG5VbBPRAADafoYvX Ac6zTLzH3WRBINHI4pWSHpScx8hojmIda1Zdo9+ClCqgN0Urs8SArFVueN2qxHTfMIn5 kMtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=4xEhI3axOJYS2dd9mxNrX3agzmt2SZlxn5ns5AzUH58=; b=LJP1jPZd30Sfb6wCSem3MfhPPNqYB8SwkYfuWZpK5Ix5Pp36Cx/pbcYePJGiN2Kreo vzLkVbwsdOAnTR3RMU/K8J5HSDAYLq5pbvyuHQ4eXkPW7z3DQA2ED/RtBynHpMpQR3T4 WOjQ6+gFUYhTnKOU9W1PH2exDlOVZesC9+Zbe7QXIo+t3VGPgymzlAkTkiW7G0ryrlao WP2M+HYG36/Xe2lKDLmphSpNLdLekgP0xgjp3aHlMGWQg2sS3x9hBlwfxnIanbyGAeqe ogSmMhjMoBfRGc9cyDQSZ1wQGkleQysm7hMdwUv9GH+AQiuYFFdXAey3zRPwSiL2IB8H lt9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@criticallink.com header.s=google header.b=cEzkNNjy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=criticallink.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o11-20020a63920b000000b0046ae2a8ea9csi2168631pgd.733.2023.01.26.14.35.45; Thu, 26 Jan 2023 14:35:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@criticallink.com header.s=google header.b=cEzkNNjy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=criticallink.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233284AbjAZWdc (ORCPT + 99 others); Thu, 26 Jan 2023 17:33:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233232AbjAZWcw (ORCPT ); Thu, 26 Jan 2023 17:32:52 -0500 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D27F9728C1 for ; Thu, 26 Jan 2023 14:32:30 -0800 (PST) Received: by mail-qv1-xf2b.google.com with SMTP id x18so2617423qvl.1 for ; Thu, 26 Jan 2023 14:32:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=criticallink.com; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4xEhI3axOJYS2dd9mxNrX3agzmt2SZlxn5ns5AzUH58=; b=cEzkNNjy9xdn2V+pJO12CL+zMeml5aYU0d5MSRymk3vzhECNfnAxv1i6QuiVcSung9 HKYXTxKhnCqIQpI5WID+qZM4HBfq75uXYeRVOoN7J9VOOhb2MbC8GUJ8z/vwK6MgWhH7 l8zzsyqzuNrtLFoh3MogI7R9KgSFwfyb4ysrZsOHEm/e3CaNdURMwSmuG0z3LXh9UuMv SIFOhIVuYksdSG/fttoK7FrudzTxSUuMREd/wnDFhDhCeb2LyBH+0i1AtDuYb+rPg1hK vwF81gE0fo/5zvsSrS9iRVv3ZT/m0zAGoqQCLHd+YqYcyJ+Jm6FRe2j8+3DYT0RorNsL cyIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4xEhI3axOJYS2dd9mxNrX3agzmt2SZlxn5ns5AzUH58=; b=JfbfRDonb7kB+2lMmghxTPVsvmeZgGH4X+LLDQw03a1o79iQ0yA5LBwmYEX67De6kP oTYrGufMjuKvwDjOu08axc7QG8WfhnusqgQLJoqPngp9foUmtN19C4fjblzlvjOYrUYL tceD8K9X0JA/BQncPBeYcTMUCOQ6mEJ8MpcPCSKhEvCnxkboPayTMqNrWtN729aPvqnw zOWsW7o3vnlEmh0zxJTA60zGh7up4JA4VH06rzUtPOXFVJTD+JJaTPoJG0Sb52OD1H5k NB1lsybSLjQOsqu4hHtbcDguhrqMOGPs6EcHptboSL5xfqAJFElWZ0FLc/DNxE6gLVVW Rmgg== X-Gm-Message-State: AFqh2koTby+YvdC4qx23B5+YPOyXl3Mp0IvmkBly3I93b8Lla4TmWvIn Wmcqq44qN/JQv+WoSgDvpOS0kQ== X-Received: by 2002:a05:6214:4287:b0:535:2d28:bf1d with SMTP id og7-20020a056214428700b005352d28bf1dmr61600177qvb.33.1674772349768; Thu, 26 Jan 2023 14:32:29 -0800 (PST) Received: from [127.0.1.1] (static-72-90-70-109.syrcny.fios.verizon.net. [72.90.70.109]) by smtp.gmail.com with ESMTPSA id m7-20020a05620a220700b006ff8a122a1asm1723091qkh.78.2023.01.26.14.32.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 14:32:29 -0800 (PST) From: Jonathan Cormier Date: Thu, 26 Jan 2023 17:32:24 -0500 Subject: [PATCH v4 2/5] hwmon: ltc2945: Add devicetree match table MIME-Version: 1.0 Message-Id: <20230126-b4-ltc2945_shunt_resistor-v4-2-bb913470d8da@criticallink.com> References: <20230126-b4-ltc2945_shunt_resistor-v4-0-bb913470d8da@criticallink.com> In-Reply-To: <20230126-b4-ltc2945_shunt_resistor-v4-0-bb913470d8da@criticallink.com> To: Jean Delvare , Guenter Roeck , Rob Herring , Krzysztof Kozlowski Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bob Duke , John Pruitt , Jonathan Cormier X-Mailer: b4 0.12.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1025; i=jcormier@criticallink.com; h=from:subject:message-id; bh=Ko4/DNeywEIQUpedzI15zf/CLimbk3xwVSNJ1d5SvMM=; b=owEBbQKS/ZANAwAKAdzX/S4LNuuqAcsmYgBj0v967dbZK3pTHY2jf3XbNoFu7verxjCaGB5B9/94 99Zfs7eJAjMEAAEKAB0WIQT/MozqCeZtYxNnVN/c1/0uCzbrqgUCY9L/egAKCRDc1/0uCzbrqqUfD/ 4oWWVTbKPgDKGULT2hNoHx/PX85X3YWhcjEp1/ZPPYjIXrqO/Fbu0x3mXg1ki52jK7s5bqdjxPn8Im br2YFa9GAiX7kRSE8JQqtsypb7cD8SP6WhXEftP8I7jJMDINzWkIrqrguLlxnk+gdypv4jydKPb0Sv h91mCNu/hc2Zs6uV/+P9Yozh71LK9r7uVB4Sk9OSag6Ld2cYmHDVoVl5cNZmOvFxrQEjbn1nGvsfpl VJbMZ4sALN8wX0MJ05ISUf8+Py9fq9Cto+cwPAkKo5CemIGoGf5renPvPLgWQMyJiY/PyTDCeM+S4P GRY1r5KsOBsCEc++b2riR7Shjy72oQZY+j9XAXs39vSZrY9/0+xfmbjDkBWEtP8mHzzbIeeYpe43Ir fAWhkbJP+VW7ZfKmOCw2TbgYeBf/2fD7/3vAro2ZBE6PMu1+yqIEHZ3tWwelW2PmfsddvgchoruM1j aaxlCeHlG8xjOdiNXiWuTFzPtnXup5a/aiBrCJG3ftT45xtRDwTFIosHRp7ZrCXcUVhB09JAqysPM3 9XWaKXRjz9NkYdTN/BVbhpPyVXvG9DCmkw1lUTUEhQKU26Bnr96fBrMydOF4vbeEpdXO0T2F82QrDI zCnCXAq2Q4Od6fA9XDEVplrpnl6Ahc38XDbOMbvuDxyefknFaNMlJxFIWkUw== X-Developer-Key: i=jcormier@criticallink.com; a=openpgp; fpr=FF328CEA09E66D63136754DFDCD7FD2E0B36EBAA X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756126309749331545?= X-GMAIL-MSGID: =?utf-8?q?1756126309749331545?= Add adi,ltc2945 compatible Signed-off-by: Jonathan Cormier --- drivers/hwmon/ltc2945.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/ltc2945.c b/drivers/hwmon/ltc2945.c index 9adebb59f604..9af3e3821152 100644 --- a/drivers/hwmon/ltc2945.c +++ b/drivers/hwmon/ltc2945.c @@ -58,6 +58,12 @@ #define CONTROL_MULT_SELECT (1 << 0) #define CONTROL_TEST_MODE (1 << 4) +static const struct of_device_id __maybe_unused ltc2945_of_match[] = { + { .compatible = "adi,ltc2945" }, + { } +}; +MODULE_DEVICE_TABLE(of, ltc2945_of_match); + static inline bool is_power_reg(u8 reg) { return reg < LTC2945_SENSE_H; @@ -475,8 +481,9 @@ MODULE_DEVICE_TABLE(i2c, ltc2945_id); static struct i2c_driver ltc2945_driver = { .driver = { - .name = "ltc2945", - }, + .name = "ltc2945", + .of_match_table = of_match_ptr(ltc2945_of_match), + }, .probe_new = ltc2945_probe, .id_table = ltc2945_id, }; From patchwork Thu Jan 26 22:32:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cormier X-Patchwork-Id: 48939 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp521477wrn; Thu, 26 Jan 2023 14:35:37 -0800 (PST) X-Google-Smtp-Source: AK7set+2NHZr86XsItEYee2K1oOJnAkTRioaUcc/yiuSGfH8tCFeiETO3BT2aFTTXFZ3ye1MyJM3 X-Received: by 2002:aa7:8596:0:b0:590:7735:5384 with SMTP id w22-20020aa78596000000b0059077355384mr4883733pfn.23.1674772536746; Thu, 26 Jan 2023 14:35:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674772536; cv=none; d=google.com; s=arc-20160816; b=a7LglGNssC+Nsa5LdB4lnrkY2mOGe4FuSKYvN53D3qCmM0THztybjp88/FQ54BcYhw PY7N5HUK5Z5AJy9kjyAulG7SOfB91BRmnlqFOD7iyX/FCsTxF3p3/HElm7R85Y3X7f8k YhbU/klcEvkL3riLU1gOr2IaEEFj40Q+r7ay6REwHNTUxcmGOng+iFXWmuc1cb1Eunr8 5kObmge8Hij3YuqTza0xUK8czhIKuOkzjgHRV+nZ2e5J3UVJpzUtRNArCxWNzTQutgqT hBsmfGIj9c6mPxkhoy9184wk+SPOvdIBVQHBtIN80KJs1jNFXg6jcXXCYC3MPJRT0k1K oc1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=OlgJAvEkxbhhdbp3uu9+lWHtfcFwlocAfS6RLhi2B3k=; b=z3dSG8ezQgtg/VHjnYfsGdimweh381WNBvQSevo0FMjP6e50cDY5PWcSaxpjOICPCX +3XgWgQj4FFe7QlCMpjIm70ZXEUeVeDvIOWIj9L21sG7/GJhnZrRkeyIQjiZoudXR9N+ RKT/bi+hdVBIjCscNV4PB5L0h45sTYNFyHl3m7KzFLVKJPuVr1Lle+169ju09nB5Oh1N g6YOFm0s235ul35/LPDhmiTC/K46Xqede5raLatrzFYdKSyKmj/XBfQh4QoLijqFs4Fk F0x2GsjNiZxF+Lvsb+EvyslAUF8i2TnBcY+9sq8lLVbUpWHE5B9ckdyvbf96/8xindr5 AGGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@criticallink.com header.s=google header.b="mT/ufr4G"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=criticallink.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n24-20020aa79058000000b00586546418e2si2434838pfo.139.2023.01.26.14.35.24; Thu, 26 Jan 2023 14:35:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@criticallink.com header.s=google header.b="mT/ufr4G"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=criticallink.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232584AbjAZWda (ORCPT + 99 others); Thu, 26 Jan 2023 17:33:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233235AbjAZWcw (ORCPT ); Thu, 26 Jan 2023 17:32:52 -0500 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E3AF728E7 for ; Thu, 26 Jan 2023 14:32:31 -0800 (PST) Received: by mail-qv1-xf35.google.com with SMTP id d13so2587021qvj.8 for ; Thu, 26 Jan 2023 14:32:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=criticallink.com; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OlgJAvEkxbhhdbp3uu9+lWHtfcFwlocAfS6RLhi2B3k=; b=mT/ufr4G73UuIeie3utMHAeoQ+z9zmYRgkQgaLFdHEFErxqGa+40raWQ02BdISm+Q7 aw7jMlVwoqdta6ZGsBNXwLg0NdjhlUA1JPoyWlQ8EJMR+QeGttil0fYJd8rtBjNgGobS k9x6qTNK7zjl8bXyb7FLwl0qoLwBE1O4SmuZh76Yd8ndk43ScY33lNt+93W9vXBWyuQB fJWtUHAArrcuNo5pAI1DtGLcBUS0NrqA11XQXKRHscUTsitukwj6Kadqqi7a82AVpyM1 fWgXJ49XVk//zGvPkPJBjnuDh4cHgVZO6guW+TBMfuLk4u8yLP+C/jS66q6kMO4jRtE1 +vWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OlgJAvEkxbhhdbp3uu9+lWHtfcFwlocAfS6RLhi2B3k=; b=SMH230o5glZyV3atEbaQg+Ei9kw1eCEhoFlKqs3g+KZMtaV/1j00JNfF4gQiaWwf6h 8npTQGdLYSmsUhA5MwDfCE8U2Iz3XOh8oXasUxXFPUhXU9qjiJK7n8j0GwDW71Fsmw+n Ml2pfeeCviX3mg6eRsd+Lja/mycWUxQ0xcSIjYq+z5Fo/RqajUhxOb+ai4TwNuTvHclm fKsVKb6OOxDDmO/9oSsSntAMNs6DqBZJrek3sAZUOrcO72GiEZ/owcXd+cWTNBAGev4/ yNjuxnb6YCC4/hFzjGL14RyAbazvLBQqNkDvWJk6SqrJP38NxLwZLNlyNNvEQQeCfq1R rSlA== X-Gm-Message-State: AFqh2krjhCD61By9V/P2a2r5ul0NNDk76yflTFpX53aIelCf9AEBPMXP awEhk9HVblc5k2V34hrFhETGLg== X-Received: by 2002:a05:6214:803:b0:532:d34:5aaa with SMTP id df3-20020a056214080300b005320d345aaamr58644565qvb.11.1674772350870; Thu, 26 Jan 2023 14:32:30 -0800 (PST) Received: from [127.0.1.1] (static-72-90-70-109.syrcny.fios.verizon.net. [72.90.70.109]) by smtp.gmail.com with ESMTPSA id m7-20020a05620a220700b006ff8a122a1asm1723091qkh.78.2023.01.26.14.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 14:32:30 -0800 (PST) From: Jonathan Cormier Date: Thu, 26 Jan 2023 17:32:25 -0500 Subject: [PATCH v4 3/5] hwmon: ltc2945: Handle error case in ltc2945_value_store MIME-Version: 1.0 Message-Id: <20230126-b4-ltc2945_shunt_resistor-v4-3-bb913470d8da@criticallink.com> References: <20230126-b4-ltc2945_shunt_resistor-v4-0-bb913470d8da@criticallink.com> In-Reply-To: <20230126-b4-ltc2945_shunt_resistor-v4-0-bb913470d8da@criticallink.com> To: Jean Delvare , Guenter Roeck , Rob Herring , Krzysztof Kozlowski Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bob Duke , John Pruitt , Jonathan Cormier X-Mailer: b4 0.12.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=867; i=jcormier@criticallink.com; h=from:subject:message-id; bh=SzzENIrGiaejxh+uQZSs7e+ccCHGcUqjL1/OnwF5OmY=; b=owEBbQKS/ZANAwAKAdzX/S4LNuuqAcsmYgBj0v96I9AKEpN83mKapP1hTRkeYHRy84kppIwH+CdQ eL5pKQiJAjMEAAEKAB0WIQT/MozqCeZtYxNnVN/c1/0uCzbrqgUCY9L/egAKCRDc1/0uCzbrqudhEA CuNh+CQew2a5gTfSFibY46D0O2N0QAEvr3Rsa0msLInZGzGb/Q37NW4Bek/e1UDQ9akNCC5edWUmSV leReoDCSY5V6auNoZggWimfdebz5pXtmZMoci4TLpq9opdQZ7M9ZR2yu50sPMN25UX+U+fSdjPJ/9F ZcOFS8a9dhWg9E40XXJdAqo3GjZG9+REU/Amh1e4I3JX4QZwHgxLgiVvhPuVW0A8p8TJRStovoi/4c m1l0sz3XYRhtQeEpuw1Kp5BVpG3s1ZVRQSLU2qVPs6/+myvT55V01RoDUkWmq98y0EzhAoKPVmHQ03 gF04Un76awayLjOYjEMUlKLAXPqnq32cwHLqCrmWN6OFO6cx+ckxI6OvlNQ08g+MrnrxPJfk+afSRl tjJZXx9rMNAHw5ZJi7dzOlBqrZivp4qVViLKPDWWdA2iXTpnInPf1IgZc7eKX+s1JPc6y00U4V4pTm +QCYQROzi/dRarcDB+FjkTUG0AaXG8Oa6mCIiIMfOvf7tzKfv2UbXUmgXRRx4pBWdc4U+UlTfT8toO yso+VmuZTXHJv3HaVHkUWSftvvh3SnofhhoR/O7WVXuIQKLQR731wF5y8WfuJmTMyTZ4QFPS+hVLC7 HRbEe8dV9CvuZ+iyYrOf+y184YJzZks7H1NN/4zLU0ze7gofQsjfp+XEVSIQ== X-Developer-Key: i=jcormier@criticallink.com; a=openpgp; fpr=FF328CEA09E66D63136754DFDCD7FD2E0B36EBAA X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756126287485001009?= X-GMAIL-MSGID: =?utf-8?q?1756126287485001009?= ltc2945_val_to_reg errors were not being handled which would have resulted in register being set to 0 (clamped) instead of being left alone. Fixes: 6700ce035f83 ("hwmon: Driver for Linear Technologies LTC2945") Signed-off-by: Jonathan Cormier --- drivers/hwmon/ltc2945.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hwmon/ltc2945.c b/drivers/hwmon/ltc2945.c index 9af3e3821152..ac15298a6558 100644 --- a/drivers/hwmon/ltc2945.c +++ b/drivers/hwmon/ltc2945.c @@ -254,6 +254,8 @@ static ssize_t ltc2945_value_store(struct device *dev, /* convert to register value, then clamp and write result */ regval = ltc2945_val_to_reg(dev, reg, val); + if (regval < 0) + return regval; if (is_power_reg(reg)) { regval = clamp_val(regval, 0, 0xffffff); regbuf[0] = regval >> 16; From patchwork Thu Jan 26 22:32:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cormier X-Patchwork-Id: 48941 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp521696wrn; Thu, 26 Jan 2023 14:36:12 -0800 (PST) X-Google-Smtp-Source: AMrXdXv5dcPdQmWAS/B2i4rUHKzmd/G/Utcsc56gbIGRt0uJqJc/ufBKB/4e37mtwVyN2f7YIVjw X-Received: by 2002:a17:90b:3b4a:b0:22a:3756:542c with SMTP id ot10-20020a17090b3b4a00b0022a3756542cmr26820626pjb.39.1674772572232; Thu, 26 Jan 2023 14:36:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674772572; cv=none; d=google.com; s=arc-20160816; b=eIsEHDUNGR8X44YH9ahtYw5WCCzsVhcIjW1X0uC9tt2WWpF41sEuLO9fxpXzbuwi+z +sJf2XGtHeZT7xIktIBz0rd961BygrXIdWrql9AcnewxX5+AYA1AOvCUE3XQAIGyUoxR /Kc4RqS0ff8GOsdtdu07prJq3kBk13B0S0gTtpNlN7BkdnQnhN77CZEVnGkeCQa7Dk+T MpDVJy7grUF0Ky/sVgHGQrzzxd04SlhWYW/PS8z8B22le3AVaOq52kL3YpJXzQB9YoL+ EzBjo6zWg7Iod/nnLMf09B4iwZ3TVDMMjyxIAo+wq+LbOpr7V8EfsGCTZoORhpIo5ee0 chCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=SCHr8u8LkHFJIdDqjoshO09JHhBWtvWwNk0DDadovgI=; b=dsV8ZBGhMPUvEM5x/aD4dyhzJlgOAByBgjXGMQKSTBvchGOKb7iq6dydKRu11+nXnz N1dsf+v0c8jLfr7gEoYUFo8wgUSw+Zphk2dKQ3qjEZB3uyiqyP+xhfFXU0lP8G0Fl9ma cgx1082C5sORQSSZfG2XRn5PwpuN2B2wYikqddDASJrObX4Ge93y2bRDmQ/FjsHBUK3f Z1xehGkCkXtCf9nicBsZrMqfYfPG5uQFSc9uUX061j2yiLTGwNgxrOa0q8jaVq0nwPlM cxQQOHPsPcKvz7FEiyQ/Gx8idiIe5kc6V7XQVVe4uHJRWKiCqJK24Opo/uAn20qKkKRo sxJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@criticallink.com header.s=google header.b=TFi70dSx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=criticallink.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n11-20020a17090b0d0b00b00228ff7707a9si2809411pjz.34.2023.01.26.14.35.59; Thu, 26 Jan 2023 14:36:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@criticallink.com header.s=google header.b=TFi70dSx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=criticallink.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233290AbjAZWde (ORCPT + 99 others); Thu, 26 Jan 2023 17:33:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232576AbjAZWcw (ORCPT ); Thu, 26 Jan 2023 17:32:52 -0500 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D504645F5E for ; Thu, 26 Jan 2023 14:32:32 -0800 (PST) Received: by mail-qv1-xf35.google.com with SMTP id h10so2588298qvq.7 for ; Thu, 26 Jan 2023 14:32:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=criticallink.com; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SCHr8u8LkHFJIdDqjoshO09JHhBWtvWwNk0DDadovgI=; b=TFi70dSxljUji9Q8+lRwOqeik36CcxykG1bkL7Zmf4w+0tfOzcN5b85Yn9/0xi8/Gj sj/I4tMTUr/52yQrbPTK5aruYP4IuMdcqDjtELTU9Bf4/KgwDKbe9h9Vo4ZXVZF1fkBC ZI/cth4gdK1SQ8awl1oUTlgXWExLx1Iyt0cZBEQiw+aQBxRIMMFHr4lcRSk+Zvg4f+y8 ae8jKPwB/UtSxPp0xbI40WchEDa4Ka7ikNQfK500slNPN7y0Mv86dv7Q7k6oDFli0wzw kZtYjh57Gw/V9vHYOmcRAjXA70S8lBR8GrW8AfphZyRzyfF6ehRilbsgdCg4mIg6TTpu 1QWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SCHr8u8LkHFJIdDqjoshO09JHhBWtvWwNk0DDadovgI=; b=zub5W+BKemSgzckjfbAYWHwFNVCU6lUcn07jkdP4Mwj9qQobJxC+WlpW+vlWTsaiLG Qu/jSaRRgp3Q6v2xbnQxKbBup/VA1CeflngfY0rwFu6uLWMWcNsX7oqDF5Y4sd2wcuOP orcXGAokgFfWmv5UMwYperPIZJhXulPzRg9D0kFzt3qYXWypLqgCDZre9B3WmRYx6X0W 2WtmSS/y7vOVyK7tjG//g30KAhsCfkniVLKSCEemdk6qgEPmMb4hsvGMc807wIL7btpl 5m8D0mslnzeWtJwjtfCqDXzhwU7qiwzFG8zubIzI/W2eMxbaBJVrLXtbpUj7WIhtqeTT 4lSw== X-Gm-Message-State: AO0yUKWYrcDtyZYi+q6Y1S5oc2UfNhrgZK+YcEGpGeYDiUYu6Si8Kl1R zF7TPuJsIGLpTJxS4XCbSy1HON9HTA6Cs+5K9Ps= X-Received: by 2002:a0c:f812:0:b0:537:8125:b533 with SMTP id r18-20020a0cf812000000b005378125b533mr4687943qvn.34.1674772351923; Thu, 26 Jan 2023 14:32:31 -0800 (PST) Received: from [127.0.1.1] (static-72-90-70-109.syrcny.fios.verizon.net. [72.90.70.109]) by smtp.gmail.com with ESMTPSA id m7-20020a05620a220700b006ff8a122a1asm1723091qkh.78.2023.01.26.14.32.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 14:32:31 -0800 (PST) From: Jonathan Cormier Date: Thu, 26 Jan 2023 17:32:26 -0500 Subject: [PATCH v4 4/5] hwmon: ltc2945: Allow setting shunt resistor MIME-Version: 1.0 Message-Id: <20230126-b4-ltc2945_shunt_resistor-v4-4-bb913470d8da@criticallink.com> References: <20230126-b4-ltc2945_shunt_resistor-v4-0-bb913470d8da@criticallink.com> In-Reply-To: <20230126-b4-ltc2945_shunt_resistor-v4-0-bb913470d8da@criticallink.com> To: Jean Delvare , Guenter Roeck , Rob Herring , Krzysztof Kozlowski Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bob Duke , John Pruitt , Jonathan Cormier X-Mailer: b4 0.12.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=9001; i=jcormier@criticallink.com; h=from:subject:message-id; bh=kCSpCo/P+JFRfq9IZAl6ayWTbbT5LfJiwbvQxfe6g3w=; b=owEBbQKS/ZANAwAKAdzX/S4LNuuqAcsmYgBj0v96zFJJWKGHqQesz69ayOn6UqiOCCZzjw53eNx4 YdJI+omJAjMEAAEKAB0WIQT/MozqCeZtYxNnVN/c1/0uCzbrqgUCY9L/egAKCRDc1/0uCzbrqkb+EA CCTTrUKXIvVjU0LpKAJFLD/5sUp+4Tg8mMk/H4dslTDJWDfBMPsCYZMxyFzxPgV4leYqaGWZjG6vns UWkFvuveqvD1kESxVbY0NiLZjuCmYe4ZP/0Rl9ycRUrFHmSMIhvpaOhBCkiPY028+bGuFc54bakurO 4txYNTh20oylXaYxx0woWD9K+cdT2zJ3p3F7e2Gbb77HM4rX98HpFC1RvMN03P42ImbaXWGgO+F0h8 5ihdlmfMMAqGiWNiVmv4++1eldYEYl+c8LrjrwSDbZewxCX6OD/y0xF9atczAWBzILF8H5wo3VQRBU VJCCyGWyZxoAeKrVAsovjs+2IO2O2A4BDCu0Mn0hxnYfodlvUYNDl1Rxc45PKFPzVDPTEQRzFfqhLv JFp29d2SdlYNesKPDoSrliGql1cOvhLBSd7pW6kVYLN0q3Y0RXt0nW0Rsjzh9oqaf0ZluhY5LadAHo UgsZNMVLMNZUAMPomN/sDwROHbspJvCYWqv84PgEHG1dwX54rCPI6Ln/FsBNk35DdNStMsh+Pjnscl JQYmNIAchqr6Xf6xniLxWNKZaFL38j4nWBYe+HygM7efrVxwe6IMImIEoTwuLEV/zxH2CjZfHB6ZeN wp90D1H0WnxpxuaUYYXXqDJ5YCRig4NyaboWviqrNd0Aj+tVRJ4E3oXOFVsw== X-Developer-Key: i=jcormier@criticallink.com; a=openpgp; fpr=FF328CEA09E66D63136754DFDCD7FD2E0B36EBAA X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756126325090835794?= X-GMAIL-MSGID: =?utf-8?q?1756126325090835794?= From: John Pruitt Add the ability to specify the value of the shunt resistor in the device tree instead of assuming it is 1 milliOhm. The value in the device tree has the name shunt-resistor-micro-ohms and the default value is 1000 micro-ohms in order to preserve the current behavior. Signed-off-by: Jonathan Cormier Signed-off-by: John Pruitt --- drivers/hwmon/ltc2945.c | 117 +++++++++++++++++++++++++++++++----------------- 1 file changed, 75 insertions(+), 42 deletions(-) diff --git a/drivers/hwmon/ltc2945.c b/drivers/hwmon/ltc2945.c index ac15298a6558..0b5e448b4f12 100644 --- a/drivers/hwmon/ltc2945.c +++ b/drivers/hwmon/ltc2945.c @@ -64,6 +64,16 @@ static const struct of_device_id __maybe_unused ltc2945_of_match[] = { }; MODULE_DEVICE_TABLE(of, ltc2945_of_match); +/** + * struct ltc2945_data - LTC2945 device data + * @regmap: regmap device + * @shunt_resistor: shunt resistor value in micro ohms (1000 by default) + */ +struct ltc2945_data { + struct regmap *regmap; + u32 shunt_resistor; +}; + static inline bool is_power_reg(u8 reg) { return reg < LTC2945_SENSE_H; @@ -72,7 +82,9 @@ static inline bool is_power_reg(u8 reg) /* Return the value from the given register in uW, mV, or mA */ static long long ltc2945_reg_to_val(struct device *dev, u8 reg) { - struct regmap *regmap = dev_get_drvdata(dev); + struct ltc2945_data *data = dev_get_drvdata(dev); + struct regmap *regmap = data->regmap; + u32 shunt_resistor = data->shunt_resistor; unsigned int control; u8 buf[3]; long long val; @@ -84,10 +96,10 @@ static long long ltc2945_reg_to_val(struct device *dev, u8 reg) return ret; if (is_power_reg(reg)) { - /* power */ + /* 24-bit power */ val = (buf[0] << 16) + (buf[1] << 8) + buf[2]; } else { - /* current, voltage */ + /* 12-bit current, voltage */ val = (buf[0] << 4) + (buf[1] >> 4); } @@ -98,9 +110,7 @@ static long long ltc2945_reg_to_val(struct device *dev, u8 reg) case LTC2945_MAX_POWER_THRES_H: case LTC2945_MIN_POWER_THRES_H: /* - * Convert to uW by assuming current is measured with - * an 1mOhm sense resistor, similar to current - * measurements. + * Convert to uW * Control register bit 0 selects if voltage at SENSE+/VDD * or voltage at ADIN is used to measure power. */ @@ -114,6 +124,14 @@ static long long ltc2945_reg_to_val(struct device *dev, u8 reg) /* 0.5 mV * 25 uV = 0.0125 uV resolution. */ val = (val * 25LL) >> 1; } + val *= 1000; + /* Overflow check: Assuming max 24-bit power, val is at most 53 bits right now. */ + val = DIV_ROUND_CLOSEST_ULL(val, shunt_resistor); + /* + * Overflow check: After division, depending on shunt resistor, + * val can still be > 32 bits so returning long long makes sense + */ + break; case LTC2945_VIN_H: case LTC2945_MAX_VIN_H: @@ -136,14 +154,11 @@ static long long ltc2945_reg_to_val(struct device *dev, u8 reg) case LTC2945_MIN_SENSE_H: case LTC2945_MAX_SENSE_THRES_H: case LTC2945_MIN_SENSE_THRES_H: - /* - * 25 uV resolution. Convert to current as measured with - * an 1 mOhm sense resistor, in mA. If a different sense - * resistor is installed, calculate the actual current by - * dividing the reported current by the sense resistor value - * in mOhm. - */ - val *= 25; + /* 25 uV resolution. Convert to mA. */ + val *= 25 * 1000; + /* Overflow check: Assuming max 12-bit sense, val is at most 27 bits right now */ + val = DIV_ROUND_CLOSEST_ULL(val, shunt_resistor); + /* Overflow check: After division, <= 27 bits */ break; default: return -EINVAL; @@ -151,13 +166,18 @@ static long long ltc2945_reg_to_val(struct device *dev, u8 reg) return val; } -static int ltc2945_val_to_reg(struct device *dev, u8 reg, - unsigned long val) +static long long ltc2945_val_to_reg(struct device *dev, u8 reg, + unsigned long long val) { - struct regmap *regmap = dev_get_drvdata(dev); + struct ltc2945_data *data = dev_get_drvdata(dev); + struct regmap *regmap = data->regmap; + u32 shunt_resistor = data->shunt_resistor; unsigned int control; int ret; + /* Ensure we don't overflow */ + val = clamp_val(val, 0, U32_MAX); + switch (reg) { case LTC2945_POWER_H: case LTC2945_MAX_POWER_H: @@ -165,9 +185,6 @@ static int ltc2945_val_to_reg(struct device *dev, u8 reg, case LTC2945_MAX_POWER_THRES_H: case LTC2945_MIN_POWER_THRES_H: /* - * Convert to register value by assuming current is measured - * with an 1mOhm sense resistor, similar to current - * measurements. * Control register bit 0 selects if voltage at SENSE+/VDD * or voltage at ADIN is used to measure power, which in turn * determines register calculations. @@ -177,14 +194,16 @@ static int ltc2945_val_to_reg(struct device *dev, u8 reg, return ret; if (control & CONTROL_MULT_SELECT) { /* 25 mV * 25 uV = 0.625 uV resolution. */ - val = DIV_ROUND_CLOSEST(val, 625); + val *= shunt_resistor; + /* Overflow check: Assuming 32-bit val and shunt resistor, val <= 64bits */ + val = DIV_ROUND_CLOSEST_ULL(val, 625 * 1000); + /* Overflow check: val is now <= 44 bits */ } else { - /* - * 0.5 mV * 25 uV = 0.0125 uV resolution. - * Divide first to avoid overflow; - * accept loss of accuracy. - */ - val = DIV_ROUND_CLOSEST(val, 25) * 2; + /* 0.5 mV * 25 uV = 0.0125 uV resolution. */ + val *= shunt_resistor; + /* Overflow check: Assuming 32-bit val and shunt resistor, val <= 64bits */ + val = DIV_ROUND_CLOSEST_ULL(val, 25 * 1000) * 2; + /* Overflow check: val is now <= 51 bits */ } break; case LTC2945_VIN_H: @@ -208,14 +227,11 @@ static int ltc2945_val_to_reg(struct device *dev, u8 reg, case LTC2945_MIN_SENSE_H: case LTC2945_MAX_SENSE_THRES_H: case LTC2945_MIN_SENSE_THRES_H: - /* - * 25 uV resolution. Convert to current as measured with - * an 1 mOhm sense resistor, in mA. If a different sense - * resistor is installed, calculate the actual current by - * dividing the reported current by the sense resistor value - * in mOhm. - */ - val = DIV_ROUND_CLOSEST(val, 25); + /* 25 uV resolution. Convert to mA. */ + val *= shunt_resistor; + /* Overflow check: Assuming 32-bit val and 32-bit shunt resistor, val is 64bits */ + val = DIV_ROUND_CLOSEST_ULL(val, 25 * 1000); + /* Overflow check: val is now <= 50 bits */ break; default: return -EINVAL; @@ -240,15 +256,16 @@ static ssize_t ltc2945_value_store(struct device *dev, const char *buf, size_t count) { struct sensor_device_attribute *attr = to_sensor_dev_attr(da); - struct regmap *regmap = dev_get_drvdata(dev); + struct ltc2945_data *data = dev_get_drvdata(dev); + struct regmap *regmap = data->regmap; u8 reg = attr->index; - unsigned long val; + unsigned int val; u8 regbuf[3]; int num_regs; - int regval; + long long regval; int ret; - ret = kstrtoul(buf, 10, &val); + ret = kstrtouint(buf, 10, &val); if (ret) return ret; @@ -277,7 +294,8 @@ static ssize_t ltc2945_history_store(struct device *dev, const char *buf, size_t count) { struct sensor_device_attribute *attr = to_sensor_dev_attr(da); - struct regmap *regmap = dev_get_drvdata(dev); + struct ltc2945_data *data = dev_get_drvdata(dev); + struct regmap *regmap = data->regmap; u8 reg = attr->index; int num_regs = is_power_reg(reg) ? 3 : 2; u8 buf_min[3] = { 0xff, 0xff, 0xff }; @@ -329,7 +347,8 @@ static ssize_t ltc2945_bool_show(struct device *dev, struct device_attribute *da, char *buf) { struct sensor_device_attribute *attr = to_sensor_dev_attr(da); - struct regmap *regmap = dev_get_drvdata(dev); + struct ltc2945_data *data = dev_get_drvdata(dev); + struct regmap *regmap = data->regmap; unsigned int fault; int ret; @@ -458,6 +477,12 @@ static int ltc2945_probe(struct i2c_client *client) struct device *dev = &client->dev; struct device *hwmon_dev; struct regmap *regmap; + struct ltc2945_data *data; + + data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + dev_set_drvdata(dev, data); regmap = devm_regmap_init_i2c(client, <c2945_regmap_config); if (IS_ERR(regmap)) { @@ -465,11 +490,19 @@ static int ltc2945_probe(struct i2c_client *client) return PTR_ERR(regmap); } + data->regmap = regmap; + if (device_property_read_u32(dev, "shunt-resistor-micro-ohms", + &data->shunt_resistor)) + data->shunt_resistor = 1000; + + if (data->shunt_resistor == 0) + return -EINVAL; + /* Clear faults */ regmap_write(regmap, LTC2945_FAULT, 0x00); hwmon_dev = devm_hwmon_device_register_with_groups(dev, client->name, - regmap, + data, ltc2945_groups); return PTR_ERR_OR_ZERO(hwmon_dev); } From patchwork Thu Jan 26 22:32:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cormier X-Patchwork-Id: 48942 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp521945wrn; Thu, 26 Jan 2023 14:36:51 -0800 (PST) X-Google-Smtp-Source: AK7set9RiiFnbcMIlAnkPuXePWxiYdc/Tu7LYna5u+a1PeawaxSq4TGx10cSlUc5Y0h/oOC1Ueuc X-Received: by 2002:aa7:9843:0:b0:590:7103:231f with SMTP id n3-20020aa79843000000b005907103231fmr5109968pfq.7.1674772611447; Thu, 26 Jan 2023 14:36:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674772611; cv=none; d=google.com; s=arc-20160816; b=atOqB07ydk0fN9FaWvGrUPE8oQONFoJu9z/uKIg9YNhdertQeel0oypC54F+k7s9nx C9teunLsG2Yl25dexu4bQ4gyGaMHMQtOgOEGCgUUkUJgb6ep1KPV/0qtkunolpNtwlR0 OuXolRAige/2A+cPnifycl/9hThmDlFfryYNurZacOaCAgDVGobHwd4mWB0nnapkTTMC RviP33LIwInbk/U/n6lyPUOiI92bSEosxJZ5xtEkmFvV1ja3vUv2OtaL/pl6PbZ6GL6l btPSp+pf9wemmso9iYCLdk90khV/Q+txJ8cJ3uaueMjAHqEsmWW0coflFVqX30Tqb6ML 2tCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=SMXyMh+Lwz3neJnqgLoV44iMFdZ/93CQTC6eXheel78=; b=wDUAPcHmtD5wiX4c7svaTsUAGzq3BUN9QZ/d/xx37B7V2moejPQVzl8qWr8pd/6SB+ 5bUtWrg9j1t8PWWcehJzSPNwxzPiMPhgC4bRsTVYHerTieJ/zs1QGIO4wEJJYafB8iRt KOnOH7fBpCY7TDb+jzpoqYxVmpNi+NfCjzVEcAkPGS0OnlnbPyd4w3GbYt+/mzwrX6Zn UvTSjAnOaZYVo/L85mXJZc7ciB3zO1b+aUu1I5whRVQoJu9dknsohV/lWPgz+27uIABQ i7NhJFdqVqZOwPUsSTXDepCsoVJZ7PPicpdi5og1/KlG2gtahJ72YMfNDgWEDJvbbAr3 PLvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@criticallink.com header.s=google header.b=khx+stdm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=criticallink.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x1-20020aa79561000000b0058de0c97e14si2507330pfq.193.2023.01.26.14.36.38; Thu, 26 Jan 2023 14:36:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@criticallink.com header.s=google header.b=khx+stdm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=criticallink.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233295AbjAZWdk (ORCPT + 99 others); Thu, 26 Jan 2023 17:33:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233184AbjAZWcx (ORCPT ); Thu, 26 Jan 2023 17:32:53 -0500 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 738964C3F for ; Thu, 26 Jan 2023 14:32:33 -0800 (PST) Received: by mail-qv1-xf35.google.com with SMTP id d13so2587084qvj.8 for ; Thu, 26 Jan 2023 14:32:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=criticallink.com; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SMXyMh+Lwz3neJnqgLoV44iMFdZ/93CQTC6eXheel78=; b=khx+stdm8gj3hVORCp3vGGwzfpFUtfpBgTEIanFn6fjEYFTnrg3+LJgDpc96HX/Ty7 4r8nwbwrUYp33LQaJHweQcEKn8jjR8j7kqqFxk55wQLrkNkkwZMLgPnXhCBVRRB8wRD4 YjNo3Y7rVbe+cT8kXRVPzB/FCCBY+8JRM2SHLeXxJjRUndyxqED4/EVnvYQLPafZmOBE fHQiMZuR+zPKShSVcp/k9YHvED3hQ0szFF+oWdaqPwNspv/2yQ37ogMmIOdWaKo9p/fJ +etDkPnrFgxbbafSb+giy1XA1g061fGgoHhmDN1gVZcc0AAm7jZ4fpNeMg9fv5eL8TQW IfrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SMXyMh+Lwz3neJnqgLoV44iMFdZ/93CQTC6eXheel78=; b=PkZLAfIJ+e2SZcK+d3VCEbqIzEtILx0w8r0t5WNnriheuK4m/1Ou8l/dmKK5+OvVM5 wj7JkLbWPg/EeXZ23S6b0a2O17FmlmptjErMUXy55oK1a5cuzxVcbbnmvrJw2u44mbNl ucH+Dak1nlaEHSeAL7qX0xvmyRLV0HrEh5T/cIbmPt7b6ig+K+RIS3qNd3wvKAc3okDN ESpQjkCealjtdka1V8JS5N5JlwujQP+5/+T/59crM+u1lbgl+aScWbNMYJOFJDgW1C3J iwWFlYSyAKlzKf5t8uwKvPVOY7Rd8eziMn23puN+nYrWTfK3f7CSWx7bki2a7KHcaStG n40g== X-Gm-Message-State: AFqh2kqkcuPm+cgsSBnAoZWNpscBvobyLPDDeqVJMtv0xYs3vIBA3WC3 IOFhr4hQYD7YT3IN0wLjDLiCrg== X-Received: by 2002:a05:6214:3492:b0:534:2b55:6320 with SMTP id mr18-20020a056214349200b005342b556320mr55824540qvb.9.1674772353054; Thu, 26 Jan 2023 14:32:33 -0800 (PST) Received: from [127.0.1.1] (static-72-90-70-109.syrcny.fios.verizon.net. [72.90.70.109]) by smtp.gmail.com with ESMTPSA id m7-20020a05620a220700b006ff8a122a1asm1723091qkh.78.2023.01.26.14.32.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 14:32:32 -0800 (PST) From: Jonathan Cormier Date: Thu, 26 Jan 2023 17:32:27 -0500 Subject: [PATCH v4 5/5] hwmon: ltc2945: Convert division to DIV_ROUND_CLOSEST_ULL MIME-Version: 1.0 Message-Id: <20230126-b4-ltc2945_shunt_resistor-v4-5-bb913470d8da@criticallink.com> References: <20230126-b4-ltc2945_shunt_resistor-v4-0-bb913470d8da@criticallink.com> In-Reply-To: <20230126-b4-ltc2945_shunt_resistor-v4-0-bb913470d8da@criticallink.com> To: Jean Delvare , Guenter Roeck , Rob Herring , Krzysztof Kozlowski Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bob Duke , John Pruitt , Jonathan Cormier X-Mailer: b4 0.12.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=708; i=jcormier@criticallink.com; h=from:subject:message-id; bh=ztSizwKCRQbuO5hjHb+ixZi9TnHDXa8I5HXLLGMpWUk=; b=owEBbQKS/ZANAwAKAdzX/S4LNuuqAcsmYgBj0v96Md1xv21n7cR5HEwD5IPLFz0I12Y2BnjVI/ES HP4bOeCJAjMEAAEKAB0WIQT/MozqCeZtYxNnVN/c1/0uCzbrqgUCY9L/egAKCRDc1/0uCzbrqoLlD/ wNZmu751rOnzdh7g2RQ5g7eZ3Y51D8vPnAwxHLHA8qgc1jAv7nVp4+T4xtxMyfbrI8R8VNK0PM8NLe l/expSHT30K8SZhxjrLn7r5AdiAh2jOLIxPCbMTnf4ZSZOAAViy9YUhLFpg94Qa9bNOVupLDd6p3ml QJuuW4HoPRJkcjetV/cQLrHhkdcJd/fxExAnQABDGltSrKhbIFDwVVKxkOhgAzCs4QiZgB91KWpdei sa5xVLscph09wvnHjkKGG1hIK0pISajE9GIBPdM1R7ek8rdhQCU3jblxIkQxDFnjWHgjE01V2W9HQ1 5NOM8sFqobmMsOyr4S8h6Y+Kcikh6HGZRdquU+oMQy+c6Y97VH4gG24ZWTNhNxau3qIVJcCb4Cmv2m KWYrNfJCNe3zF7wN0qy7D4WT2aVhRWGHZCGztcQdhg6CMc+jESLjuc4maOg0pxjh8mKOledXGK6LLm 3nKoCUicm14yoD6vnCcHB+FuZLc+o1crK/+UmOTKEYbzMY79FNEHQNfx90bs+qz0wOzdG70lb11OqU /OcejxRTDxEHxdsXj7p29v1a/NOfvUrzW0rmZqoNdGB1kESXI+bOINOhSyWeb9TUAfmQYC4rISi15G FTTLoHHR5blXPO0dLrzaJ9g6O2dO/ZiTKmUEQAwYDQmUuy2sZdn+acrXVrXg== X-Developer-Key: i=jcormier@criticallink.com; a=openpgp; fpr=FF328CEA09E66D63136754DFDCD7FD2E0B36EBAA X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756126365818120526?= X-GMAIL-MSGID: =?utf-8?q?1756126365818120526?= Convert division to DIV_ROUND_CLOSEST_ULL to match code in same function. Signed-off-by: Jonathan Cormier --- drivers/hwmon/ltc2945.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/ltc2945.c b/drivers/hwmon/ltc2945.c index 0b5e448b4f12..33341d01f1f7 100644 --- a/drivers/hwmon/ltc2945.c +++ b/drivers/hwmon/ltc2945.c @@ -212,7 +212,7 @@ static long long ltc2945_val_to_reg(struct device *dev, u8 reg, case LTC2945_MAX_VIN_THRES_H: case LTC2945_MIN_VIN_THRES_H: /* 25 mV resolution. */ - val /= 25; + val = DIV_ROUND_CLOSEST_ULL(val, 25); break; case LTC2945_ADIN_H: case LTC2945_MAX_ADIN_H: