From patchwork Fri Oct 14 15:04:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Delaunay X-Patchwork-Id: 2726 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp234942wrs; Fri, 14 Oct 2022 08:14:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4u8wZwMUdGWxMuLCBDDDSvL+aeFKAJO0sD8ZiXWeXGP+NeaoSKCkdrFNq1cIGSmrPXFXau X-Received: by 2002:a17:902:9684:b0:17e:71b2:bd16 with SMTP id n4-20020a170902968400b0017e71b2bd16mr5850754plp.163.1665760483304; Fri, 14 Oct 2022 08:14:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665760483; cv=none; d=google.com; s=arc-20160816; b=AzP2ZxsjEZn1OnKpJpQqkcUirUxQPj7npCu+3Pxhn9OVdM0hF69d5Cq+JG3iS4yNEF kCS50San3bp9Nl9TZHEquSawegzEiIBp1ZO3G+IVvGGcYLZenJ5/kDPceUTV/gYeYo9r zP7/yl1xrJsvJBM2YlIGSnM8SZOkLFDXI1lev87y37ZkoqbzWvHAveV46nSFDeHhrYdC V2uHKPRFdREqLshQWRkU+7aS8/qu75AsQfij5IUUTCIS0pwsWRwexBv0dl0njdqK7l4K GtpFGme5MXb677pB6Tza29JyfA2kSVLzgZvEdhGnmyFd3OzEhEi+Uw2Df7rJ+v3LacCm CFEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=wRlyGKw6VgdQ2d1sRB7WsBi1jFMUKA9qlH7Ogi8UJ3Q=; b=Fco9HI4Xu9nQ1AZIKl4LdXbkeittsj6M7kG2bbVf3BbGN2oRKBw+GuJ2Xqk/CaTbnA Cwfo3Ry6E/mRwcI2ZAEkYgcRx2wCiYTU2d0l8NpxhO3qztxuQAT52loId7dqoJko6H50 wuTc/OvvNI8nqGLCHcZ8i2dGyuHJTVDJDBDiQrjuD5hlTArSyasTgvfUv8y8mFFdX/Vl maOzP5JKDq3y7Zkv54lhkoIIKB5U6a6UbbUU13UoLHk0OstnwKW+rzZ+SQJX7mKCeCok QJG1RJwtEmdog4C8+DKuBhMoU6YlAjDelFoR9QY0O7ass6OUGUSr7Lgqmf9NlmKpdvPk 11JA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=SZ3hTvda; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f23-20020a63de17000000b0046ae2a99bc3si2888981pgg.357.2022.10.14.08.14.28; Fri, 14 Oct 2022 08:14:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=SZ3hTvda; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229799AbiJNPFe (ORCPT + 99 others); Fri, 14 Oct 2022 11:05:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229824AbiJNPFb (ORCPT ); Fri, 14 Oct 2022 11:05:31 -0400 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84881A3AAB for ; Fri, 14 Oct 2022 08:05:29 -0700 (PDT) Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29EF5CUm031283; Fri, 14 Oct 2022 17:05:16 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=selector1; bh=wRlyGKw6VgdQ2d1sRB7WsBi1jFMUKA9qlH7Ogi8UJ3Q=; b=SZ3hTvda1/8mgXWADaxQc5uP+6m6EJSUGbwxAVUNdADrYqx97d75pK101tdOl5VJqH7M xeesK61F6zcZczXV1+Vfv+IysappYKZh54mMdnAUCVpnl0UHvr4fTiP4PQsQDmErhjSD FY3PXltu0Vgf2mPioCh9I88Ce8ZBm4Ba1J7ssZjfp8IeBGvnJzsIsNQAR+ISAfybjrSX 7j8oqipLlWInnojuDGd8M0fmRfU0nQ2UJj9QNa7dxc2krpP7fvNVpDQmugzP/JFj0Psy za9EIKOZMfQAxal7+K3yLRcsh3BL4425OrSi2ypNNoH5vmwsx0uQZmOZo0ai9yOq6Ie5 uQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3k64m7xbpe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Oct 2022 17:05:16 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 292EA100038; Fri, 14 Oct 2022 17:05:13 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 23FC0233C75; Fri, 14 Oct 2022 17:05:13 +0200 (CEST) Received: from localhost (10.75.127.50) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2375.31; Fri, 14 Oct 2022 17:05:10 +0200 From: Patrick Delaunay To: Srinivas Kandagatla , Maxime Coquelin , Alexandre Torgue CC: Patrick Delaunay , , , Subject: [PATCH 1/2] nvmem: stm32: add warning when upper OTPs are updated Date: Fri, 14 Oct 2022 17:04:28 +0200 Message-ID: <20221014170426.1.Ifa806ff30d7c669ba9a3df9c6b64698a2dcc073a@changeid> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-14_08,2022-10-14_01,2022-06-22_01 X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746676464522197947?= X-GMAIL-MSGID: =?utf-8?q?1746676464522197947?= As the upper OTPs are ECC protected, they support only one 32 bits word programming. For a second modification of this word, these ECC become invalid and this OTP will be no more accessible, the shadowed value is invalid. This patch adds a warning to indicate an upper OTP update, because this operation is dangerous as OTP is not locked by the driver after the first update to avoid a second update. Signed-off-by: Patrick Delaunay --- drivers/nvmem/stm32-romem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/nvmem/stm32-romem.c b/drivers/nvmem/stm32-romem.c index 354be526897f..e3c3c333b5d1 100644 --- a/drivers/nvmem/stm32-romem.c +++ b/drivers/nvmem/stm32-romem.c @@ -133,6 +133,9 @@ static int stm32_bsec_write(void *context, unsigned int offset, void *buf, } } + if (offset + bytes >= priv->lower * 4) + dev_warn(dev, "Update of upper OTPs with ECC protection (word programming, only once)\n"); + return 0; } From patchwork Fri Oct 14 15:04:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Delaunay X-Patchwork-Id: 2725 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp234331wrs; Fri, 14 Oct 2022 08:13:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4+gqYD9bgVDTvXvDoBF9Q4O/PPV76+olK/fExAwhKJKTE8pUKMNRKZlmEtx4h9eOByopAC X-Received: by 2002:a17:902:ce8f:b0:178:703f:68bb with SMTP id f15-20020a170902ce8f00b00178703f68bbmr5647160plg.7.1665760423615; Fri, 14 Oct 2022 08:13:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665760423; cv=none; d=google.com; s=arc-20160816; b=rSeIAJ3WKG7V1tWCBx/+Zx2582syAfU03w+gTtoBuGEw9KyLleCfb1m7Ar44Lrn4IW DE6YeBCBVCb7bIE2H6UjHSm0rzKnZgyqRIz2yeHLPmL/16H9fWgz/myDxRC2xF3U98dP J4sp8umTMAu+cTnhy/AksiCLcbFuNIGCDAtKeLqf02deROTgzgGeGSyhWV7msS+wkl8V oTq+PrIpsIyYG0si47nleKX9ZDFrLAkOW+qszI0+v+OHpNaWsfg2N31z8OZf6mxrPeTX 5prpUlHbioc9l7Xk6KLBVees/H55bjfDkOamecB7p8rPYZiiDEwW1m7/tVKe6ZRdv3Ev KmtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=npw86qUeqP5mhoB1P4qfCWCWdob8jPDQT+PZIr9f+XE=; b=fA/jF2Fk00TNSDewDlq+fvrcyNPxsonZUF41oTudbxIlSgmswvt7EF3K/X4pyJuQrT /y7rE5Q08zxEwbexRESeDvdQIX4cG4l977tJd4w4KWJ1LSLr9f9iCglusdxtoHbwWgWy 23p03yUNkPoFop2rpbCUxN/O3vjNR5hDT8t6e8AQ7xs4LJ3RANwBDXIhrJ+Lul7khP5O iSbdGIvYWdtMgFMZnG0LXgRUiwLNrJNGxxeE6UU4S5K2+JQUF6wDBJjZU3S/sHornei8 Kpt81mTEoyIss+wh6Mmv+qCRiWOhN6l2VvRsrXlbtjBjGpEru4iPpBQZWYIQM1srCsIo /usg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=CqImZdRa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q6-20020a170902dac600b0017b6eaa5dc5si3490456plx.315.2022.10.14.08.13.29; Fri, 14 Oct 2022 08:13:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=CqImZdRa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229838AbiJNPFi (ORCPT + 99 others); Fri, 14 Oct 2022 11:05:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbiJNPFc (ORCPT ); Fri, 14 Oct 2022 11:05:32 -0400 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98A8CAD9B4 for ; Fri, 14 Oct 2022 08:05:30 -0700 (PDT) Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29EF5CGh032239; Fri, 14 Oct 2022 17:05:16 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=selector1; bh=npw86qUeqP5mhoB1P4qfCWCWdob8jPDQT+PZIr9f+XE=; b=CqImZdRarYObvR0YIp+8/zEXErxeB8EkV1hexKoOtCWqAeQUUgiPtSvBmaPlHmBfSLwa 9u5GvY8aYB5O6ovoTNpk+ju/7QnJkiTfJkxPlAfW3AdDM6lrAyVW77M4VvABoRWh0Hn4 ybhS6JxHU62uy3GQ2Mwz8H46gjc+WpEgHdW+ed1CmLDYnkzXAHBLB1/rRKQMBbmvx0Rw FQfnoHrGXWWCdevSJ9hfBpdzCblchvJ75qeD478IcrwzrcKesyfwYz5IZfe6FBY6aHUf zody0QCtQKhhtMTKDDngne7ccZw0warGYg1gljPRTKPgcTSsOK5XnPZoiULHvrf1aU85 gw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3k75sd9w8v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Oct 2022 17:05:16 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id AC3A6100034; Fri, 14 Oct 2022 17:05:12 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id A2945233C74; Fri, 14 Oct 2022 17:05:12 +0200 (CEST) Received: from localhost (10.75.127.122) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2375.31; Fri, 14 Oct 2022 17:05:11 +0200 From: Patrick Delaunay To: Srinivas Kandagatla , Maxime Coquelin , Alexandre Torgue CC: Patrick Delaunay , , , Subject: [PATCH 2/2] nvmem: stm32: add nvmem type attribute Date: Fri, 14 Oct 2022 17:04:29 +0200 Message-ID: <20221014170426.2.Iaff264d5b87f54b7c5fe3a408b4d1662d1fdfd2a@changeid> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221014170426.1.Ifa806ff30d7c669ba9a3df9c6b64698a2dcc073a@changeid> References: <20221014170426.1.Ifa806ff30d7c669ba9a3df9c6b64698a2dcc073a@changeid> MIME-Version: 1.0 X-Originating-IP: [10.75.127.122] X-ClientProxiedBy: GPXDAG2NODE4.st.com (10.75.127.68) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-14_08,2022-10-14_01,2022-06-22_01 X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746676401921558845?= X-GMAIL-MSGID: =?utf-8?q?1746676401921558845?= Inform NVMEM framework of type attribute for stm32-romem as NVMEM_TYPE_OTP so userspace is able to know how the data is stored in BSEC. Signed-off-by: Patrick Delaunay --- drivers/nvmem/stm32-romem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvmem/stm32-romem.c b/drivers/nvmem/stm32-romem.c index e3c3c333b5d1..7b3a5a5a64b0 100644 --- a/drivers/nvmem/stm32-romem.c +++ b/drivers/nvmem/stm32-romem.c @@ -161,6 +161,7 @@ static int stm32_romem_probe(struct platform_device *pdev) priv->cfg.dev = dev; priv->cfg.priv = priv; priv->cfg.owner = THIS_MODULE; + priv->cfg.type = NVMEM_TYPE_OTP; cfg = (const struct stm32_romem_cfg *) of_match_device(dev->driver->of_match_table, dev)->data;