From patchwork Tue Jan 24 22:03:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 47914 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2394689wrn; Tue, 24 Jan 2023 14:07:04 -0800 (PST) X-Google-Smtp-Source: AMrXdXsWtl4wS2EQTLGlVnhEnIPmgRlLoCDV9+eNJAOeSiDBsHNFH4zdFcnPinrFlwWwrJBPzq3M X-Received: by 2002:a17:906:6b86:b0:86b:6a02:3187 with SMTP id l6-20020a1709066b8600b0086b6a023187mr42575301ejr.71.1674598024325; Tue, 24 Jan 2023 14:07:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674598024; cv=none; d=google.com; s=arc-20160816; b=uBKDj5WjC0CR2qsdk5eBr9eE/Qt+YyVgiRF6K1d+EYMXYlBMtq9Nyy0maVrCqNPGUo 3/9Zr9rPrLTZd1lRzn+da9wtuE6Ie5ZusVFa6vzgPcn0yWBvFkswnU9W9XoIEV5uUl03 Cn34NVHQ0ESG4sbFUNGSbDvRjKvUMsdO6elt4bmGNg77SBtrBlGkW6koUVgh+yYSjsVW nuREk3TJPd6hwN1gfGUXa6qgLH2vKd8KbAq2faa7e3sUprOVSpUuSMK2uAUUjRroTkCG dU6U/vB5S+aYICgXcdZJ7SY4h48X+jOxR7aLnonDJsupGXjcL13pVWZk4tA6ZgwJvHf+ 5AJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=E3QUDM7lOv5vhtcSI90OpPSN2/l5dUarb+bY6Rv4FS0=; b=viOatR/+yuZQOYiMAOq4GO6FL7Q2P801e6SDOGzkXOZaygFKVjKRblJy6R5v7ErjNq Q8U/RleRWM0J/LHaUg3/FCRZCB9p7Wh4/Mos232ij6vd6ba0wJUBdlgS54eeWXtp5Zff cQ68JiQABZyT7u+TlvYYX8ulwDe1ppnLq8GZ/0vd/U5mf+GIrku2hcWPb9E9pxYeEEB8 F4PODObPSMMfm5F2Yo3lrmSBCCVm8PhVeVQG7OzMfS2yuYYX9GJRITbuzaFyHHb6M2e/ Ubo+30P3HmJtZjuQSGNFYIvjB7IaWxx1dEP0ttZzyoeUDGt8aSyhTLNK0wkbS+cJ2Rq0 OSSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HnDQ8jcU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z27-20020a17090674db00b0086ef097dc5esi4022971ejl.887.2023.01.24.14.06.40; Tue, 24 Jan 2023 14:07:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HnDQ8jcU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234553AbjAXWDT (ORCPT + 99 others); Tue, 24 Jan 2023 17:03:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234596AbjAXWDS (ORCPT ); Tue, 24 Jan 2023 17:03:18 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D490C30E96 for ; Tue, 24 Jan 2023 14:03:14 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id h16so15259277wrz.12 for ; Tue, 24 Jan 2023 14:03:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=E3QUDM7lOv5vhtcSI90OpPSN2/l5dUarb+bY6Rv4FS0=; b=HnDQ8jcUqzklYtZ+03sHwmyFK6XwULAk90aX9K8vKRZmzTSzBSE+x5U9WJUQ/2ZMiw 5WJx8nGlSFG2PmE+vjWUNeWoaJ9PEX9JZCRSuTCWKjIrS6jWn0/6xXZR3Zve4GhWrkgw VtZ1HdZxdEFE58L+Y/ohnStgDkf1/Cw9aa0wq8F7rXCprFFhPUxPkNprBf09rSikdYjd 47lB4MR8ZiZcyCBMvaynOXwckJ59EWSeFzrWegWYI263Y859xrv4Ft1w5Boois8daGpz 87BmOatXXFM1w0iLc3E1wjcKQwQTeap/iQd3xoGEpcz3i33hFIwInjllbVUsE3OD70pL /N3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E3QUDM7lOv5vhtcSI90OpPSN2/l5dUarb+bY6Rv4FS0=; b=tcK+KCLUulLbPvj0ox1qbZFvIFRhbSZSeWwawedZR0idGUTWFuvQdnt4ImGvH+c6lE 3ujsU/4f87KQN6Q0KfibSD/XQ0lFVy942WWf7/BmLgqfvFVKxM2Rdqm7qraxxDverOud U07O+3PJ9L8Iz0vAUSfVK+fySyqNKVfqZbBAC7w2QM4exza5d2rgoqPQxIh6cT6nqcgT JaX1ZdIT2wNsenM7upFay2bi2poHR7Lg2FdcLJRVrOCkugd23TRaPRS844phJyaKtvYY yq9YKXAAkSTq/IBtJdkkanLV8GGnvuRWHFNnzKELasw6VE7+558KHRdEbddx9vr6deYj gwxQ== X-Gm-Message-State: AO0yUKVR/LBbMv1WxVGS6rET/olveoVr34NlMyiMnjfDr0+Ju750jHfR 1Zljk6j0KbwfaOp4cF34wSc= X-Received: by 2002:adf:a492:0:b0:2bf:b9b1:9568 with SMTP id g18-20020adfa492000000b002bfb9b19568mr3649wrb.2.1674597793145; Tue, 24 Jan 2023 14:03:13 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id r4-20020a5d4e44000000b0027cb20605e3sm2814715wrt.105.2023.01.24.14.03.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 14:03:12 -0800 (PST) Date: Tue, 24 Jan 2023 23:03:10 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 01/11] staging: rtl8192e: Remove unused variables rxrdu and rxok Message-ID: <20738d339066e36f5347c7e5011bd3d1aa3e4f53.1674596722.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755943298317993426?= X-GMAIL-MSGID: =?utf-8?q?1755943298317993426?= rxrdu and rxok are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 -- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 80450d46191c..605146c840c7 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -1938,7 +1938,6 @@ static void _rtl92e_rx_normal(struct net_device *dev) if (!rtllib_rx(priv->rtllib, skb, &stats)) { dev_kfree_skb_any(skb); } else { - priv->stats.rxok++; if (unicast_packet) priv->stats.rxbytesunicast += skb_len; } @@ -2186,7 +2185,6 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) tasklet_schedule(&priv->irq_prepare_beacon_tasklet); if (inta & IMR_RDU) { - priv->stats.rxrdu++; rtl92e_writel(dev, INTA_MASK, rtl92e_readl(dev, INTA_MASK) & ~IMR_RDU); tasklet_schedule(&priv->irq_rx_tasklet); diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index 983bc663a570..82cbc7f5536a 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -183,8 +183,6 @@ enum reset_type { }; struct rt_stats { - unsigned long rxrdu; - unsigned long rxok; unsigned long rxdatacrcerr; unsigned long rxmgmtcrcerr; unsigned long rxcrcerrmin; From patchwork Tue Jan 24 22:03:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 47915 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2394779wrn; Tue, 24 Jan 2023 14:07:19 -0800 (PST) X-Google-Smtp-Source: AMrXdXvPV5ajy3ByToKhfCYZQUG4ZWsaLb8lo8sjJ8kBJnGF8y/gS31v1nMPPAyFTRd0qkkvhq5D X-Received: by 2002:a17:907:d094:b0:7c9:6e0e:1427 with SMTP id vc20-20020a170907d09400b007c96e0e1427mr28705113ejc.6.1674598039807; Tue, 24 Jan 2023 14:07:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674598039; cv=none; d=google.com; s=arc-20160816; b=q9vl1AGtDTHLhFu6JmUgqUuBEVcx5AT2e/cvbygTnHuTSmqhnXTTbJFgr6iWKCS5qA q/aBZDoLshwRY1JiqvXhMZSjE1RNLAtvRm8sf5egy/ZBbGjSFkOsUCZfg6A20Tzi+N0p UAz4U/cQaQzFWl0Jk02/OcBdGMlPiN4tVak8fFnmR87F9YD2/wL7MRNhjNXdPZ9+W8aS wmUDy9hZgvljg+aoo8oWe3OBYEUtM4h3gOByG03ydJoKP5TjyPeQRhCuylyFKneR7fQD Q+4wKv7r/pu7YVs6vIS6ak1eBNLGgtCZ1zn68zD93xKMRztnLu5wG9eXyyO9RO1+JJ40 c2xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=bF+Lp+JDPbwdrmjIfQ0g/QFY3xJvOU79Nk3DY5MrQzU=; b=W6XlzRPsiKviWcy6pTP4NXDLxdNLwzgekUnzDzo7EVVfo2oaJDDmNxEnQs06ZBdFTe iQtj8as26ICjKSikarEjaRd+aWTQzk33IY9TK0cV62ixXhiWasU1GiQB5PLA3WudW+Hf 7/7xVxJ0rSG9jOrGlqm9YsWFDUGWgNcrvrTIXOwnEpuQtyYgc28SeVXAPcPt4FQBcj8a WanbavEQgRFVOLgIuH1jiPEtYlLpL5IW6ud9L7AkGDdHQXAFZdZXL4RdsR9H6/meJ2Lq xPajO+W5VDwzfbvON9Ba5yiuSQquhFj8JCJm/vxTx4qGYrQj1BwKmOi8R72QREg5lplM qOrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=OF3bvE9B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 20-20020a170906101400b007c14afc0ecdsi4208577ejm.479.2023.01.24.14.06.48; Tue, 24 Jan 2023 14:07:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=OF3bvE9B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235104AbjAXWD1 (ORCPT + 99 others); Tue, 24 Jan 2023 17:03:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235086AbjAXWDY (ORCPT ); Tue, 24 Jan 2023 17:03:24 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 539A810261 for ; Tue, 24 Jan 2023 14:03:22 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id t18so2457155wro.1 for ; Tue, 24 Jan 2023 14:03:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bF+Lp+JDPbwdrmjIfQ0g/QFY3xJvOU79Nk3DY5MrQzU=; b=OF3bvE9BGHU4pLMINeGZ7j1sGTNaHyVnwnjqw71YdNbdZFDA9COuaWvpF0baR6bZWH MSinkl6soRMGeltRq/QiUkB1p6CgoVjP/eYhZP+JxR6xjX5in9XcNHDjM8ktAw7dkP3S sYNJfZ6dYTsAGWh745r4IirbHC/q3NzLRqESUzhkGyw7HGr0p5Tk1heHE2h8fSv/+J9B eD5DERpuYKTkj772BhDdt2TOQU0u4dTFkmg8LXMO1DN5P+yVJ1mQdkGoviAvFkZta9Eh +WLzkBQilCZDAD1CgjsME/FU1+Lq6o4VYa+Rzqp0B/tIcaa5zsVgjzHDY/HORQB+LpVv EquQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bF+Lp+JDPbwdrmjIfQ0g/QFY3xJvOU79Nk3DY5MrQzU=; b=7Db1fq8pUv/ez5+E3DX3bi3aeJHkV74TaGJ6KLk3tM8YaFERZ3srKijpEDHtdeXtii soE/UvzYsOJJQaKclwvi3T8UODEVhVDAlj4kdwpBEshE0WHS2mffT4r9HoHQ6MaKq+bB Fa5zPq8jJPOjlO5lEXw/Tc27MgE8OHJQqLA+wm9t+IthMc6M/oRU06uGdeRB2ClzrUBu P+BHOC4e/CO9/sCtQ9HzDKPmC1oVXjiB69fG2Rzn9B0ft+aBuo9NH8PrZcGcKTrpjXSt JiuUBWz83r0PP9fIBvRkRmIMxx+GIabueUvZiEXICi5pXMbPYbvUaXqzQbFu7jiCGA54 8gEw== X-Gm-Message-State: AFqh2kq3gD/hKwq6cmCXthmvIiTdzqX/6gy192WnqKB9EZhENHmMxxD9 QqPUoNu9o20ji+fjj7Cbzcw= X-Received: by 2002:adf:a446:0:b0:2be:55ed:c065 with SMTP id e6-20020adfa446000000b002be55edc065mr2848791wra.7.1674597800811; Tue, 24 Jan 2023 14:03:20 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id n15-20020a5d4c4f000000b002bfad438811sm2167871wrt.74.2023.01.24.14.03.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 14:03:20 -0800 (PST) Date: Tue, 24 Jan 2023 23:03:18 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 02/11] staging: rtl8192e: Remove unused variables rxdatacrcerr and rxmgmtcrcerr Message-ID: <32c9183fa2f4edd24ae6f93d56b808eb1821832b.1674596722.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755943314414805203?= X-GMAIL-MSGID: =?utf-8?q?1755943314414805203?= rxdatacrcerr and rxmgmtcrcerr are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 7 ------- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 -- 2 files changed, 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 605146c840c7..e0d0f4faeca7 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -1926,13 +1926,6 @@ static void _rtl92e_rx_normal(struct net_device *dev) priv->rtllib->LedControlHandler(dev, LED_CTL_RX); - if (stats.bCRC) { - if (type != RTLLIB_FTYPE_MGMT) - priv->stats.rxdatacrcerr++; - else - priv->stats.rxmgmtcrcerr++; - } - skb_len = skb->len; if (!rtllib_rx(priv->rtllib, skb, &stats)) { diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index 82cbc7f5536a..f91a6f7a4e0a 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -183,8 +183,6 @@ enum reset_type { }; struct rt_stats { - unsigned long rxdatacrcerr; - unsigned long rxmgmtcrcerr; unsigned long rxcrcerrmin; unsigned long rxcrcerrmid; unsigned long rxcrcerrmax; From patchwork Tue Jan 24 22:03:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 47917 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2395129wrn; Tue, 24 Jan 2023 14:08:09 -0800 (PST) X-Google-Smtp-Source: AMrXdXtXoiJaCv4Sw1tSxT9qH/X55QVRAfnWGTJyszWivBLYwnZtLH6Kes30/nBFbE8+9euvEQXi X-Received: by 2002:a17:907:8c89:b0:871:74c:b1f1 with SMTP id td9-20020a1709078c8900b00871074cb1f1mr37889734ejc.12.1674598089293; Tue, 24 Jan 2023 14:08:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674598089; cv=none; d=google.com; s=arc-20160816; b=gKsAlUIept+AxeKG7DAUevgfVytPt0DNbnok2rFV8chszkG4pN/zGAO3GXuvIvH1lp w+pP+R7T3yTBafeujWod6jCUiIwim7WHcVlxcftRVgYtvwfn+y0gg62XUIWo+g1i+t+z hJsXVxtXt2/TZIdefhMxT+yRetCaPDET2mtxb854KTv8zN6uH+cDvtm07w2AO7RqLSVt Vhkp+pQrUwjVlCyJ9MKWEBNry604zijmH6+xJCdBIsxU7xa+maVI2lJOkN4Z/Ku2vRG8 ZStHI3S7U2gPwanJKAcUJ2JO9iVqLFgeJMszvm7DOVyrOMzSoNG+O7Eh9DHdL4HIv6GP eZRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=e3159gyzRYnyKWw0j8EF0nhK1aLDWnlIYkjwkYEv8/0=; b=L2gi0BF7VjUK/z/zl4gt/MOiHi1/BcSFKI2iYT7L6BmkeHRH0B40MPKanTtI6ymsf9 0fy5WkrpmgmhXsa9Q8KsROGwZoTBTMrORm3dvsBNqJjxlNYnjTfxmkVK9YxX/V++rBHx Lrfh2L3yTD6iOhjW7+i1kIdvkIaqUjcq3uDxMMGKNsahNNwWv9XO3VKsx2ENQcoVyVjl wB77k9Z5Y9b8YDymnckKH+fb/o5Jr4CEnxeAgsawkDurAO2LY1svaUFEc5BbCyXsUpea 8uleGc1GOsgYhvq2h7Yim/9VaPKHk1xsTo7RPnDDCN9D9xVTwiLquhuywDAg2rXFNYEo cXJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=obg3uU8D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v26-20020a17090610da00b00870ecd1a337si3403746ejv.460.2023.01.24.14.07.45; Tue, 24 Jan 2023 14:08:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=obg3uU8D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234994AbjAXWDl (ORCPT + 99 others); Tue, 24 Jan 2023 17:03:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235075AbjAXWDk (ORCPT ); Tue, 24 Jan 2023 17:03:40 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F6BC50849 for ; Tue, 24 Jan 2023 14:03:32 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id t18so2457516wro.1 for ; Tue, 24 Jan 2023 14:03:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e3159gyzRYnyKWw0j8EF0nhK1aLDWnlIYkjwkYEv8/0=; b=obg3uU8DWV4BQmYLBCIVOFVJxtEtJ/4sLceLV2ZkxWSLZWliGknOA12QmuT99oGa4j BDbnqcKyXAiXsmKb+vV8kFq4ZwE8dSvhzeDYPVCJRGBFxnJHjMta4LB5dYzczO+j6JFV 0PpAGNC3Dgx/b6WfO8orRNTgHVQn3h7+eXPHBCSH18wlk5l5anQle3ZsrM6xkviNbVWC OhOB5UewNG/OfTVZlqOnwXXssQaU4PCg1YcDUQbr5njGxdO7yNDtfEEn+WxHW+2qA8ZK OSeylPmLYm25mEAVuDBAxhZDsdMznQxUdtnzHb5OLEuVuHg+1K/t4L8MyBZuN+9Wc6NE T9Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e3159gyzRYnyKWw0j8EF0nhK1aLDWnlIYkjwkYEv8/0=; b=nslhvBEavNlDg4DnHqv4ulKb3TLEnZPE5p9a7qpwjA/M7wheIaa4/EycmLnhEm9rqf zU/rOmC6Zm5OyWN6wwi/6A63H0dQEZP8DhwIgXjv1PQXy+fqmuEArzyeoeQ80X6PkkyB UxXTrJlwPTuasIyWiXtnkHIaSoSwHqL6UnooAArcfrw6Cr8DUdpLb7fexf1Dbmc9RIeR sUU3Tmygc5PaI6ohsKX/0612WIAw+dXz7xnXSPhvMDJEsRkZD7ZdKcD7Z8Hynbf2Tr2O oCTnrQCKLrKuYuzuzFo1TbFyCAQ02ZTLaIqG7JmXNujed1RyixVNAiAMapNEo6pOxrom qbBQ== X-Gm-Message-State: AO0yUKX+1JdNE9s4ly/l+M5qygs+TpJcItc9QEIE8pMsUAnPyHfdTwei hOaXtDFWVJZI+GL8mC41/eo= X-Received: by 2002:adf:d239:0:b0:2bf:b2fe:a2c4 with SMTP id k25-20020adfd239000000b002bfb2fea2c4mr408221wrh.7.1674597811807; Tue, 24 Jan 2023 14:03:31 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id bj7-20020a0560001e0700b002bfb5618ee7sm1123210wrb.91.2023.01.24.14.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 14:03:29 -0800 (PST) Date: Tue, 24 Jan 2023 23:03:28 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 03/11] staging: rtl8192e: Remove unused variables rxcrcerrmin and friends Message-ID: <4c791fbb3559ce15de60b7bdcabbc50b0ee9adb9.1674596722.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755943366233217565?= X-GMAIL-MSGID: =?utf-8?q?1755943366233217565?= rxcrcerrmin, rxcrcerrmax and rxcrcerrmid are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 10 ---------- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c index 9260d308e68b..e9273dfb638e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1812,7 +1812,6 @@ static void _rtl92e_update_received_rate_histogram_stats( bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats, struct rx_desc *pdesc, struct sk_buff *skb) { - struct r8192_priv *priv = rtllib_priv(dev); struct rx_fwinfo *pDrvInfo = NULL; stats->bICV = pdesc->ICV; @@ -1825,15 +1824,6 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats, if (stats->bHwError) { stats->bShift = false; - - if (pdesc->CRC32) { - if (pdesc->Length < 500) - priv->stats.rxcrcerrmin++; - else if (pdesc->Length > 1000) - priv->stats.rxcrcerrmax++; - else - priv->stats.rxcrcerrmid++; - } return false; } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index f91a6f7a4e0a..167c4aeea44e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -183,9 +183,6 @@ enum reset_type { }; struct rt_stats { - unsigned long rxcrcerrmin; - unsigned long rxcrcerrmid; - unsigned long rxcrcerrmax; unsigned long received_rate_histogram[4][32]; unsigned long received_preamble_GI[2][32]; unsigned long numpacket_matchbssid; From patchwork Tue Jan 24 22:03:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 47916 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2395100wrn; Tue, 24 Jan 2023 14:08:03 -0800 (PST) X-Google-Smtp-Source: AMrXdXuYqARkXVMGk62FYMNsdpe9SQY1mFwvB5/e8W0DoMCZq30ur99vCJOp+MK/uVj3Fj69xrYB X-Received: by 2002:a17:906:6a27:b0:872:8c97:db27 with SMTP id qw39-20020a1709066a2700b008728c97db27mr38244539ejc.69.1674598083689; Tue, 24 Jan 2023 14:08:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674598083; cv=none; d=google.com; s=arc-20160816; b=bhoU/ZsgFVfiW+T18kTqxzugFgfE+ikYhn8m+oD2w6/K8OEr9jayoSULxaWzip5mCk xRT0Zu9qLywo0hiAV7fpAnYR1LMBU9ubwPkNk012YZcPFilsAnXBHslqB+ElyjbonJ9F 8N+KT+cy9Pcht98kAYgcyvP1RCy+BSyjuopUoKTEOc6vJNYGHm0oPA5qmc9YybPQqswi zgtl6AKPXPKrLTDJeANuO1wCr78qRF6cTwPtcPWZgkzZY+dthZYxxjJ4U6yTHVuqLU+e OI7AyCABzTjMuz7D5epaxo1JZXZSJv53iMZSt/UfHfn1ypi5jxgMEmx24ry02KBINF8f jbYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=X2hw80KcuVAFiY4CDXg3tE7695ii5d+NENvOP8i9jB0=; b=aQzLLFPyda22jcldmKTMqcKRsAw360aGzud2HywiOtTRBgKXWulwLp6b1MDFjREh7L cc3d78gF6BibzEQ8Dtvzf1I3ErPRgspsGnhgZSdtE/lNulV+2lioROv6ZrpNn4EYtsDR 9dPhm8kusyzmEp1xbcvngj2h+KGD52IKb+dbcgbCkyPXgQd8o/XAV+1V91QaoioNe+ur +56tHQHlvf9vw32ljz8LoOpz2ZryeEavW9YtLeQ+DMcRRq5Afk1KfW1oFfwSWWcctqzI zVq50VU8um38ijAj8D7wABXmyMpa8xDAfPhK10PknhcfwLMpthf19VTPW98xsurHzp4v TBfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=naB3RXah; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 19-20020a170906015300b00877a7ce0ec4si4522715ejh.252.2023.01.24.14.07.40; Tue, 24 Jan 2023 14:08:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=naB3RXah; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235043AbjAXWEA (ORCPT + 99 others); Tue, 24 Jan 2023 17:04:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235093AbjAXWD7 (ORCPT ); Tue, 24 Jan 2023 17:03:59 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFFF7521C8 for ; Tue, 24 Jan 2023 14:03:43 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id f19-20020a1c6a13000000b003db0ef4dedcso25741wmc.4 for ; Tue, 24 Jan 2023 14:03:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X2hw80KcuVAFiY4CDXg3tE7695ii5d+NENvOP8i9jB0=; b=naB3RXah16zS9TYfv3SuY5nU7oB2KZyejVbO9DWBDbuMl2nZHaPx25OzJhY9mvzUi1 Yl1usIiQGf1EDfvF042o7yQ068rHWw9U07gIZfkIgAmexVHQvzygQXsLhMcRf86NOApJ XHPGNaihw4JbYMLuYkaiRHxC4F4kEfAk46MiiLGZ1FAJdBDnfTs0y92oJz9I1DBz5ntT EOl1mEZcEu4VqGid3XOgtIfnJjlfpQYTdiZQCoA9gIdIEkbEZJRb/xO5Yxwk6Xb25aTT 6Ws9E7sR4y8TzGUGJIYyAAQ6d5BimVP6B1pPD4k0TRjP7GVkOaB9YO9a6moPYRpkE+Nh KGvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X2hw80KcuVAFiY4CDXg3tE7695ii5d+NENvOP8i9jB0=; b=xzg6SgGZObHFgH5HT5aBe+x2Qmwi6uQANbw+Z/u1vSF4pjXBLwreW8SynWOMk6xgg0 /lbAoh/b+D+Cn6tY2buRKU3sKCvaLF5Dpg9zkijMaZLn/6S7DT/JDU7/KAh0BxO2o/TF IjkdY/ot8o5Y27EcOhsCbbpHYAbmXjo3C9VDodTAkDKudBXw/l1pc/0sL8cP5l6Nvlh8 k5Wxlo4nECiIIymOJalamkkjeGDNJ5qd93++gbm/yIhMW+4KlG8w5joM4pjahctXPJI0 pQ/fxpTt4Pzvsm2z18IpXEESKwdNKV73xDy0AfZ51bX99bl9J91iW52MJd2OkwDpXsN4 UUIQ== X-Gm-Message-State: AFqh2kobQvOmF2Z4mQzKCgc5P23+PN7UozWisDQ/8jZ987C3Au1v6tJy RXDVvhUIBCf1CjGwRrX83FE= X-Received: by 2002:a05:600c:3b29:b0:3da:f7a9:50ca with SMTP id m41-20020a05600c3b2900b003daf7a950camr7698187wms.0.1674597822371; Tue, 24 Jan 2023 14:03:42 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id f9-20020a05600c4e8900b003d990372dd5sm37792wmq.20.2023.01.24.14.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 14:03:41 -0800 (PST) Date: Tue, 24 Jan 2023 23:03:40 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 04/11] staging: rtl8192e: Remove unused variables numpacket.. and received_pre.. Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755943360514516637?= X-GMAIL-MSGID: =?utf-8?q?1755943360514516637?= numpacket_toself, numpacket_matchbssid and received_preamble_GI are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 5 ----- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c index e9273dfb638e..c5ebc33dc7f1 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1685,10 +1685,6 @@ static void _rtl92e_translate_rx_signal_stats(struct net_device *dev, ether_addr_equal(praddr, priv->rtllib->dev->dev_addr); if (WLAN_FC_GET_FRAMETYPE(fc) == RTLLIB_STYPE_BEACON) bPacketBeacon = true; - if (bpacket_match_bssid) - priv->stats.numpacket_matchbssid++; - if (bpacket_toself) - priv->stats.numpacket_toself++; _rtl92e_process_phyinfo(priv, tmp_buf, &previous_stats, pstats); _rtl92e_query_rxphystatus(priv, pstats, pdesc, pdrvinfo, &previous_stats, bpacket_match_bssid, @@ -1804,7 +1800,6 @@ static void _rtl92e_update_received_rate_histogram_stats( rateIndex = 28; break; } - priv->stats.received_preamble_GI[preamble_guardinterval][rateIndex]++; priv->stats.received_rate_histogram[0][rateIndex]++; priv->stats.received_rate_histogram[rcvType][rateIndex]++; } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index 167c4aeea44e..70767238e721 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,9 +184,6 @@ enum reset_type { struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long received_preamble_GI[2][32]; - unsigned long numpacket_matchbssid; - unsigned long numpacket_toself; unsigned long num_process_phyinfo; unsigned long numqry_phystatus; unsigned long numqry_phystatusCCK; From patchwork Tue Jan 24 22:03:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 47918 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2395264wrn; Tue, 24 Jan 2023 14:08:26 -0800 (PST) X-Google-Smtp-Source: AMrXdXv1T/cVv9LPGL1Ie5C/WVHUf6D3P4bStiqGGu9fUrKNvSOTmC9Z3LonMavXjuy5/THc7vOO X-Received: by 2002:a17:906:a09:b0:7af:1139:de77 with SMTP id w9-20020a1709060a0900b007af1139de77mr37562068ejf.4.1674598106022; Tue, 24 Jan 2023 14:08:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674598106; cv=none; d=google.com; s=arc-20160816; b=TuJ6gzxC1vrRUPYqY4y0d7pksSVqaL4uuvHfk/ItT+LV+jyuNxhNM5gY0+J4YSDxr+ 8t0dhHOzdlCJHoEnQKVWtLnDkYdahcBZ0E+/+T6rDzRIGx8gSIGliuOF+0H9FeSfIPd+ o8sOKmrc65hVaifEygkBkGKcYfDMcVvQJ72TpWuWU7JuybUYU+7H0Tt0ftt3uNt2M82k g3ngd+dBx7+R6w9T1AZ/E+jOc1gvkaQKLi0f3c9j1NFLQl0zYgXJC/feZCygA6A1qTPE bbTPE3GhDH9G3gUjW42RRVp71KBNwtkYQ1dqzCIIuWJWeN6KZsiog3t00jyy8GHUnpml rFWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=90Z8arZ8S7xn+pHZz9yBB5NUzJn4HNmNZB/3Uj4Q9P4=; b=Dosb5i/9mXN4ZujQ9qFi588Dngz/TSFN56W3V3pNAH1j5iUYyYxQFLitC3vkNfvhyq VdTUytBY52sNwaH7IW6bhnaGsU8GdpbR1Mh1r90XYTOv8NZVLKz0SPYKKAfuNBey7luX YpzW4eSB55u+iv774alqOYUwUCjPrAyRgSzMs3eYZqeY6z5ckLwZj7ZLcsSZrCCMauOT Q7y37wYU8ewmCp6DCVR4pdQrh6kT4GHOf/TPHdK4PsoF+dkAuDTrJDCywLXzLXRcMyRw tcrssC3oB8mImX4OdD0uoiFELYqLmE+XnRYMHsQCE86jw0gw0fzTIEbCMl+8IJ7jqODb fkzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=TJWRvJrt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 9-20020a170906004900b0087761356439si3965807ejg.693.2023.01.24.14.08.02; Tue, 24 Jan 2023 14:08:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=TJWRvJrt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235093AbjAXWEK (ORCPT + 99 others); Tue, 24 Jan 2023 17:04:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235095AbjAXWEJ (ORCPT ); Tue, 24 Jan 2023 17:04:09 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F23E4FCE7 for ; Tue, 24 Jan 2023 14:03:52 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id e19-20020a05600c439300b003db1cac0c1fso23273wmn.5 for ; Tue, 24 Jan 2023 14:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=90Z8arZ8S7xn+pHZz9yBB5NUzJn4HNmNZB/3Uj4Q9P4=; b=TJWRvJrtjQOLpizydU1exBKvpWb0s72G89GIe0WwyYLAvsSsWnBL9EPGMVe2V0Wgvu ijVhnn/V0TOAcHAxYv/Yd8d9ZFrI7zczAhI9y6HcSx+MPt7yi2q41SK0vZ9g4Zd45oww voa9s1WQHF3ekI4mbRuDEUMTQOsDgFP09q1Mh5kHqz6oIWmF1v1fsmbwnLF3PQFlIXxp qOhLITkfvYGgvXZ9fSIyqNc/R5Bh5r8fjeRBlr5cyzbODYoyB9pCnObphsRFXfyxteFc z9Jox+/gYJF2m3pkKMw3cK511yEp6cP0og15fnZhcgoZZSxNgWSCNotencf+j73/PE8K KekQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=90Z8arZ8S7xn+pHZz9yBB5NUzJn4HNmNZB/3Uj4Q9P4=; b=3eE+voDtnQkgsQ1k6LRPaIvldOfpY5YFnGaHAuzZ3ztwDhvKh4kREOXDAEp/QBPe14 GX1cymHUor5ysP90ZypIaFIbg2xSrYFP3NngNlluRnyJuHZ7NJZWQpQCP0szHxTLORc3 PXr9aGO/mdDZ6qPvYhdvCXhbrDeGw13Wx92sByHemy6JIAbOi6JVSTw8SYJooMuEbksd 5tL3rTAI/03zxiTu0aS2LY55atQ2SVSuBZvPuxN8pRCLs78e+1D1J6NqUN34k+ca+z8+ J2U1NjV4f3i2Gx/8clQU14jnMH/Ju9A41Spwgc3d009teJiQYyR4cZdotadfuUPwGWyU IJ+w== X-Gm-Message-State: AFqh2krkDXNKft3tQDGvqOddjllrR6vmh3yPtQxvb0PPDNDshBAGZHop UB3j31tq4+ElNtx9/SnnLWc= X-Received: by 2002:a05:600c:6029:b0:3db:2922:2b99 with SMTP id az41-20020a05600c602900b003db29222b99mr5233661wmb.4.1674597831102; Tue, 24 Jan 2023 14:03:51 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id n24-20020a7bcbd8000000b003daf7721bb3sm38892wmi.12.2023.01.24.14.03.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 14:03:50 -0800 (PST) Date: Tue, 24 Jan 2023 23:03:48 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 05/11] staging: rtl8192e: Remove unused variables numqry_.. Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755943383617435101?= X-GMAIL-MSGID: =?utf-8?q?1755943383617435101?= numqry_phystatus, numqry_phystatusCCK and numqry_phystatusHT are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 ---- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c index c5ebc33dc7f1..31b4823e6324 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1308,8 +1308,6 @@ static void _rtl92e_query_rxphystatus( static u8 check_reg824; static u32 reg824_bit9; - priv->stats.numqry_phystatus++; - is_cck_rate = rx_hal_is_cck_rate(pdrvinfo); memset(precord_stats, 0, sizeof(struct rtllib_rx_stats)); pstats->bPacketMatchBSSID = precord_stats->bPacketMatchBSSID = @@ -1341,7 +1339,6 @@ static void _rtl92e_query_rxphystatus( if (is_cck_rate) { u8 report; - priv->stats.numqry_phystatusCCK++; if (!reg824_bit9) { report = pcck_buf->cck_agc_rpt & 0xc0; report >>= 6; @@ -1416,7 +1413,6 @@ static void _rtl92e_query_rxphystatus( precord_stats->RxMIMOSignalQuality[1] = -1; } } else { - priv->stats.numqry_phystatusHT++; for (i = RF90_PATH_A; i < RF90_PATH_MAX; i++) { if (priv->brfpath_rxenable[i]) rf_rx_num++; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index 70767238e721..e38de4d8a467 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -185,9 +185,6 @@ enum reset_type { struct rt_stats { unsigned long received_rate_histogram[4][32]; unsigned long num_process_phyinfo; - unsigned long numqry_phystatus; - unsigned long numqry_phystatusCCK; - unsigned long numqry_phystatusHT; unsigned long received_bwtype[5]; unsigned long rxoverflow; unsigned long rxint; From patchwork Tue Jan 24 22:03:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 47919 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2395317wrn; Tue, 24 Jan 2023 14:08:34 -0800 (PST) X-Google-Smtp-Source: AMrXdXsVFeh6ms2XaNiHHpjdi132AKfWfRq20LuoggegBd646Z8R04WuhGxc/jRNCzeboRV48edm X-Received: by 2002:a17:906:848e:b0:7c4:fa17:7202 with SMTP id m14-20020a170906848e00b007c4fa177202mr29268121ejx.33.1674598114106; Tue, 24 Jan 2023 14:08:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674598114; cv=none; d=google.com; s=arc-20160816; b=LuDinFFHJnF1lf0HTBXGFzPKChacw0EcLqV9na3rYYvgnlxZVxQw1TVgvvX9wEnIoW jM6/+C6hQcwM8N5q336wfdLY0UCFDPgDCxfEIdP3rT4SU3MqYVLxSM/0N7RLh3Gf7D0O 6Bb91TF+KXSX4hlCklLEC6ZjFm9QVHQn8jpZM5zxk+YR76Cz3bbqY6vSyvm+dqKwtxy9 T2uCeNOQFJw2vBSvhiGAhjp2zEA8wukufvqkak/OnYG3Bzqge3fzrL6YB/zuVH0/TgXr 5B96SeCy4lUV/hlSim4hDK8WxRE7ZZ1OnlXyadKdigJPl2BBFfHb/+XmnIgnUatWOm6d wekw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=75/IjlhstHHhYWzsbQIR4Dd2QgIIp4238rHFb4NvJPg=; b=cUTaHPOsDUZSv/91VG2/8xSc0VKNLTaqaimVMoEaCt1DsNYjiva006tk7hrqPnxdkB Fh86KdUbQe8Bv2MLXK2zM9uYwYvHunl5Jk+ybp9GRj+UyKupgDA6YDwP/25UeM5sRxLm 4I5/BRUEDknhz/r8XuYsUmhGdfsB9t6ufpwBsdChQkKX1/mq/s6NqfcB7M2gOVtPZcni X5e11TxcYkwNbyw9LNe6xbykoNtghDsw+J30mlIgqRZQGM5BgS3PxUJR0pax0osWhWVu nGor5x4U0zky3FMTSrp8qXBB//dllfBjO6fxGkwJwiMsGDBPY6RC7RSF3TrMspOmZAs5 2LKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=AUJrtPJN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gh13-20020a1709073c0d00b007826cb6f57csi3385030ejc.407.2023.01.24.14.08.10; Tue, 24 Jan 2023 14:08:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=AUJrtPJN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235113AbjAXWET (ORCPT + 99 others); Tue, 24 Jan 2023 17:04:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235095AbjAXWES (ORCPT ); Tue, 24 Jan 2023 17:04:18 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 079244FCF4 for ; Tue, 24 Jan 2023 14:04:01 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id c4-20020a1c3504000000b003d9e2f72093so41042wma.1 for ; Tue, 24 Jan 2023 14:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=75/IjlhstHHhYWzsbQIR4Dd2QgIIp4238rHFb4NvJPg=; b=AUJrtPJNhcoozirZE5FdY6iWPNtWlFrObe7Pouo+G3eNQt8ubArB/ugRI/EzBk9OSX 1aq6Z17HKeVHJ/q36qE9oS1RMEDv5jjAwcewxT63fnFkjsgfFANbeaC3arfNSH+yM7w2 xT7f7b4ycOCZWq8KFDadRPl3sUvStDTw/0DCHEhhkrbsPyqrywJjmLakQirMH9f56Nu1 d6ulFPt+bPPB/tuHOHKArqU+uU1/KlbWsy+JHfYYHQKIlxIL5g/E7Ok8V27Swx2PG+xI 1/hicgnaOETKo56WUCdj+ruFnlflR0QyzyQ7Dfnx1/hAKZq5jdVhJ55hXLmYCbtzS97/ osZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=75/IjlhstHHhYWzsbQIR4Dd2QgIIp4238rHFb4NvJPg=; b=ehMmjnulyciWJ4zW45+SLMv+dfBWm33RVcpTkDd2atdWNP45k38xF+yTWIRyFEXRIa 7Ou03RF0bFJgD7/R81hihhwUpt+lGOUiAd6yDLMgwiod8ypK6Lxqp5AEElYOks38vey5 j4RKWO2RrK0K+2Mkr6EKhVLlhJVj6AYHC/yu3obTQOAjPhgk2U6friJxrSHLDCXiMJv8 tar6m7W0OIg4W58KbfAefAnnuHp8jCd1ipIQMApiKEG7topsEdkOjqWw9fM96IU7nhBe fdXSNWKfvsk0lQYLcJd//lqAHFwVGtMqK82zA7QIfdkGQlGVuqY8Ud0QB2U+qcM1MMRY PoXw== X-Gm-Message-State: AFqh2kpzZOWTb4OHIUYwvvqYZNGYaZQiIs19LZ1IC41UjN7f2ZVPPFQ9 Wqi80JHZ+Qu+zLs8/solrvc= X-Received: by 2002:a05:600c:3b0a:b0:3db:22a:1349 with SMTP id m10-20020a05600c3b0a00b003db022a1349mr7678769wms.2.1674597839531; Tue, 24 Jan 2023 14:03:59 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id j20-20020a05600c489400b003db0f4e12c8sm22371wmp.34.2023.01.24.14.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 14:03:58 -0800 (PST) Date: Tue, 24 Jan 2023 23:03:56 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 06/11] staging: rtl8192e: Remove unused variables num_proc.., recei.. and rxov.. Message-ID: <67df12497bc6f93c6ef85b4dda7490b037f2a3da.1674596722.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755943392221325976?= X-GMAIL-MSGID: =?utf-8?q?1755943392221325976?= num_process_phyinfo, received_bwtype and rxoverflow are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 5 ----- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 +--- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c index 31b4823e6324..154d15b68b8e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1469,10 +1469,6 @@ static void _rtl92e_query_rxphystatus( rxsc_sgien_exflg = pofdm_buf->rxsc_sgien_exflg; prxsc = (struct phy_ofdm_rx_status_rxsc_sgien_exintfflag *) &rxsc_sgien_exflg; - if (pdrvinfo->BW) - priv->stats.received_bwtype[1+prxsc->rxsc]++; - else - priv->stats.received_bwtype[0]++; } if (is_cck_rate) { @@ -1535,7 +1531,6 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer, if (!bcheck) return; - priv->stats.num_process_phyinfo++; if (!prev_st->bIsCCK && prev_st->bPacketToSelf) { for (rfpath = RF90_PATH_A; rfpath < RF90_PATH_C; rfpath++) { if (!rtl92e_is_legal_rf_path(priv->rtllib->dev, rfpath)) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index e0d0f4faeca7..c5fe8e0aa83f 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -2183,10 +2183,8 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) tasklet_schedule(&priv->irq_rx_tasklet); } - if (inta & IMR_RXFOVW) { - priv->stats.rxoverflow++; + if (inta & IMR_RXFOVW) tasklet_schedule(&priv->irq_rx_tasklet); - } if (inta & IMR_TXFOVW) priv->stats.txoverflow++; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index e38de4d8a467..bb942283bc7a 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,9 +184,6 @@ enum reset_type { struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long num_process_phyinfo; - unsigned long received_bwtype[5]; - unsigned long rxoverflow; unsigned long rxint; unsigned long ints; unsigned long shints; From patchwork Tue Jan 24 22:04:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 47921 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2396660wrn; Tue, 24 Jan 2023 14:11:50 -0800 (PST) X-Google-Smtp-Source: AMrXdXsfq64i2v44ci3YDObnXsY2Sg8yJH3LZW5pCB5Ju/1Dp3ODVL96pM/N2ymrKdIsOB4TWMj7 X-Received: by 2002:a17:906:848e:b0:7c4:fa17:7202 with SMTP id m14-20020a170906848e00b007c4fa177202mr29276497ejx.33.1674598309972; Tue, 24 Jan 2023 14:11:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674598309; cv=none; d=google.com; s=arc-20160816; b=Q6A4sFuXL4lbIvTHVpacultYPQZ7nDrRRdSZxgCKzEQNZYdAox9LxUcvIT2mAlbH4z nJdA7h2Wq32sZEbO2qrJNEq3cWQ5k33b4QxTmJLD5pdh9Iasix5Tao+n8yCBvx9UrRYk o9dyYCGfD0mB3y0uSHTiwCQvfLmvQUQicYB8Mr4E/7zFaLkvHPhTR0+vNYr3fvVkiAfT RfIG4JRujcu37nh1AQCA6oWmFhcqG+dg0h36+fd9NXoYcbr+Iszt1NV1B2lXdLSIUCz3 an0PduoXZj7eoSthbeL79xKx6Phfh3Gy4uJqSiHBZNbDylLqGGPzn3tnVRLKi26j/9LR 3yrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=RPkDVI+kwbAJ93P/3HO1c8dYxoMR9aHUJQ6dLWT3TnA=; b=T7q2hYptgRkeyQl2/xMSkbPfAP0IB9JkFd98nnrM9L/bU+cqb5wKrGXh8Yl/cDkE9m wPHGp5GOP1BQdBH/oHOQlhoREskFVTmrxa4dXu9O6dETg5XHEHyu+D5tlmd6T04Qdupa zvQOjqgoX51VZhS0eldm95XMlwv7gez1Qcdv6dTtHE1LFNcb8GyRkZ0GSvN4B42AFpJq r/XXPk2XPAgT5Iqq2JBjqEDfWW/UK0C+KK4cE4DTSpnkkquR4mDQpxfSjKrUm2VKBTKO bUKNeY9HbH4RQqcDCVAAKDTUDiZwf2YygHBl4ONa9B93/CKRPtGqUo9DKH0evC7hI7Jp rccg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=imbFKXga; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wj22-20020a170907051600b0086f53c24da4si3431921ejb.635.2023.01.24.14.11.25; Tue, 24 Jan 2023 14:11:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=imbFKXga; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235085AbjAXWEZ (ORCPT + 99 others); Tue, 24 Jan 2023 17:04:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235123AbjAXWEW (ORCPT ); Tue, 24 Jan 2023 17:04:22 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7208750851 for ; Tue, 24 Jan 2023 14:04:08 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id j17so12529991wms.0 for ; Tue, 24 Jan 2023 14:04:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RPkDVI+kwbAJ93P/3HO1c8dYxoMR9aHUJQ6dLWT3TnA=; b=imbFKXgalkTRtXQTXS9Fs4SMJ1hEqVH6EWLyRtnqTVPrlhpWUUQ1u4lfEQ4WKeXpPF NyjTcCzs9Ox6xMslre3S/woYwiqj4nzNXgFcgXHGS63XDCuz+pkXpIxpDB5BdePrk26R bJMRM5w+gm/wyhyckDP+PRIzNmeLuIgKqLzfePKkhQWY7303AiOnNMnDtVgFi6bjEtur 25Urg82ec+AXJwjUti5PmgvdBnsmRMc+hbDyJ4VFolTl6kJsBe1L9v3BqXOGxfmaTQyY Viiihktwgv/i6Ri9C02RyJ4SoDUcdb0lybTR+y7912gAGTeXk15k5Xdn28jO2dXD++QO Pg/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RPkDVI+kwbAJ93P/3HO1c8dYxoMR9aHUJQ6dLWT3TnA=; b=MAytn+inK05tAUO16HZb68r9+JjfN4fj+WBedNMKnUgWcUUuft84z4Ha+LBpPI8/4j +q/wM0D8orj/3k1zS5zYVTL7Qm/cjBOdRxUVH5j+WE4lF+kydSo042wXB6aOLISg+jPa Dkc4GKhjqrxVqnayY1IyFWl50ppbHEnRWcqNmyGU2r1qsyCXkgRveF0CnQ6Tu9X+kDvU PfX+3JtdJBixOGYNiY0LzTeTcln1x28y3ouQHNQynGUOqTuy760opM1p57m9+XF5l7f1 HplFQFM026mMmB/1DxLdKrR49YPKK9pCR/TW2igywkAGJmzxx0zi/RID9mF2z/IauilP rAhA== X-Gm-Message-State: AFqh2krI7BCbyNaqSvfST4MWpDGYYRNnCcDE3StRqEWs0Gbfzq1rqJXP XDxYjuNBjfL3ei1kBb7BJO04cYdhYV4= X-Received: by 2002:a05:600c:5120:b0:3db:21b8:5f53 with SMTP id o32-20020a05600c512000b003db21b85f53mr5582344wms.1.1674597846842; Tue, 24 Jan 2023 14:04:06 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id p15-20020a5d4e0f000000b002bdc39849d1sm2791366wrt.44.2023.01.24.14.04.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 14:04:06 -0800 (PST) Date: Tue, 24 Jan 2023 23:04:04 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 07/11] staging: rtl8192e: Remove unused variables rxint, ints and shints Message-ID: <1ddfe407a0b93f991466ecba71741c5025fb6352.1674596722.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755943597781770379?= X-GMAIL-MSGID: =?utf-8?q?1755943597781770379?= rxint, ints and shints are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 7 +------ drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index c5fe8e0aa83f..ff9dc06642f6 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -2123,7 +2123,6 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) spin_lock_irqsave(&priv->irq_th_lock, flags); priv->ops->interrupt_recognized(dev, &inta, &intb); - priv->stats.shints++; if (!inta) { spin_unlock_irqrestore(&priv->irq_th_lock, flags); @@ -2135,8 +2134,6 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) goto done; } - priv->stats.ints++; - if (!netif_running(dev)) { spin_unlock_irqrestore(&priv->irq_th_lock, flags); goto done; @@ -2169,10 +2166,8 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) if (inta & IMR_HIGHDOK) _rtl92e_tx_isr(dev, HIGH_QUEUE); - if (inta & IMR_ROK) { - priv->stats.rxint++; + if (inta & IMR_ROK) tasklet_schedule(&priv->irq_rx_tasklet); - } if (inta & IMR_BcnInt) tasklet_schedule(&priv->irq_prepare_beacon_tasklet); diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index bb942283bc7a..2d1561a202d0 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,9 +184,6 @@ enum reset_type { struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long rxint; - unsigned long ints; - unsigned long shints; unsigned long txoverflow; unsigned long txbeokint; unsigned long txbkokint; From patchwork Tue Jan 24 22:04:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 47920 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2395794wrn; Tue, 24 Jan 2023 14:09:36 -0800 (PST) X-Google-Smtp-Source: AMrXdXu2Rx1/vr09JBrIc4GYopGbkZdYFDwST1xGBoRBNA7Ej6gvlcyxaOcBc6rdOvN085nHo/9G X-Received: by 2002:a05:6402:25cb:b0:49d:6ebe:e9dc with SMTP id x11-20020a05640225cb00b0049d6ebee9dcmr39476097edb.25.1674598176471; Tue, 24 Jan 2023 14:09:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674598176; cv=none; d=google.com; s=arc-20160816; b=p/EmZaikrdvbfNPk8+YVRemx3z8R52CB82X+KiEvpdE+Ql1J4BukO2kVU97XXNM95m 7fx0nlNF0t+T+5JFTWyMpbxfAiUtlE/qyUj3bGs3e/gwtbIPkl7lpborzCARIJ8rlQGI VC/rfLC9uSQbZTX55ELtjuMs4Ee40es+KnOiz2399eHqa+toPj0lQKBH00wzOc6WclM2 cEODD2mHgS+rWaa6A+heNi18sdwcg4EhxAm8ssObFE17EmA0DTMcDmGWtPz6bENTk4eI RS2TeMtncUrSxlQnEiOmhX/SQX7mWycxx217u5WCkoOBVeR3SGyRt08ixjNr7442IOWQ J1KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=u9KDPpjVKPB5sOQxBI2Abbi3wGikXqFCKNDvpCWP0FU=; b=ObJ/wTWhTq1xYXBBAZBafFYMVM8aH1PON6+6yGVBG0Mu22Tu2YsmAcsjWKJCjpryZw /QrIdX3qE+NdYtfGZ+biRBGjl2SDNS5Xe9JU9UDZZjHyGc8iu4KHqktlanXIXR0N4ZK7 PtuPkI3YDQmMeKz6JXLGMTjj8cQ2zmhatUfbi0mXfcshVoAjxIFF4poH1RGm+sr0C1EO Gqc2ngEaZFK/drjk8HzMJSPX+cPUtYwhD8KT6SmFLQ7tA9XIYHv7tWb8T+bcnHmVDWqy 5fHLtsa+CkbY14YoSgB/AiAD0jO+XktOwmfmprhk4bHIbWwVDTn7ziazsIhxlkqMvXe9 K5HA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=V+OeiocR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f20-20020a056402069400b0048d42f6970bsi4154211edy.252.2023.01.24.14.09.12; Tue, 24 Jan 2023 14:09:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=V+OeiocR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235130AbjAXWEx (ORCPT + 99 others); Tue, 24 Jan 2023 17:04:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235147AbjAXWEu (ORCPT ); Tue, 24 Jan 2023 17:04:50 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9213E51C7F for ; Tue, 24 Jan 2023 14:04:27 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so38968wmb.2 for ; Tue, 24 Jan 2023 14:04:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=u9KDPpjVKPB5sOQxBI2Abbi3wGikXqFCKNDvpCWP0FU=; b=V+OeiocRchdGib1s/15ba9Yh9kWOa/t6CczrE/IdZOPu/1PrCug4laVgpF+HwPlDWV VHn3u8bqvjBFwLtVoQeSpp91Z1PQrmoWgR1cea4FKAbINUtR+raHEXJB7lQDNZCtZJQt lIg6A50sfFwfeLIeYU2YZXSRC6uexu6CB6ZqGs/OWBgsYy/v38WCNCBjE78fFrkPTcW3 TjardTD5pOArjJ9s/6xAieTfkIT/KkY207ARTpXLSsRqpL1mD5WVs/kFPXbVRkocOCno VlJS9uKOmBrYGWqgpgZPjMsd0AHB7fXSRn6zS4aLdlXbwFhZx767lKJHrkhJnmXR5jw1 x/yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u9KDPpjVKPB5sOQxBI2Abbi3wGikXqFCKNDvpCWP0FU=; b=lzqImHn4WcW6AmHA80ZZ/AUZOkOXMgpVvDuP9XZrzYnIAdeO+JqaJp948orsi5nI4R YM+UhcBB+EJZu52G+8VHRwH+ioyOkc8BE3HhaJNF5C9cn5a/8zoXARTLPK/wlUzDckvY u/mpwbmcNu09B6mSgM5xvHV8h9804ioF3RQF80um5X+n9uVAaA3Qrj8vU16953yBwvSS U2juQ819UDxfsUWLf850QGMaciqsYpL9zEo31jLfi3V+uFXh7OyUI4tmH/yOirNQt1+F FChwKvbTT/tW1nijJlYN7OEzmDzvTshJe7Ti30iCTvYTaaRFOm1tIkPLQnWyyKFObAYd wnfQ== X-Gm-Message-State: AFqh2koXafVPbfOx8p2VtknxOwcPtw/tq/0iUYgdU90HtKd94OAKF2JB lrViBWwWVDfYWGjWYL4u7lY= X-Received: by 2002:a05:600c:1e22:b0:3db:2063:425e with SMTP id ay34-20020a05600c1e2200b003db2063425emr5573938wmb.1.1674597863634; Tue, 24 Jan 2023 14:04:23 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id f5-20020a05600c44c500b003d1de805de5sm42022wmo.16.2023.01.24.14.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 14:04:22 -0800 (PST) Date: Tue, 24 Jan 2023 23:04:20 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 08/11] staging: rtl8192e: Remove unused variables txov.., txbeokint and txbkokint Message-ID: <9ded1e4c43c87faef908df1d4aa564d0ba00e1a3.1674596722.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755943457304234095?= X-GMAIL-MSGID: =?utf-8?q?1755943457304234095?= txoverflow, txbeokint and txbkokint are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 5 ----- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index ff9dc06642f6..768324cbe253 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -2181,17 +2181,12 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) if (inta & IMR_RXFOVW) tasklet_schedule(&priv->irq_rx_tasklet); - if (inta & IMR_TXFOVW) - priv->stats.txoverflow++; - if (inta & IMR_BKDOK) { - priv->stats.txbkokint++; priv->rtllib->link_detect_info.NumTxOkInPeriod++; _rtl92e_tx_isr(dev, BK_QUEUE); } if (inta & IMR_BEDOK) { - priv->stats.txbeokint++; priv->rtllib->link_detect_info.NumTxOkInPeriod++; _rtl92e_tx_isr(dev, BE_QUEUE); } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index 2d1561a202d0..96d340f686e9 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,9 +184,6 @@ enum reset_type { struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long txoverflow; - unsigned long txbeokint; - unsigned long txbkokint; unsigned long txviokint; unsigned long txvookint; unsigned long txbeaconokint; From patchwork Tue Jan 24 22:04:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 47922 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2396743wrn; Tue, 24 Jan 2023 14:12:01 -0800 (PST) X-Google-Smtp-Source: AMrXdXtYT15uOEXBZV0ZT2aJOgXZ74lF3qPUgCl8UsihErFvohTWFx4L5P7gJ1ReUiVAwlFvkaM7 X-Received: by 2002:a17:907:6f07:b0:7c0:f90f:163d with SMTP id sy7-20020a1709076f0700b007c0f90f163dmr35672326ejc.11.1674598321733; Tue, 24 Jan 2023 14:12:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674598321; cv=none; d=google.com; s=arc-20160816; b=fmONiq0j+hm3qg+TRAsk6uHPCVZIRRZ9f7F+vmXbtr+sYxQiAoX5XyGggPqkHG4FuP 3Ps/Y+F96p5b3lBeTCT5aLAA8skX5oeFh1z17tmT9ne7j51UQ4L8kTw3YkvNE9Cx5SbW Hclt/EMlq3EQOAX6iee29/WrW5vJqrPcv0MUBzu7IaP6mEeWg5+9YOwxtDwMVjCct7dE MbR0ezK0J5WlgTb+AKSLCavWqxsup7qfmNECbVS+2C40tZmHIAFENTwJAlVlfeMJFnVX 68Gi8Zpp/d9wdYm/Aa0ZSLMwNVJak5CRoSKht/eQJwGgOP3jt5R3p0CM0XLyElumabKL 3TaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=gMf09+fC4QI99DmXPRyQuRL+tFfoSe44zXEcxxr3d1Q=; b=VdMo7QcouzOgbLiWj0QZSOOMW43e1lW15YeknSVqNvP0Xx5IZy0FvfFu/7gbweaBu9 PKt3PiH8CAWYPJ/WyvQ/4ftIAE9VVhA+o6B08oi1iltArPeAPbTkFiQU3Wgj6MNwGYoK 7CrNl3ML3Cym7dUVOSKzBwji3hUQwF/es3qGdeGOFakANs19pN0wPuytzzrH8h7ltmSE tM9A4Kg+tQcJZGFV6SrQ8/L/b5kW/9zzz+6S/Y5kkSQ8dTXr3p/Nz0MENsRnEPtk3QGI 8MiBQ10OdaH9F/ke1g93Fyx6OI/GCtPEEJQ2rHRCMyAUq87V1+5DPlwEdv+xUU5XUztq 3+AQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=IEgYNIvN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i27-20020a0564020f1b00b004a0a956ef6asi239531eda.234.2023.01.24.14.11.35; Tue, 24 Jan 2023 14:12:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=IEgYNIvN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235138AbjAXWEz (ORCPT + 99 others); Tue, 24 Jan 2023 17:04:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235160AbjAXWEv (ORCPT ); Tue, 24 Jan 2023 17:04:51 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E159360A0 for ; Tue, 24 Jan 2023 14:04:28 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id fl11-20020a05600c0b8b00b003daf72fc844so58148wmb.0 for ; Tue, 24 Jan 2023 14:04:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gMf09+fC4QI99DmXPRyQuRL+tFfoSe44zXEcxxr3d1Q=; b=IEgYNIvNCC9mddSqNfaCCAz0oUCnF7np9L8WKM+zB3789lBGkDNb9niMNvK9QHJ1+h ImSB5ok4C9Hu2t3IGHmEc5lH9BC7SIN/CrBtaM4cKBuRFswjHrcr5Slew7e/VBEQ49+C SRJFX8/J07sByHNIZYD1cuH3TNsIbmhBRK64eR2FKk7B7jYW2R/kpvAqSQT+J+OzVOWZ jM9wZZV8Ad/Ljy1qQZV2HfIAfz2zLAE5aFYX+CnkJHNAhlforaQv1xLqoNH8Q0CviLmz QSZn3rol5PqQdvSu9RWkEX06cEfkwtFK1yhhpeSQnG/GuEcAWu3P3F7XPxZcs0AkQoxV yWJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gMf09+fC4QI99DmXPRyQuRL+tFfoSe44zXEcxxr3d1Q=; b=M+EK0QGH/NMo6/yvm9L/0KpiWmCn/kS74Tmh0dahcdE8ZCC+Fu+aqKvj9OqrxHhPb+ DJOs4d7ceFFV/AsMvZ+F94OrtBsR+c3fWhlJWlZhPuDS6JMS9ncvEZEo+qLfC/B/Us7O eW/GvDyfy85VOHTnGScgbYmvEtrVFWFeAoXHqeD+1+FgQoCVfeUpMtorRZsFGLfSF0XE kvtWTdgZeSEDW/Mh1pojMkF3Yu2HoLqwyAiIAp+jkiu15GVQlWLgZ8QbRtAmWLTyft+x efOqZfDVTBswaWHZJgI5Lc/Sql0kqnrZxCSCaIbQzxTmKgUAwyd9AuCC0jmOxtVBT1zG 4kLA== X-Gm-Message-State: AFqh2kq4xkKSdqWDwcyuVniH1/hlvqaqvFUNgxjowBUGLDuccKM2CsDn q0O8NMsepnGZKxtDvlIP96M= X-Received: by 2002:a05:600c:3b8c:b0:3c6:c5d9:dad3 with SMTP id n12-20020a05600c3b8c00b003c6c5d9dad3mr7996420wms.0.1674597865822; Tue, 24 Jan 2023 14:04:25 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id y4-20020adfd084000000b0028e55b44a99sm2735451wrh.17.2023.01.24.14.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 14:04:25 -0800 (PST) Date: Tue, 24 Jan 2023 23:04:23 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 09/11] staging: rtl8192e: Remove unused variables txviok.., txvook.. and txbea.. Message-ID: <1500a146bd4f46e8c49ff35f71c21def978fe9d6.1674596722.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755943609911894936?= X-GMAIL-MSGID: =?utf-8?q?1755943609911894936?= txviokint, txvookint and txbeaconokint are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 5 ----- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 768324cbe253..4cc90425fa4c 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -2139,9 +2139,6 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) goto done; } - if (inta & IMR_TBDOK) - priv->stats.txbeaconokint++; - if (inta & IMR_TBDER) priv->stats.txbeaconerr++; @@ -2192,13 +2189,11 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) } if (inta & IMR_VIDOK) { - priv->stats.txviokint++; priv->rtllib->link_detect_info.NumTxOkInPeriod++; _rtl92e_tx_isr(dev, VI_QUEUE); } if (inta & IMR_VODOK) { - priv->stats.txvookint++; priv->rtllib->link_detect_info.NumTxOkInPeriod++; _rtl92e_tx_isr(dev, VO_QUEUE); } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index 96d340f686e9..f8b2201ea288 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,9 +184,6 @@ enum reset_type { struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long txviokint; - unsigned long txvookint; - unsigned long txbeaconokint; unsigned long txbeaconerr; unsigned long txmanageokint; unsigned long txcmdpktokint; From patchwork Tue Jan 24 22:04:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 47924 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2396821wrn; Tue, 24 Jan 2023 14:12:16 -0800 (PST) X-Google-Smtp-Source: AMrXdXuS0v21FYccdQ7D2HVOZHqd/hubzEF7Xm8Zpz4gA6+rGLoD1cX2fHJPgpWZHpGqOQ3JUEkA X-Received: by 2002:a17:907:5014:b0:7cd:ffd:51f2 with SMTP id fw20-20020a170907501400b007cd0ffd51f2mr27656529ejc.57.1674598336421; Tue, 24 Jan 2023 14:12:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674598336; cv=none; d=google.com; s=arc-20160816; b=irQJ0iUp62TzC0J5I27cVzaJb/hL+4T/czKRRZi0Dn8NkX9+IKlpBm95ugu8EwKpTa DrpQVWvoDKloD2I/c/+uA9Bx0saI8n8cutxRiRyWJTCI8icQagHZI9f8yiUz2KSYKW2g 7pH4hxMRtk2qXGNH49RgtaC1xpYzyJuhJabXkF29z4rVuonqV8uEDHr4R9oHqRNwZlyb dScklritR8Y4q8/ixZXxeox0/A1e9Bkx7N2F0c/a/z98K6ixpRWrvcJ36d19Nvhk1Fqx u6xcATKD3d6IV0QnvJWPQsxuBBste5v5DAWI+Y983+sF88UCl2+mhdqApq78XAIP5D0J mTpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=NDxe4oIJJSUOqPRwp3G0IGOgJo50hIDpNvcK0HbcW+I=; b=Ug2oiyKClun96KJ3I7D2MDkwTzo2VZOJL5Oh0B/MbFbbkl/DjPQ+PhkvibWx7GCmFR 7gwdIKYjfD1Dl1GkhQ81s9BY740rtPqazbdmI1BbXTG17/sqiYFpUvTP2OeHbXm75JqG gOaVSIJY3MO1lyX7c0Z89YhZ8a/7H0o1GsESG4spyZtJCBZAF8KPnYDsuO/BedT+iVSj C76Z1Zis8P5bAQ6R+w1ZXkkt4XtJkn6raboI5cRoiA2eh7EQY+pfE+FmQgN5xgY8zScb EVPKUQsfje4QEieMHxnB9K6scOMKmKDCCp5q3Au/KXXYKX2L5Hl68mvUKrdnqJrunB/5 nzDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WBkvXYXk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fc5-20020a1709073a4500b0087786d721d9si3210532ejc.408.2023.01.24.14.11.51; Tue, 24 Jan 2023 14:12:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WBkvXYXk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235146AbjAXWFI (ORCPT + 99 others); Tue, 24 Jan 2023 17:05:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235140AbjAXWFE (ORCPT ); Tue, 24 Jan 2023 17:05:04 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51F4D5140D for ; Tue, 24 Jan 2023 14:04:45 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so39169wmb.2 for ; Tue, 24 Jan 2023 14:04:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NDxe4oIJJSUOqPRwp3G0IGOgJo50hIDpNvcK0HbcW+I=; b=WBkvXYXkvoKDXytnJfUU8oWA+parU/KCWf/I5sg/p3eClZPsxIvW7DeUIiwOvH4Fj3 YlCE0XCIY1laBfVZPEPVSalqFcfhOSB+YDt14gYlwJ0M4e8zOjXdpdEhi6w9yJDn+CPo Er42ROETd++Gt9iprGqRzUYfy6e1IX+kVPp98lJz8C8iRn/bn7k7ZGIN1M/1hExJitRQ G9RhNts8dN939D3TP93LgjGPuZ0DTwjXh0CyW0KRsn2dNQK0pcovmQNqZ651WyL3X/OF /84Kv89aQwLEfWXz5zqHeVFjwEdPHnlyyTUkibhbbrLuSPPG5GOCx2Wnejt9PySD3ZLk yuMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NDxe4oIJJSUOqPRwp3G0IGOgJo50hIDpNvcK0HbcW+I=; b=n0jM+M1+gadKlndfPa8aARkMjlDoLlwvWOQdC/7GUGwoo/K7/f43ocpzNdk09mC7/D AgxVp4taZg5mUAGLRrYWWgvg2FtavCGNygxc0sK7sqOefZ1IqqQBRLTzim5Iw8zYz888 8qEyP5byBTArcWezo5XCZ8TrJEx3uIFWDHYvWnGq5R1hHQDIEdfzN8R6s6nReDdle/hW mUR5nGImqQsifD1UfkJ+RGqRQIRig8QLW0SvBcFOF793rp6A1P04rSTL/MkBY4bY408G NZ2KmwPX/e8W4cUMfr5JKDRksXbls6RwkzwQ5LEqKdZCYXzXge3sV6EVrZ1dk5aQcH2J WAoA== X-Gm-Message-State: AFqh2kp4m6oxeqVhQsczrR8EtfRhQ7IB/nE0WPiuqknZxuw6kkEl+HhT RLGnjIed2mEOnhi9I4XZaUGnUHhPots= X-Received: by 2002:a05:600c:1695:b0:3da:f452:a975 with SMTP id k21-20020a05600c169500b003daf452a975mr6480278wmn.1.1674597873237; Tue, 24 Jan 2023 14:04:33 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id j8-20020adff008000000b00297dcfdc90fsm2825015wro.24.2023.01.24.14.04.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 14:04:32 -0800 (PST) Date: Tue, 24 Jan 2023 23:04:30 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 10/11] staging: rtl8192e: Remove unused variables txbeac.., txman.. and txcmdp.. Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755943624816939517?= X-GMAIL-MSGID: =?utf-8?q?1755943624816939517?= txbeaconerr, txmanageokint and txcmdpktokint are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 8 +------- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 4cc90425fa4c..2c5edda74e73 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -2139,11 +2139,7 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) goto done; } - if (inta & IMR_TBDER) - priv->stats.txbeaconerr++; - if (inta & IMR_MGNTDOK) { - priv->stats.txmanageokint++; _rtl92e_tx_isr(dev, MGNT_QUEUE); spin_unlock_irqrestore(&priv->irq_th_lock, flags); if (priv->rtllib->ack_tx_to_ieee) { @@ -2155,10 +2151,8 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) spin_lock_irqsave(&priv->irq_th_lock, flags); } - if (inta & IMR_COMDOK) { - priv->stats.txcmdpktokint++; + if (inta & IMR_COMDOK) _rtl92e_tx_isr(dev, TXCMD_QUEUE); - } if (inta & IMR_HIGHDOK) _rtl92e_tx_isr(dev, HIGH_QUEUE); diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index f8b2201ea288..c6a4ac6ce959 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,9 +184,6 @@ enum reset_type { struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long txbeaconerr; - unsigned long txmanageokint; - unsigned long txcmdpktokint; unsigned long txbytesmulticast; unsigned long txbytesbroadcast; unsigned long txbytesunicast; From patchwork Tue Jan 24 22:04:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 47926 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2397810wrn; Tue, 24 Jan 2023 14:15:08 -0800 (PST) X-Google-Smtp-Source: AMrXdXtOFraGL3uMPETJKSaEhytkBHOR7oIi7NZf3dzON4jyrHdVX1C+XaNbqCh746CwQRY8Lmsa X-Received: by 2002:a17:906:4d89:b0:86f:57d3:e3a7 with SMTP id s9-20020a1709064d8900b0086f57d3e3a7mr29654244eju.48.1674598507891; Tue, 24 Jan 2023 14:15:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674598507; cv=none; d=google.com; s=arc-20160816; b=rjpHDD9SunkBjjo7PKXl3Kqog660Gmmcyid7YDeDM6NbQLVdGBOwlhi+f+63zNAyg6 4loDUvjonk1k2d3yWRfzuyVHXZmWKzoB54pmEd+fEaLB3soKshj8RBtXMXCSVRZLXOr/ n/vQP7WuSEP6ghPdigT7cnDUZmihf10BsM9AiU3y3VX06gnvrAhHC+gE0/aDT1Pv3Xt3 paq17zdYddtAzREiQfA7K1bsmvD6nRBd8sVDyQOkx0tJktIF7LfJ+q1X/5C5S24CAMJ2 DH9++vhV7q6fnPBezmhjCNR75jdIGbuGLtvio3sh3eO8pc0YOwG78VzKvzBNKKJxDD/L AGZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=9S2rTJlEcWEor4NpjYK8tyE3FSBDpDNy8fvb6AVYPwo=; b=xBny7JEHOJV5lKLqyuN5BmwolY5Mp2keJbvwrZyLVJXtKmpGIcqNkmw1r+RfHcBmnN YxXRZ0fprkQFf+1QoyNFtdcVNetDfaNRHrfgnbgkLVBiZu7d/U+SXdOX4+UosFj1N6XZ VJ48FiYF2uI1Sxa/YkxS4GR/lflgyN5uP4kvDasbnLxBiwyOUOAJowsdblbN10Sohuod fWaToK0qTRzCHA0Ag/Ap+iSpRdif5jwgpQtaXNC5byMLO9WMDEVTt/O2agpRVi4vJX2c wiiS4NaOIphqp/bJAsMDpBrRV67adsF+ZIYIIUgZVnv0t6CvcG1rf/4+YBof8pANFmz6 h2Tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=SIvJKZtS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wc22-20020a170907125600b007c10e7a7628si2822178ejb.839.2023.01.24.14.14.30; Tue, 24 Jan 2023 14:15:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=SIvJKZtS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229778AbjAXWFL (ORCPT + 99 others); Tue, 24 Jan 2023 17:05:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235142AbjAXWFG (ORCPT ); Tue, 24 Jan 2023 17:05:06 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43A1D4FCE0 for ; Tue, 24 Jan 2023 14:04:48 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so39317wmb.2 for ; Tue, 24 Jan 2023 14:04:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9S2rTJlEcWEor4NpjYK8tyE3FSBDpDNy8fvb6AVYPwo=; b=SIvJKZtSi9jA4IyGpgIv4sKxGDXt1pKkXJImNFVlpqnh6ibkX4NdoisQ/vn3MQdfcD 1v21r0uxK7VPqKwXwdljp5Wz1LQgbyw/btPRrO3UGIIP8K+cIqe6Eu8p6os7/T3D4lp1 xfJMrNdC8SYDerb+12duC0uRbIq5juECHQPYv2TxA2n/x1Xvhkiei5iHWZz8RXYB/V0w anirJHlKmrp+8m11dmVlxZD7969CRHBXXxj+fq3xZNB57pCL2CAlG9uuYI2Ohu2z2Dew 7FPJanGxfa6wGcuCeB9MTHY4x+2m8TimnwYHUrgUErLnqDDN/o9sjU7qdPgIIEJdEZ6U xNUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9S2rTJlEcWEor4NpjYK8tyE3FSBDpDNy8fvb6AVYPwo=; b=sbdT0H5/pCCUYZEwzzn/klO8I6l6L5P8kywFZ8vdJ/ow/W7ipDx2rc9UTwzPDeWemn YfO3CRxboMXLSAvXNCd3VsijAmagByWpnkYIrKt5hHrq3p6uBuza3VgBABraVw0264Y3 37Y3gIqNq0lDrZedMkq8VDl38sg6rDwAY/MVC23GUXwNUTq2AvcdHHFkvE0b2MK++uiX 6RWQC0tdBHIwEsiGQIeF9Jy5cLH79C2PNAszpMyt5K6WetAGELFrIFE4xQBZaPmVzi3Z e5nerV6FUtoFjnr7ZnaYViUN5QRU01i4Hg+NesZmveQE2q+Q2cQiSerZ/WOtDsqa8pSj xQeQ== X-Gm-Message-State: AFqh2kpOJCvHxY24BkFURWSOMMwZBmit8dZvnQfBlpKXrviiEudKOCs/ 2YGGE5Hzx7wTVGf5Tm7oxB0gU04fFVs= X-Received: by 2002:a05:600c:5120:b0:3db:21b8:5f53 with SMTP id o32-20020a05600c512000b003db21b85f53mr5582634wms.1.1674597880319; Tue, 24 Jan 2023 14:04:40 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id g26-20020a7bc4da000000b003d96efd09b7sm38551wmk.19.2023.01.24.14.04.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 14:04:39 -0800 (PST) Date: Tue, 24 Jan 2023 23:04:37 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 11/11] staging: rtl8192e: Remove unused variables txbytes.., txbyt.. and signa.. Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755943804649892884?= X-GMAIL-MSGID: =?utf-8?q?1755943804649892884?= txbytesmulticast, txbytesbroadcast and signal_quality are initialized and increased or set but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 1 - drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 +----- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c index 154d15b68b8e..7616486bb1ec 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1619,7 +1619,6 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer, tmp_val = priv->stats.slide_evm_total / slide_evm_statistics; - priv->stats.signal_quality = tmp_val; priv->stats.last_signal_strength_inpercent = tmp_val; } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 2c5edda74e73..f8a8ece40ac1 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -1616,11 +1616,7 @@ static short _rtl92e_tx(struct net_device *dev, struct sk_buff *skb) type = WLAN_FC_GET_TYPE(fc); pda_addr = header->addr1; - if (is_broadcast_ether_addr(pda_addr)) - priv->stats.txbytesbroadcast += skb->len - fwinfo_size; - else if (is_multicast_ether_addr(pda_addr)) - priv->stats.txbytesmulticast += skb->len - fwinfo_size; - else + if (!is_broadcast_ether_addr(pda_addr) && !is_multicast_ether_addr(pda_addr)) priv->stats.txbytesunicast += skb->len - fwinfo_size; spin_lock_irqsave(&priv->irq_th_lock, flags); diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index c6a4ac6ce959..4cf776094ac0 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,8 +184,6 @@ enum reset_type { struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long txbytesmulticast; - unsigned long txbytesbroadcast; unsigned long txbytesunicast; unsigned long rxbytesunicast; unsigned long txretrycount; @@ -195,7 +193,6 @@ struct rt_stats { unsigned long slide_rssi_total; unsigned long slide_evm_total; long signal_strength; - long signal_quality; long last_signal_strength_inpercent; long recv_signal_power; u8 rx_rssi_percentage[4];