From patchwork Tue Jan 24 21:48:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Karcher X-Patchwork-Id: 47911 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2393773wrn; Tue, 24 Jan 2023 14:04:51 -0800 (PST) X-Google-Smtp-Source: AMrXdXseVEpjMGxgwNbmc/9wBN/fMXmVQz60lzhOdA7qBqoeXiBmxMlzkkPMxy551bd7N5DMZw/J X-Received: by 2002:a17:907:9891:b0:870:42e8:2468 with SMTP id ja17-20020a170907989100b0087042e82468mr31285073ejc.70.1674597891474; Tue, 24 Jan 2023 14:04:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674597891; cv=none; d=google.com; s=arc-20160816; b=RmmeVx62V7sJ/UYDAsgUuTPYYlwPF6b0IQfIayacQsADrd5dqsBktZ78FXSNDrxuex S4gkAjVvj3tD2g8+6tLhzFK57kpNA7Mht55pav1fClDCHFcJKdppVfao4VEz8ka0v6R0 7WgKUHrE4LjNkHsFWM1mw44SYeLeekkYpR9qvGXZYvNGxP+ciepmdCjXM4IuLLHcfT51 yo1aAhPPuf3eNWM4Ioqzrtq6FM7jSnr6+DEq4h/9ofoiD/M3y6cAuGSS/D3hfr8/Qf1l 7abQJe5U55/lQ7VpyaS1zte+mB5t/6hulp1Nx3XBIH6Tuo5r4IrbVwDxKv9peXQ+VS8s Ksog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:to:subject:from :user-agent:mime-version:date:message-id; bh=+SRC+yyPZC+mm0zu4mc2V9SqhUUejg3/XTkRcEvhs/c=; b=ZYCp1smvaMGpqc9T3i9oo9ytTaMC1jKeH6uwBAHqr0fO5XUeLQcSjUFx3cpKcu7VXL BlolFOyVZKuAdByQYYIAkaDymUqG9zDEOG148ndS6PVNdSPNXZhFXww77aKwIkWkcnT2 FwJWqx/xWAWhAnsglg9IDcVGjkMUPVUFVspNQMIz218h4xD+FBUN8IE66LlCqzwjqqqA mEw3QRxXlIjbdx3xMY3/sCdq/2Bz7492DxXVJ+2kkyBjW64d21J1D8DedIv1aMkQs0lI zyjpOmdqX6D00PXkrJC0DelDbmdt+ieE19feyQ/FSU9Dp5yQ5z2hFVl++PFB3Omlz5i5 wMsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 26-20020a170906029a00b007ae74740fa4si4272781ejf.275.2023.01.24.14.04.27; Tue, 24 Jan 2023 14:04:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233859AbjAXVs5 (ORCPT + 99 others); Tue, 24 Jan 2023 16:48:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233564AbjAXVsy (ORCPT ); Tue, 24 Jan 2023 16:48:54 -0500 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E80449969; Tue, 24 Jan 2023 13:48:51 -0800 (PST) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1pKR9s-0049W3-LT; Tue, 24 Jan 2023 22:48:48 +0100 Received: from [185.238.219.21] (helo=[192.168.46.66]) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (envelope-from ) id 1pKR9N-0044P4-Fd; Tue, 24 Jan 2023 22:48:48 +0100 Message-ID: <619fa552-c988-35e5-b1d7-fe256c46a272@mkarcher.dialup.fu-berlin.de> Date: Tue, 24 Jan 2023 22:48:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 From: Michael Karcher Subject: [PATCH v5 1/1] arch/sh: avoid spurious sizeof-pointer-div warning To: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, Segher Boessenkool , Rich Felker , Yoshinori Sato , John Paul Adrian Glaubitz X-Original-Sender: kernel@mkarcher.dialup.fu-berlin.de X-Originating-IP: 185.238.219.21 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755943158762649847?= X-GMAIL-MSGID: =?utf-8?q?1755943158762649847?= Gcc warns about the pattern sizeof(void*)/sizeof(void), as it looks like the abuse of a pattern to calculate the array size. This pattern appears in the unevaluated part of the ternary operator in _INTC_ARRAY if the parameter is NULL. The replacement uses an alternate approach to return 0 in case of NULL which does not generate the pattern sizeof(void*)/sizeof(void), but still emits the warning if _INTC_ARRAY is called with a nonarray parameter. This patch is required for successful compilation with -Werror enabled. The idea to use _Generic for type distinction is taken from Comment #7 inhttps://gcc.gnu.org/bugzilla/show_bug.cgi?id=108483 by Jakub Jelinek Signed-off-by: Michael Karcher Acked-by: Randy Dunlap # build-tested --- (resend of the mail as plaintext only instead of multipart/alternative) History: v5: - Cleanly generated the patch v4: - Put the case distinction into the numerator instead of the denominator - Refactor the case disctinction into a second macro v3: - I had a stern discussion with Thunderbird about not mangling the space characters in my email, and I hope spaces get sent as standard spaces now v2: - improve title and remove mostly redundant first sentence of the description - adjust formatting of the _Generic construction diff --git a/include/linux/sh_intc.h b/include/linux/sh_intc.h index c255273b0281..37ad81058d6a 100644 --- a/include/linux/sh_intc.h +++ b/include/linux/sh_intc.h @@ -97,7 +97,10 @@ struct intc_hw_desc { unsigned int nr_subgroups; }; -#define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) +#define _INTC_SIZEOF_OR_ZERO(a) (_Generic(a, \ + typeof(NULL): 0, \ + default: sizeof(a))) +#define _INTC_ARRAY(a) a, _INTC_SIZEOF_OR_ZERO(a)/sizeof(*a) #define INTC_HW_DESC(vectors, groups, mask_regs, \ prio_regs, sense_regs, ack_regs) \