From patchwork Tue Jan 24 21:01:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 47892 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2374116wrn; Tue, 24 Jan 2023 13:08:37 -0800 (PST) X-Google-Smtp-Source: AMrXdXshMI3WY81qA1OFWjwJdoac2bUVvaNM0+ico3szpG1v5hrWEYT6fYciouj+2P8q1nEsMbNZ X-Received: by 2002:a17:906:6d0b:b0:871:818e:6e9 with SMTP id m11-20020a1709066d0b00b00871818e06e9mr32559362ejr.64.1674594517466; Tue, 24 Jan 2023 13:08:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674594517; cv=none; d=google.com; s=arc-20160816; b=d7c7+aCDWhlAx9hs4+KKj325EoHiFIe6F52roTRguotj216y6eu9ZEBCWPyZhjG//E PZn8UoN+9nZgbTXHkDFMmYokOzvZPWgnt9BYiJHLhi3FuzHePKfcUmqAL8dIqiY7CNLL IFxKInD4Nnsmul7IlsTkX0dBLENMNn0BTlogOQiWCNkrkTfHqKzQqQikPN9ae94chbrP BBWhMFJRowRjxPyowtopC94tz2uIUlJUB6Ro2AQ15K++muglhA7nbeNJ6TsYwkRIFyFm M2voiDzrSydOXZPbxN8Iao+zNYvtQpzr5rjdUOWQ0BxfiHCdLWwzHX6rvKCQ3I4T/xRl JDTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=3WE8PWwKgGTMs19lNlFrAIt1Ie+mz8VD8oImQDD2cyk=; b=OWGSo2REikBEALxf4ySwtM82GcrY61hlJtMdBa88pSy6eLxixMB5EIYsrD/iwf5QRb beJ8xjP6Gb0LsEthIm+rbP3lJqOKhbwik5np8qNWmEzzggS0BS0Mv3siB1qj3hZhu+5O 39CTZq2NlGioYwbwgIvgoQL5drUcaaFQo34b7t0pqbkemhiYutM7G01JGVoL6v7YrSSh JKRrMZeAZnLJ4cnApa/yQcFneElcjzM+3DkhxnPX9ohAawWF82frnbAI4doHKWaWqhYx KzFAqIZ1EgmNGywr6hMnbjOgze3rqC9NUPP9ujvesJHNfcgRnHak2xb6GRkcWwg/qC+s mzng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gi33-20020a1709070ca100b0087752be1dcasi3335368ejc.914.2023.01.24.13.08.10; Tue, 24 Jan 2023 13:08:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234565AbjAXVBe (ORCPT + 99 others); Tue, 24 Jan 2023 16:01:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229747AbjAXVBd (ORCPT ); Tue, 24 Jan 2023 16:01:33 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6C5041B6B for ; Tue, 24 Jan 2023 13:01:31 -0800 (PST) Received: from dslb-188-096-139-204.188.096.pools.vodafone-ip.de ([188.96.139.204] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pKQQ1-0001xR-1C; Tue, 24 Jan 2023 22:01:25 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 1/4] staging: r8188eu: usb_read_port_complete needs no regs parameter Date: Tue, 24 Jan 2023 22:01:05 +0100 Message-Id: <20230124210108.62170-2-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230124210108.62170-1-martin@kaiser.cx> References: <20230124210108.62170-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755939620305111983?= X-GMAIL-MSGID: =?utf-8?q?1755939620305111983?= Remove the regs parameter from usb_read_port_complete, it is not used. Without the regs parameter, there's no need for the define that makes usb_read_port_complete usable as urb callback function. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/usb_ops_linux.c | 2 +- drivers/staging/r8188eu/include/usb_ops_linux.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c index e122c8ca929c..0f789d5250db 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -344,7 +344,7 @@ void rtl8188eu_recv_tasklet(unsigned long priv) } } -static void usb_read_port_complete(struct urb *purb, struct pt_regs *regs) +static void usb_read_port_complete(struct urb *purb) { struct recv_buf *precvbuf = (struct recv_buf *)purb->context; struct adapter *adapt = (struct adapter *)precvbuf->adapter; diff --git a/drivers/staging/r8188eu/include/usb_ops_linux.h b/drivers/staging/r8188eu/include/usb_ops_linux.h index e406a1fccda7..0a8fefbd4c2e 100644 --- a/drivers/staging/r8188eu/include/usb_ops_linux.h +++ b/drivers/staging/r8188eu/include/usb_ops_linux.h @@ -19,8 +19,6 @@ usb_bulkout_zero_complete(purb) #define usb_write_mem_complete(purb, regs) \ usb_write_mem_complete(purb) -#define usb_read_port_complete(purb, regs) \ - usb_read_port_complete(purb) #define usb_read_interrupt_complete(purb, regs) \ usb_read_interrupt_complete(purb) From patchwork Tue Jan 24 21:01:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 47893 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2374617wrn; Tue, 24 Jan 2023 13:09:55 -0800 (PST) X-Google-Smtp-Source: AMrXdXvqmI2sKKSCbGBstjfhel3L9Ms96j4bKP3TIEGtmyXglJiO1ffYmlAyKNT2dlA0mrJyFfG+ X-Received: by 2002:a17:906:b317:b0:86e:5124:20b0 with SMTP id n23-20020a170906b31700b0086e512420b0mr33567974ejz.64.1674594595670; Tue, 24 Jan 2023 13:09:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674594595; cv=none; d=google.com; s=arc-20160816; b=WBKyupsjAQDYR7pt3VMsIfNdL/+xV8kofHGnoCpC4x9i4vZMSk10hG7NPGfANuE0V2 vtmCO5EZk4IRbQU5faMCpogP6YxTdfGFt7UU1B2fbLumaJKRm5Rn2zUUAnK2ApY7ynkB PvfXh4FlO4mRDZebKUxTWD7l/7eNO3YxJDpOS46Ldbd5IXvx6gaH417NATK54mOLWVUE Dd+I3hy0hkhE5Chzkks7vTE89WB2zk5apEfRJ9fHV2H1Vu2uMhIg/b8gn7PVpkRn97Vq 6QxTzfpda2IEjW1RXeO/3yOXwHeBgGL5qVcY+0fGkeVnRJvaJUpGHdptiLD29qEnuuFU wPhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=6HfDCaXSGlANcZkc7X7FMAtH1Xp3VMUvc8xx5OH2KMU=; b=E4mrLRf5M6HznmqXrbzEWLE/Rg1Gv71j7VSeFRCEyB77XsS7vgn41qCZa7H4hCvEOZ svzzRdQ8zaEM1qwe4cRVeL0XwAVz4a/q6GtPGoScYUkZzIiQnLXBswx06AU0tyY97uIl 2ufT35XQdSZGGLXAMl3/HS2kj2llozM8vL2tZ/vm5z1N34VTBzXvxF2sUrfVsl3g8Cdy Qkg+CdkediQZaIW46ur9swF7NQupb8VYVCfsENZvbAmcSLaHLl8jQbrB9QmA1bcA/Bb/ 7KnyDFvSlJbKOafKPZQYZJzkBKqnSnunBrC8yAePWPJ1D5K3DrQctcuwwMhMk7+YwzJM gyBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id uk19-20020a170907ca1300b008738b6acdedsi3659401ejc.238.2023.01.24.13.09.29; Tue, 24 Jan 2023 13:09:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234540AbjAXVBp (ORCPT + 99 others); Tue, 24 Jan 2023 16:01:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234549AbjAXVBe (ORCPT ); Tue, 24 Jan 2023 16:01:34 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0EBA46D4A for ; Tue, 24 Jan 2023 13:01:31 -0800 (PST) Received: from dslb-188-096-139-204.188.096.pools.vodafone-ip.de ([188.96.139.204] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pKQQ1-0001xR-Sc; Tue, 24 Jan 2023 22:01:25 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 2/4] staging: r8188eu: remove defines that strip regs parameter Date: Tue, 24 Jan 2023 22:01:06 +0100 Message-Id: <20230124210108.62170-3-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230124210108.62170-1-martin@kaiser.cx> References: <20230124210108.62170-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755939702514854966?= X-GMAIL-MSGID: =?utf-8?q?1755939702514854966?= usb_ops_linux.h has a number of defines that strip the regs parameter from function that should be used as urb callbacks. Remove the defines for functions that don't exist in the r8188eu driver. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/include/usb_ops_linux.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/staging/r8188eu/include/usb_ops_linux.h b/drivers/staging/r8188eu/include/usb_ops_linux.h index 0a8fefbd4c2e..c7a0dc482761 100644 --- a/drivers/staging/r8188eu/include/usb_ops_linux.h +++ b/drivers/staging/r8188eu/include/usb_ops_linux.h @@ -13,13 +13,4 @@ #define RTW_USB_BULKOUT_TIME 5000/* ms */ -#define _usbctrl_vendorreq_async_callback(urb, regs) \ - _usbctrl_vendorreq_async_callback(urb) -#define usb_bulkout_zero_complete(purb, regs) \ - usb_bulkout_zero_complete(purb) -#define usb_write_mem_complete(purb, regs) \ - usb_write_mem_complete(purb) -#define usb_read_interrupt_complete(purb, regs) \ - usb_read_interrupt_complete(purb) - #endif From patchwork Tue Jan 24 21:01:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 47896 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2375618wrn; Tue, 24 Jan 2023 13:12:20 -0800 (PST) X-Google-Smtp-Source: AMrXdXuSLRh4lpQrOs1Tf2PgQXuXHfDv6U5Y97MaV3MeSaZdMfPpjWHagOoqelCefjkO/47mpid5 X-Received: by 2002:a05:6a20:8402:b0:b0:30d8:d53 with SMTP id c2-20020a056a20840200b000b030d80d53mr40088015pzd.19.1674594740472; Tue, 24 Jan 2023 13:12:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674594740; cv=none; d=google.com; s=arc-20160816; b=qOweDq10l5EmwSWBDR3HGkwptHqo3i1L3QQTKmIeBFESa1ALbcmPm8+vZrb2ycCao/ qL+QDbFjNMvHMoXyWj/SFHP6oG8fLo0qj53aJuUo/LzttMyagihdZ+eMdlKEkwUyLhCM qSI3nKHKboGHE6mauT+t060/0vJHiQGJcZQOLYB+fkn0Erp5KVjOUTy6e71LRqYL8gxl Uzcd1TjOl5jtWyKEE29vDiJpwK70vgoUXj2u1UjDDrYOTAsdoEssWQ49ZI7tOXH0IXUh hJ4NnTgvXPIu3AVX5XZVCesK+NMoUWtOqCR5vLV8AEtiFg9DpRE47YpiurSkqV27LDKG D5gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=C64wBzN9pP7SffATb7MwkBOx6DF+Ksdn3n0SAIS6pXY=; b=HKhMY+8HhhmJBYa67CHRs3ih7vQ1X4bns8D1yfvzE9UztTJWI2DrLdjWYJSgM46+sG dRjg35yn6HGRR6XYEForqwjHPdDLzRfBY9W1S6Evzhz5UdQp2DWA87YpySHxwCaXu5uf GGtDlMTOSK+I3i5vuLBXx0Dzr52pbzCW9M+a8/c0yW72IvAjXwtDvj28qsvKVcJuTLy+ 3kQTHNgiREyKone9nK7lmpWp8aaqby9LxN2jda8qMYnrcGqLeSYCqG6APGY5N6I52qUc V83TyRfOhUhp+L/NDvMzNHaomJclmKohgFVSFqmDGPRisCxRD8G423S4MXy1vGm5E/Aw ReMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b69-20020a633448000000b004a2e257462bsi3397502pga.211.2023.01.24.13.12.07; Tue, 24 Jan 2023 13:12:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234623AbjAXVBt (ORCPT + 99 others); Tue, 24 Jan 2023 16:01:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234543AbjAXVBe (ORCPT ); Tue, 24 Jan 2023 16:01:34 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0DF745BF0 for ; Tue, 24 Jan 2023 13:01:31 -0800 (PST) Received: from dslb-188-096-139-204.188.096.pools.vodafone-ip.de ([188.96.139.204] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pKQQ2-0001xR-NC; Tue, 24 Jan 2023 22:01:26 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 3/4] staging: r8188eu: remove unused defines Date: Tue, 24 Jan 2023 22:01:07 +0100 Message-Id: <20230124210108.62170-4-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230124210108.62170-1-martin@kaiser.cx> References: <20230124210108.62170-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755939854682509971?= X-GMAIL-MSGID: =?utf-8?q?1755939854682509971?= Remove some unused defines from usb_ops_linux.h. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/include/usb_ops_linux.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/staging/r8188eu/include/usb_ops_linux.h b/drivers/staging/r8188eu/include/usb_ops_linux.h index c7a0dc482761..b149df7957dd 100644 --- a/drivers/staging/r8188eu/include/usb_ops_linux.h +++ b/drivers/staging/r8188eu/include/usb_ops_linux.h @@ -6,11 +6,6 @@ #define VENDOR_CMD_MAX_DATA_LEN 254 -#define RTW_USB_CONTROL_MSG_TIMEOUT_TEST 10/* ms */ #define RTW_USB_CONTROL_MSG_TIMEOUT 500/* ms */ -#define MAX_USBCTRL_VENDORREQ_TIMES 10 - -#define RTW_USB_BULKOUT_TIME 5000/* ms */ - #endif From patchwork Tue Jan 24 21:01:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 47894 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2374736wrn; Tue, 24 Jan 2023 13:10:09 -0800 (PST) X-Google-Smtp-Source: AMrXdXuXv6zupVFKFv6puI3TJfPQn2KCgd7Im65jV6OG8Y/VeKFzkzteDLxXJRk1uRHTeaRzkedK X-Received: by 2002:a17:90a:460f:b0:227:23c3:5db1 with SMTP id w15-20020a17090a460f00b0022723c35db1mr30903392pjg.47.1674594609280; Tue, 24 Jan 2023 13:10:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674594609; cv=none; d=google.com; s=arc-20160816; b=CdIxMbUyXcn+Vt0fLlzM9gmmx8zeK15+DkteT4Z4G8AbAi9rhjj5I+v+/Ni3AaFz2k DMi/GnqGdPiTpOe2RbE9+o6t6YZ6JoIdimIaooJV7T1Yd/4gJGu18JJPEadcL9vKr8mI 1BXtAeIph21c7XJY1eb/XGJxLKUQETD5G7lb7fFVsiU4cr26HUym4HMr30acgXN3UkZG XLDpruKaZd233gjnyKGL1xHA33mHjt+DWoNcw7ojyoosDkC9V/NE8yMFnst9CHisGVXh PV4kYZOREAU8KNXR++o7ACAmdrY8fHhfsYO2KgvBsTwsIzoQ0vhky6VMNd6F8NfOAKg3 11OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=f262yNvP9Yi0uCVDGb2tY7suPNslrKENPGcLqAQAyFQ=; b=Pg97vqeezgH5zQro3yiC3kglTfveq4VmDRBEGes/fzgMABr+/vFzuVyggKQRWUrEEj zcQks9cSjKEnodqdAa6TB+yRUSmJhLV1MSaLhphwtXEWoA3wks/b9ve4yo/ifiAJzJrO qcR+O0bn2FiKfst+GJdJpNRKDqJM13dln7i6l6VvSKsXj2w9g3cgd9+8fU5k3HBjQZlP VmZxN6DREV3S/3dFjSmqd1JCsll7LaxsP4IcEpDnpdtXpJ8ae89au2T6ATddcw+hsCm6 +c7Z6QKTykY3qOE2HHQBHXJBclarLs6Mf8gU8H3MrfMUgsTh3YnZhhU3z/nI79hyQ2v2 FlXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mn22-20020a17090b189600b002294c54e84fsi15034601pjb.166.2023.01.24.13.09.49; Tue, 24 Jan 2023 13:10:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234593AbjAXVBl (ORCPT + 99 others); Tue, 24 Jan 2023 16:01:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233643AbjAXVBd (ORCPT ); Tue, 24 Jan 2023 16:01:33 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD5A141B43 for ; Tue, 24 Jan 2023 13:01:32 -0800 (PST) Received: from dslb-188-096-139-204.188.096.pools.vodafone-ip.de ([188.96.139.204] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pKQQ3-0001xR-Hz; Tue, 24 Jan 2023 22:01:27 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 4/4] staging: r8188eu: remove usb_ops_linux.h Date: Tue, 24 Jan 2023 22:01:08 +0100 Message-Id: <20230124210108.62170-5-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230124210108.62170-1-martin@kaiser.cx> References: <20230124210108.62170-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755939716889031703?= X-GMAIL-MSGID: =?utf-8?q?1755939716889031703?= There's only two defines left in usb_ops_linux.h. Move those defines to usb_ops_linux.c, where they are used. Remove the now empty file usb_ops_linux.h. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/usb_ops_linux.c | 4 ++++ drivers/staging/r8188eu/include/usb_ops.h | 2 -- drivers/staging/r8188eu/include/usb_ops_linux.h | 11 ----------- drivers/staging/r8188eu/os_dep/usb_ops_linux.c | 1 - 4 files changed, 4 insertions(+), 14 deletions(-) delete mode 100644 drivers/staging/r8188eu/include/usb_ops_linux.h diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c index 0f789d5250db..9c940ab8fd41 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -7,6 +7,10 @@ #include "../include/usb_ops.h" #include "../include/rtl8188e_hal.h" +#define VENDOR_CMD_MAX_DATA_LEN 254 + +#define RTW_USB_CONTROL_MSG_TIMEOUT 500/* ms */ + static int usb_read(struct adapter *adapt, u16 value, void *data, u8 size) { struct dvobj_priv *dvobjpriv = adapter_to_dvobj(adapt); diff --git a/drivers/staging/r8188eu/include/usb_ops.h b/drivers/staging/r8188eu/include/usb_ops.h index ddc46cb44358..5bd8ce37aebf 100644 --- a/drivers/staging/r8188eu/include/usb_ops.h +++ b/drivers/staging/r8188eu/include/usb_ops.h @@ -17,8 +17,6 @@ #define MAX_VENDOR_REQ_CMD_SIZE 254 /* 8188cu SIE Support */ #define MAX_USB_IO_CTL_SIZE (MAX_VENDOR_REQ_CMD_SIZE + ALIGNMENT_UNIT) -#include "usb_ops_linux.h" - /* * Increase and check if the continual_urb_error of this @param dvobjprivei * is larger than MAX_CONTINUAL_URB_ERR diff --git a/drivers/staging/r8188eu/include/usb_ops_linux.h b/drivers/staging/r8188eu/include/usb_ops_linux.h deleted file mode 100644 index b149df7957dd..000000000000 --- a/drivers/staging/r8188eu/include/usb_ops_linux.h +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */ -/* Copyright(c) 2007 - 2011 Realtek Corporation. */ - -#ifndef __USB_OPS_LINUX_H__ -#define __USB_OPS_LINUX_H__ - -#define VENDOR_CMD_MAX_DATA_LEN 254 - -#define RTW_USB_CONTROL_MSG_TIMEOUT 500/* ms */ - -#endif diff --git a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c index 583533631133..c9ee1173a1d6 100644 --- a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c +++ b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c @@ -4,7 +4,6 @@ #define _USB_OPS_LINUX_C_ #include "../include/drv_types.h" -#include "../include/usb_ops_linux.h" #include "../include/rtl8188e_recv.h" static unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 addr)