From patchwork Fri Oct 14 14:30:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 2705 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp213876wrs; Fri, 14 Oct 2022 07:31:52 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5M96dJ7R3PoSxaiGJkWiLVwewVWhfFjiYZZ+tMl26n6WCboAu5TkbcJVq3aOpjqI3ZsvKM X-Received: by 2002:a05:6402:35cd:b0:45c:c4d4:6e11 with SMTP id z13-20020a05640235cd00b0045cc4d46e11mr4288725edc.275.1665757912535; Fri, 14 Oct 2022 07:31:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665757912; cv=none; d=google.com; s=arc-20160816; b=RbouZUJ5yn+HfwYLvCY00WFFrwVq2waaZPoS5IQ8sTE8MO9tvGDgI98s2i7Aqfg4En 6q9Of+hXQJko8lMgb4TvwDVZf7ztaSr9KXnCHEJFopEggXrrKZ5f84bwbvIFeNMHpGC7 101mHPj9iQjjJQuAxQYS7wpUThLAicjbeQemif2Gcn5u0EFjkwGZWFFoaW8ESFSJIF9G fJTSeFbFlVc6+ykNxFG97gEBLTj/ylH6RlSZxKZT2RcjlBmFopjUFvt0vEKw1/QagUP9 ULTZeZm4wBautpr9TguAOPmKivQnKjsWXi/9Wr8/ZLR7y2IV3MmU075+VSeoEXHOHW7I z9fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=bjQK2X7r0d74JLw7bHwD0gzx6tXUMsBME3U8p788Esw=; b=ha+gbEy04ILic+X+KfNFrCzgoMnMbc+XCVImzcZ95ukcvUvNM5VbN1FKSXUkdNM9qv y6rsacQ6yFwWtG9NcJ+8A8EFsAh/QlCcqzyfshWPm7l6SFm/kMA4F7ONyjRad7NIyBsX IdYEezHJezmMzxrQpPCSWs+xp/J9/hydN8uVP/8CLERLD0hlnvXwTnlt0exM9JoGTvom blELKtMRhypZ2ior77WtfsTeegIBP5e4RDirYKk5T3SCcei33Nbp0ukaSjYrRV/ZcNv/ spkcg8VP2x0VtRkude+o9krp329HtgevdBJqBPcbfERafi7JRq/xbfmPhq5iBqcud2et gQAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=TdaRoVZu; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id y26-20020a50eb9a000000b004592847889fsi2054739edr.158.2022.10.14.07.31.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 07:31:52 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=TdaRoVZu; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3A8603857038 for ; Fri, 14 Oct 2022 14:31:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A8603857038 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1665757911; bh=bjQK2X7r0d74JLw7bHwD0gzx6tXUMsBME3U8p788Esw=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=TdaRoVZui6522QtoQGMwM7X7YXeXf51ivFGJu1vFFOnTbJexyuNpmTBRWC9C+KPal LNv/SqmNV+zSue0iH9f70mZ7xCUiyK//w3Y9nrhD3QZLDqine7KJ2tN+8wnsUpxBJX nM1yenxmAYTjtnU26ICvdwJcqidanC9DCfkmaOvw= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 438A93858024 for ; Fri, 14 Oct 2022 14:30:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 438A93858024 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-247-sGUfhStbOemC5dEcphUQlQ-1; Fri, 14 Oct 2022 10:30:53 -0400 X-MC-Unique: sGUfhStbOemC5dEcphUQlQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C6E00886461 for ; Fri, 14 Oct 2022 14:30:52 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.195.163]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5D7BE4043479; Fri, 14 Oct 2022 14:30:52 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 29EEUnrU672031 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 14 Oct 2022 16:30:49 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 29EEUnEk672030; Fri, 14 Oct 2022 16:30:49 +0200 To: Jakub Jelinek Subject: [PATCH] Check rvc_normal in real_isdenormal. Date: Fri, 14 Oct 2022 16:30:47 +0200 Message-Id: <20221014143047.672008-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: Aldy Hernandez Reply-To: Aldy Hernandez Cc: GCC patches Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746673768688344724?= X-GMAIL-MSGID: =?utf-8?q?1746673768688344724?= [Jakub, thanks for pointing this out. OK?] [-Inf, -Inf] is being flushed to [-Inf, -0.0] because real_isdenormal is being overly pessimistic. It is missing a check for rvc_normal. This doesn't cause problems in real.cc because all uses of real_isdenormal are already on the rvc_normal path. The uses in value-range.cc however, are not. This patch adds a check for rvc_normal. gcc/ChangeLog: * real.h (real_isdenormal): Check rvc_normal. * value-range.cc (range_tests_floats): New test. --- gcc/real.h | 2 +- gcc/value-range.cc | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gcc/real.h b/gcc/real.h index f9528d765ec..306e9593866 100644 --- a/gcc/real.h +++ b/gcc/real.h @@ -290,7 +290,7 @@ extern bool real_issignaling_nan (const REAL_VALUE_TYPE *); inline bool real_isdenormal (const REAL_VALUE_TYPE *r) { - return (r->sig[SIGSZ-1] & SIG_MSB) == 0; + return r->cl == rvc_normal && (r->sig[SIGSZ-1] & SIG_MSB) == 0; } /* Determine whether a floating-point value X is finite. */ diff --git a/gcc/value-range.cc b/gcc/value-range.cc index 6b4f3dddcd5..ee15eb35df8 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -4014,6 +4014,11 @@ range_tests_floats () r1.clear_nan (); r0.intersect (r1); ASSERT_TRUE (r0.undefined_p ()); + + // Make sure [-Inf, -Inf] doesn't get normalized. + r0 = frange_float ("-Inf", "-Inf"); + ASSERT_TRUE (real_isinf (&r0.lower_bound (), true)); + ASSERT_TRUE (real_isinf (&r0.upper_bound (), true)); } void