From patchwork Tue Jan 24 15:40:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre Gondois X-Patchwork-Id: 47749 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2238367wrn; Tue, 24 Jan 2023 08:11:26 -0800 (PST) X-Google-Smtp-Source: AMrXdXvSi9blgTMMboa1cMGgIwnLLXc6W5LNUvFifedmkTBWoujOjWFPgEinc5H5HyDe1oG5nBSY X-Received: by 2002:a17:906:3a44:b0:860:c12c:14f9 with SMTP id a4-20020a1709063a4400b00860c12c14f9mr30120608ejf.40.1674576685853; Tue, 24 Jan 2023 08:11:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674576685; cv=none; d=google.com; s=arc-20160816; b=xHmjlFRUot7TGiY9ZRGI78bhmpPS6kkdIvXjRJmsCDPYdl4MleDrbeN8zKp1HdsUy4 vWTukQeCp4GN1yARcc/MBVaH/FFVIfbh8Mv8SMoyuy63gvag/nnOT9ChLzM4ZfuMJYQO ERE3wKyJXN3bK5Rjch9zkfvdJhiAUtbGCQ/JhfoeBJa/Cy2Tad+KzSRTTE/5Mlkmkwbf +NPm0TehG5uwoSfxheugXJCzM84ai1iL5g3u2PJVw9vwlq8lh20rgv5NfEYmKTb+H1HO UhM/T/RqcSWlrSP/3i3SqoSMrnyzJNmmWXH/OnR70QxMSoEDoIaA5F84kduiPwbYDMXk x1KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=tnqE9kg5WkaBBAgS19WRuoBPNmvL/+jl+l/XFX6SQVg=; b=I0gtLAjDTNCbHX+7iI7TFMunYeHMG/GhHtw0iva+JCTLHgqRv3MR1TOx7/4ljk6EOc ZS+0RphNHMNW56eKVTCWrI7E6QC4LkjWOTfLpRZ9CcxW6Iypts8WAQlrsk15C//aVTXZ RTBgAawU/gm01sALvdw7CENPPflQxMMBQXxrNkS1cmZSqDVAWkjhfG/EM5j5YuLSIPvj CxXUc3XjSebvhPT71L6ve381tmMDKilp02q+4jmyi3gq8jOx2SEYEs2wMTCOnQJ64soh +jeAswZ9aLP3z+5BiMaAzcWgPILt5bTnOyTlaP9d8o3rqKNFMe4pCrcydLxyF8STtU8/ LSCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id aa24-20020a170907355800b0084c464789aesi2678251ejc.764.2023.01.24.08.11.01; Tue, 24 Jan 2023 08:11:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235185AbjAXPl3 (ORCPT + 99 others); Tue, 24 Jan 2023 10:41:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235283AbjAXPlR (ORCPT ); Tue, 24 Jan 2023 10:41:17 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B8BBF4C0DD for ; Tue, 24 Jan 2023 07:41:15 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 33A0BC14; Tue, 24 Jan 2023 07:41:57 -0800 (PST) Received: from cam-smtp0.cambridge.arm.com (pierre123.nice.arm.com [10.34.100.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 01B003F5A1; Tue, 24 Jan 2023 07:41:12 -0800 (PST) From: Pierre Gondois To: linux-kernel@vger.kernel.org Cc: Geert Uytterhoeven , Conor Dooley , Dan Carpenter , Pierre Gondois , kernel test robot , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Palmer Dabbelt , Oliver Upton , Akihiko Odaki , Gavin Shan , Jeremy Linton , linux-arm-kernel@lists.infradead.org Subject: [PATCH -next v2 1/3] cacheinfo: Initialize variables in fetch_cache_info() Date: Tue, 24 Jan 2023 16:40:46 +0100 Message-Id: <20230124154053.355376-2-pierre.gondois@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230124154053.355376-1-pierre.gondois@arm.com> References: <20230124154053.355376-1-pierre.gondois@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755920922968881804?= X-GMAIL-MSGID: =?utf-8?q?1755920922968881804?= Set potentially uninitialized variables to 0. This is particularly relevant when CONFIG_ACPI_PPTT is not set. Reported-by: kernel test robot Link: https://lore.kernel.org/all/202301052307.JYt1GWaJ-lkp@intel.com/ Reported-by: Dan Carpenter Link: https://lore.kernel.org/all/Y86iruJPuwNN7rZw@kili/ Fixes: 5944ce092b97 ("arch_topology: Build cacheinfo from primary CPU") Signed-off-by: Pierre Gondois Reviewed-by: Conor Dooley --- drivers/base/cacheinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c index 418a18acc8f9..f6573c335f4c 100644 --- a/drivers/base/cacheinfo.c +++ b/drivers/base/cacheinfo.c @@ -424,7 +424,7 @@ int allocate_cache_info(int cpu) int fetch_cache_info(unsigned int cpu) { struct cpu_cacheinfo *this_cpu_ci; - unsigned int levels, split_levels; + unsigned int levels = 0, split_levels = 0; int ret; if (acpi_disabled) { From patchwork Tue Jan 24 15:40:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre Gondois X-Patchwork-Id: 47753 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2241495wrn; Tue, 24 Jan 2023 08:16:57 -0800 (PST) X-Google-Smtp-Source: AMrXdXsF7tXDERzSMLAg6mxb8TIm201ZPfpOXWn+Hzl/0xFuFYLl5I/3bWXuMEaynh6xpy7UqNCb X-Received: by 2002:a17:906:80cd:b0:86d:b50f:6b00 with SMTP id a13-20020a17090680cd00b0086db50f6b00mr28049974ejx.43.1674577017192; Tue, 24 Jan 2023 08:16:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674577017; cv=none; d=google.com; s=arc-20160816; b=mQNeSNVgJ0lVP79qrHr0LvUvlWnoq7RGn/PhCeNiUQy/oClvjrAHwGIxjBtZnmDV/P E+XviszWS94SsD+WhuYj91NrM5ofTY2d2v6zXJXRrnSyGtZah1Lwja1gDmdlGJlY9JZL 4hsCeWH2xScqaUPhs7hJLLvHtN1trTvb+e/D5VkPOhMW5lufPNrevfSXBUc9xCgDIwpe NDMlUJe1awE8DLJKvWZMz3j7N2h4Nx+eVioRzuABfmqocMe1YMG+3Y0XausUfuA2/cJQ PDowuQqH2dQb0ZFQIctUdJpg6gP30b1sKwLZuMC5dI8BUICSHvLT1LgXl+Es2U2hnbjs yIfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=YRSoVPsyUsPatWUNHNPXVj2c8/Nds+pKyTV9O1rOqRs=; b=DdVuMuyhKWdhkcB2l/PNeLtHjtsIzlCH7JRHBXT6wpMzqbO5EkbcKlVQ4rMBj2U9uO XbZPWpvzbv2VH70znsR308yK6BWT/zeF+aJ3BNHPBx6cUSA8cqXIdueca1rNkLuoAm3c 5E96WMxs9qu/fuo1YjrzXPbdkeuN1ttrxmcitr19X1vzQLHIb1QOWqF0yGDe/t7VlQrD Peu+qK4HKOTybUlz5+oK7bu40PeEvxkztXWi+kmQ2/iDGmC+QxQEt4r7FEm9V+waJ3g2 T2ZgLKork6ZLcHfj3cgpJoIY4dDF+qaljiB0R1A40V3/JaCZSugAeeIEGUeGu25X9p3r m3pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 24-20020a170906101800b0086f3e470d23si2898150ejm.723.2023.01.24.08.16.32; Tue, 24 Jan 2023 08:16:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235348AbjAXPly (ORCPT + 99 others); Tue, 24 Jan 2023 10:41:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235298AbjAXPlc (ORCPT ); Tue, 24 Jan 2023 10:41:32 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4662748A32 for ; Tue, 24 Jan 2023 07:41:23 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B66AE4B3; Tue, 24 Jan 2023 07:42:04 -0800 (PST) Received: from cam-smtp0.cambridge.arm.com (pierre123.nice.arm.com [10.34.100.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E9F893F5A1; Tue, 24 Jan 2023 07:41:20 -0800 (PST) From: Pierre Gondois To: linux-kernel@vger.kernel.org Cc: Geert Uytterhoeven , Conor Dooley , Dan Carpenter , Pierre Gondois , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Akihiko Odaki , Palmer Dabbelt , Gavin Shan , linux-arm-kernel@lists.infradead.org Subject: [PATCH -next v2 2/3] cacheinfo: Make default acpi_get_cache_info() return an error Date: Tue, 24 Jan 2023 16:40:47 +0100 Message-Id: <20230124154053.355376-3-pierre.gondois@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230124154053.355376-1-pierre.gondois@arm.com> References: <20230124154053.355376-1-pierre.gondois@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755921270427906287?= X-GMAIL-MSGID: =?utf-8?q?1755921270427906287?= commit bd500361a937 ("ACPI: PPTT: Update acpi_find_last_cache_level() to acpi_get_cache_info()") updates the prototype of acpi_get_cache_info(). The cache 'levels' is update through a pointer and not the return value of the function. If CONFIG_ACPI_PPTT is not defined, acpi_get_cache_info() doesn't update its *levels and *split_levels parameters and returns 0. This can lead to a faulty behaviour. Make acpi_get_cache_info() return an error code if CONFIG_ACPI_PPTT is not defined. Also, In init_cache_level(), if no PPTT is present or CONFIG_ACPI_PPTT is not defined, instead of aborting if acpi_get_cache_info() returns an error code, just continue. This allows to try fetching the cache information from clidr_el1. Signed-off-by: Pierre Gondois --- arch/arm64/kernel/cacheinfo.c | 2 +- include/linux/cacheinfo.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/cacheinfo.c b/arch/arm64/kernel/cacheinfo.c index d3fe9542c370..bf348b8d321f 100644 --- a/arch/arm64/kernel/cacheinfo.c +++ b/arch/arm64/kernel/cacheinfo.c @@ -59,7 +59,7 @@ int init_cache_level(unsigned int cpu) } else { ret = acpi_get_cache_info(cpu, &fw_level, NULL); if (ret < 0) - return ret; + fw_level = 0; } if (fw_level < 0) diff --git a/include/linux/cacheinfo.h b/include/linux/cacheinfo.h index dfef57077cd0..908e19d17f49 100644 --- a/include/linux/cacheinfo.h +++ b/include/linux/cacheinfo.h @@ -100,7 +100,7 @@ static inline int acpi_get_cache_info(unsigned int cpu, unsigned int *levels, unsigned int *split_levels) { - return 0; + return -ENOENT; } #else int acpi_get_cache_info(unsigned int cpu, From patchwork Tue Jan 24 15:40:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre Gondois X-Patchwork-Id: 47752 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2239529wrn; Tue, 24 Jan 2023 08:13:28 -0800 (PST) X-Google-Smtp-Source: AMrXdXtQxeJErIA0yQZkGLa6VcBqWqrQtbrycekjU4OtgPj4oY9C/dkP8YNYcL0BJ34BBfHwDhGh X-Received: by 2002:a05:6402:b:b0:496:f517:d30d with SMTP id d11-20020a056402000b00b00496f517d30dmr30852964edu.38.1674576808402; Tue, 24 Jan 2023 08:13:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674576808; cv=none; d=google.com; s=arc-20160816; b=Pzd5+83NVLSePFre8ey1YjBX5XgrnX3y2JCaszj6Mxhszm0Jcwe7CXrrxr8GbaY83J n2VKMI67jklIT3QFzUcsi/jJImgAlyBImTfJk0wkxuTZwQFDCAuv/q3tjHZfOPvtPag/ W9vjG9FFa1nBG7yex/Copvidr1jwVaJTT8mC5ys5oLDQp4Q51AIrSbtWfaUAX/vE95IL GjY3WLcXoLeQG1Kb9T1lxd+l1IxCx9sI9tQy4w2OyX+em2nFqrW07QQsTJZ2XDg0iXLF c+BV0V5Xd01eNCInzc2HXijlY19bOP48og/99bd1j+cc7n1R6+Qoi954tb06fDhmijoF Wr/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=VbtL2BZd2vUp+hHGrgvAfDq+mDfDeI3OPxX7Ki9f8mE=; b=bzHPo0v9uSdJxCIZb4Ps17buxC034IA1ixhtdraRIL6OBowNKPBmNHUey1i1XR6f/8 LCLFhwQF/6mr2uew2De8dukEN9Y6teniladbcZ8wJkl9qMZR0bNmfgsOdIjv/68y2EXn 6hXrVDuK15xfL3XxuXAICow49cotqC6lknQLw/V8PbsD3DRHdkTZC5n56+iVY/ZRtHkr 4CfUY4Ig6AaZH3FMyWcUZi6zKfhtEwZpGyfk8Tdcrh5sC6rUL7iZf5MisYjb7ASSNxfr 8N9VSTnMfFbvGXlT5NsQy5X9JNVHZWJc78ZHWDpqBDCtBOXikW1dRD+UXEQKJjf/UhY7 8U7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y4-20020aa7d504000000b0049e420baaeesi3414151edq.470.2023.01.24.08.13.04; Tue, 24 Jan 2023 08:13:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235325AbjAXPmE (ORCPT + 99 others); Tue, 24 Jan 2023 10:42:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235293AbjAXPln (ORCPT ); Tue, 24 Jan 2023 10:41:43 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 81E114C0E6 for ; Tue, 24 Jan 2023 07:41:30 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 143ADFEC; Tue, 24 Jan 2023 07:42:12 -0800 (PST) Received: from cam-smtp0.cambridge.arm.com (pierre123.nice.arm.com [10.34.100.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3E3903F5A1; Tue, 24 Jan 2023 07:41:28 -0800 (PST) From: Pierre Gondois To: linux-kernel@vger.kernel.org Cc: Geert Uytterhoeven , Conor Dooley , Dan Carpenter , Pierre Gondois , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Akihiko Odaki , Palmer Dabbelt , Gavin Shan , linux-arm-kernel@lists.infradead.org Subject: [PATCH -next v2 3/3] cacheinfo: Remove unused check in init_cache_level() Date: Tue, 24 Jan 2023 16:40:48 +0100 Message-Id: <20230124154053.355376-4-pierre.gondois@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230124154053.355376-1-pierre.gondois@arm.com> References: <20230124154053.355376-1-pierre.gondois@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755921051018088538?= X-GMAIL-MSGID: =?utf-8?q?1755921051018088538?= commit e75d18cecbb3 ("arm64: cacheinfo: Fix incorrect assignment of signed error value to unsigned fw_level") checks the fw_level value in init_cache_level() in case the value is negative. Remove this check as the error code is not returned through fw_level anymore, and reset fw_level if acpi_get_cache_info() failed. This allows to try fetching the cache information from clidr_el1. Signed-off-by: Pierre Gondois --- arch/arm64/kernel/cacheinfo.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/kernel/cacheinfo.c b/arch/arm64/kernel/cacheinfo.c index bf348b8d321f..c307f69e9b55 100644 --- a/arch/arm64/kernel/cacheinfo.c +++ b/arch/arm64/kernel/cacheinfo.c @@ -62,9 +62,6 @@ int init_cache_level(unsigned int cpu) fw_level = 0; } - if (fw_level < 0) - return fw_level; - if (level < fw_level) { /* * some external caches not specified in CLIDR_EL1