From patchwork Tue Jan 24 01:30:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 47486 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1911382wrn; Mon, 23 Jan 2023 17:37:59 -0800 (PST) X-Google-Smtp-Source: AMrXdXsAahes98AQ62+sxif1ceijAgic2+b80Awg+FRAo8HaWbketfEi8vX7fhy1JFae2AnM12HJ X-Received: by 2002:a17:906:d8a8:b0:84b:b481:6188 with SMTP id qc8-20020a170906d8a800b0084bb4816188mr24756286ejb.64.1674524279484; Mon, 23 Jan 2023 17:37:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674524279; cv=none; d=google.com; s=arc-20160816; b=wHxn/LGjBYxR9AtE0mNHDyFbAc1pYY/C4OHz2NuEElKjpveKq1r5AxUWQ0l451AV0L F7zNMYz2yzavJx9GI83f7EU/PugghcNd/orqizFOSeXnoNeP17WNsYPtti9D+o8Ea9ys mgvkYfeEU7u0tovm+Ax3d79ZNdN3zN+sT9LyOwYiZZAiAgGZ84N4g/0Ksts3BFS5kfeP rJAvkrFUbh8QtFbelbz0PsLU0BZ8rYPJ124bjDndPoslHRrDye8nLJyJ4EPGvzFwDjkX jMyL1mIm+ljpXJtPMFXvpD1lQEEgEJvg8vbRFB01o9WqYW+J6JYWO+P3q35LWcWbdoc1 Srgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nSp19ujQ+ktxCD6Dze1xGnN3rj3fGXlTk3QIIyKXR7Q=; b=Qzo573qrV2nZyqE8dDKFMkTmCzMWYqX3bXNSQ/7DG110/EoNrc9BtzELSToRqBjkIr 783FxUMhNNMGvMF5qau0RL0/TWcayE49xghdXZ0LGSqsIbn/bqANK5pf7oswUTgAHaeL Ssg7jICujBLvu18OBWnuq5SrRASO+cJ9ITrgFQtGVZB1Mntn5TLx2NKH7yavGjD2SmH6 4SwAskbEM3varVLpN1z6ihGP56JDBWBgHGWbWsmxho0sLnguPgHDPtDFBhyHOnaoXs4z C9reDxcT5ZX5bq6THHNvuQMvND0X9Ml+KiknDVnwEBdCfXRRIvEoHD5tOnXfWmn/u9du 70EA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=RKmQLDt+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kb21-20020a170907925500b0087765997120si563783ejb.32.2023.01.23.17.37.36; Mon, 23 Jan 2023 17:37:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=RKmQLDt+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232305AbjAXBaU (ORCPT + 99 others); Mon, 23 Jan 2023 20:30:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231760AbjAXBaS (ORCPT ); Mon, 23 Jan 2023 20:30:18 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 206D312869; Mon, 23 Jan 2023 17:30:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=nSp19ujQ+ktxCD6Dze1xGnN3rj3fGXlTk3QIIyKXR7Q=; b=RKmQLDt+q2mx7+HZ2KoFnjklUW uiYSwBVvbxB9kllH9g46k8r3ryyb7gIDxzK5XqU9xan0Fpog1a8yc+YHqBw/2yeXD+jgKxUAQAwGA 6zSVJQh7syc6nN0q0FoK6d5I7A7Lk4OYe32BRvosylNjP0v0KzH9uwroW4V4nFkQPyHhbXL4oOvAv 6ai0v/4W/7Wiirl68/E5FJ6d/X+Ezekwtjka2ZtsBCsGCYDaotELoBqUzjYJYIJZkTcRi4vSu6WiG CeJN++U+0RH5HMC3y+hoCm4Racd2ONn1BNVQkZNeopViJ7sC0o7PBfpi3JNPSH+8fyk11Hy2Y3nKv QAgDymaA==; Received: from [2601:1c2:d80:3110::9307] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pK88d-00223C-T5; Tue, 24 Jan 2023 01:30:15 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , linux-media@vger.kernel.org Subject: [PATCH] media: atomisp: fix build error, use vb2 interfaces Date: Mon, 23 Jan 2023 17:30:14 -0800 Message-Id: <20230124013014.23578-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755865971131898522?= X-GMAIL-MSGID: =?utf-8?q?1755865971131898522?= The atomisp driver uses functions that are provided by VIDEOBUF2_VMALLOC instead of VIDEOBUF_VMALLOC, so change the 'select' so that the correct interfaces are built. ld: drivers/staging/media/atomisp/pci/atomisp_fops.o: in function `atomisp_init_pipe': drivers/staging/media/atomisp/pci/atomisp_fops.c:649: undefined reference to `vb2_vmalloc_memops' Reported-by: kernel test robot Fixes: 9d4fa1a16b28 ("media: atomisp: cleanup directory hierarchy") Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"") Signed-off-by: Randy Dunlap Cc: Hans de Goede Cc: Mauro Carvalho Chehab Cc: Sakari Ailus Cc: linux-media@vger.kernel.org --- drivers/staging/media/atomisp/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig --- a/drivers/staging/media/atomisp/Kconfig +++ b/drivers/staging/media/atomisp/Kconfig @@ -14,7 +14,7 @@ config VIDEO_ATOMISP depends on VIDEO_DEV && INTEL_ATOMISP depends on PMIC_OPREGION select IOSF_MBI - select VIDEOBUF_VMALLOC + select VIDEOBUF2_VMALLOC select VIDEO_V4L2_SUBDEV_API help Say Y here if your platform supports Intel Atom SoC