From patchwork Mon Jan 23 22:02:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 47428 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1836908wrn; Mon, 23 Jan 2023 14:05:16 -0800 (PST) X-Google-Smtp-Source: AMrXdXvYhnLEhPS2TRgdM2zW+/QKH6YihgLL/JXfn+EPILLg6HOnEmSrzglTeP42BjRLbbJZXEOy X-Received: by 2002:aa7:cd69:0:b0:499:bffb:7e58 with SMTP id ca9-20020aa7cd69000000b00499bffb7e58mr40321075edb.20.1674511516398; Mon, 23 Jan 2023 14:05:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674511516; cv=none; d=google.com; s=arc-20160816; b=jFeb307/MdTLgk/29PJf1ex8/lamr8Osi7DAReqGEd2k9aaHzQAI2u1kXZBC4JS+EL LO89LOwPI5VawFkfCIGsWTz+68GnVbYvU0zXqmOSSs6o6rmBiKqKRXzx2mCFWykE/+fZ NrUbX9RdKM9iWkq4ZjSjtyjsvy7bitUP7N8plbCSEp3v1UPyQCYO4zjw2pJM/kLRGDLQ TJBnyVnzG58GrrLU0P6BFTmpqTjDG8zlIe4HNvWgwlzO/4Y43iaYXb8jOVu03BH8IEdH Cq09gypbvJ9YVtV7ic3HnHmfNoEO+i8dhVIgwkWqPc9k7RfiOSqzWBAOaCE0bIKzQWE9 Z5Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=/1QCX9xEbnDyZ+BWvuxlT8SkzZkHxDa1Mh+IH4d4WW4=; b=DTCWH4qzqjBANw07ppwF462bGzn5cPE6GjykYATcA4lKy2op2o5iV+e8G4HtkZ6t4B 3aWWVxNSTm9YWVALjimqPsLhsx9C77CteG51EC2OyJ7KAA0zEWpQbKJ1DWijfRGIQOtq 66SyE2jf6gzln+vJM/+0vReJ+yEvx4ODyWo9/20bAOb9xOucNUvS74yLsB+0J56DhcL0 oPx0BYIY402E4cg9jnUdr23iDcoLgB2tzTvmfURlqk7K1E8NIVC7AbLxh5x1KCnziuGf iLZw/aSDsgMnjfQklULFWbuy+m5Nl1lCQgZpvTlsTJceH9vau7mgTJmP/jzP2VAesUap pJjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f3-20020a05640214c300b0049d221b4b39si629183edx.187.2023.01.23.14.04.52; Mon, 23 Jan 2023 14:05:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231989AbjAWWCb (ORCPT + 99 others); Mon, 23 Jan 2023 17:02:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231618AbjAWWC3 (ORCPT ); Mon, 23 Jan 2023 17:02:29 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A991B75B for ; Mon, 23 Jan 2023 14:02:28 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pK4tV-0006OK-Qq; Mon, 23 Jan 2023 23:02:25 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pK4tU-008A4k-Ed; Mon, 23 Jan 2023 23:02:24 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pK4tT-00FKzQ-Fc; Mon, 23 Jan 2023 23:02:23 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Daniel Lezcano , Thomas Gleixner Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH] clocksource/drivers/sh_cmt: Mark driver as non-removable Date: Mon, 23 Jan 2023 23:02:21 +0100 Message-Id: <20230123220221.48164-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1414; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=+LZ+8HX+K947Qy1BXMUgF+Llkliggacmtec8irlFfsk=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBjzwPpbWZ0nGHe6nGBI7qAUnO3folNpNsXNatgw+GU Ut2MnPqJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY88D6QAKCRDB/BR4rcrsCU6BB/ 0VROzzPWpDcv/g/MwIGwQOsNhuh0W75RbVWFiX51coKCs3n+cKQ9Z4CmFX2pdg0FHvwVyCBm2axm/Z 4YuKpyDPVAA9lCKISrayZxgDjKylU0swhPioWcK2n2FER5N1Tr+U0MXLM9u9W8MNB3UBxdmc2Yt4KJ vfOSm5anHRgOx/VHJzXcbkr/pCimHf3AMiOUcSCV1ScX/odmBrQwHjMDDULSarNp21nTlI0HBivJrm fm81XmHBiqAiYbb4Y3GhJQHrLmwKZhr2apTKvbJBNZmTKPXK9MY6N1+xNQ+U2RrfYAj2LQLceIxyYv ehNIMO0OyFKbc/kj3+RlbpE0RyxkfF X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755852587874042187?= X-GMAIL-MSGID: =?utf-8?q?1755852587874042187?= The comment in the remove callback suggests that the driver is not supposed to be unbound. However returning an error code in the remove callback doesn't accomplish that. Instead set the suppress_bind_attrs property (which makes it impossible to unbind the driver via sysfs). The only remaining way to unbind a sh_cmt device would be module unloading, but that doesn't apply here, as the driver cannot be built as a module. Also drop the useless remove callback. Signed-off-by: Uwe Kleine-König --- drivers/clocksource/sh_cmt.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2 diff --git a/drivers/clocksource/sh_cmt.c b/drivers/clocksource/sh_cmt.c index 7b952aa52c0b..8b2e079d9df2 100644 --- a/drivers/clocksource/sh_cmt.c +++ b/drivers/clocksource/sh_cmt.c @@ -1145,17 +1145,12 @@ static int sh_cmt_probe(struct platform_device *pdev) return 0; } -static int sh_cmt_remove(struct platform_device *pdev) -{ - return -EBUSY; /* cannot unregister clockevent and clocksource */ -} - static struct platform_driver sh_cmt_device_driver = { .probe = sh_cmt_probe, - .remove = sh_cmt_remove, .driver = { .name = "sh_cmt", .of_match_table = of_match_ptr(sh_cmt_of_table), + .suppress_bind_attrs = true, }, .id_table = sh_cmt_id_table, };