From patchwork Mon Jan 23 20:02:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 47357 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1793245wrn; Mon, 23 Jan 2023 12:07:01 -0800 (PST) X-Google-Smtp-Source: AMrXdXsOC6y6duk2adir2Bo0U/i0kMH7OuiWJApYRJ0F9LDHOKq6hFu0JAAJGYJ+NTSDG6gwdTSi X-Received: by 2002:a17:907:2a03:b0:877:9ebc:efa3 with SMTP id fd3-20020a1709072a0300b008779ebcefa3mr11539418ejc.45.1674504420888; Mon, 23 Jan 2023 12:07:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674504420; cv=none; d=google.com; s=arc-20160816; b=F1jcrBd5UJykmsgCjiDUy8ao/S4FngvCVKza0r6J5+crhd/kEDrqitg52FstUjAVaD +DaiS6jIlZGTOl0iXg70VI2AdNI2PXtMsPfMoZsLwfbPIJvSTppDq8l8W3vGU4KkSgAv TBY3XZa2tStF+im3NBFblKCZsLO7XAjVVIuc6EmrY5e9hCr9Sk4CKKFrmhmzQmWWdWq8 kFRhmkseNHFNXi2ifztpbNz+CyWfrZykB+VZZffRWpJC3iwIEeU/AzA+Pmy6rfOYqBaZ a+5n75N5O5lbtovAVHPXEqvLAKMpkUM7ArWcbYwAXmXBxP0hXb3m8l6PvPHhi6Oc2x7e LK4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=kLnDNkkI/ofompHbNI3p/Hi3nJNzFutm9TcQL778pmU=; b=warij4G6nCSGNQ1ILR74/GIHTaLfBuMlPPwUd9rqaOfdr+GgLOfezv26bKJBksdNK4 bDpdQMBOLWU4U0TahEklGQu5vhNbsYGj0tX9hR7mKfy+4TuIYif58JQmOJfAB5fB5A5q L02YvzsW9if4Qqis/wCkfQ1/sCOEUD4OaWlQsKlEz9Pqmt1e3/JsjvTurvupnG93ff6A OpxNB+Rirnt9lEwGrLCEJnYDhtFttEpAQ5qDhSes0jqzlIG4ceXm3oa3ZxUXFyrY1hW9 ZG2LmRbu4yl2Z3CsJmXFCOKKm2uoLuw8Ujjo9wa1Jf1XKUS4U9/iloGiThvAapf13UVj B+DA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=LMfds0bS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hv13-20020a17090760cd00b0084c855e9b5bsi31890751ejc.97.2023.01.23.12.06.37; Mon, 23 Jan 2023 12:07:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=LMfds0bS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232878AbjAWUC3 (ORCPT + 99 others); Mon, 23 Jan 2023 15:02:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230267AbjAWUC1 (ORCPT ); Mon, 23 Jan 2023 15:02:27 -0500 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56C3A28854; Mon, 23 Jan 2023 12:02:26 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 9177F20004; Mon, 23 Jan 2023 20:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674504144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=kLnDNkkI/ofompHbNI3p/Hi3nJNzFutm9TcQL778pmU=; b=LMfds0bSuBsB94c2ksSXe1FONM3/3/f71kCpvAXvVHbL91NuxgvmrsILGKsP+yMcFuS9DL H8SjvACmS9y/W4VQGT8yaJVcws6sx8cu1V0K/sRID1EoUEcmPUQRPTLsUOHG7FgYBAAYzL 9WzYKZPcxBvJ73NK3iIEtRuqWaD20ElimzkkuhIc10RGxesUFqG+K+7dnsJz+FJHSU+9np CG3wEu0q49NQBmbFmT3vDnke0BeP9KRUzlUN2omGkPPU9TtofWL3/sEEVBGgCGbERw1KfP 8KUuJaGYgI3ngOPqGpVrgyiD6L/+mZlY6hGDtUNY6VPJjxggKAmkImO4hrbIDw== From: alexandre.belloni@bootlin.com To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/12] rtc: rx8010: use IRQ flags obtained from fwnode Date: Mon, 23 Jan 2023 21:02:06 +0100 Message-Id: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755845148002167944?= X-GMAIL-MSGID: =?utf-8?q?1755845148002167944?= From: Alexandre Belloni Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rx8010.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rx8010.c b/drivers/rtc/rtc-rx8010.c index 5e2fd39f70bb..b9c8dad26208 100644 --- a/drivers/rtc/rtc-rx8010.c +++ b/drivers/rtc/rtc-rx8010.c @@ -394,9 +394,14 @@ static int rx8010_probe(struct i2c_client *client) return PTR_ERR(rx8010->rtc); if (client->irq > 0) { + unsigned long irqflags = IRQF_TRIGGER_LOW; + + if (dev_fwnode(&client->dev)) + irqflags = 0; + err = devm_request_threaded_irq(dev, client->irq, NULL, rx8010_irq_1_handler, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, + irqflags | IRQF_ONESHOT, "rx8010", client); if (err) { dev_err(dev, "unable to request IRQ\n"); From patchwork Mon Jan 23 20:02:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 47356 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1793178wrn; Mon, 23 Jan 2023 12:06:52 -0800 (PST) X-Google-Smtp-Source: AMrXdXtWHgIFt4eTadlKJeTHBlUdFeByQz4KMT1CoGz7roRKFsuyk7IpVjhpWOXWFgErjvcoKX1i X-Received: by 2002:a05:6402:4447:b0:497:c96b:4dea with SMTP id o7-20020a056402444700b00497c96b4deamr34224943edb.5.1674504401959; Mon, 23 Jan 2023 12:06:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674504401; cv=none; d=google.com; s=arc-20160816; b=psvHOuDbF93wf3t6NrLHxighBRRCQ3/3L7l/49oyOD6vTmNPsDg1qts8we8FUmV80H g5oqV9ZizxpV8dsbDEMs3joHjTAJH53GHx0YInMzTiMpCl70js5vwu2akTgbnY3EzSRt soYf1i0wrjsjbKkIM6xlYHb8idwbPF4wGLiAa5gFp8lnZ7QZNSI5vn///ndcs72zVg2p 4Pz5hKSYta0EwikJBXuJB4Wubi1/g7SDOCs0O9wTvBx0AGQPRXkZpMCb6VMU+CoeJeWv jhIZW5Uay5cM65rYGcgOMNMtSTRjPmlFZ8IfmXFERr3pIl6aGIgTu0z05bjR0EVf6Yu8 2GEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=itQ/AGjKyNo2fkcIbkmOoRnuNHgnlz3Nr0BwieritzE=; b=tzbMyVtwM7ERu6FgC8IoxjTVvDxaIhjBPtPkzbaeQKnpEr0dsDRD0ZFgKJ1UH4z/Ig 0iw+C6rzlbEhC9PJdVkWT1cmVLMEDqlMKAcm84fk8JEYW5p4hdpPOaFhyq5wKpz/SuqY uG+ELqBydq+x1qpcN/K1iRjrIxA6Ys50+3rmNz8QSn+F7e9EZ/ze/LPiGOtnbDACANB/ v0nZhimbIUZWFp46PLCXgTKOEL7ugiL/9xxrE5sRT405Vx/h+QhKVPXK2byZwmlYWYgJ XMAmo22G/SPaufeev13UFD4lU0lfcsgeBgy+2LLuzSK77hsEnYHnjpW6yDq6qyIKgcHZ teCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=XVzFPaXm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c25-20020aa7df19000000b0049ecc8190basi351283edy.254.2023.01.23.12.06.18; Mon, 23 Jan 2023 12:06:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=XVzFPaXm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232894AbjAWUCa (ORCPT + 99 others); Mon, 23 Jan 2023 15:02:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231776AbjAWUC2 (ORCPT ); Mon, 23 Jan 2023 15:02:28 -0500 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D49BA30E93; Mon, 23 Jan 2023 12:02:26 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 5E72640006; Mon, 23 Jan 2023 20:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674504145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=itQ/AGjKyNo2fkcIbkmOoRnuNHgnlz3Nr0BwieritzE=; b=XVzFPaXmTJzszYm9iugkGbl66Q8+SpKYtxXDwZ5GnZbsl9xhZ5WOMrmzXBuvxCk4Fe1Hg/ L0b6FADbFn0NivlQaFO2GqNBtScJXlJdp4nbZuItxfbvIU1L0mkVgBeSrmYuM68/AAp7Al jWxNiYOjkojXQgCs54HkRVK2Inq1PKOWBJF+toxQsIkFsAZ8UjGi9eLQV8tHHx5p21wh6k RMgkslp7QhJ3l/664TuF1Kf0JGnifiFMIHkSFxYZTfjsHcPnEkXhB4tIP852cEvls6ze1f yH+80lm5gc4xrrubzqZ+xCyQmqTbg4z9eaeMcii7I49AjMxLG/1esM5YXzzOPA== From: alexandre.belloni@bootlin.com To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/12] rtc: ab-eoz9: use IRQ flags obtained from fwnode Date: Mon, 23 Jan 2023 21:02:07 +0100 Message-Id: <20230123200217.1236011-2-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> References: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755845128106236752?= X-GMAIL-MSGID: =?utf-8?q?1755845128106236752?= From: Alexandre Belloni Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ab-eoz9.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ab-eoz9.c b/drivers/rtc/rtc-ab-eoz9.c index 2f8deb8c4cd3..34611f6dedcb 100644 --- a/drivers/rtc/rtc-ab-eoz9.c +++ b/drivers/rtc/rtc-ab-eoz9.c @@ -536,9 +536,14 @@ static int abeoz9_probe(struct i2c_client *client) clear_bit(RTC_FEATURE_ALARM, data->rtc->features); if (client->irq > 0) { + unsigned long irqflags = IRQF_TRIGGER_LOW; + + if (dev_fwnode(&client->dev)) + irqflags = 0; + ret = devm_request_threaded_irq(dev, client->irq, NULL, abeoz9_rtc_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, + irqflags | IRQF_ONESHOT, dev_name(dev), dev); if (ret) { dev_err(dev, "failed to request alarm irq\n"); From patchwork Mon Jan 23 20:02:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 47364 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1793712wrn; Mon, 23 Jan 2023 12:07:59 -0800 (PST) X-Google-Smtp-Source: AMrXdXvw7dUZL9Duptk5IFn0f+/NvF4Ge/LJyLYcr5E7qZabLWcUd98M7hjHWBrVYJ8451AFLUKW X-Received: by 2002:a17:906:314a:b0:870:2cc7:e8e2 with SMTP id e10-20020a170906314a00b008702cc7e8e2mr27400274eje.54.1674504479080; Mon, 23 Jan 2023 12:07:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674504479; cv=none; d=google.com; s=arc-20160816; b=Yee7ZHjH+WIarC9zkx88iAPjdahyb3J9O7+LZ1GRF0bfuwwy/esQDcgBuWcDMXK72g uYhFPW+wtJWzekrfNdv9+vf7doLryfG1M5g2m2c1V7yDv3E389Iku4Qd27vyKaoponTp vjhMWAKRK6LM2fdgBo3eJ0uOtEriLvZEVPEbdRXX0kj0XoUxayVRDuFTzWGHGofyVCGp Tt2E2ivwV8RKPwMiBq/UCY9eOefCrakf2mqmgW2mX00+Z1yneCfUkg2e3tA5Y2bYPDYf 1dHOYoBSUvGTaRBTcqkLd1zvVYezKVRI7AkMVQ1CuzosxAkr8V3GdfVfYaNbYFuyxea1 13EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=K74/5wsg3+yOTxqONEVSXTGYGP5hKkIUuUVWXEdPX+U=; b=zXdJFmiVey9JOOI/455W90rinYS1QGfKUvOZ7V6kFhZelCawp+eZJ7y0KF3YnQHbSc WplGQ0kS7nEdcBZwkHlW2KPYZG2tBrQvFtTnkKFKWA8HJffc45l1qvmhHh2rWQjczq6z jWs7HYQiqCAu6Da3ICW/g03Pc0wgDaxxfGwMx6/rD0Gzdti7yH1kqbBoY8aFhlZ2zPAR XLDGa448S9E9d/HECjCVT5n7E9pB+imK5fH5aNH6cc/k5AO9T/k1Tb6m2MpNwUKSifiu 15tyVWY4mSWB11RQZ22PWpTUfSGLWsnQpeMoKMjyyUYz9nEZtvftyRI3Rksf50AhmLeq BKwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=PVeZuonQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dm15-20020a170907948f00b008777140c600si6574680ejc.906.2023.01.23.12.07.35; Mon, 23 Jan 2023 12:07:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=PVeZuonQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232920AbjAWUCd (ORCPT + 99 others); Mon, 23 Jan 2023 15:02:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232876AbjAWUC3 (ORCPT ); Mon, 23 Jan 2023 15:02:29 -0500 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E070230EBF; Mon, 23 Jan 2023 12:02:27 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 0C5D340008; Mon, 23 Jan 2023 20:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674504146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K74/5wsg3+yOTxqONEVSXTGYGP5hKkIUuUVWXEdPX+U=; b=PVeZuonQyRMV8fUknilmMDX/TXRlPVFlCLaZ9sFKyaYVA0vxJRVcjQCZzFDW03toZaoJv2 lVXCH6v6vbIMT0+Vt39sQne8ZvD+91OFtAOuNIVEcFu2oOlNKcIXGvQidgQkaUtP3LKhrB izNJoZnH31fz94kFDGH78YRH36hOxpae70/QH/JXL1myrSNy3kIPI2ZXiEpJTVtJQAdABJ ZjnS/i3qbQ47bNLTBzVUY81LWKxaxMoba5N8Ek0CS1ILIGS8cQwxy4bI/xvaVTUq0OJ+uJ EzrzUnMslXbSKcJAECXMCV2+8kumXSZHkg3n7zPNlpDZNulmCf/guD7R/hxVWQ== From: alexandre.belloni@bootlin.com To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/12] rtc: hym8563: use IRQ flags obtained from fwnode Date: Mon, 23 Jan 2023 21:02:08 +0100 Message-Id: <20230123200217.1236011-3-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> References: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755845208488880122?= X-GMAIL-MSGID: =?utf-8?q?1755845208488880122?= From: Alexandre Belloni Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-hym8563.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c index cc710d682121..7d5a298a9a3b 100644 --- a/drivers/rtc/rtc-hym8563.c +++ b/drivers/rtc/rtc-hym8563.c @@ -518,9 +518,14 @@ static int hym8563_probe(struct i2c_client *client) } if (client->irq > 0) { + unsigned long irqflags = IRQF_TRIGGER_LOW; + + if (dev_fwnode(&client->dev)) + irqflags = 0; + ret = devm_request_threaded_irq(&client->dev, client->irq, NULL, hym8563_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, + irqflags | IRQF_ONESHOT, client->name, hym8563); if (ret < 0) { dev_err(&client->dev, "irq %d request failed, %d\n", From patchwork Mon Jan 23 20:02:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 47355 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1793146wrn; Mon, 23 Jan 2023 12:06:47 -0800 (PST) X-Google-Smtp-Source: AMrXdXssroEX6Tq94Q1mRgcFVQ4zIXuGt9Mj2XCUEkZvJQnnppR2prIeikpPV+pmc/WmR1J1oV7j X-Received: by 2002:aa7:c9c7:0:b0:499:cc32:6a52 with SMTP id i7-20020aa7c9c7000000b00499cc326a52mr38311574edt.16.1674504407449; Mon, 23 Jan 2023 12:06:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674504407; cv=none; d=google.com; s=arc-20160816; b=iHEtvxNBt85Bxht7AgbZO8hxnkymkgu+lVnkAElv2TkdIx7Ui+Qi6dGB7YzkXkvN85 fKTdLjh/ddLmMN8Q9W8UB4/N41XvqPnsbuX9g8nKxJ0h93HDzIfydxFjl7HeshwYBFqG +3rwHlimuUq674Kj17p8wUwTukQPp/5oiGcjqNZQtVNxqaC538Js3ayLLTK3LIqKQJ93 lc7opmhlwBun5SFyLYyk3aPrjnhYDiIY7Qgygmni4121c2TfiozMkFIKMEz4HhRoXmXE H83JjRuKXvx4dcmMCbxy5tQ6Ywogfom5Qhg1XnyKByMb0Ft4g6WMrPBn9PgooQz0/5Dk y8jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=i4CYOl5oNdw44YefzmYwC9lPiS1qIhS68kXXq1VFs7Y=; b=Uz+ar545ByJbF45qK8qLu+SqvL5f1ncPHpHZwhFn51kMA+JAFOny+RWBwtkCACUdm/ 4WGUt6R9Gr+LPOyG61PSfLrUuAuMj/EEfs44towl00FKn82SEHGqi8AToMbHSsp8lIck RwdfiCPD9iAQkV4rhS3tiocTVGvMITucdp36ZLh1+PCr2M4vKmvCetSggTdMkt3OwW7v /9fk1RxEVdDiO+ghts59uOC85dFYSRpPeHIfKcxHG0YWjG4XsBqYjjAy+kJJZ3TgDO13 XcmDoXufdpmqeA8d7EjGhvPa+I1iduk+F60d49P4ZviZNumd5tdXbiVs/O2ai49z5cdD HqPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Zy6NVI6m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q26-20020aa7d45a000000b0046721c5b7e0si246155edr.511.2023.01.23.12.06.23; Mon, 23 Jan 2023 12:06:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Zy6NVI6m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232921AbjAWUCf (ORCPT + 99 others); Mon, 23 Jan 2023 15:02:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232883AbjAWUC3 (ORCPT ); Mon, 23 Jan 2023 15:02:29 -0500 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BD7528854; Mon, 23 Jan 2023 12:02:28 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B150D40005; Mon, 23 Jan 2023 20:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674504146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i4CYOl5oNdw44YefzmYwC9lPiS1qIhS68kXXq1VFs7Y=; b=Zy6NVI6mqBIUHMRhbq92oVN/rz91vj+BTE2KLGqj1zYuVn0X1kCg2TYEIFZkRPFaRyK/Uc dmjWfVt6HwtDIuo6tu8y4KgHScBGOZ71EPBwXCRrRCM+Niw2WcMdRUNYuHsugB3VVtHrB6 g86FnThlDyF1MDZFar+m+boHgOX03Xwv03P6Jxi/u59SexLM50WBTR0OdG7mKEa7JG2eAU Bviag3+orR22GvUFK2vooa/DSy70naTS8ZBHgkvHp0LzCkhuP7/YrcC/JWyqVCqw466SBq LSDDoYOCFOnlQxuBFJ4k3FP35C13yWT0+EzqQmZpk5Y3csjnVWKGhmqJpb7OMA== From: alexandre.belloni@bootlin.com To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/12] rtc: m41t80: use IRQ flags obtained from fwnode Date: Mon, 23 Jan 2023 21:02:09 +0100 Message-Id: <20230123200217.1236011-4-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> References: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755845133122961197?= X-GMAIL-MSGID: =?utf-8?q?1755845133122961197?= From: Alexandre Belloni Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-m41t80.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c index 494052dbd39f..c1963f7c424d 100644 --- a/drivers/rtc/rtc-m41t80.c +++ b/drivers/rtc/rtc-m41t80.c @@ -914,9 +914,14 @@ static int m41t80_probe(struct i2c_client *client) "wakeup-source"); #endif if (client->irq > 0) { + unsigned long irqflags = IRQF_TRIGGER_LOW; + + if (dev_fwnode(&client->dev)) + irqflags = 0; + rc = devm_request_threaded_irq(&client->dev, client->irq, NULL, m41t80_handle_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, + irqflags | IRQF_ONESHOT, "m41t80", client); if (rc) { dev_warn(&client->dev, "unable to request IRQ, alarms disabled\n"); From patchwork Mon Jan 23 20:02:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 47366 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1793762wrn; Mon, 23 Jan 2023 12:08:06 -0800 (PST) X-Google-Smtp-Source: AMrXdXvm8CPFbxgxmjpgn/W+0ocO8VhU8h3A7ve0E4QzX2RbJzElYr0iuInVlXjqJj6yBvYdfUyu X-Received: by 2002:a05:6402:27d3:b0:499:b3db:6aa3 with SMTP id c19-20020a05640227d300b00499b3db6aa3mr33626164ede.1.1674504486361; Mon, 23 Jan 2023 12:08:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674504486; cv=none; d=google.com; s=arc-20160816; b=tafSaMDDPLJ1g8fomlNngVbaMsjf//QSxVQyumJ53lHVHF/qMo+we+uUzhkZN+Hz6G bwmtUjTY6zN14UfdVbVSsVZdB7hZlRNw1qF9/MsnTaRyuCMfDTw4Eb8PoAxpFIQHcb7f zBa20Jlj9aBpo7wQtNsAIV1MToTzGxk81RA9Zr55GubXO4gGV+PV71b7i6+yG5gRqRRL O9vRdh8tI/En1AEQwP70AV2E8Xinvby7Rf/CtpZAfMrBAN5YwJKHgBgcMuj/MuNna2Fc JGzcrX/bry5jysROp9U3SJqfxOCAC06984TN7O4RYZWgO09wYGJ1WJKQQkvS+x3W1+M2 n2hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0s8fB4SB1tQYPXzwsCZtyf9R6xiwoC+ZC5ZWgRWvKTE=; b=VpPbp6agpG1jVhc04CD+RZcWgc9uj5lu2S1UR5/HuSU7l0PNQDrka+q3bvil6jk5Mk gpKF7XmwpnKs9rmMVRDp7Znh1V73ajNnmO/s+jN86PD1UnlF1F8zav39XiX3LSYTzhvX vS7DMJja6rhNE1NHji7Q6htjec88LWT0Fq3ho5tI1oSGSohtKG3LwkKEH8uYCUv1qrYQ qDH6iFqIjYCRxjLveYDTxFWvA/OmbWn8ctPEMP+aZUE4+FxNfMKYsXzEgsmASjrI2fA+ 8qXh+DV+8GrG59lxQVHE7+QIVAa7MQ+NVENJIoygdpc9Qvfb8adm2L9wo8tdYkvCzELB XVaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b="H3jCM/ZV"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o2-20020a1709061b0200b0086f05817f39si23452691ejg.39.2023.01.23.12.07.40; Mon, 23 Jan 2023 12:08:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b="H3jCM/ZV"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232974AbjAWUCi (ORCPT + 99 others); Mon, 23 Jan 2023 15:02:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232902AbjAWUCb (ORCPT ); Mon, 23 Jan 2023 15:02:31 -0500 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DCB530EBF; Mon, 23 Jan 2023 12:02:29 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 7F31824000B; Mon, 23 Jan 2023 20:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674504147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0s8fB4SB1tQYPXzwsCZtyf9R6xiwoC+ZC5ZWgRWvKTE=; b=H3jCM/ZVWDDDNwuETFqpY5ZJy8yxY2BBXf/O5Bs27SAYGCPcLWbov9Q57NS6aGIU34Nn3z GGdpvNVdH3DeFYVG9sT89EWhGesgHEpI/izuEiDLest+d8YUmO9wbsLNVPHkT/aKx3xTQq GtH9M4950RAmWi4xo9DoE3dnzIvsM4A10QnXnKKbk2uEFys3OzbNzjxQWy2WvN2kFHfJcZ o6Gs8vLqJKiFOo8rnuP8707oac8orIpSL9PgThLiFyxBzfe/pchZgP1KJKFyXuuoXt4CWn hR01/HvjtRKbPNlp6MVYY6aEl9by3UDvQwvh4P7Wm6HxJQC7Y3KwI5tFHnNAvQ== From: alexandre.belloni@bootlin.com To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/12] rtc: pcf2123: use IRQ flags obtained from fwnode Date: Mon, 23 Jan 2023 21:02:10 +0100 Message-Id: <20230123200217.1236011-5-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> References: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755845216232425843?= X-GMAIL-MSGID: =?utf-8?q?1755845216232425843?= From: Alexandre Belloni Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf2123.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c index e13b5e695d06..e714661e61a9 100644 --- a/drivers/rtc/rtc-pcf2123.c +++ b/drivers/rtc/rtc-pcf2123.c @@ -413,9 +413,14 @@ static int pcf2123_probe(struct spi_device *spi) /* Register alarm irq */ if (spi->irq > 0) { + unsigned long irqflags = IRQF_TRIGGER_LOW; + + if (dev_fwnode(&spi->dev)) + irqflags = 0; + ret = devm_request_threaded_irq(&spi->dev, spi->irq, NULL, pcf2123_rtc_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, + irqflags | IRQF_ONESHOT, pcf2123_driver.driver.name, &spi->dev); if (!ret) device_init_wakeup(&spi->dev, true); From patchwork Mon Jan 23 20:02:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 47358 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1793256wrn; Mon, 23 Jan 2023 12:07:01 -0800 (PST) X-Google-Smtp-Source: AMrXdXuPlEbZT6TPordcb/hztHATHWl75rGvaJGSie/MUpLYUHvfhqQ008nIYFg9E+XyuLQXJIAB X-Received: by 2002:a17:906:aacf:b0:860:5723:a5e5 with SMTP id kt15-20020a170906aacf00b008605723a5e5mr24556729ejb.69.1674504421699; Mon, 23 Jan 2023 12:07:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674504421; cv=none; d=google.com; s=arc-20160816; b=TZonsFsNxvkgC4lGJBYRv73+0IjUgfFs1fpMyGBRpGLl7DFK36YKuLaAHDPK6sAZOy sux4ks+4YUD1NJOuLp+iCAsHbobNnHAhMb3TWMJoeS8zbz1uaN1ix8DM75Mi3Mr665py ykc1Z5DhlkopBv/lclMXIrWaTVK3NDEasa8Q5bzzO6E7ozCpQdTABXo1ZZ/uBwIbHHgm 8i7f2x0Ef79Ny0O9XUPNKBSehszJGUVgaao1iNBl1SC5gazF4csoX0UjciSpNo6FIV+w 8JqBD549xVo+wmoj9k5NI5wYuGOA4Td+P2M3fCqgMU57qhVdA2zPCYSAzAk1jlgIT0WH AkkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lZoBZM9hdVyL6nx8DGe06qdlPCrvXzgiMdMYi/92dwk=; b=LO3XBIkv0iBPD20+Y65H1Io7bUxpOEMr8PXPv50if4HKjH9pVrj8SGmcVKZfczGoHm 8UOHhpBgNsL7lm7SYYvx1e8f+eWZPSTd/XE/MwKMWoWg9mtRSfPQnm8NNR/PEFuKqPzW +dnTqdAS7DAP0ceftAbpyfh3gt3mXwdkxw9z07qpGqG3SDcM9w+fFyiMYpQ3H6c/AsJR kQwKOh5cwCEC2rpcVP3HdtHl8gbMPEZ3a9FYfKp79l/uxXSBmL/XUHauhOLXSUF/gJfj 80bQPNnKnahDh+Tc6AMl2Du7Zxhj/1qts0oal5va0RwkHPn9tU043GpgdYiyEYzR8688 qcbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=H2y2d+CA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fd22-20020a1709072a1600b00871160a1e90si19357724ejc.999.2023.01.23.12.06.37; Mon, 23 Jan 2023 12:07:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=H2y2d+CA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232989AbjAWUCl (ORCPT + 99 others); Mon, 23 Jan 2023 15:02:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232911AbjAWUCb (ORCPT ); Mon, 23 Jan 2023 15:02:31 -0500 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55D06360A3; Mon, 23 Jan 2023 12:02:30 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 824FFE000B; Mon, 23 Jan 2023 20:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674504148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lZoBZM9hdVyL6nx8DGe06qdlPCrvXzgiMdMYi/92dwk=; b=H2y2d+CAk8+YdLqlBVdLuNxyasiJThl/vidlmRFzQqxu6bdwAgDvpdIMd5ZyTEYJ68J+aQ E9M1C6Ygux9REMJS/tlMOs+1gXnq4yYYKsgmXgOdf3wN5mWEG2SE7qQrdxKL8YVweWC/hG pgfwXzJO/sGPIShoH8LRYfN23AYyuyaixih+H/5TrIrSNW5/Q1LHkLtP/sg14fXDwARlJi 0dcAG0XIoI148fJ2MmubSE1GOAEb8MgF/sv/XZhZw9Z9mrOY0s+TklM+SERNbUKg5DyNI7 zMdpADH100NLW47V9LlJ6TDbJ3sqg5eCUav1UpxEoDRygxy4jg6U4iQm9AM1bA== From: alexandre.belloni@bootlin.com To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/12] rtc: pcf85063: use IRQ flags obtained from fwnode Date: Mon, 23 Jan 2023 21:02:11 +0100 Message-Id: <20230123200217.1236011-6-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> References: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755845148612587338?= X-GMAIL-MSGID: =?utf-8?q?1755845148612587338?= From: Alexandre Belloni Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf85063.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c index 754e03984f98..71a456355981 100644 --- a/drivers/rtc/rtc-pcf85063.c +++ b/drivers/rtc/rtc-pcf85063.c @@ -621,9 +621,14 @@ static int pcf85063_probe(struct i2c_client *client) clear_bit(RTC_FEATURE_ALARM, pcf85063->rtc->features); if (config->has_alarms && client->irq > 0) { + unsigned long irqflags = IRQF_TRIGGER_LOW; + + if (dev_fwnode(&client->dev)) + irqflags = 0; + err = devm_request_threaded_irq(&client->dev, client->irq, NULL, pcf85063_rtc_handle_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, + irqflags | IRQF_ONESHOT, "pcf85063", pcf85063); if (err) { dev_warn(&pcf85063->rtc->dev, From patchwork Mon Jan 23 20:02:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 47359 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1793293wrn; Mon, 23 Jan 2023 12:07:06 -0800 (PST) X-Google-Smtp-Source: AMrXdXuQDtJYpNZmaQardbyalIN3Izk9TPq27nMt6A9FhdhcDvXAsM89uq7HmlSD7hKv88xTofx3 X-Received: by 2002:a05:6402:25c4:b0:49e:24a4:4f32 with SMTP id x4-20020a05640225c400b0049e24a44f32mr30282994edb.13.1674504426480; Mon, 23 Jan 2023 12:07:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674504426; cv=none; d=google.com; s=arc-20160816; b=KqMb8HQnkRqpTkhrfo215IQozqkSxWV1V/SMTvswdsioKoRQ/rEOpL0RtpHDiD1lgw VvDk6aMrxPJRqcd4pA+kNlCnGWPHrw4WgrikEH8m+1nO1qRvtyyH3dINdZEufknSwoLB 20f8s/6Re4FijVXa3344ORiGRXfeiJ3VxID37YYYpOoPEkQcLHqLDCK6V5yw6FtkaSSx iTkm9OQC854nFi9bIcW1DV4we+qpGjJRTQmajZzlf3SatxlonRzyLc5so09JgMtj8Jk8 EROyKG4OHOr+c+LE9OgsleZVj2h4TCb4LJ4kGRpMSAgQQtgjxRVewOgCq3wg/6nGRYa0 Enyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cX4WT0iUjsi0ct/mZF8XOG2185oGJ6UhHNdyoYuiuYI=; b=O7/ZQpyXfhsnpgTg/2Ylg2xMvbi10Bqz0k2THu58gdfnniu/g16nTigPCRcJ8RAN/o sSivZb4nV+kNDkzpJPY99z3dFQ8Jf3Wkt4pfNl9hphLtGfrqgM9yeyuntmF7ENkOYtJy SodB+A/r2kzaLtaZlRdcPDCZPrIn9Ya/MbnYLdMIQGXnN3kGMW0N8dcFVMi7SsKvRqnm CnuTBXESm3qVQfbklJmZqafVdlHw2sr6a/KZ811RWvavktD7eTC0ykQSJj7WJ5TdJVGH cBycWcdDl6WBnDuMiFMC6B1v34CVd3cYxe+iJrmjfTSEOGca3Wtrgus3H3+0kfjSQzeC cBLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=L9okzIkI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s20-20020a50ab14000000b0049e0d2dd9f4si363762edc.497.2023.01.23.12.06.42; Mon, 23 Jan 2023 12:07:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=L9okzIkI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233004AbjAWUCn (ORCPT + 99 others); Mon, 23 Jan 2023 15:02:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232934AbjAWUCe (ORCPT ); Mon, 23 Jan 2023 15:02:34 -0500 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6173236691; Mon, 23 Jan 2023 12:02:32 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 39BC620005; Mon, 23 Jan 2023 20:02:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674504149; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cX4WT0iUjsi0ct/mZF8XOG2185oGJ6UhHNdyoYuiuYI=; b=L9okzIkIOjt6FAoqR3EvvcJ9ZVKrXwt8Yy2qY0y8xGgrlULzKDPxZ/bWjcbKDKbRDik9P5 OrAOcZVmMNBIo/Oz3+Tnb47ZgyJWiNjtXBzFsVAhKmiFEHi8DbKHMEj9N2DIf0rdVK9+39 Kj1zwzWXqtIvyl+9nyUHjLJzyp4Jk5fzemo3MYWwrOJu/StMTwb+6YnH6C0+WTHXWsE26I I5E+tudFrTQ5zC4pjNsyuJ4+Xb45FlfN8H7LMNvgxbneePwlZtHHhtoEqGEHvXR1AcjmHx cq7qlL0MsAWaQy0npGO0f+59R4W4JBHMYAF49sTVJ+pLOMjAzThqhbTCFeOAsw== From: alexandre.belloni@bootlin.com To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/12] rtc: pcf8523: use IRQ flags obtained from fwnode Date: Mon, 23 Jan 2023 21:02:12 +0100 Message-Id: <20230123200217.1236011-7-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> References: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755845153384448513?= X-GMAIL-MSGID: =?utf-8?q?1755845153384448513?= From: Alexandre Belloni Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c index 92de99f11a7a..2e111cdb94f7 100644 --- a/drivers/rtc/rtc-pcf8523.c +++ b/drivers/rtc/rtc-pcf8523.c @@ -445,13 +445,18 @@ static int pcf8523_probe(struct i2c_client *client) clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->features); if (client->irq > 0) { + unsigned long irqflags = IRQF_TRIGGER_LOW; + + if (dev_fwnode(&client->dev)) + irqflags = 0; + err = regmap_write(pcf8523->regmap, PCF8523_TMR_CLKOUT_CTRL, 0x38); if (err < 0) return err; err = devm_request_threaded_irq(&client->dev, client->irq, NULL, pcf8523_irq, - IRQF_SHARED | IRQF_ONESHOT | IRQF_TRIGGER_LOW, + IRQF_SHARED | IRQF_ONESHOT | irqflags, dev_name(&rtc->dev), pcf8523); if (err) return err; From patchwork Mon Jan 23 20:02:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 47367 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1794074wrn; Mon, 23 Jan 2023 12:08:53 -0800 (PST) X-Google-Smtp-Source: AMrXdXvAATxUVQ65t1HdPkfONTy+uVMQn3FBzZ9/XS94eGLdv4Km4JDiVJRxA6MAWDfTtO/BpoKP X-Received: by 2002:a17:907:2064:b0:871:5065:613a with SMTP id qp4-20020a170907206400b008715065613amr27283207ejb.47.1674504532895; Mon, 23 Jan 2023 12:08:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674504532; cv=none; d=google.com; s=arc-20160816; b=EM/OaYAhS7Koc9oka6k5BF1a375hU/EV/zZxXXcGD6vk4o+vAvH12kxLktnMN6EpCu cYSpq/dwx6FzA6EBcHMHeV4IFGu/mmW4YG82rFTDEZucUSY5N5x9LLOegLPqSHjd6gTl YJruRA/UdChV/Bi8hodio2mjFc0Oq1gp4UV9yIpkDkVPrdjcPNSBLom8B0qKKf+zApoU dUdfW5uKObKyMMBVSJDYVwDvpCtVCNThhiYeLT0rU6F8xdY8CQp0wOgowfzF1tOnMNmV LrB0nxJDwBVFeffyHEkgmWqlRvIbEAwoa0fikGBIkDo8xjZsRagIJSwJk3ErMXp0liuT lryA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bUMSKoIqoTY1ys3wlmeSnwP9pCI3vVCTlSO8cM9HZHU=; b=P1f5PfhNgDmjWOYdvK+eL8vlBCqcHtqBSHyAeiQs6t5x3mw9i4V2pjBnR/PF39sqlR FSBp3kxKvPtqxouQt61vJeBLkpsx3k/2mCJxg0QNoOLk/p5mQotJ8ihDx6TufnJl6lkp O10/k2hFkxSDEnem0hyb7IErgqHKdVfVrYKQhpIWdYX13kZuTc2q++x/vaVR74LI7gzj JLztQ/8M5z8267m1AP1VMH4bkMwCYNnYaL+xu8RspF0i8nJfllFrvgfeB3g7lF5UnsXc 65de7Jmrh3FYzBZDLwDqv5gkcmSup4ZGIxkyekp5qyO09++tKBoM5XwmkYzIrICm6pEg Vl4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b="jQ1/tQVV"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr15-20020a170907720f00b0087021ff7bf4si5136206ejc.240.2023.01.23.12.08.28; Mon, 23 Jan 2023 12:08:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b="jQ1/tQVV"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233013AbjAWUCq (ORCPT + 99 others); Mon, 23 Jan 2023 15:02:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232937AbjAWUCe (ORCPT ); Mon, 23 Jan 2023 15:02:34 -0500 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [IPv6:2001:4b98:dc4:8::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5222430EBF; Mon, 23 Jan 2023 12:02:31 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 04DFC100007; Mon, 23 Jan 2023 20:02:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674504150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bUMSKoIqoTY1ys3wlmeSnwP9pCI3vVCTlSO8cM9HZHU=; b=jQ1/tQVVLTcCrf/Q0N71HrN+ndkglafDwHTNyQ1ynK1lm3amQGKK8o1dI3Elc/sqpP6VWU 7pmfnCXfMdA+W+zYl6u12ZyZXzLrf1J6jh74RNwudhNcoUaw9bVSiKHHA9Lk5Np6kP6KEb OMKlR3NHKJ+ghDiDzrJne+VdVQ+/lmSBlg9EMbCvkclppJEmkp604/kQsVz1TpSN2RA5Ne Qw0vraFLbyNTVG8HwU6OrEUTBcBeGIzThQXzy7SdhEdFf/FCRk+ZQBy8hfWQWx+bWaABPx v+RiXYQ9+qZV7UrZjwxuFFtkWN3Xu6eR/xvJN/MrjUaM0S+++KNo4jAahdRJzw== From: alexandre.belloni@bootlin.com To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/12] rtc: pcf85363: use IRQ flags obtained fromfwnode Date: Mon, 23 Jan 2023 21:02:13 +0100 Message-Id: <20230123200217.1236011-8-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> References: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755845264675579531?= X-GMAIL-MSGID: =?utf-8?q?1755845264675579531?= From: Alexandre Belloni Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf85363.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf85363.c b/drivers/rtc/rtc-pcf85363.c index c05b722f0060..5de323acd178 100644 --- a/drivers/rtc/rtc-pcf85363.c +++ b/drivers/rtc/rtc-pcf85363.c @@ -400,12 +400,17 @@ static int pcf85363_probe(struct i2c_client *client) clear_bit(RTC_FEATURE_ALARM, pcf85363->rtc->features); if (client->irq > 0) { + unsigned long irqflags = IRQF_TRIGGER_LOW; + + if (dev_fwnode(&client->dev)) + irqflags = 0; + regmap_write(pcf85363->regmap, CTRL_FLAGS, 0); regmap_update_bits(pcf85363->regmap, CTRL_PIN_IO, PIN_IO_INTA_OUT, PIN_IO_INTAPM); ret = devm_request_threaded_irq(&client->dev, client->irq, NULL, pcf85363_rtc_handle_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, + irqflags | IRQF_ONESHOT, "pcf85363", client); if (ret) dev_warn(&client->dev, "unable to request IRQ, alarms disabled\n"); From patchwork Mon Jan 23 20:02:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 47360 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1793345wrn; Mon, 23 Jan 2023 12:07:12 -0800 (PST) X-Google-Smtp-Source: AMrXdXth+pSZoBfXjNHxxnQx1Uh+HFVH1q12nKQ8iQKfW/dZ1usARyasUaNGvItfh5ffKuEJSZSD X-Received: by 2002:a50:ec82:0:b0:491:ae82:b7b4 with SMTP id e2-20020a50ec82000000b00491ae82b7b4mr26602683edr.30.1674504432766; Mon, 23 Jan 2023 12:07:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674504432; cv=none; d=google.com; s=arc-20160816; b=YF+EvrKbX5vtmjsLtEwHTpeoXOhRj5r7B/rfMbMSlhoKdjcUIPe+zYv6wVMp2R2dZh qxcYpyAHHw39GMgo+auufYr4gVB93FpjXj3YaqZhE9ibnKLnYfd3Qo+L5bKhp9p2eZfx 90ILgdMf+OkkcfHHubRrFvpiXDrVuKZwD7Ch867dVJpnSc6qs5pxBKtQHdo42j6w7nfS PgF2yH9+ltwrQirI4VSf/oFLczJ0xEqV/yyQXG/V3xqexrjTTsgkQSoub40MCMgEyu9a JGhQHruozTkv3ug/jIPt0KjOeNZHINJgTx0RZgGq/LF/iUUeMpWfr3QWTiZssqI/aBHR WwlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Fmaqsb9kmO3TmJW/YFmsCtVyenih1v/2TVqIzrS5D/U=; b=K694OkDt94czsU4fsxLyKPtTpUXvxddDAwlqOsuJCkEkvHeE/xvVcV8R6MTZ5FHol+ ba7nzB77NzO/lcmovyBrO91DUVjo4Md74JCXlCNH39Zxv0sPHrOGeU4BlsCiT59XQJLV Rjuy4YHtLeTQFHpO19bZkdKGxjhcjQ3M9l0QB/39H7xv3LqchVn/NRvAgEJY90WIIPxp +OBtklTvTphDhipunNpQdGIePLB4dQ8c+92uCucfV/KoYpdE0B0p9Pfx4kZeaTpQayzS 1OVlHVF5ZwPrkfCI4TmN02ZOI2BcWce1fwR9NqbL/jWB8IB1INQvww6NqEcBGH+wysct 3bew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Kp8ChoOO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m11-20020a50ef0b000000b0049b5322126dsi308431eds.425.2023.01.23.12.06.49; Mon, 23 Jan 2023 12:07:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Kp8ChoOO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233025AbjAWUCt (ORCPT + 99 others); Mon, 23 Jan 2023 15:02:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232944AbjAWUCf (ORCPT ); Mon, 23 Jan 2023 15:02:35 -0500 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E90DD36089; Mon, 23 Jan 2023 12:02:32 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id D10BAFF802; Mon, 23 Jan 2023 20:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674504151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fmaqsb9kmO3TmJW/YFmsCtVyenih1v/2TVqIzrS5D/U=; b=Kp8ChoOOzQ1KdfXtuD2S1zrT433O4l9CqSQQyRtDdfoQhGAzPulstnAfVzPyEXX51OGB6V CDXbQmmgCReBshJHxahbHvyT8u+74XXT4cSA089gFgCjtrlnfqU8e5S9biJ6K8uQtjRVAg 1DnuoSqdg5lKF63yCF/xO9TXKSPT2KxLBOs46FcAYTxh/g1JzX8m85HjzocS2I3Zsxq+yA AN8/R/oAy10ZqnSWGFJhTs7kkDN2vZan22zLnl7dA6g9xgnuFTEM2k9GRAAraQskV8YADr f08uLRxnKctQYbyxLWiS23BzCnHu+lBYnyXbsPyRFoE04OrgHaWZ5pMp9yIvSw== From: alexandre.belloni@bootlin.com To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/12] rtc: pcf8563: use IRQ flags obtained from fwnode Date: Mon, 23 Jan 2023 21:02:14 +0100 Message-Id: <20230123200217.1236011-9-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> References: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755845160041346491?= X-GMAIL-MSGID: =?utf-8?q?1755845160041346491?= From: Alexandre Belloni Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8563.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c index 0a7fd9478465..7e720472213c 100644 --- a/drivers/rtc/rtc-pcf8563.c +++ b/drivers/rtc/rtc-pcf8563.c @@ -558,9 +558,14 @@ static int pcf8563_probe(struct i2c_client *client) pcf8563->rtc->set_start_time = true; if (client->irq > 0) { + unsigned long irqflags = IRQF_TRIGGER_LOW; + + if (dev_fwnode(&client->dev)) + irqflags = 0; + err = devm_request_threaded_irq(&client->dev, client->irq, NULL, pcf8563_irq, - IRQF_SHARED | IRQF_ONESHOT | IRQF_TRIGGER_LOW, + IRQF_SHARED | IRQF_ONESHOT | irqflags, pcf8563_driver.driver.name, client); if (err) { dev_err(&client->dev, "unable to request IRQ %d\n", From patchwork Mon Jan 23 20:02:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 47363 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1793581wrn; Mon, 23 Jan 2023 12:07:43 -0800 (PST) X-Google-Smtp-Source: AMrXdXukyZEXaxvuv5ySt7Sz9BeTXAJIvt+1W3UT96jbN4QSFtkMKOgefsXSXwdQWgaT+JFFM+e2 X-Received: by 2002:a17:907:84ca:b0:82b:61db:92b8 with SMTP id oh10-20020a17090784ca00b0082b61db92b8mr23255319ejc.57.1674504463447; Mon, 23 Jan 2023 12:07:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674504463; cv=none; d=google.com; s=arc-20160816; b=hkbfLeHvi1pgSQ9hcQcMAUT5dKzwZwSPy7hYyh4+tdRSifrJDrZu938ONOVB9dMo1f SNs+UQIp7SPn6A1HUgT+mAbFZaoPlsJ2lISaVHKIxGlJOPvYKV9bzG+OIX5HfUycuojT DfLEdRryD24qui26Ksn2awbJPWD3KDlb5oZW7ExWuaaOOPGr2Q3mJaaqxHT0OQWECA3D q58JiL4enZipevPNn3b6gqP9acfF0e2eI+oF7f//UXsYkjcpyzRzqaO2jq2oud3rkKfP FGGhzYf/Ruv7Kx3tjVWKKtcggHiYE+C6EYGgGPvjAFP3nDOT2eR1vLp9y04Jm34G9OHx gUtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TXtTZs09uSxVKKdsIxv/TOmQrf4x0mBpqBxucCPNmJk=; b=bfo+Ojd+a8RRQg5fhMedYpfGbVKt8JwDiGgafsgdsIb5QNc681Qsclc2TOaK+jLioU m0cf4fMDKAtXKQ1B9FOvIT/VkFmju3K5FwnTS9L3wxFVwOeCouCX1odQiH4pVq1VPJDv Q89bwfihIkob2hNFoTC9iKVZHbnvB/Rp+2x9QfUxMLllPIDzmaYkc7kM5Z/bcPm7nC22 IiqyEpck6qiiCpeOdGH5bFhM416ZnPyT7+Z1YelEj5ZtrRzh+x2pEgxGfAxU409RN3nv QawdP2dJkhkR3hw0Qnn4EuryAohntbggxe7a9grWyCcJrKsQ5i5hVAyumf93It+nWSI7 WpUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=gV+g4gEO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hd33-20020a17090796a100b0087767469a64si19344972ejc.673.2023.01.23.12.07.19; Mon, 23 Jan 2023 12:07:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=gV+g4gEO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231664AbjAWUC5 (ORCPT + 99 others); Mon, 23 Jan 2023 15:02:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232951AbjAWUCf (ORCPT ); Mon, 23 Jan 2023 15:02:35 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3BA831E25; Mon, 23 Jan 2023 12:02:33 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id A32466000B; Mon, 23 Jan 2023 20:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674504151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TXtTZs09uSxVKKdsIxv/TOmQrf4x0mBpqBxucCPNmJk=; b=gV+g4gEOzAaXk8QjVfnAgZ8mMAg+uOJgXpM3ec3BYhHv7G1djqNH29+VxaFwowEFTxR+lH CpTpHdwubehIyALaEalN5SH8QK8nxlPIKuxFhDqKSHlDpT39+iLVsfUnpCk3uRdRMGorYU 0aNly5ODQ+befIvIhR+WdLhFNac90bd2W5iEmOplcLmijNQhIMPJmea8mYoGLtnLUHCC7P jpdaiVqpHCz2eFaG0Fnfc2sRS3seOVgaD6tBy54Of5J1eZwExAJNb6TXWQ1get+MR819lC n/hXkBKvSMX8zhUvEM+Bfxi8JOWhp60bE0OV4kda/hJqS8p/3yvpiSFzOTSRNA== From: alexandre.belloni@bootlin.com To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/12] rtc: rv3029c2: use IRQ flags obtained from fwnode Date: Mon, 23 Jan 2023 21:02:15 +0100 Message-Id: <20230123200217.1236011-10-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> References: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755845192622793706?= X-GMAIL-MSGID: =?utf-8?q?1755845192622793706?= From: Alexandre Belloni Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rv3029c2.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rv3029c2.c b/drivers/rtc/rtc-rv3029c2.c index e4fdd47ae066..0852f6709a85 100644 --- a/drivers/rtc/rtc-rv3029c2.c +++ b/drivers/rtc/rtc-rv3029c2.c @@ -735,9 +735,14 @@ static int rv3029_probe(struct device *dev, struct regmap *regmap, int irq, return PTR_ERR(rv3029->rtc); if (rv3029->irq > 0) { + unsigned long irqflags = IRQF_TRIGGER_LOW; + + if (dev_fwnode(dev)) + irqflags = 0; + rc = devm_request_threaded_irq(dev, rv3029->irq, NULL, rv3029_handle_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, + irqflags | IRQF_ONESHOT, "rv3029", dev); if (rc) { dev_warn(dev, "unable to request IRQ, alarms disabled\n"); From patchwork Mon Jan 23 20:02:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 47361 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1793432wrn; Mon, 23 Jan 2023 12:07:24 -0800 (PST) X-Google-Smtp-Source: AMrXdXuoRNrRHLtXh50wRnpjfi5KQEiHqaWmCQSzLK6wzmyFnV/vpqDUqNX3HiUp0oJCwPh4Mp22 X-Received: by 2002:a17:907:6746:b0:871:2051:637a with SMTP id qm6-20020a170907674600b008712051637amr31298645ejc.60.1674504443949; Mon, 23 Jan 2023 12:07:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674504443; cv=none; d=google.com; s=arc-20160816; b=YbJW0yPooLcZIOe5MnJ1n32nDh9ZDh8tFCe/H0701VMK1zd8EvmF01lX30aSerblbT Mi5vWdGIQFUOQRLTCpkrTbi1gVkdvdW1ooHcRMbjrrjB3xK/OJarR/MXwbaEnd+jdpQk 2wADqm2P56Eu6yqKBOy7nRJp4cxkm2CBHFkK+gMemXCrGt2CR/VdCLV0A0ZyZX6N4nkW 6I08zGcJJBT6X76tXzY8rajs63gzEFGsCuiCXBEUahLkoMlK40nU8bJpvNhogq4tMZTH LlxynIMRfxI9lJ+GX4UFNKY5DsHx5buDbi9n9KVHw+Swzb7LlTvYHoHEjcrmCT9YVS33 ZrGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zoJz4NTugfiOLZnwnnd2c9EVeNFPlrapvV4p8gpqtPE=; b=PO878+wzgEZroK3HhGGs0J8WTNA8t/TwmpFWup/dn/p5QAs5NiCfxTdEaW1GM8vQ1I AP/DNGqyoYLiqQ6XYzT1dCsCau4336xpC6cCCv4ypwjEBDlIst+7CBvr1fFx/Mwq61kP wsHSF73gRi8rDxPrDGPpp3JcAyL73vlg8Rh0ARvvJUA+9B2eMtuKMFidjeD7GARF1mOz Q8tqgnVy5ltH4e9Yeym2R1AwLwDM0yBsHXbsIsU7qOWIZUmG7EfhBEIDjZU2aMOASdA8 ptUn8sa1b/QLxvH7ZxMrPTc5PSgOBdMr/Ge7fxIiAZOY2BqjU9CrekTKUe5sUwDQfNGV mapA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Npzqv5No; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e9-20020a17090658c900b008704b0a4d64si18665946ejs.117.2023.01.23.12.07.00; Mon, 23 Jan 2023 12:07:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Npzqv5No; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232963AbjAWUC7 (ORCPT + 99 others); Mon, 23 Jan 2023 15:02:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232954AbjAWUCf (ORCPT ); Mon, 23 Jan 2023 15:02:35 -0500 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19B23366A5; Mon, 23 Jan 2023 12:02:33 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 65E4440014; Mon, 23 Jan 2023 20:02:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674504152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zoJz4NTugfiOLZnwnnd2c9EVeNFPlrapvV4p8gpqtPE=; b=Npzqv5NozjwgAjAgr7Z6+OjREe/p5GQKuBhIfnfTmmKIpsMIN1XZqkCDHvcsfskqUnpD87 zhFVIRbd77OvgN1dOwLDATWRqwpdF0Bm9uH2nTVncTS+717QBjPY7b2jW3HeBmjv/ytrFC jW3feMC42YYP8Tu0TnHlQBWUqEyTzV8u6enl2FdeCDoGSENTHE3u9OOzL+ithKrsFbEMLJ yu+xM456bTptvcBlT7W3JYdYG3X02EH0eVEwc5slPYnLhSWUSRy2w9FADBNhsev0ZzZkzE Hafxe982zyQQ1mGQnfe15tbhE7y9F6ybJNQDc5/C9Xu571IcxUlOwvZwmPTz5w== From: alexandre.belloni@bootlin.com To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/12] rtc: rv3032: use IRQ flags obtained from fwnode Date: Mon, 23 Jan 2023 21:02:16 +0100 Message-Id: <20230123200217.1236011-11-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> References: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755845172067802291?= X-GMAIL-MSGID: =?utf-8?q?1755845172067802291?= From: Alexandre Belloni Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rv3032.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rv3032.c b/drivers/rtc/rtc-rv3032.c index c3bee305eacc..bf6954ec5943 100644 --- a/drivers/rtc/rtc-rv3032.c +++ b/drivers/rtc/rtc-rv3032.c @@ -930,9 +930,14 @@ static int rv3032_probe(struct i2c_client *client) return PTR_ERR(rv3032->rtc); if (client->irq > 0) { + unsigned long irqflags = IRQF_TRIGGER_LOW; + + if (dev_fwnode(&client->dev)) + irqflags = 0; + ret = devm_request_threaded_irq(&client->dev, client->irq, NULL, rv3032_handle_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, + irqflags | IRQF_ONESHOT, "rv3032", rv3032); if (ret) { dev_warn(&client->dev, "unable to request IRQ, alarms disabled\n"); From patchwork Mon Jan 23 20:02:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 47362 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1793438wrn; Mon, 23 Jan 2023 12:07:25 -0800 (PST) X-Google-Smtp-Source: AMrXdXtaopmmPloW1+bAO3x9hFCTSeG3EwaiPAMO3v0L7ufu9eTQrvNKFyZUHxSKRzoS+TMZzbXy X-Received: by 2002:a05:6402:454:b0:492:8c77:7dad with SMTP id p20-20020a056402045400b004928c777dadmr25207228edw.8.1674504445218; Mon, 23 Jan 2023 12:07:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674504445; cv=none; d=google.com; s=arc-20160816; b=eJLhFwRsDCqo89gW0681d8DNujBJLfPscxMQVEZeU3U/jQNffvEkDWph0yqYx49nIy +uBV6zXdtb//aqUik5zLfMHDDrBm1v7mzrDkIPAZMMnLgACdhF6a7xvUX0nftZyILGhJ 14fkkjH7Dd0L7881S7BTZ3GnSWOUKb7zunCGPJVt2tY+Itb9Q/9nKpPXCM6sg00/iCCO cMYo9Po5UtGWClQsse71a++4ufl+xP8/c5lQudaatPCfQx/Gg0U1SZElamDVgr6cCuh8 MyLQ4T2wxG9iFvX3Zkkzl/xOytoFHfEILi0uSgLIA/8AJQhFLkLVCm2AYymfRE+W731k rTVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/DvFjwH0rtf/vONiwh3u+FyqUYVxFWWjs2YdFUIg4mw=; b=HPs6kCUGS13GIxFeS7yNCtV5i+WxiD6G//DnED4i8vEYxc7nAEoEVyHiGXEswaI/Ty 7xrrJCETLiF+XyrsHpNobRCNYgdZW9gKAck9d3KSsjaupi9v7Bi4m0WKQ+ALbTkwOBt+ mOcoSrvO+bKgEN+3y1GlZPiAth1yS9kPCelkqi6XsjOaMTvKDJqiApuyuBMOBHB5Pjxx dVIdBaY42fs0MB7Y6Nwoov9jF+kPbhboleC0k+Odibq/2R6MDptWm8cNmtGm1M7CQ6Q/ rR27Hk0ugrfCPf5Qmhd8ZpX0BWIhdDiMdshcyHA/U48ZT9A0ZzAyRT/CUBW1dKXwaIia 32ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=KTaEwkLt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d10-20020a056402078a00b004854e1d2682si297330edy.249.2023.01.23.12.07.01; Mon, 23 Jan 2023 12:07:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=KTaEwkLt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233085AbjAWUDB (ORCPT + 99 others); Mon, 23 Jan 2023 15:03:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233039AbjAWUC4 (ORCPT ); Mon, 23 Jan 2023 15:02:56 -0500 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5DD0367C0; Mon, 23 Jan 2023 12:02:34 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 220932000A; Mon, 23 Jan 2023 20:02:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674504153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/DvFjwH0rtf/vONiwh3u+FyqUYVxFWWjs2YdFUIg4mw=; b=KTaEwkLts11ezfeabW/K8PoDih+yQw/eDcSXN9lgezdqpFKAv3wCsWFeVou4A7nNBzUo1+ H6VbaIVybhBo5XiAObdisldpMIye1FLhYmruiDxIPsBDRXmGtmTXOmkJSUWSh/bqydGpLc 0/YXxWhszlnd7wbNfV+b3KQ1+RXm17hVS3mafCa18ko0BcgOOyba95ZgencKkYDh0T6dvM ipeKhcCcpNKQlp46+4ezokKwSwQ9NnUs++dr0liT9jp0NatX9Pp8tz0d/JhI5q09L+rdJ+ Z2ltA4KbMfsm0ALKkAxelfVY7GGlleC5w5JaldIXh18m5Fi62DcHGbldaiPQog== From: alexandre.belloni@bootlin.com To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/12] rtc: rv8803: use IRQ flags obtained from fwnode Date: Mon, 23 Jan 2023 21:02:17 +0100 Message-Id: <20230123200217.1236011-12-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> References: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755845173157991302?= X-GMAIL-MSGID: =?utf-8?q?1755845173157991302?= From: Alexandre Belloni Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rv8803.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c index b581b6d5ad73..53d1de01b719 100644 --- a/drivers/rtc/rtc-rv8803.c +++ b/drivers/rtc/rtc-rv8803.c @@ -641,9 +641,14 @@ static int rv8803_probe(struct i2c_client *client) return PTR_ERR(rv8803->rtc); if (client->irq > 0) { + unsigned long irqflags = IRQF_TRIGGER_LOW; + + if (dev_fwnode(&client->dev)) + irqflags = 0; + err = devm_request_threaded_irq(&client->dev, client->irq, NULL, rv8803_handle_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, + irqflags | IRQF_ONESHOT, "rv8803", client); if (err) { dev_warn(&client->dev, "unable to request IRQ, alarms disabled\n");