From patchwork Mon Jan 23 18:45:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Karcher X-Patchwork-Id: 47330 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1765436wrn; Mon, 23 Jan 2023 10:55:06 -0800 (PST) X-Google-Smtp-Source: AMrXdXvMgHW46bDxzdLfS0FFK+HepMFDRUHj7t5f2R6wgqvPQkPx/dFlktsz7hW75jN2Z4aSNxVF X-Received: by 2002:a05:6402:3986:b0:49d:5c6:3e5f with SMTP id fk6-20020a056402398600b0049d05c63e5fmr31643693edb.41.1674500106154; Mon, 23 Jan 2023 10:55:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674500106; cv=none; d=google.com; s=arc-20160816; b=bxBf8B7b97TGuIQW3T9qu6dv69EZkOUkVhPSRNay/9G6cRQa9r2kNRE1TK9KbGTrUP oUnDSI6Ak6oK1K+zSTFUYmwyLWxijX4iam4Yu2BwLIflDIHnThYKXDboBLLdHyr4fQkG ZYnKfBZmaZcCGzp86N7kAoKfvIuCykrmLROMz/KhJ00LCx2WTLU5nhouneb4+Z666P8f r7bjHfzzZVXlJyjfVUGrHBO7FOwy8yV5Y7FM7mU0bvEnGIZG6kfQKvgv/G10/L6Qqhn9 IhQnEzV3WNrL0SshUZW0Pejhp79b1QDpcjIdsHeIJj8DL7XFGnGBD/pPMHoUy4Cvi1/M tZpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:to:subject:from :user-agent:mime-version:date:message-id; bh=tCJN85AQXiQHwX2XdnU2VWHyxTsSyXQ3++kBu3uDCf8=; b=GxaHl2EkjgtEmHQkq7sXTtYbSUItan0kTCQ7jztlERvF5UOwSXoIDCtiss+tPWS2t0 OrSgC6Mfd4KiAfhSxmwT7Y9M7G+DPDPcPcoMsmoNQaGe9JNlCCgnpWDNYA5JELWHtnGh QGfEJ/K4XNgcZsM+nPGO/jvSt1WqTDIZjwAQmJM+QSkdXJlXIxtVNunXTL8AeWogIUoR q2McGOHyVp+QaIRg2Yv218RMzoMB4bGTUVWHj6sijvP4y5wkETDx8P2vSlL21sSZap5C 7sINsOKZHO4LQRRtaV4UXXjmV8CkWjuOzGdCQDIg1cYmKh9ed76Yuj5DcODyfvL9D1YP t9Lw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z3-20020aa7cf83000000b00485731f9eb0si138459edx.345.2023.01.23.10.54.41; Mon, 23 Jan 2023 10:55:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231682AbjAWSpY (ORCPT + 99 others); Mon, 23 Jan 2023 13:45:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbjAWSpX (ORCPT ); Mon, 23 Jan 2023 13:45:23 -0500 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D0CF2139; Mon, 23 Jan 2023 10:45:22 -0800 (PST) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1pK1om-003lk6-AJ; Mon, 23 Jan 2023 19:45:20 +0100 Received: from pd9f631ca.dip0.t-ipconnect.de ([217.246.49.202] helo=[192.168.144.87]) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (envelope-from ) id 1pK1om-0001f8-4B; Mon, 23 Jan 2023 19:45:20 +0100 Message-ID: <68e5d3d1-7d7d-232c-c6dc-3f65bfb55114@mkarcher.dialup.fu-berlin.de> Date: Mon, 23 Jan 2023 19:45:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 From: Michael Karcher Subject: [PATCH v3 1/1] arch/sh: avoid spurious sizeof-pointer-div warning To: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, Segher Boessenkool , Rich Felker , Yoshinori Sato , John Paul Adrian Glaubitz X-Original-Sender: kernel@mkarcher.dialup.fu-berlin.de X-Originating-IP: 217.246.49.202 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755840623230002463?= X-GMAIL-MSGID: =?utf-8?q?1755840623230002463?= Gcc warns about the pattern sizeof(void*)/sizeof(void), as it looks like the abuse of a pattern to calculate the array size. This pattern appears in the unevaluated part of the ternary operator in _INTC_ARRAY if the parameter is NULL. The replacement uses an alternate approach to return 0 in case of NULL which does not generate the pattern sizeof(void*)/sizeof(void), but still emits the warning if _INTC_ARRAY is called with a nonarray parameter. This patch is required for successful compilation with -Werror enabled. The idea to use _Generic for type distinction is taken from Comment #7 in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108483 by Jakub Jelinek Signed-off-by: Michael Karcher --- History: v4: - Put the case distinction into the numerator instead of the denominator - Refactor the case disctinction into a second macro v3: - I had a stern discussion with Thunderbird about not mangling the space characters in my email, and I hope spaces get sent as standard spaces now v2: - improve title and remove mostly redundant first sentence of the description - adjust formatting of the _Generic construction diff --git a/include/linux/sh_intc.h b/include/linux/sh_intc.h index c255273b0281..98d1da0d8e36 100644 --- a/include/linux/sh_intc.h +++ b/include/linux/sh_intc.h @@ -97,7 +97,9 @@ struct intc_hw_desc { unsigned int nr_subgroups; }; -#define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) +#define _INTC_SIZEOF_OR_ZERO(a) (_Generic(a, \ + typeof(NULL): 0, \ + default: sizeof(a))) +#define _INTC_ARRAY(a) a, _INTC_SIZEOF_OR_ZERO(a)/sizeof(*a) #define INTC_HW_DESC(vectors, groups, mask_regs, \ prio_regs, sense_regs, ack_regs) \