From patchwork Mon Jan 23 16:22:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 47232 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1701930wrn; Mon, 23 Jan 2023 08:35:13 -0800 (PST) X-Google-Smtp-Source: AMrXdXuhsxXbFShCNtkXWKf3npoF1XDj0f28GekZHaKfX6AT31YOtbX2SFAEFAJc9BRHkqj9RCxz X-Received: by 2002:a17:902:c24d:b0:195:ecac:985f with SMTP id 13-20020a170902c24d00b00195ecac985fmr11530712plg.41.1674491713119; Mon, 23 Jan 2023 08:35:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674491713; cv=none; d=google.com; s=arc-20160816; b=AuR/snNdi+y/3JF/LsyAyUJydc3onEQc+o3DgO95/7PvQWbJ8EqmceWqaN30sbu8je oPtuJyuIH1DNmh7hzi+4PYBEkbFMWKQFjZU/Id8g7vIe3++MG7A34Cv+52GtxZ1TwOpa 2lkd23prFCMlKlzXDOyAG6YlwuskIp9RUEh/K/0G3ahM/oJBnjyCXIbioG49uAr7jO3u 4WLqPNOjDe5iLLrVIkRrfE9w3zglK579/X/i4WWD/bE6A7iiISY7kyJhAM0z61Aebvzj 6NV55icYn2ep7C96NFkuzOY12bdst/BRZYVlpL52YqJX9v3JE3kR60tlsFQnG9j77MPO SJWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:subject:cc:to:from:date; bh=EqxlCWfUBiTJCVXL62qBEexSWAsoq0PD+uBAOrnzQkU=; b=qE0ZRL8bP0DixqdlJjhtNBSH9NPREnQ+sGUUo4s0dmWvD3Ox2kCw5NI+ZToZesWmzk MU2UxVwArGJvfqezx7t3hTFYGoG3H4GrBxvamIpeaaD0bVFnnT1+pAJ7HuncCR1stsFK ut52cRMlOOmoyDeXZXvcB0AHmANn+73eI4vjPvDG5U53LQ/jMA0Itk97aNg9tdiiR/IC hcXL2lJAt6X7IkPvNLU9/++M+xXRFQnWmySniNC1QTOHBI0gj96ErVo/5UhP5i9ZFU6W LKRkqQ9nAAQC6cebD1VSYTBIwWpHZOpr0EllXLFBYtXWnf+W4FRfq5GgxZsdxgKWZ48d BIrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j9-20020a170903024900b0017a034f7246si4122967plh.560.2023.01.23.08.34.59; Mon, 23 Jan 2023 08:35:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231610AbjAWQXF (ORCPT + 99 others); Mon, 23 Jan 2023 11:23:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230128AbjAWQXE (ORCPT ); Mon, 23 Jan 2023 11:23:04 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C97C226BD; Mon, 23 Jan 2023 08:23:01 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 213EECE1398; Mon, 23 Jan 2023 16:22:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9249AC433D2; Mon, 23 Jan 2023 16:22:55 +0000 (UTC) Date: Mon, 23 Jan 2023 11:22:52 -0500 From: Steven Rostedt To: LKML , Linux Trace Kernel Cc: Masami Hiramatsu , Mark Rutland Subject: [PATCH] ftrace/scripts: Update the instructions for ftrace-bisect.sh Message-ID: <20230123112252.022003dd@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755831822867952578?= X-GMAIL-MSGID: =?utf-8?q?1755831822867952578?= From: "Steven Rostedt (Google)" The instructions for the ftrace-bisect.sh script, which is used to find what function is being traced that is causing a kernel crash, and possibly a triple fault reboot, uses the old method. In 5.1, a new feature was added that let the user write in the index into available_filter_functions that maps to the function a user wants to set in set_ftrace_filter (or set_ftrace_notrace). This takes O(1) to set, as suppose to writing a function name, which takes O(n) (where n is the number of functions in available_filter_functions). The ftrace-bisect.sh requires setting half of the functions in available_filter_functions, which is O(n^2) using the name method to enable and can take several minutes to complete. The number method is O(n) which takes less than a second to complete. Using the number method for any kernel 5.1 and after is the proper way to do the bisect. Update the usage to reflect the new change, as well as using the /sys/kernel/tracing path instead of the obsolete debugfs path. Cc: stable@vger.kernel.org Fixes: f79b3f338564e ("ftrace: Allow enabling of filters via index of available_filter_functions") Signed-off-by: Steven Rostedt (Google) Acked-by: Mark Rutland --- scripts/tracing/ftrace-bisect.sh | 33 ++++++++++++++++++++++++-------- 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/scripts/tracing/ftrace-bisect.sh b/scripts/tracing/ftrace-bisect.sh index 926701162bc8..94ca73930f8a 100755 --- a/scripts/tracing/ftrace-bisect.sh +++ b/scripts/tracing/ftrace-bisect.sh @@ -12,7 +12,7 @@ # (note, if this is a problem with function_graph tracing, then simply # replace "function" with "function_graph" in the following steps). # -# # cd /sys/kernel/debug/tracing +# # cd /sys/kernel/tracing # # echo schedule > set_ftrace_filter # # echo function > current_tracer # @@ -20,22 +20,39 @@ # # # echo nop > current_tracer # -# # cat available_filter_functions > ~/full-file +# Starting with v5.1 this can be done with numbers, making it much faster: +# +# The old (slow) way, for kernels before v5.1. +# +# [old-way] # cat available_filter_functions > ~/full-file +# +# [old-way] *** Note *** this will take several minutes. Setting multiple +# [old-way] functions is an O(n^2) operation, and we are dealing with thousands +# [old-way] of functions. So go have coffee, talk with your coworkers, read +# [old-way] facebook. And eventually, this operation will end. +# +# The new way (using numbers) is an O(n) operation, and usually takes less than a second. +# +# seq `wc -l available_filter_functions | cut -d' ' -f1` > ~/full-file +# +# This will create a sequence of numbers that match the functions in +# available_filter_functions, and when echoing in a number into the +# set_ftrace_filter file, it will enable the corresponding function in +# O(1) time. Making enabling all functions O(n) where n is the number of +# functions to enable. +# +# For either the new or old way, the rest of the operations remain the same. +# # # ftrace-bisect ~/full-file ~/test-file ~/non-test-file # # cat ~/test-file > set_ftrace_filter # -# *** Note *** this will take several minutes. Setting multiple functions is -# an O(n^2) operation, and we are dealing with thousands of functions. So go -# have coffee, talk with your coworkers, read facebook. And eventually, this -# operation will end. -# # # echo function > current_tracer # # If it crashes, we know that ~/test-file has a bad function. # # Reboot back to test kernel. # -# # cd /sys/kernel/debug/tracing +# # cd /sys/kernel/tracing # # mv ~/test-file ~/full-file # # If it didn't crash.