From patchwork Mon Jan 23 09:01:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 47072 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1503586wrn; Mon, 23 Jan 2023 01:06:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXu0xY/78r4n0THQRmFq75rfX1nui1f9U/rcpn+ABkqgso66/vNaUYHTyYuNDineUbrKAeF7 X-Received: by 2002:a62:ab19:0:b0:58d:abd5:5048 with SMTP id p25-20020a62ab19000000b0058dabd55048mr24741530pff.3.1674464800322; Mon, 23 Jan 2023 01:06:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674464800; cv=none; d=google.com; s=arc-20160816; b=OldtlSdjvHOuaKicmPm4e3d9ZKaFL1v026eFBOGkap+FlsuBudHdp435zB8UN2+RYh WbP6iqyp1rwirA5tJwV3rymne/U9ZnSXp/LHIyjTQAv5LVvKN7QtDMRW3bA0hmTHzwf2 8CaJxtr5g+3MC5QyjUDZd6ZZUbAgYuasBFtLKy/uWUdfNd4HFkfMPljFw2yK3UmIg2a1 C8o5yQED1Y/tuMSEk//2AVgXlw2pfI+cOiYuwIK1sevrL65hNIRgUo3+heHwHrJpr3oa vGxEZgteWKMVJNP7x/lKN6Bw1dgyLI1bdYRt8Ag+lWoS2d+x4mPcYIMbJLJno701oCKj uj0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=EnbR18XVTVgA/kG2E8Uv4DzkNNYetgwaJLUmuarDdSk=; b=ct39azeAu7O77UwDcnaRV8qEo/UNy3zIKZygDznypMZ5Mgmnj02prIXASQL3zi5g8g iy1krY9EHj2HF2Is3lsRiz3cnhoIGXfybe7/MBev8+q/n3/4JYofVC8/HNEJ9l8Vud9J +YdeG5gO8aaZCTuqIph2v10vprnU54eWCqyhTJFLuxvRinn1NJ26Puo8mNXidYJDsJTi mktsQWKAVhOmVzYSh2qD+YUMjza59nxIQTW87QOpWcjSZjwktWY9WCs4qqAHhPgyiEVk 14OgRjVaU+sH0Lt71TucTAXnOaCleFQiYsplu8Ao639MasnwnonDLTM49aLAqvAMeju6 Fpvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JzK8IhpB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y71-20020a62644a000000b0058a71b56a06si38151364pfb.130.2023.01.23.01.06.25; Mon, 23 Jan 2023 01:06:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JzK8IhpB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231633AbjAWJBi (ORCPT + 99 others); Mon, 23 Jan 2023 04:01:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231499AbjAWJBg (ORCPT ); Mon, 23 Jan 2023 04:01:36 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56DD51C32C for ; Mon, 23 Jan 2023 01:01:35 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id f19-20020a1c6a13000000b003db0ef4dedcso10045877wmc.4 for ; Mon, 23 Jan 2023 01:01:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=EnbR18XVTVgA/kG2E8Uv4DzkNNYetgwaJLUmuarDdSk=; b=JzK8IhpBF46oOeAJ76jz6D0Y6GOOrokHvTEDGusuNe3Me7BOEfEx95JrDZGmUc8yDg StBnXbbXFuwDTZsCKINAjG2zces9HDT92dI7smnCOexe7cALbOH8I4A10R+BQcFKW/9U PmrkYNZHXZKZq83Ul2puFJ2PXNiUM/1PFjsyO9bA6dzu8OpLazow+sdEas+m/V3R7Uq4 8i5H+HP6Jo+bOHL7Ut7RBOm53akrdpAAPxLxWXnAXzkYHdfIfORZ5E9drFbX6uv+C4W8 BC7S4Ou+88ayBwicUuyemqRWjFHXIWWP7d/fxEiaqlsc6IhAypkZkF8SD4oQRydkRDj1 sIVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EnbR18XVTVgA/kG2E8Uv4DzkNNYetgwaJLUmuarDdSk=; b=vtiWvN/B9bpHsDpOtzK4wySAyfYux3DNwXMVQK93geLSXiPf26F0JTlt+0iYbP1GAp 6HNp5Pnb9IFeuUQVL3QZDUHNAI+JUa+lFPsbfUrsCPSG6RQH7g2a7D1w2G5teviGR22v HO1t9ur5RS/o50LCsSsX7wu8y0+WQvhVNux/HMNgw1T6+E7QU0xUp8yAxXh2tBqbB08R MGwAaCSX4fHgmRKt3HNyZMi6f6sSLn29X7WFKBsHh1gdquqHbtkm0/A1/Qi90P3909aG 0aGG0XLaeVh6N5SxxgkdS7Eztx2YV8BgC8cPkH/QoCTOI4hd6H+mybO1Ze62grFjekUt i2MA== X-Gm-Message-State: AFqh2krYzj8/wKiTILn1ywEdh98HIoZzeh/WYwCVHbMytpBBia+jKvif Wyk0k+BBw/eCC4HtayD0vnX+Iw== X-Received: by 2002:a05:600c:4fd3:b0:3cf:7197:e68a with SMTP id o19-20020a05600c4fd300b003cf7197e68amr19869124wmq.18.1674464493842; Mon, 23 Jan 2023 01:01:33 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id t15-20020a05600c198f00b003db32ccf4bfsm10106087wmq.41.2023.01.23.01.01.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 01:01:33 -0800 (PST) From: Neil Armstrong Date: Mon, 23 Jan 2023 10:01:25 +0100 Subject: [PATCH] usb: dwc3: qcom: enable vbus override when in OTG dr-mode MIME-Version: 1.0 Message-Id: <20230123-topic-sm8550-upstream-dwc3-qcom-otg-v1-1-e287a418aa5f@linaro.org> X-B4-Tracking: v=1; b=H4sIAOVMzmMC/x2NSwrCMBQAr1Ky9kE+BqNXERf5PNtA8zEvVaH07 gaXM4uZnRG2iMRu084aviPFkgeI08T8YvOMEMNgJrlUXEgFvdTogZLRmsNWqTe0CcLHK3j5kqD0 GYy4XDVacTbBsVFylhBcs9kvo5W3dR2yNnzG7399fxzHD1TTZ32KAAAA To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Thinh Nguyen , Greg Kroah-Hartman Cc: Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong X-Mailer: b4 0.11.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755803602512675102?= X-GMAIL-MSGID: =?utf-8?q?1755803602512675102?= With vbus override enabled when in OTG dr_mode, Host<->Peripheral switch now works on SM8550, otherwise the DWC3 seems to be stuck in Host mode only. Signed-off-by: Neil Armstrong Reviewed-by: Bryan O'Donoghue --- drivers/usb/dwc3/dwc3-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2 change-id: 20230123-topic-sm8550-upstream-dwc3-qcom-otg-81795ea148db Best regards, diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index b0a0351d2d8b..959fc925ca7c 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -901,7 +901,7 @@ static int dwc3_qcom_probe(struct platform_device *pdev) qcom->mode = usb_get_dr_mode(&qcom->dwc3->dev); /* enable vbus override for device mode */ - if (qcom->mode == USB_DR_MODE_PERIPHERAL) + if (qcom->mode != USB_DR_MODE_HOST) dwc3_qcom_vbus_override_enable(qcom, true); /* register extcon to override sw_vbus on Vbus change later */