From patchwork Thu Jan 19 23:17:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 46054 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp595266wrn; Thu, 19 Jan 2023 15:21:10 -0800 (PST) X-Google-Smtp-Source: AMrXdXtQ9m3bRjTf8G5AQidbDq7oIMr1WrNSh58PJksYMqxYSAo4eZfJRErGZgFiiseSXIQ0p3Vh X-Received: by 2002:a17:906:3cf:b0:78d:f455:3118 with SMTP id c15-20020a17090603cf00b0078df4553118mr12822829eja.64.1674170470619; Thu, 19 Jan 2023 15:21:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674170470; cv=none; d=google.com; s=arc-20160816; b=KXTgHE8nLIduZGg2j8DK+7Wkxro/rOcKda7v3aheKl7cNCXLnBbKEQms531AiTswis S+rpiDv47x2P/TREjf/orjwERGKVLxRhwL5KpZ3D1A7mbkbSAhd5M1602LO9hLw6n5Yj ohDf0sgS3T/3Jle8qmhRzJI8B0/BlreRqg5bBaLR89qHE4usNQYxNiRKxIgsWiYbdzjm TH/RxdrQXZ96wgT13MOjTmB7bZsH0720rTc1MarlVnbf6RtPsHO4xgv+g73tUw9tGl7H rPhQbMKbiz4bGGMRlGuFqQBjXnnZpEPobSYZAUsh8h6AWacmDi7Nsa9qsnU3Jw43zMxA 1U2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LoPT1qZTZAiwXdlOT9grX8TQ8vUdaTmpWhI7QC60cXs=; b=ggzEy7Dgd0Re0TBKMuolRaL5t693tHp/7Zby4ze47CwXc3HesQYw+L9JnVEB1/Ir/w 7Q5rQBVOZQH6nKX+oHJJAgPbgUWFKOFXvFyyaL27AKYpFmFzFbdLa6dHToHXSEz/Jpgs ZXqsvDSnWXoyj3zvdkdRL1OiGfEbRJk2hdwOkffvh/cdoCG46rrrblO+G/fjP5qeBVt5 wN4bQNRrArY6C1acrZSWy+hR0NPm6ySDDRluBz4gxnoKwc27Bz2qWG0PQ29htbGGjJpY xQ6NS5ti2SuiMUp1lFJArvkt9ZcIrplBN0carXn2E1hc0rAziX/DB7ROVuQLs1I6PV8p haBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=awbv6pu4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf26-20020a1709077f1a00b0087769779bedsi4594665ejc.229.2023.01.19.15.20.43; Thu, 19 Jan 2023 15:21:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=awbv6pu4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229689AbjASXTl (ORCPT + 99 others); Thu, 19 Jan 2023 18:19:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230310AbjASXTX (ORCPT ); Thu, 19 Jan 2023 18:19:23 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E182A366AE for ; Thu, 19 Jan 2023 15:17:30 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id z1-20020a17090a66c100b00226f05b9595so3326743pjl.0 for ; Thu, 19 Jan 2023 15:17:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LoPT1qZTZAiwXdlOT9grX8TQ8vUdaTmpWhI7QC60cXs=; b=awbv6pu4ENIEU6blOT7ognTpQESQ7PK3rksK/Li2rhuFEXMIgQPIVEQJgFOhFvQZMM z1qM4WyqdoS2qycGh4iuFu9CzCkCDEfCbVYcbnocOQ7X1mUJgZVJhmNsgz3AlsXZgPUB RX97qZm5KkyND7oXpFMe0e2zN0iJX9R+1xiaDmDggFxLobRLz1OMtHlXQkYCe1wVVC5R KpQzyTJyUjkfG++QAB7DBxJVT/mrBUa9OaNpwR4qPXrRx41TB4YSI7k8VM5lQxsLN+O5 M99Y6PF0ogupxXhew39KKeCyvLrEVzlAYA2tabdXeE7cqz/2SrRlENPKajqHTlez5Hwt udUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LoPT1qZTZAiwXdlOT9grX8TQ8vUdaTmpWhI7QC60cXs=; b=RnA940hKgBwG3eBu1NELIJxBfdutcY5rXeU6F3djJg2zQ9OEX+6OqM+gWPSxlJDF1m AKD3CykKMcSHEahcld6Iv6lCtun+VZQAnCrSnb07zxbPMvqXtc10RnJX3lHvNUOS9UZm bJXMbBrHvfVWQubmaODFin1ImDu5OTHhx7jI61YU4AOCeW3GSxZOvj+X8qPZSugJQmA5 3IreIkPJhCgV7XGa7ek+0CKm4eVYQKPiqVWP9lALvO1mm80OIZeSPikbPlPgsKl3Tcd/ zDAYZIsHyOaSR6hHRDKaLoqP5rKqW6CmjHPOSj9czOvbF6kJZaYH9PI61ToYCCnaBkPV jZpQ== X-Gm-Message-State: AFqh2kpMX5YiKVWZ5YAf6QfkkS606ov8s7Eu6vxFrbHTypLiO/4we19a gbCaXjXfXpI4GBj0KrVnvJw= X-Received: by 2002:a17:903:200b:b0:194:ab2a:b74a with SMTP id s11-20020a170903200b00b00194ab2ab74amr11069280pla.38.1674170250390; Thu, 19 Jan 2023 15:17:30 -0800 (PST) Received: from localhost ([2a00:79e1:abd:4a00:2703:3c72:eb1a:cffd]) by smtp.gmail.com with ESMTPSA id l15-20020a170903120f00b00188fce6e8absm22498801plh.280.2023.01.19.15.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 15:17:29 -0800 (PST) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: Rob Clark , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , David Airlie , Daniel Vetter , Daniel Kurtz , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] drm/rockchip: Drop unbalanced obj unref Date: Thu, 19 Jan 2023 15:17:34 -0800 Message-Id: <20230119231734.2884543-1-robdclark@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755494975362146047?= X-GMAIL-MSGID: =?utf-8?q?1755494975362146047?= From: Rob Clark In the error path, rockchip_drm_gem_object_mmap() is dropping an obj reference that it doesn't own. Fixes: 41315b793e13 ("drm/rockchip: use drm_gem_mmap helpers") Signed-off-by: Rob Clark --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index 6edb7c52cb3d..19b46c00dcbf 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c @@ -262,9 +262,6 @@ static int rockchip_drm_gem_object_mmap(struct drm_gem_object *obj, else ret = rockchip_drm_gem_object_mmap_dma(obj, vma); - if (ret) - drm_gem_vm_close(vma); - return ret; }