From patchwork Thu Jan 19 21:13:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 45966 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp551895wrn; Thu, 19 Jan 2023 13:24:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXu1i5/vnWVtrL1YyA4JI13U4Zt1zADFSzMF/vpDb0NXrmu3GS+GN1HCc3tBnvgkHhEoNFUJ X-Received: by 2002:a17:90b:3c4b:b0:229:ec2c:1263 with SMTP id pm11-20020a17090b3c4b00b00229ec2c1263mr3428502pjb.42.1674163463232; Thu, 19 Jan 2023 13:24:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674163463; cv=none; d=google.com; s=arc-20160816; b=ZkIQ7SA1SZiDOCnAo8eY0kCX5NsrGmT4LVtw+5V6BtOOD2JgAwECEDsLhZ9D0nkTCv UsO55274LrkwUUW5pYlUGzm2lS/8B6GCGs7F9PQyrgj+xWaUJCsAafPEyp9b02Ec3a2z nHBAxUFAsSyKsI7CcYfnNJSP5n2/XOlZQRrPatPMxcx8ecDStkoGl/Az5HNQfxBKcW/S U+/KV7lezXwCCPMIN/5PQ9yV5t+NfBIF/r2oDpk06Gm6VlHf7Z7wGMy4tpj81Uyedu17 URd5OjM0l62QQNfLpiuSodYNRxrDPrvKTN7cLtF0TvDpvSyNXEFalbCfiTXEYswRYjip XFMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=fXQAX4zgQIEcR46hfecs8ivLI9Fp7qzLdoZtzRMFxAM=; b=HuDU6AgMXAsD4aV+9vmWP7Avbdg7Ng833x3i0Snig6EEQFK8wPih9q6yTUDKdD5iDm Iwxbk0YEdVdVzI8uru17m9pABC4x1hslalY7A+H9bwGyFLg4+hwHfTIONRt8KAHRXZh5 OKA0v59I6EHr2rxSdf6kozlk4CPjkOIAFtpmncBqs1sK5A4+UFrHxEja0kLiBiRNL2ip O0PzIxnkMLd2kZJzEeFhdHAmZ+nJQB8FY2f2vwQLxf+LegmORbV1q6ikcfdaDC1LxvZ+ PoooZM1xQYT+xV4fyYCMlk9u06h/Cfssec5Q2sEDWzf6Mr7QdkhTeQbqNmFGb9nbGQx3 FvMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LeGGy9TX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t11-20020a17090a5d8b00b00229d64c32dfsi334945pji.15.2023.01.19.13.24.10; Thu, 19 Jan 2023 13:24:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LeGGy9TX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229696AbjASVU2 (ORCPT + 99 others); Thu, 19 Jan 2023 16:20:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229974AbjASVTi (ORCPT ); Thu, 19 Jan 2023 16:19:38 -0500 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E6C3A9592 for ; Thu, 19 Jan 2023 13:13:23 -0800 (PST) Received: by mail-pg1-x52a.google.com with SMTP id 78so2595939pgb.8 for ; Thu, 19 Jan 2023 13:13:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fXQAX4zgQIEcR46hfecs8ivLI9Fp7qzLdoZtzRMFxAM=; b=LeGGy9TXclqavq1GJEP5BeJuqLAP77mJj9M/dx+YZB1k8oz48n4eWPGqVlYjqDCLRE 41YHxOMQmIPn4GecoCfNdSfjX7LtOwzw481wfJI+TUHrlJT0YXSVbMTSxk7vLqaMm35k isUkT8z/Zm8eLWKwPPOPPE3qKEIo5tMt4u/U9Z2tA27ZMD9AbBVh5NaY8RcniOdcvUMi pyrAFAChvhZharJnDgULt0wPu06u8xTrPVKuwTv/MbeonFQrYfzcIF/B0ce5rWIFQ39h ubIZ7WeGiuR3cNGBk8p1LMXvjgWovU46wbhWELbGrWsie3y+NdQUdLbxAI2m+8DqNVzX 1Jow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fXQAX4zgQIEcR46hfecs8ivLI9Fp7qzLdoZtzRMFxAM=; b=DeXByVsi6G8qchel4ltwQh0eHqjOljWXDcm8q7Mz1+bxdkefjUe1DVX8kC3tYKz8ba WxkhQt1bwjvSXNXKTdrUjdwWKikCy4VJdxaOwdjfCif9tcbXfyXdqYta299ZaeYStkmS GcsbriEwMmygMxIG2YjfZGKRn/NRRwDf7LvdD2wJkFpjdsgFZ2d+63cPw197snMMB9BA SO4vMxJ3sjbWpm23nKCsOBLrnLGBNeLvJF2sPKi5f1gX+Fv9XxQ1d8tT/iZR3ISO3G6k WLAfdvGhOQqRFxN04Q8Gf74fhtwd/Kh+wZ4f0f53bpoi3IrqTJv8EjYSQzUxGWGWTk4z +mQA== X-Gm-Message-State: AFqh2kpx+BGdlxa88d+Qs/NEuQ5osPRqiTT5edMluPFub2RRHOBiTWsY vysY2PeHXGBuLEv7PUTAmiE= X-Received: by 2002:a05:6a00:f91:b0:583:319a:4413 with SMTP id ct17-20020a056a000f9100b00583319a4413mr13329053pfb.24.1674162800057; Thu, 19 Jan 2023 13:13:20 -0800 (PST) Received: from localhost ([2a00:79e1:abd:4a00:2703:3c72:eb1a:cffd]) by smtp.gmail.com with ESMTPSA id 66-20020a620645000000b00581172f7456sm7056240pfg.56.2023.01.19.13.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 13:13:19 -0800 (PST) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: Rob Clark , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] drm/dma: Drop unbalanced obj unref Date: Thu, 19 Jan 2023 13:13:25 -0800 Message-Id: <20230119211325.2851211-1-robdclark@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755487627847229532?= X-GMAIL-MSGID: =?utf-8?q?1755487627847229532?= From: Rob Clark In the error path, drm_gem_dma_mmap() is dropping an obj reference that it doesn't own. Fixes: f5ca8eb6f9bd ("drm/cma-helper: Implement mmap as GEM CMA object functions") Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_gem_dma_helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_dma_helper.c b/drivers/gpu/drm/drm_gem_dma_helper.c index 1e658c448366..784356d6f39d 100644 --- a/drivers/gpu/drm/drm_gem_dma_helper.c +++ b/drivers/gpu/drm/drm_gem_dma_helper.c @@ -544,8 +544,6 @@ int drm_gem_dma_mmap(struct drm_gem_dma_object *dma_obj, struct vm_area_struct * dma_obj->dma_addr, vma->vm_end - vma->vm_start); } - if (ret) - drm_gem_vm_close(vma); return ret; }