From patchwork Thu Jan 19 03:50:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takayuki 'January June' Suwa X-Patchwork-Id: 45570 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp124330wrn; Wed, 18 Jan 2023 19:51:03 -0800 (PST) X-Google-Smtp-Source: AMrXdXst41YKizxfqJSa9OmDXKPIbhRBM1sOUWCMzlNXlbKEa+Prhx0JvzUwpe/KFb9zNV4yV+so X-Received: by 2002:a17:907:98f4:b0:872:6bd0:d25 with SMTP id ke20-20020a17090798f400b008726bd00d25mr9398996ejc.37.1674100263535; Wed, 18 Jan 2023 19:51:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674100263; cv=none; d=google.com; s=arc-20160816; b=jJ2Fd4o30M19qwTs8s8EcZivpNlQUa6n8tdie7BwB/bxVS1Mcd9Pts+9tRgiJNQBRg 85xXrsY74dWLFj41KQUVqENmK2hvmHPIBNsGGUsQCUEcrwjQ7Fnpa+Tgi++8JVlCas9Q WYbKPYZ3qc29SdsOKcK60mVToreytBxlLSy2dIdBb5THicspxwbEt3d4cZCJ6lpjayVn tow0M9tgh0wukIBnnJfcoiTuF6PbptU3GyqH/nMAEZr0XfDr0RJ1/nF2xBtHtkm8Ra/l 9DlbULeN80C3BLvKAD52QcdxVnAg4yWgFPYJ2CN6C4EPy12EcnsTJ2h23PXMK9GavMpu dg7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:references :content-transfer-encoding:cc:to:subject:user-agent:mime-version :date:message-id:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=CB/5ughfF+qp2YDToekVACI85rMTIKf1PLiiU8GccaM=; b=oBFyeOacAmzb3ES7kiW3+4iesG/0DNmWEbC1TshXE4JnBjxhr52KE4S2XpNjnmbyab 2lMSRKJGx0nQV9iUhzXxVJ53yC/jbd6PE6OfkoadvYwzVURd0Iak2ji5DUupOB4JFiOS 5BfN2OPJSO+GP70D8uPZm+V2pyTH7ow2tsMEzTYlZV5D6EJKGOT9m3PC5LA/t80dPNQo 2aDx0D69daC12XPgrR5spp7GFHLst+sqPqNj6UxzhLiiKLpS9yaHDnbzKKm4jNDg1BPY ws974ON958dKKfFEWaeoqk/1NmGiuwgKITbp98DgyEIwzjqEqRYDlP6vWjyRhpiG/xBw hU9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=QUO9QRbQ; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id u2-20020a17090617c200b008717c29398esi8936117eje.522.2023.01.18.19.51.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 19:51:03 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=QUO9QRbQ; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 80E873858426 for ; Thu, 19 Jan 2023 03:51:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 80E873858426 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1674100262; bh=CB/5ughfF+qp2YDToekVACI85rMTIKf1PLiiU8GccaM=; h=Date:Subject:To:Cc:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=QUO9QRbQpe3vTtqFK76wXnlu6i4wpja+/wIs4mz/5qCVRNhcsHVoMwqiwcXmqi/Ig tmCAxM8UPOWqrUKplq3y7IQYKT7YICNG/cFVLVfoh4+8ysQpW3zEi0xdlaq7TloIdR vvGDSeuB0+9MVRA7L/Mtm66QP+JNlowj2wbTAYJM= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from sonicconh5002.mail.kks.yahoo.co.jp (sonicconh5002.mail.kks.yahoo.co.jp [114.110.61.26]) by sourceware.org (Postfix) with ESMTPS id 3B0C83858D28 for ; Thu, 19 Jan 2023 03:50:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B0C83858D28 X-YMail-OSG: 59egE8kVM1kuxbmYhItV3ZCTcju35gMPDR43KTOLXjPdXnr99SV6mj1YP_1aF41 GqibsvLG6altOrUZw_wglmej.MAY1RGlOD7ZqZmJSEzw2g4gHLNIM3VnIXFXMWXp8g_PGByi8w0l OGnJTTbhnNFPuob_IZx.dHIhkL5qzgK1eImSPGpxMOaBQNJ5dSx8LAaU6R7Ap28xkGLhjBkKCZmA CSgtimaN5D9X9MYRZX3mu2VNbkSjNMKBzYAjf8cYy.G8_td1SoZrDD2SiUjb7ajLHi1GXsKKC1GU 5oTq1Ar2iyt.E7pJa_hnqiJ0P2lWPqdT3fW_iw76SiVg2vtvrgdSwz3IgcqLSCOZlyVhLHj63D5z eLwKkhA4WUSY.BxVavvGTz5XbG2qdHVFFFQaU7kOV6dsQyceTYjy0ScBCo1nS_iU8ECBJIQKsyEK MHH2Oso7fjkrZtNutOhDKNE8t5WJ8qUuYiV9fk6c_mH0SWzaDDP5KVgfi1SExp1PRoZdv_EnGN2s UZanOwQVBS94sffSx1a7KQT_grpBf3R3uTLTTlVsBCaQJz6ybzqjoUmcNcev1dmdp3ETR2FbfLaA PfScq8Svt1xpTiVh3zPibfdi2qldq6wpaWFFfRjs57aZBcwONanOphdpr.puK6l6twThU1D9pCKI 23CkVzeZI.zZqQDaVK50MCzPwe1wjlGJCuSEyCzAINU9XiKx1KkMJ4cpipGpN081nFk4nxMHyIP. pR1BYos4FC7WQEvbWVg_6J79jVrus0RP4wxJyY5U13horNXPeJ5oyjMNUhKd5AvwoVgPxuUgt_7U V_FodbBirnT8Pgmvyt4key2AtMhxgg9Dz47RCwawvyFqL0Ii0p7PxiOsOLXYBcLDrYPc3FvSXaml b1DaUeuBXf5L1sP4ksBLgayo6OZ_ti0FM8COzafK5SBeU04zg0YtEwgzc1RCEcujKA4XywP0Qr_O zxmBk3TM- Received: from sonicgw.mail.yahoo.co.jp by sonicconh5002.mail.kks.yahoo.co.jp with HTTP; Thu, 19 Jan 2023 03:50:13 +0000 Received: by smtphe5002.mail.kks.ynwp.yahoo.co.jp (YJ Hermes SMTP Server) with ESMTPA ID af6a8cd935fe9e1ab8852e4a201f4723; Thu, 19 Jan 2023 12:50:10 +0900 (JST) Message-ID: <465b0cbe-73ca-f5a0-661d-d34217e29b4d@yahoo.co.jp> Date: Thu, 19 Jan 2023 12:50:10 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH v4] xtensa: Eliminate the use of callee-saved register that saves and restores only once To: GCC Patches Cc: Max Filippov References: <465b0cbe-73ca-f5a0-661d-d34217e29b4d.ref@yahoo.co.jp> X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Takayuki 'January June' Suwa via Gcc-patches From: Takayuki 'January June' Suwa Reply-To: Takayuki 'January June' Suwa Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755421358312081824?= X-GMAIL-MSGID: =?utf-8?q?1755421358312081824?= In the previous patch, if insn is JUMP_INSN or CALL_INSN, it bypasses the reg check (possibly FAIL). ===== In the case of the CALL0 ABI, values that must be retained before and after function calls are placed in the callee-saved registers (A12 through A15) and referenced later. However, it is often the case that the save and the reference are each only once and a simple register- register move (the frame pointer is needed to recover the stack pointer and must be excluded). e.g. in the following example, if there are no other occurrences of register A14: ;; before ; prologue { ... s32i.n a14, sp, 16 ... ; } prologue ... mov.n a14, a6 ... call0 foo ... mov.n a8, a14 ... ; epilogue { ... l32i.n a14, sp, 16 ... ; } epilogue It can be possible like this: ;; after ; prologue { ... (deleted) ... ; } prologue ... s32i.n a6, sp, 16 ... call0 foo ... l32i.n a8, sp, 16 ... ; epilogue { ... (deleted) ... ; } epilogue This patch introduces a new peephole2 pattern that implements the above. gcc/ChangeLog: * config/xtensa/xtensa.md: New peephole2 pattern that eliminates the use of callee-saved register that saves and restores only once for other register, by using its stack slot directly. --- gcc/config/xtensa/xtensa.md | 62 +++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/gcc/config/xtensa/xtensa.md b/gcc/config/xtensa/xtensa.md index 4f1e8fd13..ac04ef6f0 100644 --- a/gcc/config/xtensa/xtensa.md +++ b/gcc/config/xtensa/xtensa.md @@ -3029,3 +3029,65 @@ FALLTHRU:; operands[1] = GEN_INT (imm0); operands[2] = GEN_INT (imm1); }) + +(define_peephole2 + [(set (match_operand:SI 0 "register_operand") + (match_operand:SI 1 "reload_operand"))] + "!TARGET_WINDOWED_ABI && df + && epilogue_contains (insn) + && ! call_used_or_fixed_reg_p (REGNO (operands[0])) + && (!frame_pointer_needed + || REGNO (operands[0]) != HARD_FRAME_POINTER_REGNUM)" + [(const_int 0)] +{ + rtx reg = operands[0], pattern; + rtx_insn *insnP = NULL, *insnS = NULL, *insnR = NULL; + df_ref ref; + rtx_insn *insn; + for (ref = DF_REG_DEF_CHAIN (REGNO (reg)); + ref; ref = DF_REF_NEXT_REG (ref)) + if (DF_REF_CLASS (ref) != DF_REF_REGULAR + || DEBUG_INSN_P (insn = DF_REF_INSN (ref))) + continue; + else if (insn == curr_insn) + continue; + else if (GET_CODE (pattern = PATTERN (insn)) == SET + && rtx_equal_p (SET_DEST (pattern), reg) + && REG_P (SET_SRC (pattern))) + { + if (insnS) + FAIL; + insnS = insn; + continue; + } + else + FAIL; + for (ref = DF_REG_USE_CHAIN (REGNO (reg)); + ref; ref = DF_REF_NEXT_REG (ref)) + if (DF_REF_CLASS (ref) != DF_REF_REGULAR + || DEBUG_INSN_P (insn = DF_REF_INSN (ref))) + continue; + else if (prologue_contains (insn)) + { + insnP = insn; + continue; + } + else if (GET_CODE (pattern = PATTERN (insn)) == SET + && rtx_equal_p (SET_SRC (pattern), reg) + && REG_P (SET_DEST (pattern))) + { + if (insnR) + FAIL; + insnR = insn; + continue; + } + else + FAIL; + if (!insnP || !insnS || !insnR) + FAIL; + SET_DEST (PATTERN (insnS)) = copy_rtx (operands[1]); + df_insn_rescan (insnS); + SET_SRC (PATTERN (insnR)) = copy_rtx (operands[1]); + df_insn_rescan (insnR); + set_insn_deleted (insnP); +})