From patchwork Mon Jan 16 21:10:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fedor Pchelkin X-Patchwork-Id: 44322 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1406636wrn; Mon, 16 Jan 2023 13:21:43 -0800 (PST) X-Google-Smtp-Source: AMrXdXvz2Q5U6QS+dkBLKakoOWSFaKtYcC6pvxnZ3dq3URzY0INemais28dSLJrsX3Dr0E1y4fCW X-Received: by 2002:a17:907:971c:b0:86f:d154:ef4f with SMTP id jg28-20020a170907971c00b0086fd154ef4fmr466776ejc.28.1673904103200; Mon, 16 Jan 2023 13:21:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673904103; cv=none; d=google.com; s=arc-20160816; b=imxhjoCPtTt8yKv0SBQq/R4ts4KEKHu7pWvTmpodem2t3vXvNlIt04umR15Tr5o0ge xLO/nXA84KgqI1HtSPGN+COHnCjJShJVN2IZAKxKmxDA5twfWamzPnTeASPA0Jk1G0us IbzcxpVgI0Vq3wqCy4FLE3D5HJMfv8CG6+UxBVVur6MOtqq6MGnEJs9HtFOITYc8Ezy4 sPQiJGO/amje6kMJFllzfiBU/l5NmETUcPaa1WFmHNI82ibSX0cfnLPGWOVaoqgFIuWb ol8hiNN1btoePfGimpDlIPoNcTV3igUXE4nZG/gsZf94m1yuagjFnEOdNSqHEpWkHXzi b/gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter; bh=JgF6PdGUqUIiW+PcAMJiQ/9RP2j3tExghwoZn9wrIig=; b=JfY+bKlhfyH81qay/hllriCkOhkodMuIL38ZKAfSuU+IrjBYW6V9A1Jni21N5ECvMu 9GkqbsNMfiJax44LgHkmF8i7A4Rtb9Wwg+HzuzGlfny0u1HEKGSupffILokgu92IzpkZ DMNklhQuxsIEcK5YbaFFSPv0GHSS+BMbCnPJKq7CL6BL8XApZsiMATbYIGp1X3VP1jgy 3NiOJz3n1jiI9p7B4pCDzuAlZPv4vu6kEZKb0rWmJRzngWyz+NJHsSeerc30+Vy/5xgj PwlEzznePRwq2F4CjbA+t/VGy7zrraPoLD5L++Q3nzHlr4QhExRE8Zr50lUdSrJXG3de jDqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=KkhWXRfp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr5-20020a170907720500b008327270a7ffsi1151003ejc.663.2023.01.16.13.21.19; Mon, 16 Jan 2023 13:21:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=KkhWXRfp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234018AbjAPVKX (ORCPT + 99 others); Mon, 16 Jan 2023 16:10:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233847AbjAPVKV (ORCPT ); Mon, 16 Jan 2023 16:10:21 -0500 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 358171CAE3; Mon, 16 Jan 2023 13:10:21 -0800 (PST) Received: from fedcomp.intra.ispras.ru (unknown [46.242.14.200]) by mail.ispras.ru (Postfix) with ESMTPSA id 6242740D403D; Mon, 16 Jan 2023 21:10:19 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 6242740D403D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1673903419; bh=JgF6PdGUqUIiW+PcAMJiQ/9RP2j3tExghwoZn9wrIig=; h=From:To:Cc:Subject:Date:From; b=KkhWXRfpLeToZU3rkquVnGfm4EHcU1i5LWLYoWHWDVaJtlye4kq/ORrphzAFEKAgt oyzHOsXFLo/2ECq0WOjp58mpa1Dk0AbvotogEbFlnB4XhP5EnWIS4aW5xF4M3dc9+A HTJznExyVaTW8+VfGSzj4IS2Z1kygMCmEAYH2fXg= From: Fedor Pchelkin To: stable@vger.kernel.org, Greg Kroah-Hartman Cc: Fedor Pchelkin , Jens Axboe , Christoph Hellwig , Chaitanya Kulkarni , Johannes Thumshirn , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov Subject: [PATCH 4.19] block: fix and cleanup bio_check_ro Date: Tue, 17 Jan 2023 00:10:13 +0300 Message-Id: <20230116211013.822998-1-pchelkin@ispras.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755214733021706053?= X-GMAIL-MSGID: =?utf-8?q?1755215669044900176?= From: Christoph Hellwig commit 57e95e4670d1126c103305bcf34a9442f49f6d6a upstream. Don't use a WARN_ONCE when printing a potentially user triggered condition. Signed-off-by: Christoph Hellwig Reviewed-by: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn Link: https://lore.kernel.org/r/20220304180105.409765-2-hch@lst.de Signed-off-by: Jens Axboe Signed-off-by: Fedor Pchelkin --- block/blk-core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index 80f3e729fdd4..4fbf915d9cb0 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -2179,10 +2179,7 @@ static inline bool bio_check_ro(struct bio *bio, struct hd_struct *part) if (op_is_flush(bio->bi_opf) && !bio_sectors(bio)) return false; - - WARN_ONCE(1, - "generic_make_request: Trying to write " - "to read-only block-device %s (partno %d)\n", + pr_warn("Trying to write to read-only block-device %s (partno %d)\n", bio_devname(bio, b), part->partno); /* Older lvm-tools actually trigger this */ return false;