From patchwork Mon Jan 16 21:02:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fedor Pchelkin X-Patchwork-Id: 44319 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1401069wrn; Mon, 16 Jan 2023 13:07:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXuN3R4AMJrb0CfCx19JKiaSVNCuat18t92U4sgs+jf5RZbURsCn21OA+58J1JV7z1qQjWtV X-Received: by 2002:a50:ee17:0:b0:499:ccfc:dd0b with SMTP id g23-20020a50ee17000000b00499ccfcdd0bmr618467eds.17.1673903242833; Mon, 16 Jan 2023 13:07:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673903242; cv=none; d=google.com; s=arc-20160816; b=vGKs+HgLo460R0g9CbmGW1PJFvO4vbtU01zQBsT12hChbPB5CqEVEBkZID3rVAkNyx /mZRxI7AJfexo5Mjffp+ptR4Hoz3EkmtvDONYcen/V+q09HnPWMtwnc8RekLsRljbNDN uIlfPwZvFCHeAkjGDEPvN/0tK18UNf2qUqSqNDfJMyKlfV4pEbqu2b5VYvZsAe0spQ+i d9uKy/4eekorqVHJz2AbDZbXjhvcQL8C+jjZHG730RNL56vcJB2yb8Np3P07v2bQrsxp oCaSo8GoVfc7uGcotig8CyGXMhu7mvO5pmTXOzsW/gQevOS4KdhiUzcKYYfzCtXUt/FE pbRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter; bh=4kw1QVgX7O7Y5Cc2cOPB5opeDLXtwox1qw8ig56WKY0=; b=PSobZz1uOlv32PFzn5mtIDmCS350EXxn2rLub1b5bjJflEIfAjnZM/6Xn3w2NrIYIR 0fxiMprJLpNsGP9ZWQvsgm3gY2hPLh1ineDcUQuYZV7nU5QUmvs0XYgVr3Y9dSMHxviV cQfaK6ryZ2XuNEZvhOQ1+iS2oCqYNH7VR8c6OZ2V4m/LqvtSwLo+kXrwaU5YYeF+v8tt RFvJa2CWseQxbtWRnAXMfh9a9O8B737RcdCxE1I/rop8jt5AxbWEQ23tSoXJw4AvoarF moZVQ6op/zXdLNhsXcvJOgom+c1nIlhu8NZaRpJuMPx+ZALwtJ9+md13928+Iy6YN9Bu Xl0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=aigFG812; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t10-20020a056402524a00b0049e2f4a1ec2si530736edd.596.2023.01.16.13.06.59; Mon, 16 Jan 2023 13:07:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=aigFG812; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233765AbjAPVCW (ORCPT + 99 others); Mon, 16 Jan 2023 16:02:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232671AbjAPVCT (ORCPT ); Mon, 16 Jan 2023 16:02:19 -0500 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50A2921963; Mon, 16 Jan 2023 13:02:18 -0800 (PST) Received: from fedcomp.intra.ispras.ru (unknown [46.242.14.200]) by mail.ispras.ru (Postfix) with ESMTPSA id BD07840D403D; Mon, 16 Jan 2023 21:02:16 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru BD07840D403D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1673902936; bh=4kw1QVgX7O7Y5Cc2cOPB5opeDLXtwox1qw8ig56WKY0=; h=From:To:Cc:Subject:Date:From; b=aigFG8121I2YihAOh/hqqMnZsIx5GKQb9KFpy59C5mDhW/5gm8mmC15HfG3RbcTh7 Ve1gflOVyAVTjlr+pORl4ShYNhPAKX3i9O2xlu25+DLcYaSrRCscuLxHqTX0OBWSPN Pq9LiP7uAnT6GbtEOef6VbSxhVS1TbAmG61MzPuM= From: Fedor Pchelkin To: stable@vger.kernel.org, Greg Kroah-Hartman Cc: Fedor Pchelkin , Jens Axboe , Christoph Hellwig , Chaitanya Kulkarni , Johannes Thumshirn , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org Subject: [PATCH 5.10] block: fix and cleanup bio_check_ro Date: Tue, 17 Jan 2023 00:02:05 +0300 Message-Id: <20230116210205.805024-1-pchelkin@ispras.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755214733021706053?= X-GMAIL-MSGID: =?utf-8?q?1755214766863906807?= From: Christoph Hellwig commit 57e95e4670d1126c103305bcf34a9442f49f6d6a upstream. Don't use a WARN_ONCE when printing a potentially user triggered condition. Signed-off-by: Christoph Hellwig Reviewed-by: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn Link: https://lore.kernel.org/r/20220304180105.409765-2-hch@lst.de Signed-off-by: Jens Axboe Signed-off-by: Fedor Pchelkin --- block/blk-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index 26664f2a139e..9afb79b322fb 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -700,9 +700,7 @@ static inline bool bio_check_ro(struct bio *bio, struct hd_struct *part) if (op_is_flush(bio->bi_opf) && !bio_sectors(bio)) return false; - - WARN_ONCE(1, - "Trying to write to read-only block-device %s (partno %d)\n", + pr_warn("Trying to write to read-only block-device %s (partno %d)\n", bio_devname(bio, b), part->partno); /* Older lvm-tools actually trigger this */ return false;