From patchwork Mon Jan 16 18:56:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 44289 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1349713wrn; Mon, 16 Jan 2023 10:57:29 -0800 (PST) X-Google-Smtp-Source: AMrXdXsxEJ5eJ1jRmOgugSvHnqwfvml/NSzLbNSegBataUB/cvCydeDSHPZGYNk65PJ9/pbucYqR X-Received: by 2002:aa7:cf0a:0:b0:49d:a87f:ba70 with SMTP id a10-20020aa7cf0a000000b0049da87fba70mr241284edy.38.1673895449374; Mon, 16 Jan 2023 10:57:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673895449; cv=none; d=google.com; s=arc-20160816; b=t4moM9LPxrQiRoZjSQLMPZlnLQ8nr7twX5mkG88Tmh9cXDTk1thb7KLhDzPHJ+LSNM 07AU1UhRpUqVhcmeEy8pLA8rs7AnoNIAUzsT5itSfK385rtLcadco5WWOmzrrRd9FIuz DleX8Ovg0FLhiB/emR7EOUD8D7/x+dUFlX4jCfCfvBAX+Xw8pewyySjpRVMF5qVt1KOl QiW7e44M7tSrK81jQAop0+TuelKXtSWCjkF9wdiGUj8M6euoPRclhSot75fuYJSSc5a9 vNUdwQkNO1RttudFkEXtGIVq0SbV1EF/RiV5MfK11ry/WaIZ/UT/UsmdH4qPlSg/RaK2 WlzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=dJbT7zNaClx4GjbQmRhZuHjtXRyM50tI9HILZjHUTis=; b=wxO37pDZ32LyNmR076EbzBHkS/bdtAnpKR6vmSovPTXrrYYGubxatMhkP4kAVXCOda 395yTOjVTEpA/1T/vmfS9qfUI1ESBGSGDYk2JwtvoVRvWhD6IndREiM+8aUzK3Bf2VqF +KJnyYF/LofDk7ND5mfw9prR1kVKaOwQMfORW9sh/juS+Dte8MSIe1s7o/zocTdSeoiz XuiGazORabQ+BowET1a61iUuhbJ+R8cHDRmPnpBvVBHKD+FPIelIrvBY0eizCFsVYdLm LXdpBgW/dBWkLxSip9O1bxC/J4QzqQLQvnn5iz/qhNA4j0aX0H7g3asAoH8dZViQ06hJ 3MjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=XW6b4bMr; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id s18-20020a056402521200b0049e2adfe83dsi990522edd.235.2023.01.16.10.57.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 10:57:29 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=XW6b4bMr; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 64ABD3858414 for ; Mon, 16 Jan 2023 18:57:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 64ABD3858414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1673895448; bh=dJbT7zNaClx4GjbQmRhZuHjtXRyM50tI9HILZjHUTis=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=XW6b4bMrGPLF5nvwKLdqbjt/QSzEfUh1n650xxWc7qTSQ49ijXGN44+81IgONVhRB 8eXw8UMZ46bwOqWvIBuBZNl9zjRaAb0whHyaHyY6toa+pPH7AtILx/VMZESO0mbloi 145qsaYnDKyw7bPTs4mtC5JHUZqjUqp5hiRaB+rc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 587A63858D32 for ; Mon, 16 Jan 2023 18:56:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 587A63858D32 Received: by mail-pl1-x62a.google.com with SMTP id d3so31173069plr.10 for ; Mon, 16 Jan 2023 10:56:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dJbT7zNaClx4GjbQmRhZuHjtXRyM50tI9HILZjHUTis=; b=1y1DMoveBCXGJ5MMTiB7N26yW8bifnzqOrqjldl7iIT5HoOH4ysNbmQZp57ghksWjA NHiQFrc0uL9FGBDZYaMnbz7Tl9yc1Jn046LfKTgaJfqgoxK7QAqI8wFRqH2LPpZuRdKO z/i0EJfVmVbU8TB00dTGJYpfLhF3S9ZxmBIxfzvB1MnUy6PCOUup2PnZTbqIWXgnAIfi ynlqdS/5UvwOWWx2G5KlAxP+wROCr8mLwbS3AFFqElfccsVyPIdtbPMQf+OjDTK4F+NY 9tllRJYWAKzZFTKNd6Z0kRo+p8uLF7NlcuFn1KPKusWMM+oSsSE85N+c9i/aLnmdOzuY Rbiw== X-Gm-Message-State: AFqh2kp4dNs8wF+A2n8vt+Y4QA5vFxWoWvPSnXE0XrDLt5eFZzAzr2UX 5f4Wt2G2YbmEP4BSkAQq4245/FhLm3o= X-Received: by 2002:a17:902:854a:b0:191:4539:d2c1 with SMTP id d10-20020a170902854a00b001914539d2c1mr20740681plo.47.1673895395884; Mon, 16 Jan 2023 10:56:35 -0800 (PST) Received: from gnu-cfl-3.localdomain ([172.58.28.209]) by smtp.gmail.com with ESMTPSA id u9-20020a170903124900b00174c1855cd9sm19602144plh.267.2023.01.16.10.56.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 10:56:34 -0800 (PST) Received: from gnu-cfl-3.. (localhost [IPv6:::1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id 5039F740159; Mon, 16 Jan 2023 10:56:33 -0800 (PST) To: gcc-patches@gcc.gnu.org Cc: Uros Bizjak Subject: [PATCH] x86: Disable -mforce-indirect-call for PIC in 32-bit mode Date: Mon, 16 Jan 2023 10:56:33 -0800 Message-Id: <20230116185633.159901-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-3025.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Gcc-patches" From: "H.J. Lu" Reply-To: "H.J. Lu" Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755206594516477068?= X-GMAIL-MSGID: =?utf-8?q?1755206594516477068?= -mforce-indirect-call generates invalid instruction in 32-bit MI thunk since there are no available scratch registers in 32-bit PIC mode. Disable -mforce-indirect-call for PIC in 32-bit mode when generating MI thunk. gcc/ PR target/105980 * config/i386/i386.cc (x86_output_mi_thunk): Disable -mforce-indirect-call for PIC in 32-bit mode. gcc/testsuite/ PR target/105980 * g++.target/i386/pr105980.C: New test. --- gcc/config/i386/i386.cc | 6 ++++++ gcc/testsuite/g++.target/i386/pr105980.C | 8 ++++++++ 2 files changed, 14 insertions(+) create mode 100644 gcc/testsuite/g++.target/i386/pr105980.C diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc index 19fb03cfd44..3cacf738c4a 100644 --- a/gcc/config/i386/i386.cc +++ b/gcc/config/i386/i386.cc @@ -21480,6 +21480,7 @@ x86_output_mi_thunk (FILE *file, tree thunk_fndecl, HOST_WIDE_INT delta, rtx this_reg, tmp, fnaddr; unsigned int tmp_regno; rtx_insn *insn; + int saved_flag_force_indirect_call = flag_force_indirect_call; if (TARGET_64BIT) tmp_regno = R10_REG; @@ -21492,6 +21493,9 @@ x86_output_mi_thunk (FILE *file, tree thunk_fndecl, HOST_WIDE_INT delta, tmp_regno = DX_REG; else tmp_regno = CX_REG; + + if (flag_pic) + flag_force_indirect_call = 0; } emit_note (NOTE_INSN_PROLOGUE_END); @@ -21659,6 +21663,8 @@ x86_output_mi_thunk (FILE *file, tree thunk_fndecl, HOST_WIDE_INT delta, final (insn, file, 1); final_end_function (); assemble_end_function (thunk_fndecl, fnname); + + flag_force_indirect_call = saved_flag_force_indirect_call; } static void diff --git a/gcc/testsuite/g++.target/i386/pr105980.C b/gcc/testsuite/g++.target/i386/pr105980.C new file mode 100644 index 00000000000..d8dbc332ea2 --- /dev/null +++ b/gcc/testsuite/g++.target/i386/pr105980.C @@ -0,0 +1,8 @@ +// { dg-do assemble { target { fpic } } } +// { dg-options "-O0 -fpic -mforce-indirect-call" } + +struct A { + virtual ~A(); +}; +struct B : virtual A {}; +void bar() { B(); }