From patchwork Sat Jan 14 08:58:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 43721 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp203406wrn; Sat, 14 Jan 2023 01:22:42 -0800 (PST) X-Google-Smtp-Source: AMrXdXsdu5t8zXFc2fZzKrigLZgCQvASPGgvu5WaNMbc5ZjoFhuAKOKGS2Kdfo0OESXoTGSLBk/W X-Received: by 2002:a17:907:c388:b0:849:e96f:51f4 with SMTP id tm8-20020a170907c38800b00849e96f51f4mr63873589ejc.23.1673688161903; Sat, 14 Jan 2023 01:22:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673688161; cv=none; d=google.com; s=arc-20160816; b=SLV4IHDEx+C4v/GT5EOnEdCfDrMOPxX/NAOWcfkWDpZJ1ZlAJvrHY5q4pE8q7nHcW5 JYOkbc9bm9TA3u/WjfchJQafKO2DvDxIIBX0BSxaQfcN+61jCOGbsXiG6S3BZmJCWLkN q9a2fn6+tCWW2QQyHufH6pSbHFj9tZDUOt9r9nseIbdcoQj8j65s1ysVF6hiY0LqCUGY 0d6fRRnXfnCSRelqMn5lqx9n93b5iuYyKhVy6VqLN42z8NST2dwo98IrWfQeEE+P2+Wb +08vM8avRP7Fv0iXiidKue/jpGVoEbl1VBSPo+A8g1TkNdHMWf7sGohZsGCsjI8i3uhc IG3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=FuECuXp3fd4L3RlohSS82Srpd7tQ6WA81x2mK7++BNg=; b=UOxybT9wVZcblwa1xl9CMAV02WBw73BGFGA86T0mqUelvq7Fju8OlWRskO/bsCPA4p se+HWwfKLlurvF8Wrv6cSrw4j2gxji4hDvMYApD16PJgc5PqAdizJdqcHouEJvt9LFvg Pya1jgQFkysdjBHphbrZP9/PXwy4o1sHDc0lTuSib9+r7BZGgIa5EPSEREKUhZFZaGCA JNRaCIJjsSWe/exTKDd8dzyrLanccN9oKK9KmdmjNpWeNe1lFNdN0Fiuad0ixmgJhGHj pYLkPaZ2W6wkZPwJ+f8PHzjjVTeRERBOB9/gfcPMFo8thCq1YS06rr+6Bi8egHYZDXZS SBKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hw19-20020a170907a0d300b007c0f7afccccsi18475445ejc.696.2023.01.14.01.22.12; Sat, 14 Jan 2023 01:22:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229803AbjANI6k (ORCPT + 99 others); Sat, 14 Jan 2023 03:58:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbjANI60 (ORCPT ); Sat, 14 Jan 2023 03:58:26 -0500 Received: from smtp.smtpout.orange.fr (smtp-19.smtpout.orange.fr [80.12.242.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3EE05BBC for ; Sat, 14 Jan 2023 00:58:25 -0800 (PST) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id GcMoplIKCnvraGcMopwaX6; Sat, 14 Jan 2023 09:58:24 +0100 X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 14 Jan 2023 09:58:24 +0100 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org Subject: [PATCH v2] cifs: Use kstrtobool() instead of strtobool() Date: Sat, 14 Jan 2023 09:58:15 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754989238134489893?= X-GMAIL-MSGID: =?utf-8?q?1754989238134489893?= strtobool() is the same as kstrtobool(). However, the latter is more used within the kernel. In order to remove strtobool() and slightly simplify kstrtox.h, switch to the other function name. While at it, include the corresponding header file () Signed-off-by: Christophe JAILLET --- This patch was already sent as a part of a serie ([1]) that axed all usages of strtobool(). Most of the patches have been merged in -next. I synch'ed with latest -next and re-send the remaining ones as individual patches. Changes in v2: - synch with latest -next. [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/ Signed-off-by: Christophe JAILLET --- fs/cifs/cifs_debug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c index 56b23def4c95..612f0bb284c9 100644 --- a/fs/cifs/cifs_debug.c +++ b/fs/cifs/cifs_debug.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -787,7 +788,7 @@ static ssize_t cifsFYI_proc_write(struct file *file, const char __user *buffer, rc = get_user(c[0], buffer); if (rc) return rc; - if (strtobool(c, &bv) == 0) + if (kstrtobool(c, &bv) == 0) cifsFYI = bv; else if ((c[0] > '1') && (c[0] <= '9')) cifsFYI = (int) (c[0] - '0'); /* see cifs_debug.h for meanings */ @@ -947,7 +948,7 @@ static ssize_t cifs_security_flags_proc_write(struct file *file, if (count < 3) { /* single char or single char followed by null */ - if (strtobool(flags_string, &bv) == 0) { + if (kstrtobool(flags_string, &bv) == 0) { global_secflags = bv ? CIFSSEC_MAX : CIFSSEC_DEF; return count; } else if (!isdigit(flags_string[0])) {