From patchwork Fri Jan 13 18:26:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 43546 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp421121wrt; Fri, 13 Jan 2023 10:31:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXvpEcBPHdZx1fq+FHgxEA6MmS1QQ3U7F6uAwz8vh7zkoatISVI+hhUVdsZYvaAzIhciAhyd X-Received: by 2002:a05:6a20:9399:b0:ad:a277:eeee with SMTP id x25-20020a056a20939900b000ada277eeeemr89631023pzh.45.1673634667497; Fri, 13 Jan 2023 10:31:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673634667; cv=none; d=google.com; s=arc-20160816; b=jzZYotKt/PjAobCoImsE0+OshBl+TQ/Og6MUPNZxQll2hkIyU9xhnmSafqnqKBYTtl z+P29Z/4/yrfJQNBW5HHrj6I62MtIGaP4bnOLDSsdWhxfmQO9TaPxNtxCjhWBTTwB1k3 lSWQsp31gjCnU2b7uJCQ4XlB1FO+L5SZROBGBxHgPcn9csytjP/OqiOLWXWS/6YvHhkT tcQ3VrIojsIzWAN6c7M8/MaRAMFq1s8osniKYbbubtLClPpn69zK7g2T65Vb8ZXjhTRd iihi21qYiQXJnO8s/kg5pK2jGuy3GBF2TBCPs4si3+uyYapj8A8m0ph/WMPqnsUrXhFo zR3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=TQJSGqMczoXouGo3l5KqBDdqN8y50jXmy5qx7L+cuxs=; b=IwkYrrG9Hu50aHbREnMA26UhATIxvl0wLXPxbOIcl/kq/lCdcO79OZ+mAtvpMe3ni9 hGMcV5NGKU3RlLpfrnCw+/YJnjZB/M2KPOyXhrftPm0/EPeYNbe3LvTsjzASWK5bYBBV zeZPwWg6WforXY7FEHeJJmU/8rshhAWJ2xWSA47J3YauUgZ3YoWcWyFFyrfne177WCSr jQkGHcqfpk/7ZpcfUOJ5FFpqnOSABxquEAPyZcCvkSrX+5jnabLLzzYeVSMr2XbD92NO nTrFwoNT1wjD5nDslJyN3iUxUfi7K5gx16v9G4MAe7W5Mrrdis0d3wk9xxgTudsqsKPS ERDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CKzhJNJX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b9-20020a63d809000000b004701a950fe7si21455667pgh.551.2023.01.13.10.30.55; Fri, 13 Jan 2023 10:31:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CKzhJNJX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231313AbjAMSaU (ORCPT + 99 others); Fri, 13 Jan 2023 13:30:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230060AbjAMS3r (ORCPT ); Fri, 13 Jan 2023 13:29:47 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2AE080AE6; Fri, 13 Jan 2023 10:25:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673634349; x=1705170349; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=eG4OuRyjCZe8OikZYs+kddA7ukKCqAcj7N9qQVWtCFw=; b=CKzhJNJXyPUSoC3TsFbp/ENTdzKtrBZuV8/GXPw/32oJjpgXGKtdPRvZ ybcj+++5MPSOpYZh6YHlL0bY78CrnMHDOaH00sU+r777bfotBDQi9qhR0 qi2EiHb6sfSOGq4YCBLaLOONO44WaQw7zcjPqKWwyKFtyJAxmC24yVmLf hWTpWcCIx4aqad1Hfqd0K3RSkOluvPFadOTDZsqO/CJQoJ4Ju35bwzsyS eTurVWTcoYQQburQ8GJsAENu7+FZVJCDkiNI2988RFnpJe3FGml02ak3P p50M6S7LXz0FIaJbxmjzjFM/G4laWFSHAcodtS2eFseoNM2glT2Gmx7yh Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10589"; a="351297783" X-IronPort-AV: E=Sophos;i="5.97,214,1669104000"; d="scan'208";a="351297783" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2023 10:25:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10589"; a="987087236" X-IronPort-AV: E=Sophos;i="5.97,214,1669104000"; d="scan'208";a="987087236" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 13 Jan 2023 10:25:47 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3271FE1; Fri, 13 Jan 2023 20:26:21 +0200 (EET) From: Andy Shevchenko To: Bartosz Golaszewski , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski Subject: [PATCH v2 1/2] gpio: wcd934x: Remove duplicate assignment of of_gpio_n_cells Date: Fri, 13 Jan 2023 20:26:18 +0200 Message-Id: <20230113182619.16800-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754933144873553170?= X-GMAIL-MSGID: =?utf-8?q?1754933144873553170?= The of_gpio_n_cells default is 2 when ->of_xlate() callback is not defined. No need to assign it explicitly in the driver. Signed-off-by: Andy Shevchenko --- v2: no changes drivers/gpio/gpio-wcd934x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpio/gpio-wcd934x.c b/drivers/gpio/gpio-wcd934x.c index 97e6caedf1f3..817750e4e033 100644 --- a/drivers/gpio/gpio-wcd934x.c +++ b/drivers/gpio/gpio-wcd934x.c @@ -98,7 +98,6 @@ static int wcd_gpio_probe(struct platform_device *pdev) chip->base = -1; chip->ngpio = WCD934X_NPINS; chip->label = dev_name(dev); - chip->of_gpio_n_cells = 2; chip->can_sleep = false; return devm_gpiochip_add_data(dev, chip, data); From patchwork Fri Jan 13 18:26:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 43547 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp421301wrt; Fri, 13 Jan 2023 10:31:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXvQUGpYysGcKovqU1raqbYmFa162LFznpBJaUgPbcfhSzvfGePup9UOS++jSz/YWXyaHjsQ X-Received: by 2002:a62:1512:0:b0:58a:59d4:25aa with SMTP id 18-20020a621512000000b0058a59d425aamr15481167pfv.31.1673634690317; Fri, 13 Jan 2023 10:31:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673634690; cv=none; d=google.com; s=arc-20160816; b=HCqB6ji48dAFuYGE68yhVoLmCnsPuQqIGL4Mr0QN2NpXwWzk/mPgjteFjfh4oE+nEU 8PRyWs1qZMb0yXCdQWQKYrs4cgU4ymwJzmLu2g/9OOsqBT+BnwkQiInck0ViPPqMmWg/ d4MYAhk2Xm7cL4QrX3ysU5BFBEWx7kBEBR/W+P4BhmZE8VJ9S9deJrwS+i5jHOoL/os/ //Ed3UnlttPgIHMMFtPUYcm5L23kQd0awWbxsjorIwm1CY/j1G9OxG6hBmfJGT3X3POn w80To2s1tFmu560OPypyUGEw5fM2xf4MlXcnW5pixX4Yxvj8nCarPd0ev35hRecY0gmA oR1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EKy2UnRUwxCbXtzqakB5AeiuMK2qzXE28omS7wWrkEQ=; b=EGTh32atRkuMQ/YgMqQAIKhMaVyYpuhKZrAzNBzj4VYH9TPbLJB7w1zeTxOwXAMvYi bBQIicakZaIamCzKpkHlobXBINRBkX3SzUAHBGVJTKGpgKm0PY6eITYOysvQR7SnrSYo sLroFwMLBEcfApQA+OU6noLGeosHzBao2GlvTtYgBYPoahOVRTCpy+EAgoYwRwja5WkA iHXou37/Zg7uTy1k0fH1HE22YJjXQg+1Kt7ejhTzLW2nKndYILXTUeSO9oQr8eV4QVEf QWU5EYjknsK9+SSw2JEqxebQArxPsHBwyv0f0m36i8b8q+7+XyZo/1q/LysfNFBYX45L VlvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=m+2+MGij; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p32-20020a056a000a2000b00576c9c3c4aasi23901393pfh.5.2023.01.13.10.31.18; Fri, 13 Jan 2023 10:31:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=m+2+MGij; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231270AbjAMSaY (ORCPT + 99 others); Fri, 13 Jan 2023 13:30:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229892AbjAMS3t (ORCPT ); Fri, 13 Jan 2023 13:29:49 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 725BF54713; Fri, 13 Jan 2023 10:25:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673634353; x=1705170353; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yEyvIA73WWBK7QiaW0fyWgPeZ4RwekQQZmsZrEdJq5k=; b=m+2+MGijumBrjGwsxFA8jb19vvKSMznI+Z2CluvP+9mTzXh6lHfu7vE5 brUogOIJl84KEDnM3iFM3++lB5AYfPygfss5Ak2s+6MznmrO/AR6lSZa6 vlH1EdVyXT8RV1SpBFz7pnDlVZ5tw5SRGeaFuSYC/63BpA84TCkU/AtdF ipDr52XF6lIrhTa0linyNB19H3keQ1tGMe2DrE0Z2LW9qXeaiHuRPpQ36 FVU6IE5Jd2LxxNOQ/+6zps/U4RtI0iPPBtDpcoA8xVgx4oYtRphYc4aaQ JJLrmgQy+ukbd7J4k1IH7MfSkoQjHn1FKS1I54Op7hynlRdwUlAzRN+vt w==; X-IronPort-AV: E=McAfee;i="6500,9779,10589"; a="410303424" X-IronPort-AV: E=Sophos;i="5.97,214,1669104000"; d="scan'208";a="410303424" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2023 10:25:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10589"; a="800676179" X-IronPort-AV: E=Sophos;i="5.97,214,1669104000"; d="scan'208";a="800676179" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 13 Jan 2023 10:25:47 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3D35F92; Fri, 13 Jan 2023 20:26:21 +0200 (EET) From: Andy Shevchenko To: Bartosz Golaszewski , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski Subject: [PATCH v2 2/2] gpio: wcd934x: Use proper headers and drop OF_GPIO dependency Date: Fri, 13 Jan 2023 20:26:19 +0200 Message-Id: <20230113182619.16800-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230113182619.16800-1-andriy.shevchenko@linux.intel.com> References: <20230113182619.16800-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754933169182827061?= X-GMAIL-MSGID: =?utf-8?q?1754933169182827061?= The driver doesn't depend on the OF_GPIO to be complied. Hence the proper header to use is mod_devicetable.h. Replace of*.h with the above mentioned and drop redundant dependency. Signed-off-by: Andy Shevchenko --- v2: added one more missing header (LKP) drivers/gpio/Kconfig | 2 +- drivers/gpio/gpio-wcd934x.c | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 9995e23673dd..a2f64f880163 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -700,7 +700,7 @@ config GPIO_VX855 config GPIO_WCD934X tristate "Qualcomm Technologies Inc WCD9340/WCD9341 GPIO controller driver" - depends on MFD_WCD934X && OF_GPIO + depends on MFD_WCD934X help This driver is to support GPIO block found on the Qualcomm Technologies Inc WCD9340/WCD9341 Audio Codec. diff --git a/drivers/gpio/gpio-wcd934x.c b/drivers/gpio/gpio-wcd934x.c index 817750e4e033..b999af6b900b 100644 --- a/drivers/gpio/gpio-wcd934x.c +++ b/drivers/gpio/gpio-wcd934x.c @@ -1,11 +1,13 @@ // SPDX-License-Identifier: GPL-2.0 // Copyright (c) 2019, Linaro Limited +#include #include -#include +#include #include #include -#include + +#include #define WCD_PIN_MASK(p) BIT(p) #define WCD_REG_DIR_CTL_OFFSET 0x42