From patchwork Fri Jan 13 12:35:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christoph_B=C3=B6hmwalder?= X-Patchwork-Id: 43279 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp247686wrt; Fri, 13 Jan 2023 04:46:06 -0800 (PST) X-Google-Smtp-Source: AMrXdXsGL5tw4f7kppvLZ3qnAO4tYrzDeVHXPVakTEfNSxfBHX/YfDMoWqG/ucdBe+zVY+WS6SLg X-Received: by 2002:a05:6a00:f92:b0:582:a224:e740 with SMTP id ct18-20020a056a000f9200b00582a224e740mr39706686pfb.27.1673613966368; Fri, 13 Jan 2023 04:46:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673613966; cv=none; d=google.com; s=arc-20160816; b=xLjBUrxMTFdL733nDeFnfzl96zM9uvdo/R0BGrrBzWQvz/DapJCS2hDPZxF0nRjAnS mqEgsUQbm1YaeKXWu9YWUbQjnVYMzY5Z1ZqY1GPD4Y1qYuuW14RmFT33le6U15jqOnzy sVds76Ss0jqV1X6g+m92PzR+IB+upS4MADRK7YMJJ+HUxg5Hik5WHj5opcyeXnqmTs/z 2vGjTHQvdrs6bfuY0khGSFj8+cKG7Y/3uefUTslWIvFHJ0XsAz46AiV+hWfX/RPqiv9A ZlHnHxxWQngVw95IUqlOuusUtrlixhqoObQ84n4bvcVo/EkRDbj0do2pdXc4cUDc5mxA 6Ogg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sQNKuz5965naByKUS4y1VIo8yUx5dsUc2Lu+3dW2kE8=; b=tnuIu/UnR2+cXvRUQ+dVvsa1h91ehQlVbuQbmIBSRmxpuO/Xs3BHNW0sOHSk3eEBNo +GTXsyT6AWl/GIQd2UPAnfQ4q+BudlRYEYWo3nD2a6f8Tjkuh6CobuV6kEYsKVFBidDX wE3A4VBWFXuSwkRff9FiUANC402UflY3beQ2M++vHSXrBP8ZFcuB1kquwaSgR9pF+UpF 8704ETSu5dcApRwsdWw4ND0yyFh8ogM9AvjmwY8PjFVzbTim3ToSwFTcM6w/khWKcAAO PJb62gmlC8M+I3HX01MpB4ALCDtTCA41/LXKTnep/plA1wQcv9E3Ieuisg4ruevuMm1n QDaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b=Te252XxF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u17-20020a056a00125100b0056618176fd4si22273392pfi.148.2023.01.13.04.45.51; Fri, 13 Jan 2023 04:46:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b=Te252XxF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241674AbjAMMpU (ORCPT + 99 others); Fri, 13 Jan 2023 07:45:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241857AbjAMMnt (ORCPT ); Fri, 13 Jan 2023 07:43:49 -0500 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DF0716584 for ; Fri, 13 Jan 2023 04:36:20 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id v6so8991572ejg.6 for ; Fri, 13 Jan 2023 04:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sQNKuz5965naByKUS4y1VIo8yUx5dsUc2Lu+3dW2kE8=; b=Te252XxFJERmj6gsHMX2Ubll+K8vuDQpcz/sz6kK4szts0nTB0oktTg5ouLmIRjLKF Zi4O4udWR6to0zU4y5FjIy+WfgYAdAPl/2WYiHxedaBhxqSCXFiCDixV/CsaA31qm7tJ ynai0z9jDaha4KBuIJosdtZwVtdFA6yn4MgEsFOm13UnwoMG0wOCFyS+xo2g9Pv0Teh6 WsGFI9coLfTp7oEzWszSuZfc5ZARh1nXay20UzR7Bb9SWH4hfzkPfXpmbuyAEHS59PNz RA6E4YaegtTU5Gcec8wZ9mxcOV4lpje8yFY4O9dpV0y5TGYlrWuVKTrkZ8jCRbdEyE3U woPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sQNKuz5965naByKUS4y1VIo8yUx5dsUc2Lu+3dW2kE8=; b=3WA4maLWvVCn6kXmvIc46GzgIfxmLTtXDGvD1ynfAFPlQS0xbFd7jXiSpNUlcNxsq8 jTY/hRWBLOpVnJoys8qTHdi/br5GgAT5D530u6e4Xpi7c9W3+Fu6dImCV34PNXese9Wm Kkf/bb3ilTt60go9SUcC+EPbi0bSmcKAHKDBuYz+81JnFKpeGqKAw1JfcBxbfgeE9/J9 vvWlcy7EHf6thR1AHCMrh4cDY1sDIC4/VZpfGCktSXR1OQel8dIzebTtBiJtSZp1+R5O P7BXa3zywIaNPZy15LbweU4uazEWH8SiAbUoShNUH3Kg2cL8j2eXWpqpwesf7s9aV1FI hVYQ== X-Gm-Message-State: AFqh2ko5DQ89eOkQ835bFoGDKwgq2bjd5rD0MZz8a/tqTZR2SaFKJSk7 H96fCPjkA3Yw/2ow9DKeoZxf3g== X-Received: by 2002:a17:907:1710:b0:7c0:c36d:f5df with SMTP id le16-20020a170907171000b007c0c36df5dfmr83242439ejc.70.1673613343347; Fri, 13 Jan 2023 04:35:43 -0800 (PST) Received: from localhost.localdomain (h082218028181.host.wavenet.at. [82.218.28.181]) by smtp.gmail.com with ESMTPSA id 17-20020a170906329100b007c0bb571da5sm8402496ejw.41.2023.01.13.04.35.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 04:35:42 -0800 (PST) From: =?utf-8?q?Christoph_B=C3=B6hmwalder?= To: Jens Axboe Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, Lars Ellenberg , Philipp Reisner , linux-block@vger.kernel.org, =?utf-8?q?Christoph_B=C3=B6hmwalder?= , Joel Colledge Subject: [PATCH 1/8] drbd: adjust drbd_limits license header Date: Fri, 13 Jan 2023 13:35:31 +0100 Message-Id: <20230113123538.144276-2-christoph.boehmwalder@linbit.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> References: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754911438379218465?= X-GMAIL-MSGID: =?utf-8?q?1754911438379218465?= See also commit 93c68cc46a07 ("drbd: use consistent license"). We only want to license drbd under GPL-2.0, so use the corresponding SPDX header consistently. Signed-off-by: Christoph Böhmwalder Reviewed-by: Joel Colledge --- include/linux/drbd_limits.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/drbd_limits.h b/include/linux/drbd_limits.h index 9e33f7038bea..d64271ccece4 100644 --- a/include/linux/drbd_limits.h +++ b/include/linux/drbd_limits.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0 */ +/* SPDX-License-Identifier: GPL-2.0-only */ /* drbd_limits.h This file is part of DRBD by Philipp Reisner and Lars Ellenberg. From patchwork Fri Jan 13 12:35:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christoph_B=C3=B6hmwalder?= X-Patchwork-Id: 43285 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp248155wrt; Fri, 13 Jan 2023 04:47:02 -0800 (PST) X-Google-Smtp-Source: AMrXdXvoAA63WMcxEwMK2okU2VneY+Am5bgzt7rkg3TkmB4sj1ipocTEptOEKeVOs85JakgaBm/o X-Received: by 2002:aa7:85d5:0:b0:582:6732:ee0b with SMTP id z21-20020aa785d5000000b005826732ee0bmr10237203pfn.28.1673614022297; Fri, 13 Jan 2023 04:47:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673614022; cv=none; d=google.com; s=arc-20160816; b=lv4SGlp7i4ClE4464hH8ClBr1TsI7Z4MQt4x8rOVPTcQjDToaex43r81UpEV/gQPbX yoklgJbcygPOJdhXq/iSHLely05mI3u4OXdqZ97vsY76fh/esMCvyYL3trooRJX78FVl uTLn8O/mTx7kiKXoCPkKrXrsW1PC3wo0rG+x2LI8pFioRI6nceRo3uDmxgR293Kl9QLw RIIHtfIEM+xH+b5qRazIwJCTjyf88iLHObpuPQTpxL2d9ll58XYXbSQKU8VM0kajc0dM wqVrRV2Tb9Kr0S66rhxuJpMNFC6tKd1aqlUccF6ZsF3IEyWbVZIJbZ88xsK7vfgXmpTQ bXig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HcVlem0HZR7YKz5CwTwpHOGM7j8McIJNietyZfce8tM=; b=S7ImFXeODOM2DaCo3ak65sg/WyRjEyxJU+Pa945JTz3QHZLt0IqOO/VGQwHryyiZ/+ NUKNqWd0NkIaKzh7qX/YrHpoUTNvLJh5H4LWDVWiU5YK9vThDb51kw+L5Fqqrm9E/YLa MH9uXJhA7GGIeEwkvD59Dg6fYZ5n6bZcMYQt+AvgYukX/Gur95qnQXAm8ehkVwTT6YAj jAK1h3vc65/jsxJHX7qP59U8WgfiBIYfZlniVubpFdtmS4G5QVWWlYR009fB+uv16cdl RTf9HYqA2WE+GS2fRXrbUTTlB1N2EC5dwITx7wILpgEmTlxvmMNzlZizCi465U18vQUP /ZaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b="lG6G/hEi"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v27-20020aa799db000000b0058bb792cdeesi2153111pfi.317.2023.01.13.04.46.50; Fri, 13 Jan 2023 04:47:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b="lG6G/hEi"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241573AbjAMMpZ (ORCPT + 99 others); Fri, 13 Jan 2023 07:45:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241928AbjAMMoI (ORCPT ); Fri, 13 Jan 2023 07:44:08 -0500 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E2BA3D5E4 for ; Fri, 13 Jan 2023 04:36:24 -0800 (PST) Received: by mail-ej1-x62b.google.com with SMTP id az20so32929109ejc.1 for ; Fri, 13 Jan 2023 04:36:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HcVlem0HZR7YKz5CwTwpHOGM7j8McIJNietyZfce8tM=; b=lG6G/hEiefVVw2KVntwXpYtJaFeZcpH/bmr8zyHNCudsGl5VmkDU4N+8sUHUREXchX 9t4DexO2EUVb8fflnf450J/HAESsipmjohr0+8leLKzThOAy98UQ2LNsyLzog2q6Kzi+ QVc7cJtKfrFOMAyGHpbwA7+OSX5P+PCXYau7IJ/hQGeeG8IpWzilFfaTpUp/ICcu55XU EWCiyQyNs3M3/+PLd/ykAbv6s4xWjuiggSTvES0cZ505UVSpnzqJxFikHe08w8as1LD7 eZUOw5vgYoOmRVieRXXUIyiZkfFZ95VHB7frMXY1SD9V03Qlh0ffq17r7g+1O8AfcAJ8 iNag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HcVlem0HZR7YKz5CwTwpHOGM7j8McIJNietyZfce8tM=; b=miA7YI6qVMDz4dCAEmln+QmqVroLcPGa3bG2Ic6Vl67VGzJ2+lP7nUva6LiKETcrSo e8lfNeKqGGqRTpjh3KxgysJZVSBI/3nDkknGTDsWG2CM/0neZfBk6eC9ZWisKYvTPq4s PKBzK/sv694r0sOjqj9NxodeF7c5oPAAEqgOLv1dTamwaLANKjrmZZ+DrczyF9tKoDqa ck7Jn7mp6ug3J+nJv6veE44XjXI7A/AHoPLEVctiGbRAuzUY1DxTbntZ0KwyYM9WZ1la jVHEXeStUQ91Ysw6jC9I4WxFKbDNplzjgpQKTT7wp2GPAdLcx9ZZE7Qmg1ybbHbtDA2Y Kbxw== X-Gm-Message-State: AFqh2kop5xlXbJoUH/TMRk+D6/QkYgCLg8xwWtN5ZhpgvukDshm5A6H8 t2/fJIJaum0PQKmy1yEt6MjaGw== X-Received: by 2002:a17:907:8b89:b0:7c1:6f86:eeb with SMTP id tb9-20020a1709078b8900b007c16f860eebmr66679431ejc.7.1673613344302; Fri, 13 Jan 2023 04:35:44 -0800 (PST) Received: from localhost.localdomain (h082218028181.host.wavenet.at. [82.218.28.181]) by smtp.gmail.com with ESMTPSA id 17-20020a170906329100b007c0bb571da5sm8402496ejw.41.2023.01.13.04.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 04:35:43 -0800 (PST) From: =?utf-8?q?Christoph_B=C3=B6hmwalder?= To: Jens Axboe Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, Lars Ellenberg , Philipp Reisner , linux-block@vger.kernel.org, Robert Altnoeder , =?utf-8?q?Christoph_B=C3=B6?= =?utf-8?q?hmwalder?= , Joel Colledge Subject: [PATCH 2/8] drbd: fix DRBD_VOLUME_MAX 65535 -> 65534 Date: Fri, 13 Jan 2023 13:35:32 +0100 Message-Id: <20230113123538.144276-3-christoph.boehmwalder@linbit.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> References: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754911497354710315?= X-GMAIL-MSGID: =?utf-8?q?1754911497354710315?= From: Robert Altnoeder The protocol uses -1 as a reserved value for 'no specific volume', and since the protocol field is a 16 bit unsigned value, -1 is converted to 65535. Therefore, limit the range of valid volume numbers to [0, 65534]. Signed-off-by: Robert Altnoeder Signed-off-by: Christoph Böhmwalder Reviewed-by: Joel Colledge --- include/linux/drbd_limits.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/drbd_limits.h b/include/linux/drbd_limits.h index d64271ccece4..058f7600f79c 100644 --- a/include/linux/drbd_limits.h +++ b/include/linux/drbd_limits.h @@ -21,7 +21,7 @@ #define DRBD_MINOR_COUNT_DEF 32 #define DRBD_MINOR_COUNT_SCALE '1' -#define DRBD_VOLUME_MAX 65535 +#define DRBD_VOLUME_MAX 65534 #define DRBD_DIALOG_REFRESH_MIN 0 #define DRBD_DIALOG_REFRESH_MAX 600 From patchwork Fri Jan 13 12:35:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christoph_B=C3=B6hmwalder?= X-Patchwork-Id: 43283 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp247931wrt; Fri, 13 Jan 2023 04:46:35 -0800 (PST) X-Google-Smtp-Source: AMrXdXtcDsU1kvRFcz2oo5EzaDgkWOnnHLAAcp97n4yBtQq+LfGw4YkLpyjmvAp+rakMj8sQNu/P X-Received: by 2002:a17:90a:294f:b0:226:f7f6:ad2f with SMTP id x15-20020a17090a294f00b00226f7f6ad2fmr23756114pjf.38.1673613995438; Fri, 13 Jan 2023 04:46:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673613995; cv=none; d=google.com; s=arc-20160816; b=X3Bsbt0/nOhaLXfBfGzrwWJeMHFNlUf9J5hBxquA/plSQ5+aUSSMSVVbmW5NMOA9AZ TGxyMkvquxpP08W/TKlfcz93BVu29Nmq1Mfg18JhPws8FCpM87XWDQPSw0zZrFkFoUBw GL8KELS84q+EdNgd5nfSaJTw1lqhEpOmpz8coORR+bza3bkub2dP5u4wUFqTUs12nPJW 5Oyiv/L7+H1KSy8iLgxwMaytD3KB9OojBJ3tMR57NCoIX/6IuMKFd3RWQYrdqKMZ+E8r xY34o2zLXL/P2b99ZnJBa3x/W35ydVdqBTBVhkOfArnvMFNT+/Z5lP020RDsU9dee2LF Id4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Q42egUmEzuPqHWtFCe0+w1qRK0bznL4xm46gw6YdelU=; b=d0CDrQcZZO2++vG6GnkVvGZC0M6ZKIKnVbm1qWe609k+5dPi2ZqcuWU8yi7HYTEhOC is1yYL2DsCXv5hpSC8+r1K0JQyJE6Gug0YYibJs26GBgD0Xlr2c/6wobgVzFXstnhW7T WHJlZ7O3HdanxOyfrtI8UaNLXMJOSzwpJPakxQ3uH6ueoCUHXhFxlNtDjmUcgogAQsJ1 H4ZtpKS5hwCsO/8w/dr8t066AIeCnkLL46PDPSfcBdaYkaTcS3K4f57hKjnR6z9WHqre WVP5vRg0r0AB/oNHNsmMSZrrTR1AlKP+Wywq52E6Y7g4ShyFR0TPX1pAzWaMcO7u6AGk UWpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b=N5XvOWhm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y19-20020a63e253000000b00477b463b042si21552975pgj.377.2023.01.13.04.46.21; Fri, 13 Jan 2023 04:46:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b=N5XvOWhm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241776AbjAMMps (ORCPT + 99 others); Fri, 13 Jan 2023 07:45:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241957AbjAMMoM (ORCPT ); Fri, 13 Jan 2023 07:44:12 -0500 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEF323E0E0 for ; Fri, 13 Jan 2023 04:36:25 -0800 (PST) Received: by mail-ej1-x629.google.com with SMTP id mp20so5395971ejc.7 for ; Fri, 13 Jan 2023 04:36:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q42egUmEzuPqHWtFCe0+w1qRK0bznL4xm46gw6YdelU=; b=N5XvOWhmZAIxoqz0Mv8fo7mI6busGg9qPdX3HilGBwZQxgFvj+4vVuZndJoENqpEsa hLEsBoy3BrNWRRpFJMhjrKnFtsW5QRZ1vVOZK2Z8+8kYz8uy12xZ2+JNMz+Km8bSQ5/F KVLf/VgDjgMfxaPkrWX5QZhf3xVU6+BJqrgUE8MamG4P3iojy8MDaI6WxLI8R5jyDzbg x2UISx1ynqccb1aK4lvyzA5luhJOHxj6SmMHtA0rm6dKYxhCsocA4seaj+taXZD1LH+A qzwrwnHNJqE1ko9RHKZvjI0dKkwvnRvycZsFWC6TxiO7s2V3WnlyCkptC9ywktGJevvS Tdvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q42egUmEzuPqHWtFCe0+w1qRK0bznL4xm46gw6YdelU=; b=g5uJXkShfw85obAvOMVdaicO1IyDBHhaV8OYn/A1w6yk+C/K10Ef68N28KlQRzWxOf hzB/gyAmmi1wkxIh2aPEDsBfMf4brFCiY+Rfu3MUmznlJcsGiymB4vDE+VQgOwygbfpG SOosNnQ6l3672cXDYyDC6iq5xRbHjmSxOdlJLlPGpEuv27QS3WEXUaRhHxrdeDyvg5nH U7w6+iN+mT+L5098IhglWwUlsnIoNP7sjjbaAzu5Sul2PmWGsZefc3vtJu+tvjnUDfWg Y+pflPtoIIARexTCpvLZB/fFEU7XmnT+rn/bK7DZDQqzE3FobCIK+CyXMz0zawsnFE/w X85w== X-Gm-Message-State: AFqh2kq1hIENCKpxC+ddhlCO67LRF5hrMUzUGy5KOdRhjqiTPG3anLc+ vEf43/FoMWnm1CcmoDp8IvfNGA== X-Received: by 2002:a17:906:5f98:b0:84d:1b67:cecb with SMTP id a24-20020a1709065f9800b0084d1b67cecbmr22933542eju.43.1673613345049; Fri, 13 Jan 2023 04:35:45 -0800 (PST) Received: from localhost.localdomain (h082218028181.host.wavenet.at. [82.218.28.181]) by smtp.gmail.com with ESMTPSA id 17-20020a170906329100b007c0bb571da5sm8402496ejw.41.2023.01.13.04.35.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 04:35:44 -0800 (PST) From: =?utf-8?q?Christoph_B=C3=B6hmwalder?= To: Jens Axboe Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, Lars Ellenberg , Philipp Reisner , linux-block@vger.kernel.org, =?utf-8?q?Christoph_B=C3=B6hmwalder?= , Joel Colledge Subject: [PATCH 3/8] drbd: make limits unsigned Date: Fri, 13 Jan 2023 13:35:33 +0100 Message-Id: <20230113123538.144276-4-christoph.boehmwalder@linbit.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> References: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,UPPERCASE_50_75 autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754911468495693520?= X-GMAIL-MSGID: =?utf-8?q?1754911468495693520?= These are almost always used as unsigned integers, so mark them as such. Signed-off-by: Christoph Böhmwalder Reviewed-by: Joel Colledge --- include/linux/drbd_limits.h | 202 ++++++++++++++++++------------------ 1 file changed, 101 insertions(+), 101 deletions(-) diff --git a/include/linux/drbd_limits.h b/include/linux/drbd_limits.h index 058f7600f79c..5b042fb427e9 100644 --- a/include/linux/drbd_limits.h +++ b/include/linux/drbd_limits.h @@ -16,123 +16,123 @@ #define DEBUG_RANGE_CHECK 0 -#define DRBD_MINOR_COUNT_MIN 1 -#define DRBD_MINOR_COUNT_MAX 255 -#define DRBD_MINOR_COUNT_DEF 32 +#define DRBD_MINOR_COUNT_MIN 1U +#define DRBD_MINOR_COUNT_MAX 255U +#define DRBD_MINOR_COUNT_DEF 32U #define DRBD_MINOR_COUNT_SCALE '1' -#define DRBD_VOLUME_MAX 65534 +#define DRBD_VOLUME_MAX 65534U -#define DRBD_DIALOG_REFRESH_MIN 0 -#define DRBD_DIALOG_REFRESH_MAX 600 +#define DRBD_DIALOG_REFRESH_MIN 0U +#define DRBD_DIALOG_REFRESH_MAX 600U #define DRBD_DIALOG_REFRESH_SCALE '1' /* valid port number */ -#define DRBD_PORT_MIN 1 -#define DRBD_PORT_MAX 0xffff +#define DRBD_PORT_MIN 1U +#define DRBD_PORT_MAX 0xffffU #define DRBD_PORT_SCALE '1' /* startup { */ /* if you want more than 3.4 days, disable */ -#define DRBD_WFC_TIMEOUT_MIN 0 -#define DRBD_WFC_TIMEOUT_MAX 300000 -#define DRBD_WFC_TIMEOUT_DEF 0 +#define DRBD_WFC_TIMEOUT_MIN 0U +#define DRBD_WFC_TIMEOUT_MAX 300000U +#define DRBD_WFC_TIMEOUT_DEF 0U #define DRBD_WFC_TIMEOUT_SCALE '1' -#define DRBD_DEGR_WFC_TIMEOUT_MIN 0 -#define DRBD_DEGR_WFC_TIMEOUT_MAX 300000 -#define DRBD_DEGR_WFC_TIMEOUT_DEF 0 +#define DRBD_DEGR_WFC_TIMEOUT_MIN 0U +#define DRBD_DEGR_WFC_TIMEOUT_MAX 300000U +#define DRBD_DEGR_WFC_TIMEOUT_DEF 0U #define DRBD_DEGR_WFC_TIMEOUT_SCALE '1' -#define DRBD_OUTDATED_WFC_TIMEOUT_MIN 0 -#define DRBD_OUTDATED_WFC_TIMEOUT_MAX 300000 -#define DRBD_OUTDATED_WFC_TIMEOUT_DEF 0 +#define DRBD_OUTDATED_WFC_TIMEOUT_MIN 0U +#define DRBD_OUTDATED_WFC_TIMEOUT_MAX 300000U +#define DRBD_OUTDATED_WFC_TIMEOUT_DEF 0U #define DRBD_OUTDATED_WFC_TIMEOUT_SCALE '1' /* }*/ /* net { */ /* timeout, unit centi seconds * more than one minute timeout is not useful */ -#define DRBD_TIMEOUT_MIN 1 -#define DRBD_TIMEOUT_MAX 600 -#define DRBD_TIMEOUT_DEF 60 /* 6 seconds */ +#define DRBD_TIMEOUT_MIN 1U +#define DRBD_TIMEOUT_MAX 600U +#define DRBD_TIMEOUT_DEF 60U /* 6 seconds */ #define DRBD_TIMEOUT_SCALE '1' /* If backing disk takes longer than disk_timeout, mark the disk as failed */ -#define DRBD_DISK_TIMEOUT_MIN 0 /* 0 = disabled */ -#define DRBD_DISK_TIMEOUT_MAX 6000 /* 10 Minutes */ -#define DRBD_DISK_TIMEOUT_DEF 0 /* disabled */ +#define DRBD_DISK_TIMEOUT_MIN 0U /* 0 = disabled */ +#define DRBD_DISK_TIMEOUT_MAX 6000U /* 10 Minutes */ +#define DRBD_DISK_TIMEOUT_DEF 0U /* disabled */ #define DRBD_DISK_TIMEOUT_SCALE '1' /* active connection retries when C_WF_CONNECTION */ -#define DRBD_CONNECT_INT_MIN 1 -#define DRBD_CONNECT_INT_MAX 120 -#define DRBD_CONNECT_INT_DEF 10 /* seconds */ +#define DRBD_CONNECT_INT_MIN 1U +#define DRBD_CONNECT_INT_MAX 120U +#define DRBD_CONNECT_INT_DEF 10U /* seconds */ #define DRBD_CONNECT_INT_SCALE '1' /* keep-alive probes when idle */ -#define DRBD_PING_INT_MIN 1 -#define DRBD_PING_INT_MAX 120 -#define DRBD_PING_INT_DEF 10 +#define DRBD_PING_INT_MIN 1U +#define DRBD_PING_INT_MAX 120U +#define DRBD_PING_INT_DEF 10U #define DRBD_PING_INT_SCALE '1' /* timeout for the ping packets.*/ -#define DRBD_PING_TIMEO_MIN 1 -#define DRBD_PING_TIMEO_MAX 300 -#define DRBD_PING_TIMEO_DEF 5 +#define DRBD_PING_TIMEO_MIN 1U +#define DRBD_PING_TIMEO_MAX 300U +#define DRBD_PING_TIMEO_DEF 5U #define DRBD_PING_TIMEO_SCALE '1' /* max number of write requests between write barriers */ -#define DRBD_MAX_EPOCH_SIZE_MIN 1 -#define DRBD_MAX_EPOCH_SIZE_MAX 20000 -#define DRBD_MAX_EPOCH_SIZE_DEF 2048 +#define DRBD_MAX_EPOCH_SIZE_MIN 1U +#define DRBD_MAX_EPOCH_SIZE_MAX 20000U +#define DRBD_MAX_EPOCH_SIZE_DEF 2048U #define DRBD_MAX_EPOCH_SIZE_SCALE '1' /* I don't think that a tcp send buffer of more than 10M is useful */ -#define DRBD_SNDBUF_SIZE_MIN 0 -#define DRBD_SNDBUF_SIZE_MAX (10<<20) -#define DRBD_SNDBUF_SIZE_DEF 0 +#define DRBD_SNDBUF_SIZE_MIN 0U +#define DRBD_SNDBUF_SIZE_MAX (10U<<20) +#define DRBD_SNDBUF_SIZE_DEF 0U #define DRBD_SNDBUF_SIZE_SCALE '1' -#define DRBD_RCVBUF_SIZE_MIN 0 -#define DRBD_RCVBUF_SIZE_MAX (10<<20) -#define DRBD_RCVBUF_SIZE_DEF 0 +#define DRBD_RCVBUF_SIZE_MIN 0U +#define DRBD_RCVBUF_SIZE_MAX (10U<<20) +#define DRBD_RCVBUF_SIZE_DEF 0U #define DRBD_RCVBUF_SIZE_SCALE '1' /* @4k PageSize -> 128kB - 512MB */ -#define DRBD_MAX_BUFFERS_MIN 32 -#define DRBD_MAX_BUFFERS_MAX 131072 -#define DRBD_MAX_BUFFERS_DEF 2048 +#define DRBD_MAX_BUFFERS_MIN 32U +#define DRBD_MAX_BUFFERS_MAX 131072U +#define DRBD_MAX_BUFFERS_DEF 2048U #define DRBD_MAX_BUFFERS_SCALE '1' /* @4k PageSize -> 4kB - 512MB */ -#define DRBD_UNPLUG_WATERMARK_MIN 1 -#define DRBD_UNPLUG_WATERMARK_MAX 131072 +#define DRBD_UNPLUG_WATERMARK_MIN 1U +#define DRBD_UNPLUG_WATERMARK_MAX 131072U #define DRBD_UNPLUG_WATERMARK_DEF (DRBD_MAX_BUFFERS_DEF/16) #define DRBD_UNPLUG_WATERMARK_SCALE '1' /* 0 is disabled. * 200 should be more than enough even for very short timeouts */ -#define DRBD_KO_COUNT_MIN 0 -#define DRBD_KO_COUNT_MAX 200 -#define DRBD_KO_COUNT_DEF 7 +#define DRBD_KO_COUNT_MIN 0U +#define DRBD_KO_COUNT_MAX 200U +#define DRBD_KO_COUNT_DEF 7U #define DRBD_KO_COUNT_SCALE '1' /* } */ /* syncer { */ /* FIXME allow rate to be zero? */ -#define DRBD_RESYNC_RATE_MIN 1 +#define DRBD_RESYNC_RATE_MIN 1U /* channel bonding 10 GbE, or other hardware */ #define DRBD_RESYNC_RATE_MAX (4 << 20) -#define DRBD_RESYNC_RATE_DEF 250 +#define DRBD_RESYNC_RATE_DEF 250U #define DRBD_RESYNC_RATE_SCALE 'k' /* kilobytes */ -#define DRBD_AL_EXTENTS_MIN 67 +#define DRBD_AL_EXTENTS_MIN 67U /* we use u16 as "slot number", (u16)~0 is "FREE". * If you use >= 292 kB on-disk ring buffer, * this is the maximum you can use: */ -#define DRBD_AL_EXTENTS_MAX 0xfffe -#define DRBD_AL_EXTENTS_DEF 1237 +#define DRBD_AL_EXTENTS_MAX 0xfffeU +#define DRBD_AL_EXTENTS_DEF 1237U #define DRBD_AL_EXTENTS_SCALE '1' #define DRBD_MINOR_NUMBER_MIN -1 @@ -147,9 +147,9 @@ * the upper limit with 64bit kernel, enough ram and flexible meta data * is 1 PiB, currently. */ /* DRBD_MAX_SECTORS */ -#define DRBD_DISK_SIZE_MIN 0 -#define DRBD_DISK_SIZE_MAX (1 * (2LLU << 40)) -#define DRBD_DISK_SIZE_DEF 0 /* = disabled = no user size... */ +#define DRBD_DISK_SIZE_MIN 0LLU +#define DRBD_DISK_SIZE_MAX (1LLU * (2LLU << 40)) +#define DRBD_DISK_SIZE_DEF 0LLU /* = disabled = no user size... */ #define DRBD_DISK_SIZE_SCALE 's' /* sectors */ #define DRBD_ON_IO_ERROR_DEF EP_DETACH @@ -162,39 +162,39 @@ #define DRBD_ON_CONGESTION_DEF OC_BLOCK #define DRBD_READ_BALANCING_DEF RB_PREFER_LOCAL -#define DRBD_MAX_BIO_BVECS_MIN 0 -#define DRBD_MAX_BIO_BVECS_MAX 128 -#define DRBD_MAX_BIO_BVECS_DEF 0 +#define DRBD_MAX_BIO_BVECS_MIN 0U +#define DRBD_MAX_BIO_BVECS_MAX 128U +#define DRBD_MAX_BIO_BVECS_DEF 0U #define DRBD_MAX_BIO_BVECS_SCALE '1' -#define DRBD_C_PLAN_AHEAD_MIN 0 -#define DRBD_C_PLAN_AHEAD_MAX 300 -#define DRBD_C_PLAN_AHEAD_DEF 20 +#define DRBD_C_PLAN_AHEAD_MIN 0U +#define DRBD_C_PLAN_AHEAD_MAX 300U +#define DRBD_C_PLAN_AHEAD_DEF 20U #define DRBD_C_PLAN_AHEAD_SCALE '1' -#define DRBD_C_DELAY_TARGET_MIN 1 -#define DRBD_C_DELAY_TARGET_MAX 100 -#define DRBD_C_DELAY_TARGET_DEF 10 +#define DRBD_C_DELAY_TARGET_MIN 1U +#define DRBD_C_DELAY_TARGET_MAX 100U +#define DRBD_C_DELAY_TARGET_DEF 10U #define DRBD_C_DELAY_TARGET_SCALE '1' -#define DRBD_C_FILL_TARGET_MIN 0 -#define DRBD_C_FILL_TARGET_MAX (1<<20) /* 500MByte in sec */ -#define DRBD_C_FILL_TARGET_DEF 100 /* Try to place 50KiB in socket send buffer during resync */ +#define DRBD_C_FILL_TARGET_MIN 0U +#define DRBD_C_FILL_TARGET_MAX (1U<<20) /* 500MByte in sec */ +#define DRBD_C_FILL_TARGET_DEF 100U /* Try to place 50KiB in socket send buffer during resync */ #define DRBD_C_FILL_TARGET_SCALE 's' /* sectors */ -#define DRBD_C_MAX_RATE_MIN 250 -#define DRBD_C_MAX_RATE_MAX (4 << 20) -#define DRBD_C_MAX_RATE_DEF 102400 +#define DRBD_C_MAX_RATE_MIN 250U +#define DRBD_C_MAX_RATE_MAX (4U << 20) +#define DRBD_C_MAX_RATE_DEF 102400U #define DRBD_C_MAX_RATE_SCALE 'k' /* kilobytes */ -#define DRBD_C_MIN_RATE_MIN 0 -#define DRBD_C_MIN_RATE_MAX (4 << 20) -#define DRBD_C_MIN_RATE_DEF 250 +#define DRBD_C_MIN_RATE_MIN 0U +#define DRBD_C_MIN_RATE_MAX (4U << 20) +#define DRBD_C_MIN_RATE_DEF 250U #define DRBD_C_MIN_RATE_SCALE 'k' /* kilobytes */ -#define DRBD_CONG_FILL_MIN 0 -#define DRBD_CONG_FILL_MAX (10<<21) /* 10GByte in sectors */ -#define DRBD_CONG_FILL_DEF 0 +#define DRBD_CONG_FILL_MIN 0U +#define DRBD_CONG_FILL_MAX (10U<<21) /* 10GByte in sectors */ +#define DRBD_CONG_FILL_DEF 0U #define DRBD_CONG_FILL_SCALE 's' /* sectors */ #define DRBD_CONG_EXTENTS_MIN DRBD_AL_EXTENTS_MIN @@ -204,48 +204,48 @@ #define DRBD_PROTOCOL_DEF DRBD_PROT_C -#define DRBD_DISK_BARRIER_DEF 0 -#define DRBD_DISK_FLUSHES_DEF 1 -#define DRBD_DISK_DRAIN_DEF 1 -#define DRBD_MD_FLUSHES_DEF 1 -#define DRBD_TCP_CORK_DEF 1 -#define DRBD_AL_UPDATES_DEF 1 +#define DRBD_DISK_BARRIER_DEF 0U +#define DRBD_DISK_FLUSHES_DEF 1U +#define DRBD_DISK_DRAIN_DEF 1U +#define DRBD_MD_FLUSHES_DEF 1U +#define DRBD_TCP_CORK_DEF 1U +#define DRBD_AL_UPDATES_DEF 1U /* We used to ignore the discard_zeroes_data setting. * To not change established (and expected) behaviour, * by default assume that, for discard_zeroes_data=0, * we can make that an effective discard_zeroes_data=1, * if we only explicitly zero-out unaligned partial chunks. */ -#define DRBD_DISCARD_ZEROES_IF_ALIGNED_DEF 1 +#define DRBD_DISCARD_ZEROES_IF_ALIGNED_DEF 1U /* Some backends pretend to support WRITE SAME, * but fail such requests when they are actually submitted. * This is to tell DRBD to not even try. */ -#define DRBD_DISABLE_WRITE_SAME_DEF 0 +#define DRBD_DISABLE_WRITE_SAME_DEF 0U -#define DRBD_ALLOW_TWO_PRIMARIES_DEF 0 -#define DRBD_ALWAYS_ASBP_DEF 0 -#define DRBD_USE_RLE_DEF 1 -#define DRBD_CSUMS_AFTER_CRASH_ONLY_DEF 0 +#define DRBD_ALLOW_TWO_PRIMARIES_DEF 0U +#define DRBD_ALWAYS_ASBP_DEF 0U +#define DRBD_USE_RLE_DEF 1U +#define DRBD_CSUMS_AFTER_CRASH_ONLY_DEF 0U -#define DRBD_AL_STRIPES_MIN 1 -#define DRBD_AL_STRIPES_MAX 1024 -#define DRBD_AL_STRIPES_DEF 1 +#define DRBD_AL_STRIPES_MIN 1U +#define DRBD_AL_STRIPES_MAX 1024U +#define DRBD_AL_STRIPES_DEF 1U #define DRBD_AL_STRIPES_SCALE '1' -#define DRBD_AL_STRIPE_SIZE_MIN 4 -#define DRBD_AL_STRIPE_SIZE_MAX 16777216 -#define DRBD_AL_STRIPE_SIZE_DEF 32 +#define DRBD_AL_STRIPE_SIZE_MIN 4U +#define DRBD_AL_STRIPE_SIZE_MAX 16777216U +#define DRBD_AL_STRIPE_SIZE_DEF 32U #define DRBD_AL_STRIPE_SIZE_SCALE 'k' /* kilobytes */ -#define DRBD_SOCKET_CHECK_TIMEO_MIN 0 +#define DRBD_SOCKET_CHECK_TIMEO_MIN 0U #define DRBD_SOCKET_CHECK_TIMEO_MAX DRBD_PING_TIMEO_MAX -#define DRBD_SOCKET_CHECK_TIMEO_DEF 0 +#define DRBD_SOCKET_CHECK_TIMEO_DEF 0U #define DRBD_SOCKET_CHECK_TIMEO_SCALE '1' -#define DRBD_RS_DISCARD_GRANULARITY_MIN 0 -#define DRBD_RS_DISCARD_GRANULARITY_MAX (1<<20) /* 1MiByte */ -#define DRBD_RS_DISCARD_GRANULARITY_DEF 0 /* disabled by default */ +#define DRBD_RS_DISCARD_GRANULARITY_MIN 0U +#define DRBD_RS_DISCARD_GRANULARITY_MAX (1U<<20) /* 1MiByte */ +#define DRBD_RS_DISCARD_GRANULARITY_DEF 0U /* disabled by default */ #define DRBD_RS_DISCARD_GRANULARITY_SCALE '1' /* bytes */ #endif From patchwork Fri Jan 13 12:35:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christoph_B=C3=B6hmwalder?= X-Patchwork-Id: 43284 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp248036wrt; Fri, 13 Jan 2023 04:46:48 -0800 (PST) X-Google-Smtp-Source: AMrXdXtRpG8YgK4sx/ExyMx/py0iq+AcnqooL0UP4HbFzO7n0YyjLMweHW4kAatSCXE2/ntF7lUk X-Received: by 2002:a17:90b:3017:b0:228:e0c2:b0ec with SMTP id hg23-20020a17090b301700b00228e0c2b0ecmr10974293pjb.6.1673614007781; Fri, 13 Jan 2023 04:46:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673614007; cv=none; d=google.com; s=arc-20160816; b=irE1pEJcjxUKqf4B0BUMfDD5bCo2fGHQ4sYFJUTLzGu63ro0UjxnUbNfE5EdfFFRaw fW/i1n4YDpoKstZvOjrxVJqBfHU1YapFmKDCeASXalR8pgkXxadsyECv7VqS7jTQ/Xb3 9e1sL7R329BnSzc9jWiKqWRlhSIIaZppkv2pkld3Qxi9zmZZ0SWEMpaEwwN9L28TpcnB 3xLuP1jeHz58bM+Kr3OZclvS2Qwc3FQrgXlaRc5mxYFakG0cZv7j0+Za1Uz0veEDy2Ni LanFWAlhG2uI3xmtNurcbC8IMbrK5faK+RNox7o69M2yW7vnUNyQpOEH8mBZ40Vn5oFH Fn6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8SGWONfVHjklNBkXRu6sFYgnXokffLko1IC/BWEcSP8=; b=dNbl5LOifQna54xWXzPYcLLjhtdHzcq9SVjHO5hecUkFWom0JF1asOy/PKThHMMXVq h+H+aDwCt0RsNbwx8takKhcQ4qUaKd8LKT6t16luvNnaexMYHB0zqhVOnuWP5fIpvSfn Yf99NtJY0qrubnPhYwdJT9EkEfBaqVjMOxByNV2cc5gkyOcmGtRxUjtM5s/P/L+PaliD 5VyfZbZlLk6yx1INpEKKluIkyfAsIWEuK0xVxC773I+LXDIdDk/dq/NEKdZFKT189uCQ Qjc3zS8kTCdY1siJrQm4gNaHfXAdaCQzIGBdz1elFcYCeLD3FleeIel8vO1jZv1Wmraq 9oHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b=Joe7Sd9H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v189-20020a6389c6000000b004c5f91b954bsi556918pgd.453.2023.01.13.04.46.34; Fri, 13 Jan 2023 04:46:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b=Joe7Sd9H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241788AbjAMMqE (ORCPT + 99 others); Fri, 13 Jan 2023 07:46:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241968AbjAMMoN (ORCPT ); Fri, 13 Jan 2023 07:44:13 -0500 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF1F73E847 for ; Fri, 13 Jan 2023 04:36:26 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id ss4so44745136ejb.11 for ; Fri, 13 Jan 2023 04:36:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8SGWONfVHjklNBkXRu6sFYgnXokffLko1IC/BWEcSP8=; b=Joe7Sd9Hx4Gf2vwVgdgILntRRgbEjXOg1uMsmUrBuUlBqw+V6tmmR9kV6DLRp8BlK1 ceDmU736RBaVBZoQ+8FYfrrs5IvOy6tR8uirV7ddw9x5vp2qzik8heDc2f8Y1mkueEl+ dIelEVxs3O0T5iWPpLTmXn5E/l8duiVzSlpf4rpgk5Ad6eEN0JZNFjZp6ikSwLSFDbpS rHQISTWVPR9ijUstQljd8vTV3syLFWn6W0YrGY/O/ra3yRXVHoxF5lxlNEL+6TQBS7gw V8mffcjHc18bXEs3wF7sbNgTx206HqTvVfHJgHilmfgjWVi+2thqLCLj/mlHGai9WXPh uNvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8SGWONfVHjklNBkXRu6sFYgnXokffLko1IC/BWEcSP8=; b=CCAurj+xENk64mze/NaSb4F/S/odtaKvLHlIMj8MJRIpyg5HOEIQOqU+ZgmdEd/JA3 95a53oo8zlXfZDX7d6njeHkr+9aEKW7BsheZl6Jt3nopQJ7pgbfEpupf3ZzePequ3+yS w2zQ0ajwPxADDh5/wuEad7jCzG1LCxF3YFJw1/CTxirxyxvxqeEeC8BofzDGelnJxPS3 5Q/j3zHkgtfiKxTUkBzToi98ml1CSWevNcQZMM8VQ5TZ+1XQbh+42sBLVcRRohHFqBvX Qjf4C2E9WRj1dG9bC4E0E0mK/y/58RDVDumKW0NiqjcZZ8afjsE+iwliIYTHIh0ZwOTz xvkA== X-Gm-Message-State: AFqh2kqUqJ7PwF3Ot6tvjcrDTAMD0ZqtoLeJS4uwmo7Q60tLdQnCthAa ZEF8nLVUB0QNIdOmuWNO4JkpEA== X-Received: by 2002:a17:906:5042:b0:841:e5b3:c95f with SMTP id e2-20020a170906504200b00841e5b3c95fmr67054967ejk.29.1673613345846; Fri, 13 Jan 2023 04:35:45 -0800 (PST) Received: from localhost.localdomain (h082218028181.host.wavenet.at. [82.218.28.181]) by smtp.gmail.com with ESMTPSA id 17-20020a170906329100b007c0bb571da5sm8402496ejw.41.2023.01.13.04.35.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 04:35:45 -0800 (PST) From: =?utf-8?q?Christoph_B=C3=B6hmwalder?= To: Jens Axboe Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, Lars Ellenberg , Philipp Reisner , linux-block@vger.kernel.org, =?utf-8?q?Christoph_B=C3=B6hmwalder?= , Joel Colledge Subject: [PATCH 4/8] drbd: remove unnecessary assignment in vli_encode_bits Date: Fri, 13 Jan 2023 13:35:34 +0100 Message-Id: <20230113123538.144276-5-christoph.boehmwalder@linbit.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> References: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754911481543422924?= X-GMAIL-MSGID: =?utf-8?q?1754911481543422924?= Signed-off-by: Christoph Böhmwalder Reviewed-by: Joel Colledge --- drivers/block/drbd/drbd_vli.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_vli.h b/drivers/block/drbd/drbd_vli.h index 1ee81e3c2152..941c511cc4da 100644 --- a/drivers/block/drbd/drbd_vli.h +++ b/drivers/block/drbd/drbd_vli.h @@ -327,7 +327,7 @@ static inline int bitstream_get_bits(struct bitstream *bs, u64 *out, int bits) */ static inline int vli_encode_bits(struct bitstream *bs, u64 in) { - u64 code = code; + u64 code; int bits = __vli_encode_bits(&code, in); if (bits <= 0) From patchwork Fri Jan 13 12:35:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christoph_B=C3=B6hmwalder?= X-Patchwork-Id: 43281 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp247796wrt; Fri, 13 Jan 2023 04:46:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXuI7JpmoGSNbOz6naOliQoeZm2ItyGx5qBHrqE736PTPVRaUbQLV+iI8CcIrw7iw2QnhWR2 X-Received: by 2002:a62:2746:0:b0:58b:af27:dcda with SMTP id n67-20020a622746000000b0058baf27dcdamr4027725pfn.14.1673613980691; Fri, 13 Jan 2023 04:46:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673613980; cv=none; d=google.com; s=arc-20160816; b=EQyHTTLzmsv9U+0fvKf4lnfQr0/W7iYsvPlTcO017A5d/iA8KA+bi4TNah1YJKgUVn /KDq/X+cVcr5EmHeqph5AxAK9c+QuEOaJ0bS3Szplk024efYohTqB/TVCMwaZXGFJkSA Zx7Tb4pjVATvzqaZJLaPRfyq4qxGC9Q2QvW2EAAK1Ag1khPUEOD/798p0Bci0Hk3/FFY mFOwVZA/F/g4XdAUCd+8sP+7e2BkGzsvIjx562YPmhEEo7Oir/Y7oZjdNOyOKaXLNmko Nr34L7EyZkPC5ranzyQw/keXOn9+TGRi2Yoy+oR+PrqyIR4D8+hcSWk/hrOjI5aloaJ7 cpMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ROtOQl0iT4Ua6doSdkwJJ3Gv1mhqQe8GXYrZrg3slxM=; b=W91x2It94GxPXYIGc9xzM2/plcbOykbwEs9KyBXeDrQRTNEwVE0J3n3AyXmeAtKyDs rclLP4wg8APFR6Ggl8LAbmePYBfmp7w52kQJkXm5gpNvxXnYDcVufYMSRM+51CDpyKN+ gfxkFkQuQQpn26t2WzhDQScsUMZ5nAVBOXWB3cqavE9S8FYDOZ5Mk6G6mf1wDI/aZN+K mTAUWsIERTcZnSoP+LshlykfxPd15T9Ak2gqeT5zSHx1XJGbbM4s/NO4wShVoao39ytb k1MWcAPXEDg+hCDnpaeV+84s2nWlbPfny48oAVnv7iTM1UPlwCA/0ZRZIHdkHZI0YjqH 3V6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b="ErKW/Txl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y38-20020a056a00182600b0058bbe63c377si1123727pfa.2.2023.01.13.04.46.07; Fri, 13 Jan 2023 04:46:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b="ErKW/Txl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241734AbjAMMpb (ORCPT + 99 others); Fri, 13 Jan 2023 07:45:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241943AbjAMMoL (ORCPT ); Fri, 13 Jan 2023 07:44:11 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF9C33E86B for ; Fri, 13 Jan 2023 04:36:27 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id c17so30961013edj.13 for ; Fri, 13 Jan 2023 04:36:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ROtOQl0iT4Ua6doSdkwJJ3Gv1mhqQe8GXYrZrg3slxM=; b=ErKW/TxlAkHOp6yWMyc0PYQKS3vas/8+4CtSulX5ZBNX8lQJcb++ZtigEvatXIzNe6 kD/LuncciPfQjSE7BmEZmrNUraJOcS5aSzS/KWkviHFHVa2WlI/nfg+ZtDDC2x5ICv54 WJqdCuKUi2pca6TXQdejgPN0R4Od9CDVv8/ZKl+aT3b3Cm75o9M0XqbyIQ5azzLuukGo 5QfuG83/H2UTMigQgtM/ZeE4MqN4JhZAvmMQLIaxKSRUzCtrwY5GDjyRjlzCrctba+OQ ky9Dl5f6NcgrF5Fzc+xUf/eVUlIlSETcnSby4Itn790wXKydl9L8q+QMudSDkFFGDrNF tXnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ROtOQl0iT4Ua6doSdkwJJ3Gv1mhqQe8GXYrZrg3slxM=; b=PTKWHPT3vRQtB03SEEztnveyWdGgSj9L5jusTfMYYKI91ODSSwUPBedzEuE4GHD7X8 tiICTnGHC0zogQ9r8hFzsOCu5vqba3cq4utInpEolRv7KTPwnWJx2+3CUIsxWdT7St+B oVZpiAZ76fWsjG+vQfj2bHUs6CQSgnXSPZxbaY3AcECFZMxupsh+Q8KNrWHWLrOuiWpu zK+CHmgitjx4yaTKKOXYWV+Q7lvoztghswoUGFOmyXHqAn6443C2qmEi9qpVFOXaTyNH efe6VK30TwhvwChANOyi6NC7Ia6Y5qI4RWWxIGt4X7QDllymGdLQTFNTGApKmFNqSd1F nbdA== X-Gm-Message-State: AFqh2kqlqk4ebHWo+xvrVlLouwZBtJcJMw1K2fLFHshabyMIkopVpca4 fQFBO8myAldY1nCZWnv6Linnsg== X-Received: by 2002:aa7:cad0:0:b0:492:8207:f2ba with SMTP id l16-20020aa7cad0000000b004928207f2bamr24829569edt.1.1673613346743; Fri, 13 Jan 2023 04:35:46 -0800 (PST) Received: from localhost.localdomain (h082218028181.host.wavenet.at. [82.218.28.181]) by smtp.gmail.com with ESMTPSA id 17-20020a170906329100b007c0bb571da5sm8402496ejw.41.2023.01.13.04.35.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 04:35:46 -0800 (PST) From: =?utf-8?q?Christoph_B=C3=B6hmwalder?= To: Jens Axboe Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, Lars Ellenberg , Philipp Reisner , linux-block@vger.kernel.org, =?utf-8?q?Christoph_B=C3=B6hmwalder?= , Joel Colledge Subject: [PATCH 5/8] drbd: remove macros using require_context Date: Fri, 13 Jan 2023 13:35:35 +0100 Message-Id: <20230113123538.144276-6-christoph.boehmwalder@linbit.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> References: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754911453270685531?= X-GMAIL-MSGID: =?utf-8?q?1754911453270685531?= This require_context attribute originated in a proposed sparse patch by Philipp Reisner back in 2008. Johannes Berg had a different solution to a similar problem, and that patch "won" in the end; so the require_context thing never got merged. The whole history can be read at [0]. DRBD kept using these annotations anyway for a while. Nowadays, on a modern unmodified sparse, they obviously do nothing, and they are hardly used anymore anyway. So, just remove the definitions of these macros. [0] https://www.spinics.net/lists/linux-sparse/msg01150.html Signed-off-by: Christoph Böhmwalder Reviewed-by: Joel Colledge --- drivers/block/drbd/drbd_int.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h index ae713338aa46..edce1f7ac2da 100644 --- a/drivers/block/drbd/drbd_int.h +++ b/drivers/block/drbd/drbd_int.h @@ -39,16 +39,6 @@ #include "drbd_protocol.h" #include "drbd_polymorph_printk.h" -#ifdef __CHECKER__ -# define __protected_by(x) __attribute__((require_context(x,1,999,"rdwr"))) -# define __protected_read_by(x) __attribute__((require_context(x,1,999,"read"))) -# define __protected_write_by(x) __attribute__((require_context(x,1,999,"write"))) -#else -# define __protected_by(x) -# define __protected_read_by(x) -# define __protected_write_by(x) -#endif - /* shared module parameters, defined in drbd_main.c */ #ifdef CONFIG_DRBD_FAULT_INJECTION extern int drbd_enable_faults; @@ -774,7 +764,7 @@ struct drbd_device { unsigned long flags; /* configured by drbdsetup */ - struct drbd_backing_dev *ldev __protected_by(local); + struct drbd_backing_dev *ldev; sector_t p_size; /* partner's disk size */ struct request_queue *rq_queue; From patchwork Fri Jan 13 12:35:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christoph_B=C3=B6hmwalder?= X-Patchwork-Id: 43282 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp247848wrt; Fri, 13 Jan 2023 04:46:26 -0800 (PST) X-Google-Smtp-Source: AMrXdXuJtpcnXNEornVXGwNWdV6ZKf0sLvMFk3NR0d1f0oqyNpbaSJjtT6u9lIIkh3FY7dZTJeie X-Received: by 2002:a17:90a:4804:b0:220:bad8:b4e7 with SMTP id a4-20020a17090a480400b00220bad8b4e7mr84846919pjh.7.1673613986470; Fri, 13 Jan 2023 04:46:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673613986; cv=none; d=google.com; s=arc-20160816; b=mETkpS3wI0L6F/LyX6V6LCDnjcuNGdxLd6RLLBOiF+pYFS+KYsXufoqrSKlbTc8hCz 6K8BMLvoSvtw8tQZW/ZOCIbqbLuanmuiEMgyD5xHA4hpeuxfM9YL1qnsOEAe/ge9wtUG lj9azaKeRZRyy4F98ai3LoagtthAY1sNxM1hl+Gt4u8ecBVa5utcvRospl8LJgIpgLoD Wf/VEKbE3rbLONAZjt61WlgzXyimjyYlFfi/oBDjU5aqLo+HtPUDCNhWgp+QNYlweiYb 4idyZTxq+7WMKkPWme7d7Rm2WT+9pOBTyOCTRZ0sS+WHbxFSrDX6K5J0KGE102y+qPKj /VBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=N1ZPBPraqcCSXLcbBqEiTH4593Z8hkjnTNKrVJO6nsc=; b=Gu58JNMuYCjF5COWfE+YvxR4dr+OHIYyXL+3aX0JoJcZdCdBPTI8gbnpwUKUynBRUR DBmr7FQUAn9Ue1qHbaM/PwomFn8H4t+rqD4lpZR/RVsaw1KnUejEBu0Zlss5lPzsZv52 lvyqD+rDCjvMGkwlMp6kDIwUephefFqHdXg/r8NQRLp6ClWOTFHhEWgLARFsxs5G18d2 4Z8AkvLdHRGUKTqDxSURUSqWtQmp4g9PUXE0eGL+/C3zmPzdF0EgWJu7alTbj3dkRfNu 7edx1M5L5qJI9GfXjTylUaYdBMZgkxH4UN5YWH4Ml3KgKR89pLELT8sUsU6lzyO3uOpg 9lJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b=H1cWTLNM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rm13-20020a17090b3ecd00b002262ab43317si27198453pjb.90.2023.01.13.04.46.14; Fri, 13 Jan 2023 04:46:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b=H1cWTLNM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241765AbjAMMpk (ORCPT + 99 others); Fri, 13 Jan 2023 07:45:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241949AbjAMMoL (ORCPT ); Fri, 13 Jan 2023 07:44:11 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DB5640C35 for ; Fri, 13 Jan 2023 04:36:28 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id az20so32929456ejc.1 for ; Fri, 13 Jan 2023 04:36:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N1ZPBPraqcCSXLcbBqEiTH4593Z8hkjnTNKrVJO6nsc=; b=H1cWTLNMFyabZxRRgStGWeUzanvjp0Bj18ZcRAus/5m28S6QpN3yI1JV+uWc+YzPfU IyhyKcRkDRynH5pTc8H99VKS4vSpQywBAL8oVCIkkl6miPByqCFRIWYcxiCArTI5FwM+ zVEZ40O4VzfAFqpdDexxjWxp6DOvibzhkqNhNqnamU3SWC/y7bIh2q0RWNBzeDEeyYPl S9N91Mv8T9e5MO9p88rokudwIsO/OJrHscaNspDv743X4ILM+GEEOAuf25tVuu0pMqL3 eddMnTZdYDp42Lp4tYh3lLDK9SUdWuoN6Nfc4rRnAhnAeD8bux39C7jc8O+618+2W0Uw YTRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N1ZPBPraqcCSXLcbBqEiTH4593Z8hkjnTNKrVJO6nsc=; b=JGaAhT2ro/WgtgOJNjBgnrDGHnEBs+jtZyo3lsTnMv8kGHAE6pYznKStM84r6p+s6q 4Pg3DBt2YJ9uPt7LEWWqbV8vbPc6yu5LV+7uc1ybm2R8Jf4i+KUeHuwbUZ7hdVsmJET5 Oq+kD3fdYCre7KZNAVTqsPb4YKo21JMCfU4RVHFG2stYmNdgEYT451Yu1RXNXFaN3P7/ DqlD57PTgPNWZ63XA/9b7njq5Tdro3IzALyvl26jZEGnL4hhVACL9D6Mfoopeul8CM3d ctrL5VYtHSH4EWk/alp66/y8d0zHRLZB7pHj9OO2EQSLktSnHHrBxVkN7N/RZAEIs6Hp yjTg== X-Gm-Message-State: AFqh2kpaWe+YBYYXXq1+ryJ3+VdEGiyVx9NrihamCrtu591LDMPlEBiS gwvzUFESnxpYBwBUUf5/IfVVTA== X-Received: by 2002:a17:906:838b:b0:851:97ca:7fc9 with SMTP id p11-20020a170906838b00b0085197ca7fc9mr14761111ejx.40.1673613347524; Fri, 13 Jan 2023 04:35:47 -0800 (PST) Received: from localhost.localdomain (h082218028181.host.wavenet.at. [82.218.28.181]) by smtp.gmail.com with ESMTPSA id 17-20020a170906329100b007c0bb571da5sm8402496ejw.41.2023.01.13.04.35.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 04:35:47 -0800 (PST) From: =?utf-8?q?Christoph_B=C3=B6hmwalder?= To: Jens Axboe Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, Lars Ellenberg , Philipp Reisner , linux-block@vger.kernel.org, =?utf-8?q?Christoph_B=C3=B6hmwalder?= , Joel Colledge Subject: [PATCH 6/8] MAINTAINERS: add drbd headers Date: Fri, 13 Jan 2023 13:35:36 +0100 Message-Id: <20230113123538.144276-7-christoph.boehmwalder@linbit.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> References: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754911459618979775?= X-GMAIL-MSGID: =?utf-8?q?1754911459618979775?= Signed-off-by: Christoph Böhmwalder Reviewed-by: Joel Colledge --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 595d59eec7ea..83b6f3a97cf6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6349,6 +6349,7 @@ T: git git://git.linbit.com/linux-drbd.git T: git git://git.linbit.com/drbd-8.4.git F: Documentation/admin-guide/blockdev/ F: drivers/block/drbd/ +F: include/linux/drbd* F: lib/lru_cache.c DRIVER COMPONENT FRAMEWORK From patchwork Fri Jan 13 12:35:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christoph_B=C3=B6hmwalder?= X-Patchwork-Id: 43287 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp248509wrt; Fri, 13 Jan 2023 04:47:50 -0800 (PST) X-Google-Smtp-Source: AMrXdXsoEPPy0N7OA8stB17kMPgTBiOzN7FEBvSLddUhsjsK4Ai2gIpkvmRzVHPoAwuh6ZSLnU2h X-Received: by 2002:a05:6a20:3c93:b0:b0:c30:5819 with SMTP id b19-20020a056a203c9300b000b00c305819mr123975848pzj.1.1673614070360; Fri, 13 Jan 2023 04:47:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673614070; cv=none; d=google.com; s=arc-20160816; b=qertBDewoEXZiL4qfxL2VXr3q+80bG+t5/a9igXLnjVcz7ILZc9QoIfVd/j09mQ23R IpcYKJfdHECwPS/wJNJOruUJIjM81BBsm8mSerfxH8YYqzqEqtaaNF8Bi0yWyPg+Gppg LtTH4kBmnYjAF2n1PlqfjihCMiR513EvGIMoHpYHja6Vf9uOSuzOi4vCgNfh4LyuufLF bBU9NWXgIZnRH3lah4jRMp9aAwBRru+Xacs9k4hDQcJU/7oIyIq7MAI+Io/gFcZLwXVV sjXPAPDtR0b7hghOxHpq9NPuST1wwRfs66M69poKZm838UHctku4nWuC806VMtSPeryk ypEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=T5KT6Auu94HJGq65sn5VmhXW8yJRnWzEtldTHa29AT0=; b=n+MCOFkRzIGEuzjRPLY0UixGNTcTESlbRc6V15maJrEV+N2GMzYqptjdho0fnaLRkK 4kPYq+G1GFSjBkntEuTNenu7rtomCkZ/tBT5ftE5OX8AnKTlpcTAk0Pt+1oF6rD92DR8 o9qqhgIUFToIxdVHFdpk81AFIIx5/KX91Skm6lWzWWug1vd33PGaBw6N3PlEGqmclOcC Z815AtnjJ9ijIAOao1Sa8prTyoTYJtp/E4qoR6q9yZ6OnPaCnmIAkSzAKI7uBUUYqCW8 wN33MvMT/2PWiSipWCpAwasJ4eub2n87MC3TncbRNpyTg5a07In5GZ1LaIkQHGpNbfOd fMWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b=iEvtkhCX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l72-20020a63914b000000b004ba7c769004si6345961pge.656.2023.01.13.04.47.37; Fri, 13 Jan 2023 04:47:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b=iEvtkhCX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241797AbjAMMqO (ORCPT + 99 others); Fri, 13 Jan 2023 07:46:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242017AbjAMMoU (ORCPT ); Fri, 13 Jan 2023 07:44:20 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3577F1C13F for ; Fri, 13 Jan 2023 04:36:30 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id az20so32929547ejc.1 for ; Fri, 13 Jan 2023 04:36:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T5KT6Auu94HJGq65sn5VmhXW8yJRnWzEtldTHa29AT0=; b=iEvtkhCXslE72xJ4rRq1o4dPaZjuX9JLsa7ypmZFDHZvO1spA7qgOqdlMIgNqmOd4Q BmnYm1AreZ0f08H6qA5zzq1vhit1vtTePd21UHj1cHFD1HjWkkgvd6vUd0NYq3Flo4tW PU4z44ieH6GRE99WOpB7LDRHJPfdP/JK0iDdurBhlgpJdztFtfu1wNuJqycRTt4DfmwJ DKQGPJsW0QdNBPlwzpGCReJQBTQGz5fJbIzvrcijgWMbeBy62bZDqSBq0eYILOugbfBK POQt3cU00BEvXOTS6Px7H7/seYT2YAjrwmY0BkAOAChZsa+VBCMGVy2V6DjUXPacBhb7 5YvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T5KT6Auu94HJGq65sn5VmhXW8yJRnWzEtldTHa29AT0=; b=U+vaQtoFLsOBcgZvVSV+xkVhzPpp5gz3ZxZecd95K6ELuBL71r3dFsh+Nde5aEE/5l idt3ERKGxaxae32+iJ9HCqb0bIyCksTKuZ1rhspiImOWaCb3OdmS9FMGACSFgXTP5liu fZswv5+cPJVJi/e7T0kA+7NZGf7Q/McoyhaxRQtkpWf9pW9KWivPnhxaR5PNOvoM0QIX Wmeul1gPB+xf2HJ+iZ55+CEGznEoeOXGKUZU3ektcBBz7OAPUf+Ld/FPBga9dtfnh+rA w6co/xAOrP5Xo5lU6r2ZZGhOy9kBenRQC3RHXdfZfRLFu+LOstGDUGrI2x/2mKGtckHI Ju8Q== X-Gm-Message-State: AFqh2koyWEUb+FOwk90tu7DdJ27lWxsZep3pQoTCMyoQxafbjovlzFCI JbHGkz5BdT3Qjkp+14qY+0llTw== X-Received: by 2002:a17:907:7f12:b0:7c1:9eb:845b with SMTP id qf18-20020a1709077f1200b007c109eb845bmr3841305ejc.16.1673613348224; Fri, 13 Jan 2023 04:35:48 -0800 (PST) Received: from localhost.localdomain (h082218028181.host.wavenet.at. [82.218.28.181]) by smtp.gmail.com with ESMTPSA id 17-20020a170906329100b007c0bb571da5sm8402496ejw.41.2023.01.13.04.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 04:35:47 -0800 (PST) From: =?utf-8?q?Christoph_B=C3=B6hmwalder?= To: Jens Axboe Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, Lars Ellenberg , Philipp Reisner , linux-block@vger.kernel.org, =?utf-8?q?Christoph_B=C3=B6hmwalder?= Subject: [PATCH 7/8] drbd: interval tree: make removing an "empty" interval a no-op Date: Fri, 13 Jan 2023 13:35:37 +0100 Message-Id: <20230113123538.144276-8-christoph.boehmwalder@linbit.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> References: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754911547495786007?= X-GMAIL-MSGID: =?utf-8?q?1754911547495786007?= From: Lars Ellenberg Trying to remove an "empty" (just initialized, or "cleared") interval from the tree, this results in an endless loop. As we typically protect the tree with a spinlock_irq, the result is a hung system. Be nice to error cleanup code paths, ignore removal of empty intervals. Signed-off-by: Lars Ellenberg Signed-off-by: Christoph Böhmwalder --- drivers/block/drbd/drbd_interval.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/block/drbd/drbd_interval.c b/drivers/block/drbd/drbd_interval.c index 5024ffd6143d..b6aaf0d4d85b 100644 --- a/drivers/block/drbd/drbd_interval.c +++ b/drivers/block/drbd/drbd_interval.c @@ -95,6 +95,10 @@ drbd_contains_interval(struct rb_root *root, sector_t sector, void drbd_remove_interval(struct rb_root *root, struct drbd_interval *this) { + /* avoid endless loop */ + if (drbd_interval_empty(this)) + return; + rb_erase_augmented(&this->rb, root, &augment_callbacks); } From patchwork Fri Jan 13 12:35:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christoph_B=C3=B6hmwalder?= X-Patchwork-Id: 43286 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp248486wrt; Fri, 13 Jan 2023 04:47:47 -0800 (PST) X-Google-Smtp-Source: AMrXdXuXP4lmt6nr6l56FxibcnmvHiydDwxYh94AGoWQduyLTR1xwWLnjMkKqf9XZVtrdRGF+Dye X-Received: by 2002:a62:f203:0:b0:576:b8d0:6034 with SMTP id m3-20020a62f203000000b00576b8d06034mr79936499pfh.31.1673614067369; Fri, 13 Jan 2023 04:47:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673614067; cv=none; d=google.com; s=arc-20160816; b=SCBxQ/gikeAWh0Dr9QIlV9Q+hgCdmBPtk1voImYYQLtPERrcfJlB7GQ6TYc1q07YMT 0wgLsIQCmxXQZ2Mb/O4TxH3/6mJtl6Sy4oxm+q6CNW5I4pHTrzWobOXpFNEwSALp4Xgp qbNKC1rmYGzy6eavcq/+eV1OtVuCYbzZ15atlc+zksj5qhWU1L/lMfEQX9z8LNoFmor+ Nq6f/jR4riaT64H7uGuBJ851kprSMEX7S0O0/FxJWIt1E5BkOQoQ6WJA5NaNShBeT1Je XR2AV+TX5zvrnSnJXVL8maYBkVuNHTrRAivkhwZFbUCTRywUrVmJJfLUUxDLvLTB0R00 uUSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=w8l6YI6ll5WTtemsFOxZHnG0tRV3sgRpFSwrNSjhQUI=; b=CAgObfvjtCiG7efgnxJJwCD1iFX78VtzX1MbeMxTg3zKLfxZUNxJkbU6tAMpH5xJP+ IDhKZMRhjcQXP+QFREr9fzg/fQC5RMAi0l3457p4l7XfZ5SKFiaqHFw8Sg6/CS/C+2y/ d+ONy9/90mCtzNbqt1FWQW2x4APmniAx+eyWAJ39R+I3PTH3fqt7PKxV0CNeY42Xao1p gR/luEfAp7LBkZFmNFsdGsTRNkUMiA1E7/6S4h7ddhaLKgnGibzRWTZPAT3Jm3WcIMlH xWcN+1hrE3vv00LBrORm0BMXVAJHl2e9UDlE8aqkdZwEW2fsRPPue8RLeW9/sgzJpfEP YsWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b=n5fyYkdz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j6-20020a056a00130600b005855984976fsi20492584pfu.323.2023.01.13.04.47.35; Fri, 13 Jan 2023 04:47:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linbit-com.20210112.gappssmtp.com header.s=20210112 header.b=n5fyYkdz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241806AbjAMMqT (ORCPT + 99 others); Fri, 13 Jan 2023 07:46:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242027AbjAMMoW (ORCPT ); Fri, 13 Jan 2023 07:44:22 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C55D01ADA3 for ; Fri, 13 Jan 2023 04:36:32 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id hw16so40158609ejc.10 for ; Fri, 13 Jan 2023 04:36:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w8l6YI6ll5WTtemsFOxZHnG0tRV3sgRpFSwrNSjhQUI=; b=n5fyYkdzH0FaufBTIPFRKPuo0z+AnNGqgMIwP1N9mikuhruiPj9WRKliJKtqkJNcSH jdCwrwklvxXlnybHa2UFVFEhVxo4yxnl8RG0yqtoK6PM/qUzfFALdh3BP1L2UPVBR9o/ w6zxIZEnL5J2sKJYA0OPCfypQ0p9FVxHHUrz6Z1/JMdUq1spCP7LrSapSCEMuwGCHe8s HGX+lofy0D+Q+QodiXTM0nZKzf/sIpaOtXX8WkCVlMaYF2cEEk1uvCC20PCV1+9TJe7q 9hzSbMatiM8L1ARpqUspUBtbv9iuXjfy6N1xV7yn0VoH1DnxioqTPvTQdYkdND7Ap/8M BVag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w8l6YI6ll5WTtemsFOxZHnG0tRV3sgRpFSwrNSjhQUI=; b=8NKTZL2AZq6R8WxXeglaitn5ZT9gAZs/uCzXsOxEwBiCZSJPnJ2a3fALr8S2c7n+Rp BFbvWIMziV01UXxq7kYw0WRguKnDoFvShlZBjZ8H09oP1/bhZ59JhCY9ws82tjzBGUtC pYY2dW7PjBz1xS7h5A/04frrzxAp5U9kr9iRVKY7sQOsJ1I5AXIfXyh7iev8I0O5/j0Y /7Dw8HtcF9DnK7t8bdnxOraUrNM9ajbg0vp5VL/+cIqmlMCoQ0/T5V60zIMCYliChSHj Blbm93fGkW2AEP3haNFdUnWtcTFXz+SguGKE2T2qHOgOwyGf5DEiimK+QqG3+vzLN5Nb S9sg== X-Gm-Message-State: AFqh2krvRDyGeU74f0vtg2RSZ09KXbWoy4Q76TZLRP6+ouEiPT00Ylg5 pJ+aX2f9/dEzgvkZ8YX1dZaz6w== X-Received: by 2002:a17:906:3993:b0:844:de87:8684 with SMTP id h19-20020a170906399300b00844de878684mr78074081eje.46.1673613349021; Fri, 13 Jan 2023 04:35:49 -0800 (PST) Received: from localhost.localdomain (h082218028181.host.wavenet.at. [82.218.28.181]) by smtp.gmail.com with ESMTPSA id 17-20020a170906329100b007c0bb571da5sm8402496ejw.41.2023.01.13.04.35.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 04:35:48 -0800 (PST) From: =?utf-8?q?Christoph_B=C3=B6hmwalder?= To: Jens Axboe Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, Lars Ellenberg , Philipp Reisner , linux-block@vger.kernel.org, Andreas Gruenbacher , =?utf-8?q?Christoph_B=C3=B6hmwalde?= =?utf-8?q?r?= Subject: [PATCH 8/8] drbd: drbd_insert_interval(): Clarify comment Date: Fri, 13 Jan 2023 13:35:38 +0100 Message-Id: <20230113123538.144276-9-christoph.boehmwalder@linbit.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> References: <20230113123538.144276-1-christoph.boehmwalder@linbit.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754911544455774062?= X-GMAIL-MSGID: =?utf-8?q?1754911544455774062?= From: Andreas Gruenbacher Signed-off-by: Andreas Gruenbacher Signed-off-by: Christoph Böhmwalder --- drivers/block/drbd/drbd_interval.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_interval.c b/drivers/block/drbd/drbd_interval.c index b6aaf0d4d85b..873beda6de24 100644 --- a/drivers/block/drbd/drbd_interval.c +++ b/drivers/block/drbd/drbd_interval.c @@ -58,7 +58,7 @@ drbd_insert_interval(struct rb_root *root, struct drbd_interval *this) * drbd_contains_interval - check if a tree contains a given interval * @root: red black tree root * @sector: start sector of @interval - * @interval: may not be a valid pointer + * @interval: may be an invalid pointer * * Returns if the tree contains the node @interval with start sector @start. * Does not dereference @interval until @interval is known to be a valid object