From patchwork Fri Jan 13 12:31:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 43248 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp243737wrt; Fri, 13 Jan 2023 04:36:35 -0800 (PST) X-Google-Smtp-Source: AMrXdXv0V5lEPa52dgsipTVx/vXiW1byqLdWNDahOb9sAPvAbx7ZoSE4HAwzBEccEVAiJFeBO/A4 X-Received: by 2002:a17:906:7c58:b0:84d:4e9d:864a with SMTP id g24-20020a1709067c5800b0084d4e9d864amr14762570ejp.74.1673613394797; Fri, 13 Jan 2023 04:36:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673613394; cv=none; d=google.com; s=arc-20160816; b=SHBxxnVL/W5dm8Ffh8KYIGkK3kzptH4SVHi1yLeAUC32kFchH2KFs8G5m+nnwAgL3k 2Ko8C91aJBp0Bq06fiWv7NGSvDksiQu04K1B5QsRh/YjGftd/uq5TEDHna/gOY+O4rB4 JbZhe/UNfDJWZtYI8HXqLoa0hJn6tA4nH9x5cMBHFLumq3jMbOxLmWL7pPRecWwbR5vD kEeFEaCz7c0i39ILviPlaPM7UhzQ27aJD9Er5lJERvdPLGekjG0eOBT7SgrOepW2nm94 V6EjreSQhLG2VjHi3j7VGSOiqPpF/I+eNRinRmRAvy4nZmiz77QgZmNWZjzwjhQCcgN9 GAww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=5aASUlsmHY4Tb7vV5s9XpNeSSH8kwWok/IurZ2z1MF8=; b=HJ9RpYBfAknCD4uU+/88OWUNVyGI4iBv2X3vfp3XZdf8JSt98RDZ9Us37wshAFToTz joz3NkZRPqwSWZU7AVkZ2A/6zUnqGVmB9+OLAIqorLydhAq8y9JpL6+HK4i27bnmsmRj renozTq1TcrEgGTFKc9AXtLZS/JAjYwq0NEbO6uhAOdVQYB6DZomihzdy5x+YAaMOwG8 9Gjs+7mKTEZ8FQSeyeZuRKzzr+UeGHnDKcu7zXH59dTilWA3jObquBwlu/FJwg+DcRz3 S04uOQUL/7ToZzCkFqwD7lT6GHK5bqIP5aR/xUVeupK0r9Xhzb38e5Id4B9Dajl82WOn qo5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=RXXwtJEI; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xb13-20020a170907070d00b007dd1da8cd85si20734418ejb.126.2023.01.13.04.36.09; Fri, 13 Jan 2023 04:36:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=RXXwtJEI; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241529AbjAMMf1 (ORCPT + 99 others); Fri, 13 Jan 2023 07:35:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241288AbjAMMcQ (ORCPT ); Fri, 13 Jan 2023 07:32:16 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BFBC551F9; Fri, 13 Jan 2023 04:31:13 -0800 (PST) Date: Fri, 13 Jan 2023 12:31:11 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1673613071; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5aASUlsmHY4Tb7vV5s9XpNeSSH8kwWok/IurZ2z1MF8=; b=RXXwtJEIaiaiX0gkhyVfCR+bpFuIgB5DEejKPVThIPG8pk5V6ULQ15OgLVNQLHSbUSibaP oq5lRS/w2/0GjE83uci+sw9oPMW2l1tdZebucd643+39cqjdSdiCLENqsk3osKyru2fk0j h/mTCTRpeQ5SlEtRme+K9fwFy47W3rgAfdoDsaVzlP1Mb+v5azetHh0fGyLOCoxqhdmOtc 4+2NDcYLcfwblRpoGwXf18vBOvcL8A77XX6zKe5z/QNE2dDSWo2paSjC1Oaw5yq5dlE68U oCtOc2L6Gpsg2Gu40cYWamoFAe2/RyKlIdFR4M25gh3Wfm6zHlJhWm0B3+UXxw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1673613071; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5aASUlsmHY4Tb7vV5s9XpNeSSH8kwWok/IurZ2z1MF8=; b=icZDcXRD41zrMSRQAGJxtBwTegCLl4N03tlEXav4WfwxWJxOjJqFEWhCW9JRMV7eo6KvYi jaSP2nhch15ut8Dg== From: "tip-bot2 for Peter Zijlstra" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: sched/core] arm, smp: Remove trace_.*_rcuidle() usage Cc: "Peter Zijlstra (Intel)" , Ingo Molnar , Tony Lindgren , Ulf Hansson , "Rafael J. Wysocki" , Frederic Weisbecker , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230112195540.743432118@infradead.org> References: <20230112195540.743432118@infradead.org> MIME-Version: 1.0 Message-ID: <167361307155.4906.8563533169394574018.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754848612119609780?= X-GMAIL-MSGID: =?utf-8?q?1754910839210744917?= The following commit has been merged into the sched/core branch of tip: Commit-ID: 08a56e07cd3cb91dc700ba0a879d17e4879dd617 Gitweb: https://git.kernel.org/tip/08a56e07cd3cb91dc700ba0a879d17e4879dd617 Author: Peter Zijlstra AuthorDate: Thu, 12 Jan 2023 20:43:37 +01:00 Committer: Ingo Molnar CommitterDate: Fri, 13 Jan 2023 11:48:15 +01:00 arm, smp: Remove trace_.*_rcuidle() usage None of these functions should ever be ran with RCU disabled anymore. Specifically, do_handle_IPI() is only called from handle_IPI() which explicitly does irq_enter()/irq_exit() which ensures RCU is watching. The problem with smp_cross_call() was, per commit description: 7c64cc0531fa ("arm: Use _rcuidle for smp_cross_call() tracepoints") ... that cpuidle_enter_state_coupled() already had RCU disabled, but that's long been fixed by commit: 1098582a0f6c ("sched,idle,rcu: Push rcu_idle deeper into the idle path") Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ingo Molnar Tested-by: Tony Lindgren Tested-by: Ulf Hansson Reviewed-by: Ulf Hansson Acked-by: Rafael J. Wysocki Acked-by: Frederic Weisbecker Link: https://lore.kernel.org/r/20230112195540.743432118@infradead.org --- arch/arm/kernel/smp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c index 36e6efa..0b8c257 100644 --- a/arch/arm/kernel/smp.c +++ b/arch/arm/kernel/smp.c @@ -638,7 +638,7 @@ static void do_handle_IPI(int ipinr) unsigned int cpu = smp_processor_id(); if ((unsigned)ipinr < NR_IPI) - trace_ipi_entry_rcuidle(ipi_types[ipinr]); + trace_ipi_entry(ipi_types[ipinr]); switch (ipinr) { case IPI_WAKEUP: @@ -685,7 +685,7 @@ static void do_handle_IPI(int ipinr) } if ((unsigned)ipinr < NR_IPI) - trace_ipi_exit_rcuidle(ipi_types[ipinr]); + trace_ipi_exit(ipi_types[ipinr]); } /* Legacy version, should go away once all irqchips have been converted */ @@ -708,7 +708,7 @@ static irqreturn_t ipi_handler(int irq, void *data) static void smp_cross_call(const struct cpumask *target, unsigned int ipinr) { - trace_ipi_raise_rcuidle(target, ipi_types[ipinr]); + trace_ipi_raise(target, ipi_types[ipinr]); __ipi_send_mask(ipi_desc[ipinr], target); }