From patchwork Fri Jan 13 12:31:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 43236 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp243334wrt; Fri, 13 Jan 2023 04:35:39 -0800 (PST) X-Google-Smtp-Source: AMrXdXsPIHAoW2AuByZtG0OBdUsqYdDy7OjHPaddzb/MbS80Q9D7reLXnjO4wlHD27Qupga5q8Q7 X-Received: by 2002:a05:6402:390b:b0:465:f6a9:cb7b with SMTP id fe11-20020a056402390b00b00465f6a9cb7bmr70603203edb.12.1673613339580; Fri, 13 Jan 2023 04:35:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673613339; cv=none; d=google.com; s=arc-20160816; b=d4B0qEACUuKBSpZ1WX0CcxcPHCiDWwsr/Mi04maLxZeGlPJ3uTHfT1+W3d3SQ6lPO7 7kGjvFHsUGSL7sZPQLyDAHta85FGI9s3GbJqiRId//BNFLnQExEqDBZrs++p/Bn27hh4 0XuL+gMD8Iq6MqmtgoN0uDdgX9Bonueuk4YCiwLiav7xUoFHmCE9j+JQU3Tj8FehjYGM czlxJc/gyzq1rIjBCkddhMmESSawf93ow1ECMo7lNtyWdxMGGvBNiRzvQUVNyZxCnFjp vEkewqJIfUYYNOOFXocP5zYruZbFhH+DejsW186lpPVHuhaYEq7dP0gA1hkRiz6i2D32 Vu8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=pWTyKo6K3mnhY0i107QBhzwJ+zxlbYLQ92Q1X5DIbIY=; b=KzWd6rGqDEDbEKN598iZYxywrOe2zmg/8p0oGDNPXoIFVL77Zw+8EFA9DHy4J5oVd7 6sLKxLE9E3i6xVLg7VnuYRT/8D6gzJvApp/Mbdpf5dMfYz2+v2ZWIkOXFzN4d/IEG3+a BoraUsWe0b8Ase3FJu9AY6JEShn+Jbhmall+LWOKESTEpiyoioEQq2NXJALyz/SgkWSS U75GpTVtqSjq9PNrpqcLPqOMLaKremV/E1qnThyxSutbKgWfc2YcJPsUxvD4aBsjGQVj 3oYlYBWR5lFXSYKn7USRdQiY+FTUUNq+M5+lv4IZIRdcbDb7ZWDliUsMd3w/PyJQLuNT 6P5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=JAmhDchA; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w21-20020aa7cb55000000b0049651e9f65esi19355138edt.395.2023.01.13.04.35.14; Fri, 13 Jan 2023 04:35:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=JAmhDchA; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241512AbjAMMdM (ORCPT + 99 others); Fri, 13 Jan 2023 07:33:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241266AbjAMMcI (ORCPT ); Fri, 13 Jan 2023 07:32:08 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CA9B4D72A; Fri, 13 Jan 2023 04:31:10 -0800 (PST) Date: Fri, 13 Jan 2023 12:31:05 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1673613066; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pWTyKo6K3mnhY0i107QBhzwJ+zxlbYLQ92Q1X5DIbIY=; b=JAmhDchAM1H/s7LwB1vriHvxIShDQhVkW4/C7nA7mV1ktLQd4qqPwx6Zp1zXRxN3EcJvfk l5lMrEa/xly9VZRIJF8xRQylFgtiXf9opzjeTHnW+Y+5PYmMU3TlZpXR99gVSGvzqs5AjU 37tQ6ezIDKxUNRs3NQDnxhOLk+nuv2Q4A2HjOnxQugDNpdfEHZh4H/qnh9JxPmaVt2pV2X UNRMxOKBbiIgQB17nEGs/E7ZaL6Nyh8r/O3f8RNmwG4LlRgvcd3TLc+9PHaoDKvprsrXER cUfPXtPAUr4x87Zmf/HoLjKLkerdzzlre+bsZ7phza9xjKHXAZRa9bzrpB2e2w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1673613066; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pWTyKo6K3mnhY0i107QBhzwJ+zxlbYLQ92Q1X5DIbIY=; b=r3v4QUhG2p7+kJjjTFdL47QjNDvpJnwO44Rvxz3RAYOmlPGM26f4sl86FuqqHKsKNVorNU UvmFjniiLR9/sBAw== From: "tip-bot2 for Peter Zijlstra" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: sched/core] arm64, riscv, perf: Remove RCU_NONIDLE() usage Cc: "Peter Zijlstra (Intel)" , Ingo Molnar , Tony Lindgren , Ulf Hansson , "Rafael J. Wysocki" , Frederic Weisbecker , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230112195542.151174682@infradead.org> References: <20230112195542.151174682@infradead.org> MIME-Version: 1.0 Message-ID: <167361306587.4906.6872487884714268270.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754848508794463534?= X-GMAIL-MSGID: =?utf-8?q?1754910780807975478?= The following commit has been merged into the sched/core branch of tip: Commit-ID: 1c38b0615f84f622cd6c821aa40be60fc7f7a096 Gitweb: https://git.kernel.org/tip/1c38b0615f84f622cd6c821aa40be60fc7f7a096 Author: Peter Zijlstra AuthorDate: Thu, 12 Jan 2023 20:44:00 +01:00 Committer: Ingo Molnar CommitterDate: Fri, 13 Jan 2023 11:48:17 +01:00 arm64, riscv, perf: Remove RCU_NONIDLE() usage The PM notifiers should no longer be ran with RCU disabled (per the previous patches), as such this hack is no longer required either. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ingo Molnar Tested-by: Tony Lindgren Tested-by: Ulf Hansson Acked-by: Rafael J. Wysocki Acked-by: Frederic Weisbecker Link: https://lore.kernel.org/r/20230112195542.151174682@infradead.org --- drivers/perf/arm_pmu.c | 11 +---------- drivers/perf/riscv_pmu_sbi.c | 8 +------- 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c index 9b593f9..c34d5fe 100644 --- a/drivers/perf/arm_pmu.c +++ b/drivers/perf/arm_pmu.c @@ -758,17 +758,8 @@ static void cpu_pm_pmu_setup(struct arm_pmu *armpmu, unsigned long cmd) case CPU_PM_ENTER_FAILED: /* * Restore and enable the counter. - * armpmu_start() indirectly calls - * - * perf_event_update_userpage() - * - * that requires RCU read locking to be functional, - * wrap the call within RCU_NONIDLE to make the - * RCU subsystem aware this cpu is not idle from - * an RCU perspective for the armpmu_start() call - * duration. */ - RCU_NONIDLE(armpmu_start(event, PERF_EF_RELOAD)); + armpmu_start(event, PERF_EF_RELOAD); break; default: break; diff --git a/drivers/perf/riscv_pmu_sbi.c b/drivers/perf/riscv_pmu_sbi.c index f6507ef..7b2288d 100644 --- a/drivers/perf/riscv_pmu_sbi.c +++ b/drivers/perf/riscv_pmu_sbi.c @@ -771,14 +771,8 @@ static int riscv_pm_pmu_notify(struct notifier_block *b, unsigned long cmd, case CPU_PM_ENTER_FAILED: /* * Restore and enable the counter. - * - * Requires RCU read locking to be functional, - * wrap the call within RCU_NONIDLE to make the - * RCU subsystem aware this cpu is not idle from - * an RCU perspective for the riscv_pmu_start() call - * duration. */ - RCU_NONIDLE(riscv_pmu_start(event, PERF_EF_RELOAD)); + riscv_pmu_start(event, PERF_EF_RELOAD); break; default: break;