From patchwork Fri Jan 13 12:31:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 43225 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp242733wrt; Fri, 13 Jan 2023 04:34:17 -0800 (PST) X-Google-Smtp-Source: AMrXdXsKK5GZ+R0EsdO+Ed1qwDC/6OelgOaw1uiFT13TBPV4weSs8JJA0f6S4UjYbmYRKpYAp4YU X-Received: by 2002:a05:6402:528e:b0:481:420e:206d with SMTP id en14-20020a056402528e00b00481420e206dmr64764472edb.42.1673613257143; Fri, 13 Jan 2023 04:34:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673613257; cv=none; d=google.com; s=arc-20160816; b=yHytiYkfcFXg03aCqO1yci0MUg86W0+M4cVRw2fDtb4cKO5vr0/0263XHSbEQ2JyYL vxsAAJGFAFdtXft6V+S31NGbUaH1sY/PrYvnkYv+llfVZ5TCANgyDZssY0r3FAzyAa8x A18To9OBLBfs9APwFwMDc/lMTA59vXvh8PryZF5A8G/XAGyuYwwrkGbZuwQJRkZhzPLy OQiPUtZ8LG/q+RoDVgSCdnEvlhwFUokPaD1tGJ7hYYwduHcxbPisiixXSiI1KvgggOQr +/KcpMNswPCw4fK2Q3HdlB2jLLS/yZrsvvQguYI2XQmf93eD0/xek6eluJNp8eSibFy6 EbGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=KsLuCFgmdU19wUf/VRVgfn19J66nmtUGe6duCuVWibc=; b=U8p9kFhTE6chtwgVuNh3xS8fSDNRQHOWqitrmuamKYH9giB7Nz/vBJV40BT/q0Tfe8 KIEKcyzDKleZeFlInBgwWW85J/bAfsIc2IlbDwX+XjG9rMbS6wyb3OrLuj9UkBN988hH Ja71vA08opzDYwkd21URah+r7QCw4tqQjG9GFNkLD7sc4JEUqqj71hTaXg/O0zeEG7Xr LE7eu1Thl7XnJyzbJWiOGN/6zt7+I0p4eUsKNo0c3KTwoCRx3JYtOyfAPQ1ax+p1+6fy /7LXH7P9d8oIZ2fh7JLN7b4uQ+Z4F3TgBdXrHYp7t7x4D7P46/ZESx/mMiEhMq9VAw5E tPbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=LQwp5olN; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b9-20020a056402278900b00453688643fasi24149332ede.260.2023.01.13.04.33.53; Fri, 13 Jan 2023 04:34:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=LQwp5olN; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241503AbjAMMdI (ORCPT + 99 others); Fri, 13 Jan 2023 07:33:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241221AbjAMMcI (ORCPT ); Fri, 13 Jan 2023 07:32:08 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BEB84D704; Fri, 13 Jan 2023 04:31:10 -0800 (PST) Date: Fri, 13 Jan 2023 12:31:06 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1673613066; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KsLuCFgmdU19wUf/VRVgfn19J66nmtUGe6duCuVWibc=; b=LQwp5olNcFf1ECD8wyGYGSwX35EAkF2ptPxs/Ks0FvmUfEeDW/qeLpgn7j88sBuM4VkN68 AkL4JXIAnngkQN+B1rcBJXBu17DFgglFdCrysw5y6sfclTexDgzMj8J4DtzYIOxLtkStwL 86FsqK+2iB5pnk2xwF6iM/PYqSJBh8ScKIz4GZL3K3b4yP/g/aVD0SFCFDV7gmZY2EPfgQ m3WYwo9BtgZIoydEc/XtvL6VRVFJiJJ16JnWuGpZqWunT1TgXGbVH+jWDwrho8elsiQMas 88lP+/jWJZAiY3UkAHx3HXzHJzuUrlMT9zQa8lUOdyp2HgVshI44CkdRyI7ZtA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1673613066; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KsLuCFgmdU19wUf/VRVgfn19J66nmtUGe6duCuVWibc=; b=utr/e2RB4T03U5wzmtr3heUdRi1Iv/xzqs4YinoFQQkEwh6DtVpxuB6RKinKZRF+Z7w/af f623sHndv9mzs5Bg== From: "tip-bot2 for Peter Zijlstra" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: sched/core] sched/core: Always inline __this_cpu_preempt_check() Cc: "Peter Zijlstra (Intel)" , Ingo Molnar , Tony Lindgren , Ulf Hansson , "Rafael J. Wysocki" , Frederic Weisbecker , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230112195542.089981974@infradead.org> References: <20230112195542.089981974@infradead.org> MIME-Version: 1.0 Message-ID: <167361306603.4906.4837361000038231282.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754910694491785613?= X-GMAIL-MSGID: =?utf-8?q?1754910694491785613?= The following commit has been merged into the sched/core branch of tip: Commit-ID: f176d4ccb30747231831f66779697afa6d738b3c Gitweb: https://git.kernel.org/tip/f176d4ccb30747231831f66779697afa6d738b3c Author: Peter Zijlstra AuthorDate: Thu, 12 Jan 2023 20:43:59 +01:00 Committer: Ingo Molnar CommitterDate: Fri, 13 Jan 2023 11:48:17 +01:00 sched/core: Always inline __this_cpu_preempt_check() Quite a few unnecessary instrumentation calls are generated via the no-op __this_cpu_preempt_check() call, if it gets uninlined by the compiler: vmlinux.o: warning: objtool: in_entry_stack+0x9: call to __this_cpu_preempt_check() leaves .noinstr.text section vmlinux.o: warning: objtool: default_do_nmi+0x10: call to __this_cpu_preempt_check() leaves .noinstr.text section vmlinux.o: warning: objtool: fpu_idle_fpregs+0x41: call to __this_cpu_preempt_check() leaves .noinstr.text section vmlinux.o: warning: objtool: kvm_read_and_reset_apf_flags+0x1: call to __this_cpu_preempt_check() leaves .noinstr.text section vmlinux.o: warning: objtool: lockdep_hardirqs_on+0xb0: call to __this_cpu_preempt_check() leaves .noinstr.text section vmlinux.o: warning: objtool: lockdep_hardirqs_off+0xae: call to __this_cpu_preempt_check() leaves .noinstr.text section vmlinux.o: warning: objtool: irqentry_nmi_enter+0x69: call to __this_cpu_preempt_check() leaves .noinstr.text section vmlinux.o: warning: objtool: irqentry_nmi_exit+0x32: call to __this_cpu_preempt_check() leaves .noinstr.text section vmlinux.o: warning: objtool: acpi_processor_ffh_cstate_enter+0x9: call to __this_cpu_preempt_check() leaves .noinstr.text section vmlinux.o: warning: objtool: acpi_idle_enter+0x43: call to __this_cpu_preempt_check() leaves .noinstr.text section vmlinux.o: warning: objtool: acpi_idle_enter_s2idle+0x45: call to __this_cpu_preempt_check() leaves .noinstr.text section Mark it __always_inline. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ingo Molnar Tested-by: Tony Lindgren Tested-by: Ulf Hansson Acked-by: Rafael J. Wysocki Acked-by: Frederic Weisbecker Link: https://lore.kernel.org/r/20230112195542.089981974@infradead.org --- include/linux/percpu-defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/percpu-defs.h b/include/linux/percpu-defs.h index af10715..e60727b 100644 --- a/include/linux/percpu-defs.h +++ b/include/linux/percpu-defs.h @@ -310,7 +310,7 @@ extern void __bad_size_call_parameter(void); #ifdef CONFIG_DEBUG_PREEMPT extern void __this_cpu_preempt_check(const char *op); #else -static inline void __this_cpu_preempt_check(const char *op) { } +static __always_inline void __this_cpu_preempt_check(const char *op) { } #endif #define __pcpu_size_call_return(stem, variable) \