From patchwork Fri Jan 13 08:31:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nylon Chen X-Patchwork-Id: 43074 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp154841wrt; Fri, 13 Jan 2023 00:40:00 -0800 (PST) X-Google-Smtp-Source: AMrXdXvSf/7EqKwtqq0EfZTOBijl1UjVWVvLvoWW+Hi8vjqzm7nQBQOgqYgeaQsm8KVczx+zCFJ4 X-Received: by 2002:aa7:c0c3:0:b0:49b:cf25:152d with SMTP id j3-20020aa7c0c3000000b0049bcf25152dmr2919000edp.24.1673599200513; Fri, 13 Jan 2023 00:40:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673599200; cv=none; d=google.com; s=arc-20160816; b=g8M1loOqpLhNd6Xk5N1Fh5pVJnP06AuGm5NIV+DxSdRdf/d37cqp69epw2ovUVMHYw aVYlrQ+dfhhooTe+dnDHqdb6nfWcnlhQ2Ud5OSMy/yGgCiAgvJ1Du/2V6Z+KFAoxE90A Xs27lvDEt6xGPbNv7hVXwA3ymPyB6hWA9GcpvoXKjDJO2mGbCWY2Anw/CyrGUPSsmRmw FvY8dWGCqBUHnzznexMLjam/DEzlCBUDKYkSxag6ERj2ngUMRfKYskw+UqB8zKQOxOBo JxAOWzsZziAxEXFOJWxq6vUIUUIxQIEnf/0FeINMqshYAgUYq9mS922FlXdb8EalNSA7 rrLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cIstlIhP9pl3goBvQueMqsqc9cYboCHYREaZayJsVqk=; b=KZOASEAtOP5QlJYy3bQjxItNFzWFnkKDNqdTYk8pJizh5vbbSPu5uO4Z6Kild2hBpr DZzv0ayod1fSGmHi4XTJE8lmGv6VLqSL2tFktUk6uYD6DdMxghVpFUjAciZ1knvzkV+v MdnnLZg4/pBl2vkXdv4LgDHrP5suf8qa0fE1cbjAMu+NIYBemSva/2YUyH1Cs1hCT5kG PMkrho59ccvh3zsmr83p10Xie+jtumNgpvAreTFAvxD3y8keZ4qhPOduA8KTgD070ghv OxxA3Z7JOJY6JdAyvBoo3wr1ACw0rm364OvzD9jN1m2ioGywiWZF84NdzGkqLquwEgFD wLWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=VxkzPvdF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z4-20020a05640240c400b00484c1d97aa5si23505408edb.278.2023.01.13.00.39.35; Fri, 13 Jan 2023 00:40:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=VxkzPvdF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230237AbjAMIb4 (ORCPT + 99 others); Fri, 13 Jan 2023 03:31:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234479AbjAMIbY (ORCPT ); Fri, 13 Jan 2023 03:31:24 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD172559E0 for ; Fri, 13 Jan 2023 00:31:23 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id w4-20020a17090ac98400b002186f5d7a4cso26353046pjt.0 for ; Fri, 13 Jan 2023 00:31:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cIstlIhP9pl3goBvQueMqsqc9cYboCHYREaZayJsVqk=; b=VxkzPvdFgcDm1yhAVvF640GkpkEldw2iJ2plMjabFbxP/U2ml+k2FrHjB0c9vNhm9r b1ChL2D6l8uVud094zZmrky/pN6MrUtexVryIoLYRkUdX6PgJBxufcsJzOlXrtMtYUdG q7IR2lpZd0OLFR46EOsxwv0UxQ6wGSnQhUUZi1ZA3/mEO7onNLpI/FfhT7x3f2Xmsza+ wkhCSxYbn0mAyZzaOOcHVSooIj51FH1QLpUnklX10mq/Dr9CRdWmyvC4yrbOA2mgPvRG F/rhfy9N/kQxKQDFhhLTqTa5mVC53drVDMFusknIexal5ErMvTgnBzlg/MmnL6tJHLRy NlwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cIstlIhP9pl3goBvQueMqsqc9cYboCHYREaZayJsVqk=; b=ulyMTcs3jL33gHjyjiJUH17zuStJignO0qMSNwMq0TJNoUKZ9TW6yHe1fuNfYWBtvk +DQjAEmSKnbcpTZKepCLzuqnSJGdrmiQR9UaW5cq56fOYlHQYAWjSNv+RZ6mD55wDgOT paKqxkWe18ClpjJR8+ULISp4KOHj9LKo8kep/GWL3xtKBISAdQmUn9cbPtDE1ge9s7cI NUjKmqYF08Otru8u2mdcMq780Dw549VCh8IkGtLVelHER0zy2m32RRoBXeVJiGR9XXG7 LaJ4BFBejNx8vPUMXN4nVKeixmPdx8DVEeUDeZTCxLprpU4HoHaqAFrCShqN1yHtzPMY vMyA== X-Gm-Message-State: AFqh2krPW3boa7kdLqwpTEWikq8vLhcPo6qtlp6PQBLc42MUQ3FPJc8E Yx/HrY4Zbfnjk5Q+OsgYp31Lyw== X-Received: by 2002:a17:902:ef4d:b0:194:65fa:c354 with SMTP id e13-20020a170902ef4d00b0019465fac354mr4402952plx.20.1673598683253; Fri, 13 Jan 2023 00:31:23 -0800 (PST) Received: from hsinchu15.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id s7-20020a170902988700b0017f73caf588sm13466123plp.218.2023.01.13.00.31.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 00:31:22 -0800 (PST) From: Nylon Chen To: paul.walmsley@sifive.com, palmer@dabbelt.com, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: nylon7717@gmail.com, zong.li@sifive.com, greentime.hu@sifive.com, vincent.chen@sifive.com, Nylon Chen Subject: [PATCH 1/2] riscv: dts: sifive unmatched: Remove PWM controlled LED's active-low properties Date: Fri, 13 Jan 2023 16:31:14 +0800 Message-Id: <20230113083115.2590-2-nylon.chen@sifive.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20230113083115.2590-1-nylon.chen@sifive.com> References: <20230113083115.2590-1-nylon.chen@sifive.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754895955086427766?= X-GMAIL-MSGID: =?utf-8?q?1754895955086427766?= This removes the active-low properties of the PWM-controlled LEDs in the HiFive Unmatched device tree. Signed-off-by: Nylon Chen Reviewed-by: Vincent Chen --- arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts index 07387f9c135c..11f08a545ee6 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts @@ -52,7 +52,6 @@ led-controller-1 { led-d12 { pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; - active-low; color = ; max-brightness = <255>; label = "d12"; @@ -69,19 +68,16 @@ multi-led { led-red { pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; - active-low; color = ; }; led-green { pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; - active-low; color = ; }; led-blue { pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; - active-low; color = ; }; }; From patchwork Fri Jan 13 08:31:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nylon Chen X-Patchwork-Id: 43073 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp154570wrt; Fri, 13 Jan 2023 00:39:04 -0800 (PST) X-Google-Smtp-Source: AMrXdXvAiJf+0QTl9Wwa5GTBaIbkXWpNraB5OLLwmZyhgQXV6szsyavmgp79LYq83pQF9JhBRfIq X-Received: by 2002:a05:6a00:1da5:b0:577:9807:2db8 with SMTP id z37-20020a056a001da500b0057798072db8mr83268719pfw.3.1673599144132; Fri, 13 Jan 2023 00:39:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673599144; cv=none; d=google.com; s=arc-20160816; b=nxrJ9ky7I2VTR9B+tPXDDbBwo2mgwL7iLcY7MP1/kjl97FF4nTnbZ6+YlnfDxg9pd1 oJfkU+GqYgz6Exh1TRCdteC+v38tkay3EpZMqTp8b7Jhl7brYgZeBUiaAlGhnOnxbu+L gZ4jzyytll2dfNCB9w3V8y4GhSp5O7l30qa+aVpZq80fPqWgjkV3DZHwC6BwOfmo4TrF noq++wj7G9H/fbkseyJ+XyzMBU6vbbjYYtkggD2K24GR2xZ77mn7bm9AjRK8twd0m4pN pHbbBqm2iyj3D5jUw4Jv8dpYxOXW+MlMX4mCBDttdd4Lr2WBz3I4sr054vfX1ybKgKcL 1RtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=V6aCau9ok9jH3yQCwJE8fQSOUiSa5PU6TOL3Ajvf4Kc=; b=dThxmrU9H/owqcfGCsv33YXAR835SVZrISOqvic/c/gg9xDrS/msD+cMOcVUnen4ai rg+5nhSOaO5SHw+LMYrZUtL8cQO/qNxr+v0TANlcewKjYNkS63Aa1OxUUWpVnGPkrRMQ wM2LbzwkQcX9Mw5+1wCA06o+NwZwDD1LDfs43DrM5bL0Tp/TfNLsAI/IV564EP9NY2a4 cSPyMN/1SBTLY+aPO/cZV/zIcgDl9DeOzljKRL1dqzk/a+WYFm5ywLRGtnBokzAL5l3r 6fSQAKO7zjg8R6WMxII0xfJbLLD+p26rkzhNKjaoLPBwnv57L8o65DjOFoE3XJIXv3mp NKqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b="P4Abup/1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y3-20020a056a00180300b0057692dddc15si21422624pfa.19.2023.01.13.00.38.51; Fri, 13 Jan 2023 00:39:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b="P4Abup/1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231761AbjAMIbv (ORCPT + 99 others); Fri, 13 Jan 2023 03:31:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235363AbjAMIb1 (ORCPT ); Fri, 13 Jan 2023 03:31:27 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDA6232EB9 for ; Fri, 13 Jan 2023 00:31:26 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id b9-20020a17090a7ac900b00226ef160dcaso21952556pjl.2 for ; Fri, 13 Jan 2023 00:31:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V6aCau9ok9jH3yQCwJE8fQSOUiSa5PU6TOL3Ajvf4Kc=; b=P4Abup/1crUAKOjiLS9CVd2u9Z4bGK7XrA/T80YBSDRtaBicQ9skHpNtYMFTNUZj4b cd8VprJWowx9l5bxPudCN2e0R+OMo0h/3HH/KqlLQOvfKW+0YD2YYxxlpba6rO53GL3T V7kGpyhOTyQbJ079YIX9tOAE2gyC4VDS8GZevi1TkYwY416n5L/DUxgmpVVmbJA1vXPR m+E5ItcNclqzK+bWHaXhO18Wwi5iCh4NRa3Ewjg9y/Nu6qybbSpAwwJv+5j1UTh999IZ nBx62ff1ALzWmtca5ldC89Uv07GWRzfyu8tDLxHOEspaqHqPH+y+mGE26qbdI6XaFh8m hN9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V6aCau9ok9jH3yQCwJE8fQSOUiSa5PU6TOL3Ajvf4Kc=; b=qlPqtvRPoQUoGZ2C84eA7ARaHxSY8oTVAcuG7vh+ValciRZf7S6fD64PkJRM7XnjhZ 43hH5NWsXNK+KfVJakKky+GL2MpCOaUP9smh+rjZm1/3EO0M1cVuwSyrlnvXy2ZLbh79 S0D/yPRjZHTeRmleq6rHeS3X50cyoecwYKIYJwnIyhXCWEAT+QdraHIz0JK7IO9EGyNe mX5WsR7dMzgTIXDHeAnTJW42oynhrIuhyN98cG1UZ9a91y6XrZJybFGcFx6ClqvTfWAM ZYf7noeHZ5ZUwtf4I+PM3OMWb8FiTp80cw6avIq/E4EnrRjVvg4d117L5wQEBoetSqfX ueOw== X-Gm-Message-State: AFqh2kr++8DF0Z44O4zTgCaRvxtQFj+h2YCNcZnyqcGXWeimaxU6skg9 DKlzBNgewd65bO5x815IYCcUV+4Nl8I0t4tFHcc= X-Received: by 2002:a17:903:1343:b0:194:6103:1e18 with SMTP id jl3-20020a170903134300b0019461031e18mr3938051plb.65.1673598686241; Fri, 13 Jan 2023 00:31:26 -0800 (PST) Received: from hsinchu15.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id s7-20020a170902988700b0017f73caf588sm13466123plp.218.2023.01.13.00.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 00:31:25 -0800 (PST) From: Nylon Chen To: paul.walmsley@sifive.com, palmer@dabbelt.com, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: nylon7717@gmail.com, zong.li@sifive.com, greentime.hu@sifive.com, vincent.chen@sifive.com, Nylon Chen Subject: [PATCH 2/2] pwm: sifive: change the PWM controlled LED algorithm Date: Fri, 13 Jan 2023 16:31:15 +0800 Message-Id: <20230113083115.2590-3-nylon.chen@sifive.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20230113083115.2590-1-nylon.chen@sifive.com> References: <20230113083115.2590-1-nylon.chen@sifive.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754895896113526725?= X-GMAIL-MSGID: =?utf-8?q?1754895896113526725?= The `frac` variable represents the pulse inactive time, and the result of this algorithm is the pulse active time. Therefore, we must reverse the result. Signed-off-by: Nylon Chen Reviewed-by: Vincent Chen --- drivers/pwm/pwm-sifive.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index 62b6acc6373d..a5eda165d071 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -158,6 +158,7 @@ static int pwm_sifive_apply(struct pwm_chip *chip, struct pwm_device *pwm, frac = DIV64_U64_ROUND_CLOSEST(num, state->period); /* The hardware cannot generate a 100% duty cycle */ frac = min(frac, (1U << PWM_SIFIVE_CMPWIDTH) - 1); + frac = (1U << PWM_SIFIVE_CMPWIDTH) - 1 - frac; mutex_lock(&ddata->lock); if (state->period != ddata->approx_period) {