From patchwork Thu Jan 12 18:43:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 42711 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4054418wrt; Thu, 12 Jan 2023 11:07:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXvf81voOSNJQ8aZ5P2u2Yb+Dud1RH/gAGP10Rvst7VKk4lBGC4DYiLgOURdt4XsUc56QupW X-Received: by 2002:a05:6402:1245:b0:498:3bb9:941 with SMTP id l5-20020a056402124500b004983bb90941mr14854115edw.19.1673550433830; Thu, 12 Jan 2023 11:07:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673550433; cv=none; d=google.com; s=arc-20160816; b=iZkQgw3B374pmCpsSwcK/vJzNr4zRNXcicwyeFVXLTD26aKWtNuch+oSXv/gNPTtlc tsDU55WlUiYq/Aksz4sDyiHKdTRzASyRj7QxDTEPWtGlTI+GTLeB4gDK9lRaw98P1zcc 2aKLNY3bBxWX1KrsaEftfIhb1Gp9zrpwzODG/YML2ARGb2KNGL48Lo5QP+zdfUaIXgg8 J/n2BJiaFYIinUnAFUMYjxdm3ipzn/zaNccvf14vFCA2+A/OqJKNV0VJjINcj5RJGOqg sARyJAB5i9zrq7PfxotyWxkf2bNHdB8GV4qC5zTCzDYljY4sfwn4uzTDTkkZcFy+xlAj vrZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=sD0WmciD6aGDnjJ0n0Y1RfhYHb+M6lM1mw5QbrXgp2o=; b=QAvgdLCoZlcWVJ+mUI4xAx0Gwue6qsUT2cu7UyqPNo4SVCzNzCqbw6/3hDXi+palnP 0Y9D6WG1xqKs+ja2q7T2jeMf98iTOnz0VWq9Gyktn1G7TFflLBZc+b+R+gnnciIz/eXM sUcaV6cPSSbktN1u6F6MogxGxQ8xBXbVOSaGFiz0oQOmFBy7FVmFHAknxdT3rr6WjO7t jkBt9QtJX1w7AIiq9CNaSZp2jtEHbu14nZIxfIsn4mAUyYo5p9NvcFioWkuqpSPwbCr/ yPq1Wqyj6IDhjJs9US4oOrqb4/TiWIkb6FVsgZLOSas5hiWr4Ft2kabFqq4bvzs/L+QO Gz+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VVsrj5WM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u21-20020a05640207d500b00499b335829bsi12305146edy.447.2023.01.12.11.06.49; Thu, 12 Jan 2023 11:07:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VVsrj5WM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232200AbjALTEB (ORCPT + 99 others); Thu, 12 Jan 2023 14:04:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237748AbjALTDX (ORCPT ); Thu, 12 Jan 2023 14:03:23 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86CF569B19; Thu, 12 Jan 2023 10:43:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673548996; x=1705084996; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=XQH5u3DL5ISx2GfFC4iQ4W+ecE1+55/FppouOEOhfe8=; b=VVsrj5WMcC2BPr6ywLtnKXGPa4ohqPXLGkil3fAX56O5tjzutKLgXZQv MmFacd08PX9HKKNbXG5HbYuiYlws8jbuzQh8tyKc9a0RW3mischey3T7h 7Nk1PRJ/LSOjAZ1s2/iTGB+89f59I+alWSpGOri4WzDJ1wjIGDHp2ftto 01piTyp8UF5lDxwlExHmd8wosvWF5wL1qc5P2wtfyY431t+4lMr41yk/h PwKFOCGxVpCPRl+SDPCRTx6quZPvs9hkTVm6QTYH8BbsWnInHD4Hi4bMN oqfEV35ZsyoSfv7QqFFYvInvSSb7/dcCX4b3jeWZCJlirwXvHGvOPgCLe g==; X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="325844576" X-IronPort-AV: E=Sophos;i="5.97,211,1669104000"; d="scan'208";a="325844576" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 10:43:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="781868438" X-IronPort-AV: E=Sophos;i="5.97,211,1669104000"; d="scan'208";a="781868438" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga004.jf.intel.com with ESMTP; 12 Jan 2023 10:43:09 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 074E0130; Thu, 12 Jan 2023 20:43:42 +0200 (EET) From: Andy Shevchenko To: AngeloGioacchino Del Regno , Sam Shih , Linus Walleij , Chen-Yu Tsai , linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Sean Wang , Matthias Brugger , Andy Shevchenko Subject: [PATCH v1 1/1] pinctrl: mediatek: Remove duplicate assignment of of_gpio_n_cells Date: Thu, 12 Jan 2023 20:43:40 +0200 Message-Id: <20230112184340.79606-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754844819870913823?= X-GMAIL-MSGID: =?utf-8?q?1754844819870913823?= The of_gpio_n_cells default is 2 when ->of_xlate() callback is not defined. No need to assign it explicitly in the driver. Signed-off-by: Andy Shevchenko --- drivers/pinctrl/mediatek/pinctrl-moore.c | 1 - drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 1 - drivers/pinctrl/mediatek/pinctrl-paris.c | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-moore.c b/drivers/pinctrl/mediatek/pinctrl-moore.c index 1ec0413959e1..007b98ce5631 100644 --- a/drivers/pinctrl/mediatek/pinctrl-moore.c +++ b/drivers/pinctrl/mediatek/pinctrl-moore.c @@ -574,7 +574,6 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw) chip->set_config = mtk_gpio_set_config; chip->base = -1; chip->ngpio = hw->soc->npins; - chip->of_gpio_n_cells = 2; ret = gpiochip_add_data(chip, hw); if (ret < 0) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index 553d16703475..665dec419e7c 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -906,7 +906,6 @@ static const struct gpio_chip mtk_gpio_chip = { .set = mtk_gpio_set, .to_irq = mtk_gpio_to_irq, .set_config = mtk_gpio_set_config, - .of_gpio_n_cells = 2, }; static int mtk_eint_suspend(struct device *device) diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c index 475f4172d508..17eead44b675 100644 --- a/drivers/pinctrl/mediatek/pinctrl-paris.c +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c @@ -987,7 +987,6 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw) chip->set_config = mtk_gpio_set_config; chip->base = -1; chip->ngpio = hw->soc->npins; - chip->of_gpio_n_cells = 2; ret = gpiochip_add_data(chip, hw); if (ret < 0)