From patchwork Thu Jan 12 16:39:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 42654 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4003026wrt; Thu, 12 Jan 2023 09:17:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXtUY4e+2y6HuKYYDIuftr/iQDFH2OHMz0WsA3dog/pJc7y3GgghWl9eJ7bF8Fdc4wKUjNQR X-Received: by 2002:a05:6402:1ca4:b0:497:b6bc:b811 with SMTP id cz4-20020a0564021ca400b00497b6bcb811mr18529751edb.33.1673543874684; Thu, 12 Jan 2023 09:17:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673543874; cv=none; d=google.com; s=arc-20160816; b=kjGxqd+w+TQ2vDXn2vL+qC8/xZErhF/Zv+iw6V6mcIYHCWXZL4xcB8NVWZdtYVWsmp evoqWuul2pCQ3GnUEpAo0zVL8g1h9UD+GBA6l1m95hk1Wt/kIEvTa8u4+AZ2u2ecSr8t /zeWnc0PvgEPSNWEMT39yxiXmYXe4J52SlI2WRbT4JWLhbHazpxoZPeb7Hzco9hBqT9g 8AOBMx2KZwTyFfR969itV9q4So035mLIhEkJensBvcTgIxC/Rso7qpsKTAh5WIDpTczC q4+ia12yUAR3dI3l1W+gSNpn7QBvOwC/3uvvSwhdJ6pmx6LQ30Yoqd6/HEN215ECYgiM y/Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=HQcYcwEy63AjX03jcXk8PkEu+VUSCi2QTPLc98k6A/g=; b=Z1WITM5VcXlgi5woYwbLyw6SFrq1lX3W/5L+H2hFegITemXCe9XDixb0anuVAJXA5y Z3J5N08AJ1Ib0yck1dWIHzpNVY+FI1pFRGBPlrfAuTi2OhEchb0kqdl8btVHPzm9TZ0N f/ToxLJZYfNow+OkBVotFvKV20gCZ9Ce48pKLBwZf78EiR3ljelIj0jk+osKJOHKIvF6 67qPbxp0YpkTx5dErelbM5kZ63u6/SHthrxSyZ+IzMehDSTrCjzM0IZez/2TWQylnQmJ 5anP6ncm3N2C4Iw03Q82M2MiVv2gnuaOCHVizpOixHnSpoXy+Voq7fSO+aLf09Eg4M4r 38tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="UZUU/AIT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ee38-20020a056402292600b004591f959c3bsi15902519edb.427.2023.01.12.09.17.30; Thu, 12 Jan 2023 09:17:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="UZUU/AIT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240989AbjALQxe (ORCPT + 99 others); Thu, 12 Jan 2023 11:53:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241612AbjALQuz (ORCPT ); Thu, 12 Jan 2023 11:50:55 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C47875B145; Thu, 12 Jan 2023 08:39:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673541584; x=1705077584; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=JF5iRDY0fpuumx63GOwMxnOeegscSLVnrkxXT4Iq3pE=; b=UZUU/AITYcPRovBh5YnLR1t08amSk7p1JvgnXAFkVOmpQ4Ey66RqMHuS g70hiiHwttMAFUCQPmUh/jMd9F6zEZTTfLx0jwIUivacxt8tE2N2eL3kQ 5pLFK56tOl2Jt88cTk28PJh2oRcob7zqZZueyJTWLxbfXJOOM6PN+F1lG 5IhvvYishx9YadrRbbCOcjKNHi9cdIdqi0qyXOzNDb+dJf0UASc8Wmfjq 7D8Od/yx+NNzM0ppjr06rn1wf3fN18b58G0COjKD3etmYibA84JwASdIh YMUQpaR8EM9FWBFhnOTDkpYQQ+2buTpM/KzR48rmASh460LQl9+rIdQ6d A==; X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="304132804" X-IronPort-AV: E=Sophos;i="5.97,211,1669104000"; d="scan'208";a="304132804" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 08:39:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="635447549" X-IronPort-AV: E=Sophos;i="5.97,211,1669104000"; d="scan'208";a="635447549" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga006.jf.intel.com with ESMTP; 12 Jan 2023 08:39:08 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 1D4DAE1; Thu, 12 Jan 2023 18:39:43 +0200 (EET) From: Andy Shevchenko To: Bartosz Golaszewski , Andy Shevchenko , Moses Christopher Bollavarapu , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski Subject: [PATCH v1 1/2] gpio: zevio: Remove duplicate assignment of of_gpio_n_cells Date: Thu, 12 Jan 2023 18:39:40 +0200 Message-Id: <20230112163941.73143-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754837942032505390?= X-GMAIL-MSGID: =?utf-8?q?1754837942032505390?= The of_gpio_n_cells default is 2 when ->of_xlate() callback is not defined. No need to assign it explicitly in the driver. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-zevio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c index ce9d1282165c..c9f4c26cae3d 100644 --- a/drivers/gpio/gpio-zevio.c +++ b/drivers/gpio/gpio-zevio.c @@ -162,7 +162,6 @@ static const struct gpio_chip zevio_gpio_chip = { .base = 0, .owner = THIS_MODULE, .ngpio = 32, - .of_gpio_n_cells = 2, }; /* Initialization */ From patchwork Thu Jan 12 16:39:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 42653 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4002679wrt; Thu, 12 Jan 2023 09:17:17 -0800 (PST) X-Google-Smtp-Source: AMrXdXsGJCEpq1DzoQLRoThwDyh+CjigDmCCHpWLw8QSKRFfleCJfYK9WlL1jFepXTE4yC69cJbM X-Received: by 2002:a50:a401:0:b0:46d:53d7:d21e with SMTP id u1-20020a50a401000000b0046d53d7d21emr70036300edb.27.1673543837529; Thu, 12 Jan 2023 09:17:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673543837; cv=none; d=google.com; s=arc-20160816; b=a5TwY6R3/XoH6wEt2bqQsqgQ5k8ZzQ7z0CkNNeqbkq+iIypp/8gimJAYtpsqDvQ5PY 6YFZJe52dnRcsf66jz6ap8w1a0q8lSagPLabpfOt1Nhz9uluwKISBqZrUblptUIIrlxG cCk55H4/Lju5pV05C2kYcUAEeVrTlY2oWFLSmSbClpRrks7n5wXQv2Mulig31by77NO2 g3qXmAJ2rsgU+Xzs4RXxfQNPOBf7W9sCOsCl5OK5jH8dcYUKJTEQCYISWjBbhDcvyIyI QBzAjkE8hu98/zvp6Ggge4q+5OJIH+G03aSwIdDhLAFgF9fD91b4W2XJZ5N/m6mQ7sr0 AyLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=i5hjt86TbLVhMIxvMdk0DkOG1T8HHGMRDNU2V37SVIE=; b=g+Osy3hJZ8rpQWeCfQ9O4dOouawU2oyTmstCoi6aXIbel29F2XROv+0SwkZe1CMdhm wVMGeAorB23gvlaIkz6T0SDeiZdZ2Ss/dUhpb5grQlih8SSWXsSJvSuEqvLg6xooYZs+ 1BwSlx5GuALMXggHPmYqE+YjorLsC6feFjp065vpe20a7821C/Pdslg4lsVaqSvQwXXc 8QuWT/4hVWW/qzDItFGlqcrFYoAq++hhr+KdBsHLdeEaMj15EzXOzEPWbZ8Q/drG9Vol 8JtAS95+/ayt8btmuCSSCGZ/UO7/6f3iHrzml+00X4ijqlMBwQ1/dB2YgeExy1B1wIpj GDEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=boCmxMT3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xe9-20020a170907318900b007c101c9237asi6758641ejb.668.2023.01.12.09.16.53; Thu, 12 Jan 2023 09:17:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=boCmxMT3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240956AbjALQx2 (ORCPT + 99 others); Thu, 12 Jan 2023 11:53:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241620AbjALQu4 (ORCPT ); Thu, 12 Jan 2023 11:50:56 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B5855B149; Thu, 12 Jan 2023 08:39:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673541585; x=1705077585; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WIWZ0DmAMKPeq1ebVrtoFWO2d/xuqrJNfK25fBjzBSY=; b=boCmxMT389eKgtro9IqEkxHiFSysEpRNfuWj4YhKfbz2HMzWEDZzHwrE o5aXMcIn6hf6NU6M1SFyLdnbrluwThKvv/bgAn5W6ulHOMuw0FYpdIIXO 82zoHlxEPUlLcaJloz/KE+TMw3mJdBy22OhxsRfxCGLDqRt5T/HuHfFWw lkPOsAqQ2jsE9qnJfzYF82gvZDEtSD14d8jUyh3nQ//sbYwnh3CxxK8rq G7teWj2Dd9oGwL/spohvjuvbJeYRsAYfW3xHHQUL2w1FCD4pa5kENkoXL Cdk/y0sXOPmTc5xgRXV8B20/LwmHJOH6RSJMlW293zBWbJ5zcqEBJuctC Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="304132815" X-IronPort-AV: E=Sophos;i="5.97,211,1669104000"; d="scan'208";a="304132815" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 08:39:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="635447556" X-IronPort-AV: E=Sophos;i="5.97,211,1669104000"; d="scan'208";a="635447556" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga006.jf.intel.com with ESMTP; 12 Jan 2023 08:39:10 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 26792130; Thu, 12 Jan 2023 18:39:44 +0200 (EET) From: Andy Shevchenko To: Bartosz Golaszewski , Andy Shevchenko , Moses Christopher Bollavarapu , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski Subject: [PATCH v1 2/2] gpio: zevio: Use proper headers and drop OF_GPIO dependency Date: Thu, 12 Jan 2023 18:39:41 +0200 Message-Id: <20230112163941.73143-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230112163941.73143-1-andriy.shevchenko@linux.intel.com> References: <20230112163941.73143-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754837903127120538?= X-GMAIL-MSGID: =?utf-8?q?1754837903127120538?= The driver doesn't depend on the OF_GPIO to be compiled. Hence the proper header to use is mod_devicetable.h. Replace of*.h with the above mentioned and drop redundant dependency. Signed-off-by: Andy Shevchenko --- drivers/gpio/Kconfig | 2 +- drivers/gpio/gpio-zevio.c | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 3b2078a654ce..a2f64f880163 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -751,7 +751,7 @@ config GPIO_XTENSA config GPIO_ZEVIO bool "LSI ZEVIO SoC memory mapped GPIOs" - depends on ARM && OF_GPIO + depends on ARM help Say yes here to support the GPIO controller in LSI ZEVIO SoCs. diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c index c9f4c26cae3d..61e47456c33a 100644 --- a/drivers/gpio/gpio-zevio.c +++ b/drivers/gpio/gpio-zevio.c @@ -5,13 +5,14 @@ * Author: Fabian Vogt */ -#include +#include #include #include -#include #include -#include +#include #include +#include + #include /*