From patchwork Wed Jan 11 18:42:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Keith Busch X-Patchwork-Id: 42141 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3481356wrt; Wed, 11 Jan 2023 10:47:44 -0800 (PST) X-Google-Smtp-Source: AMrXdXtOyStd9brqcYLRvl5T8vVDoqYK/3WduNtLzHFlXKN7+IDD79Ioyr5D+Qhlyp1z4DS4FDVp X-Received: by 2002:a05:6402:793:b0:493:597e:2190 with SMTP id d19-20020a056402079300b00493597e2190mr19285730edy.38.1673462864384; Wed, 11 Jan 2023 10:47:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673462864; cv=none; d=google.com; s=arc-20160816; b=bOQXaVOPLwzFy+P3EZlQXYL4uNFpZud+96HvfRUxCop4NLgHAVo+Sq/L0buc06WcOw G+TyAgMinEaRSgVyZNAGZAAx0tGGyizl6Jsc2XN9Cj8d7ElIqOxshjIwzF1k2GR+lgsk ozLl3+1XPdRBjmb16qmo5wIaLUDxa6b30iTwQz+iqtaRPfyyDkkYSYPC7KYWpS5wZQL7 LxKiOm2ApS8MKfHB2kFWmqiFDgNjkKm8XXDfCALxEnDBFfGCLvioTXaODWBFejRbEIJU DBkudtg+6b4HBmB28uY0wul62l0oYX/YFsLAOvokopCnykncRz8l3WsRSBZGjz/Vvksr ok2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7p+BnnT0sLmST7e3EtxXjdtABFJPi38m9osctzdzx6Y=; b=lsAigLSsLRzZ890/wYKfFrcrWluIGzTgl2k2BhM3NQMyu2erROs7+Ge8pVQkaD9zJs tC5CE10dN3J8wuYzCM5+mbgNtCwIZuxVB7PoHyfpB9sbLuClnUpiMJHuy3Oa8u5ThO6o dVq2l5VQRz41DBawrtGus1NL/kzVFXoRzk18N2l7v80veB/fPnbzxGNT+4wlpCAakO8H AlFZk/2F7JdC3waHejjjTXrhJHAoPHvfphQ1MhdG1Rj6pOLMg0l/DZlJFso773EujSeM S9gtUkWNvCAa3ZQM/qwKtRRRD799yKRZu8Wt5zGVuIBZ6YgX5m0QxUjSAFYx50WmDl04 OZBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@meta.com header.s=s2048-2021-q4 header.b="E/jA8tZ/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=meta.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p20-20020a1709060dd400b007d1460bb759si11564550eji.948.2023.01.11.10.47.20; Wed, 11 Jan 2023 10:47:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@meta.com header.s=s2048-2021-q4 header.b="E/jA8tZ/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=meta.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235196AbjAKSnD (ORCPT + 99 others); Wed, 11 Jan 2023 13:43:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235496AbjAKSnA (ORCPT ); Wed, 11 Jan 2023 13:43:00 -0500 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACADE3C3A0 for ; Wed, 11 Jan 2023 10:42:59 -0800 (PST) Received: from pps.filterd (m0109334.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30BGIknM032656 for ; Wed, 11 Jan 2023 10:42:59 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=s2048-2021-q4; bh=7p+BnnT0sLmST7e3EtxXjdtABFJPi38m9osctzdzx6Y=; b=E/jA8tZ/GwlYC0kDZeKfYaJIjXgL8ah8PiXYCsiHJSsTYsnRoeFwyXJDJ9A5tkl2Jl8p bVwvxoInuG5eFQIvfOsnEoFyQZAowekYsWVZt+knoMpi1wZsB59OicpDrG4nbdw+r9gp 2nTmmqEjI54GAYDsefz4hkJoSRHcUX4Ch4lpdzpe/WV6y+vJ4hJ0rvbqPtT55ioCfhRx 1OT/Ul9ZMLRAjE1iMxjzaNGrZEWXlaCtvM4ue2QwZywKVdJa9X8akrlbBqV0cVNtgYJy 4q3GdoZYvxAXcAxloo7gKHfW0FeFcG5CrqeClzQmXg6Lgdcz3ouAVE7ak8M20ubTIhaE qg== Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3n1k51wb2g-9 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 11 Jan 2023 10:42:59 -0800 Received: from twshared25383.14.frc2.facebook.com (2620:10d:c085:108::4) by mail.thefacebook.com (2620:10d:c085:21d::4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 11 Jan 2023 10:42:54 -0800 Received: by devbig007.nao1.facebook.com (Postfix, from userid 544533) id 1F7C4EBD9505; Wed, 11 Jan 2023 10:42:46 -0800 (PST) From: Keith Busch To: CC: , , , , , , , Keith Busch Subject: [PATCH] caif: don't assume iov_iter type Date: Wed, 11 Jan 2023 10:42:45 -0800 Message-ID: <20230111184245.3784393-1-kbusch@meta.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-FB-Internal: Safe X-Proofpoint-ORIG-GUID: rOxTdqSE90exRdG924vy1S_tmthWCxwC X-Proofpoint-GUID: rOxTdqSE90exRdG924vy1S_tmthWCxwC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-11_08,2023-01-11_02,2022-06-22_01 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754752996066617293?= X-GMAIL-MSGID: =?utf-8?q?1754752996066617293?= From: Keith Busch The details of the iov_iter types are appropriately abstracted, so there's no need to check for specific type fields. Just let the abstractions handle it. This is preparing for io_uring/net's io_send to utilize the more efficient ITER_UBUF. Signed-off-by: Keith Busch Reviewed-by: Jens Axboe --- net/caif/caif_socket.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/net/caif/caif_socket.c b/net/caif/caif_socket.c index 748be72532485..1f2c1d7b90e23 100644 --- a/net/caif/caif_socket.c +++ b/net/caif/caif_socket.c @@ -533,10 +533,6 @@ static int caif_seqpkt_sendmsg(struct socket *sock, struct msghdr *msg, if (msg->msg_namelen) goto err; - ret = -EINVAL; - if (unlikely(msg->msg_iter.nr_segs == 0) || - unlikely(msg->msg_iter.iov->iov_base == NULL)) - goto err; noblock = msg->msg_flags & MSG_DONTWAIT; timeo = sock_sndtimeo(sk, noblock);