From patchwork Wed Jan 11 13:14:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 41974 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3312166wrt; Wed, 11 Jan 2023 05:15:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXviQdg/F1EUmtbB+wbabUUV05srpzROb5qEErqabZYEDh98RVuurG4WC734fLFiacp80GYz X-Received: by 2002:a17:907:8e87:b0:84c:a863:ebe6 with SMTP id tx7-20020a1709078e8700b0084ca863ebe6mr37077893ejc.43.1673442914264; Wed, 11 Jan 2023 05:15:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673442914; cv=none; d=google.com; s=arc-20160816; b=SbEd7a9bFJtnknnZH2yARzXMicgz49ojcBtCkBiX1zhSht69X3YU039DYzw3x6ryVv JE6XIBNwGtgxZYJTMgUx7UtFyetZ1MSc//oaADPLeSodRK/7AX5NOdwm8CwSsN2Bm8o1 EZsG5haPG0xZUtAdYml94w0VDYDmqY2ho09EFi3pEr1zo9YwQH3s2/m4eD1DUBi8Sv9S PmYHfCYplRUti9/3S4JVzxwJuj/cARGG/fGLLTjznAoEr1TMrFuDdo1Pk1Pcquas2RLN AZOW41zvn93iHkU/gyAgcUsD53/DOGnaNZle1QvGVnXBk1gkiKgPGoKG33EkeG1W8k9D r4lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=DLKjgckHwpn8nMJaea/zExBeHp07ccRg4foNi8AwkPA=; b=rXzgr5+/VpKA/X3aooZHVmO3b+hjAxLgVYJV8NOCldHX3DHzE95TIOH6BJvPeo/FT/ N36QQGDhSkJu1fSjafZlezm0ZZs5QSyMlUaBkp0TNhYpbVV0uWQcdRXV5gLQKEpkmC3G 7XhOx9aeuOYb3E/Zl0qQc04ZD/ybBSSGKZJCcGCtwE34vHAMHlBUiq3UwEAXwzsF5eUS J3HFtZKX2ga1Xt3g/UwNBhC7lXs6me2qVC4wL3rb0hqjx7M7uJgJg2l5KTDee9z/Ft2s eyFWhQ7o61IbPbyxiPqDmRFVjZzZwSsEynt5lIHBjf7UZ/QCvtfbqY0MGCet5lx1yXg+ LXqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=YBjDMmp5; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id jg32-20020a170907972000b0078db6f56d51si16058356ejc.808.2023.01.11.05.15.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 05:15:14 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=YBjDMmp5; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 49DD4385700E for ; Wed, 11 Jan 2023 13:15:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 49DD4385700E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673442904; bh=DLKjgckHwpn8nMJaea/zExBeHp07ccRg4foNi8AwkPA=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=YBjDMmp5cM7lNa5lDdq05xAiHBxWwSuK1GdSaSXuY2E4evKmlanZF1L5MdPKN8XIH AaguIRPEl/bW/Yok2e/WMBKwnB235dooOEeqTdXC2mbIE55zrfB6ApdK3CKT/TuOpp QmLjxdIiA+N0jr9AyW+0MSLV2BDuPLZCJ1XMEJKw= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id C41123857B93 for ; Wed, 11 Jan 2023 13:14:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C41123857B93 Received: by mail-pj1-x102f.google.com with SMTP id z1-20020a17090a66c100b00226f05b9595so2004432pjl.0 for ; Wed, 11 Jan 2023 05:14:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DLKjgckHwpn8nMJaea/zExBeHp07ccRg4foNi8AwkPA=; b=xqCAzU8341/2vHmVxvCZRGu5v9bg3Kaw38ThMOOMgCGcGrsw8GrJw2XHJtvlsTEU/1 MfYCAMZb6F66t5nXyEEPOteErYTZyDwQ1PxriBrbejpNkQdCAFihY180C0/WyVKksMe8 gzikNvAGH9XYu0KTMKZ4/2iz/P20td3BU+qwWTr0ykFqsat7s3dzHeS3qusEKWPP3AwP 21/ah+cMK0hdHWU33OU7jybu37IJEQxYxPX7j+H3CAL1dYIIkrgtDDoPlLewVyUrsrXG 6YmoEQ1GYDvmdLBgnonA0jnaCvR5tprUY0HFXd2VG5ZBgGCCJ0zyIKT8tGD78GP2e/d1 D4IQ== X-Gm-Message-State: AFqh2krKTs4RFohAn696rurd6imQsvMkzBO9jHBwFSmA7Ju19irEcPj3 mrmUQpcjAWsN55oflIgW4LxSslKsK10= X-Received: by 2002:a05:6a20:8409:b0:a7:16c4:d2c4 with SMTP id c9-20020a056a20840900b000a716c4d2c4mr3496788pzd.47.1673442894632; Wed, 11 Jan 2023 05:14:54 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:32e3:1a56:4865:4775]) by smtp.gmail.com with ESMTPSA id 4-20020a170902c10400b00194529543bdsm647006pli.25.2023.01.11.05.14.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 05:14:54 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id C11B41142CD2; Wed, 11 Jan 2023 23:44:51 +1030 (ACDT) Date: Wed, 11 Jan 2023 23:44:51 +1030 To: binutils@sourceware.org Subject: Fix XPASS weak symbols on x86_64-mingw32 Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754732077266053905?= X-GMAIL-MSGID: =?utf-8?q?1754732077266053905?= Fixes commit 16fea92ccd99. * testsuite/ld-scripts/weak.exp: Don't xfail x86_64 PE targets. Do xfail other PE OS triplets by moving code setting xfails. diff --git a/ld/testsuite/ld-scripts/weak.exp b/ld/testsuite/ld-scripts/weak.exp index bf6f8862571..9df57c7d97f 100644 --- a/ld/testsuite/ld-scripts/weak.exp +++ b/ld/testsuite/ld-scripts/weak.exp @@ -23,20 +23,21 @@ set testname "weak symbols" # This test only works for ELF targets and some PE targets. # It ought to work for some a.out targets, but it doesn't. -if {! [is_elf_format] && ! [is_pecoff_format]} { +if { [is_elf_format] } { + # hppa64 is incredibly broken + setup_xfail hppa64-*-* +} elseif { [is_pecoff_format] } { + # Weak symbols are broken for most PE targets. + if { ![istarget i?86-*-*] + && ![istarget sh-*-*] + && ![istarget x86_64-*-*] } { + setup_xfail *-*-* + } +} else { unsupported $testname return } -# Weak symbols are broken for most PE targets. -if {! [istarget i?86-*-*] && ! [istarget sh-*-*]} { - setup_xfail *-*-pe* - setup_xfail *-*-mingw* -} - -# hppa64 is incredibly broken -setup_xfail hppa64-*-* - if {! [ld_assemble $as $srcdir/$subdir/weak1.s tmpdir/weak1.o] || ! [ld_assemble $as $srcdir/$subdir/weak2.s tmpdir/weak2.o]} then { # It's OK if .weak doesn't work on this target.