From patchwork Wed Jan 11 11:23:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Wagner X-Patchwork-Id: 41899 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3263217wrt; Wed, 11 Jan 2023 03:26:33 -0800 (PST) X-Google-Smtp-Source: AMrXdXssVGx/V/tMLb+71eGvtbBluNwk6d7uVcRXGe7QOkdKgbS9xQA8GInyXH0bojtRXOTjTNvV X-Received: by 2002:a05:6a20:93a1:b0:b6:157e:dae8 with SMTP id x33-20020a056a2093a100b000b6157edae8mr6028314pzh.1.1673436392930; Wed, 11 Jan 2023 03:26:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673436392; cv=none; d=google.com; s=arc-20160816; b=d5wuSrf7cOEJG+aF+J4bF0G5SJeiVjjJszqDumT2OpKixTt+hfGcFfp0LfsOsJ8R4d Tr3g1i52OPOvn0VAIAShv4O4r3n/jsxQW8yDebl/nWp1CZf/CB9i+uXDqgPDHgejnmTh pvsU8WIvNNVl8cyW1xTskBgn/kAGZ4o26+YlHZ2BlFly3WAt4caoKWOLYix9sBHj9oxI ovQQb5O3fhmha6Ot5L+Eg5KX2S3E+eOrmP0rszbgBIjH33uzzF2EIA4yUKyzyJApY3Dc 7d53vojx16owtA5VylqR3LGSE/vFELeATonaEYr2qJqgqJMsBOqjg+86yQvc6a1DWgJW 5/tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=k16DrpOUxbhsRxLzoa57Nj/MLqGxBj4Ih9CJHaqI8AM=; b=Vvem4BhDOI0hr15Rfx3e1gfUY+6PHwSoU3QUoNFf2LMIoqutZcAqiUs5XQHzmft8Fm iWgROMW5LzspGl/yRfeemupeiH/yeaIM/MBck+iSZttM7rjcHgYLCHDm0L6JCghtXCsa 1OsCb2k8PZjyAN55YF+/fxiB8XPHYvlzYdPcH54thzy4mrRzVXumGCFDfP0W3PzeVnqA dF//u51jHf9QsSPO2SvCm/hVSnqtj3j8Yl3Wp3FVfdY6vi9qSNtSUris9IpJTA5eASZJ zeM0oNFGDFVbF6HXVxjM8hS+AVXT9m5z1XA08GTQKJxb2bm2B1MHR3YtvQaJIlQL2gXj Bu/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=zQ96q5P8; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=dHdmhZkL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w10-20020a63160a000000b00476f87434easi13309636pgl.711.2023.01.11.03.26.18; Wed, 11 Jan 2023 03:26:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=zQ96q5P8; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=dHdmhZkL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230062AbjAKLXx (ORCPT + 99 others); Wed, 11 Jan 2023 06:23:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232109AbjAKLXq (ORCPT ); Wed, 11 Jan 2023 06:23:46 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE1689F; Wed, 11 Jan 2023 03:23:44 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 4877346D1; Wed, 11 Jan 2023 11:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1673436223; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=k16DrpOUxbhsRxLzoa57Nj/MLqGxBj4Ih9CJHaqI8AM=; b=zQ96q5P8kUwlq2ViOTDco7zZr/gpS/0twHmZfwGz/P2yAoTiaHrxYjq0FfLUtr8HSAmP6o Ih19Wn6UaimUC6uX8gG+xWQhHmuS8hdE1VQiLJgwzd3/A/Agzp14WEhyKXIzUiAnOlHwMO +XdrujHDUFXYz5fc9eX/cwbF7BshnJ4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1673436223; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=k16DrpOUxbhsRxLzoa57Nj/MLqGxBj4Ih9CJHaqI8AM=; b=dHdmhZkL+TL95cqdFa4Gj8iJ75m4pUBgVFN6iMRTLm0KmS0U+ABS2rzuMRzcJpfJ5mw6vS kQN0/Qdd2oBhvJCQ== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id 420922C141; Wed, 11 Jan 2023 11:23:43 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 17828) id 3636051B7AB8; Wed, 11 Jan 2023 12:23:43 +0100 (CET) From: Daniel Wagner To: James Smart Cc: Dick Kennedy , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Wagner Subject: [PATCH] lpfc: Handle gracefully failed FLOGI attempts in devloss callback Date: Wed, 11 Jan 2023 12:23:41 +0100 Message-Id: <20230111112341.107989-1-dwagner@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754725238854111911?= X-GMAIL-MSGID: =?utf-8?q?1754725238854111911?= When FLOGI attempts fail, the vport can be released via lpfc_nlp_release() function. This function will set the pointer to NULL and the node state to NLP_STE_FREED_NODE. Though it wont stop the devloss timer in the upper SCSI layer. Hence when the devloss timer eventually fires, lpfc_dev_loss_tmo_callbk() is called and it tries to operate on vport NULL pointer. Just do nothing in this case. To be extra cautions also check for the state and issue a warning if we have an inconsistency. Signed-off-by: Daniel Wagner --- lpfc 0000:65:00.1: 94: [20252.520693] 7:0357 ELS CQE error: status=x3: CQE: 116b0300 00000000 31420002 90010000 lpfc 0000:65:00.1: 95: [20252.520707] 7:0321 Rsp Ring 2 error: IOCB Data: x116b0300 x0 x31420002 x90010000 lpfc 0000:65:00.1: 7:(0):2858 FLOGI failure Status:x3/x31420002 TMO:x14 Data x11140820 x0 rport-18:0-1: blocked FC remote port time out: removing rport **** lpfc_rport_invalid: Null vport on ndlp xffff88828bd82e00, DID xfffffe rport xffff8884f936e000 SID xffffffff BUG: kernel NULL pointer dereference, address: 0000000000000000 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 0 P4D 0 Oops: 0000 [#1] PREEMPT SMP NOPTI CPU: 14 PID: 86204 Comm: kworker/14:0 Tainted: G OE X 5.14.21-150400.24.18-default #1 SLE15-SP4 695ab7a8fc20f5ddb345280570966cd1eb06d469 Hardware name: XXXX Workqueue: fc_wq_18 fc_rport_final_delete [scsi_transport_fc] RIP: e030:lpfc_dev_loss_tmo_callbk+0x50/0x4d0 [lpfc] Code: 00 00 00 0f b7 8b ac 00 00 00 48 c7 c2 e0 d1 c6 c0 44 8b 83 98 00 00 00 44 8b 8b 94 00 00 00 48 89 fd be 80 00 00 00 4c 89 e7 <4d> 8b 2c 24 e8 37 9e 04 00 4c 8b 83 f8 00 00 00 41 8b 90 e0 02 00 RSP: e02b:ffffc9004d853e38 EFLAGS: 00010286 RAX: ffff8884f936e510 RBX: ffff88828bd82e00 RCX: 000000000000ffff RDX: ffffffffc0c6d1e0 RSI: 0000000000000080 RDI: 0000000000000000 RBP: ffff8884f936e000 R08: 0000000000fffffe R09: 0000000000000000 R10: ffffc900401fbd98 R11: ffffc9004d853c80 R12: 0000000000000000 R13: ffff8884f936e000 R14: ffff88810b705000 R15: ffff888126973080 FS: 0000000000000000(0000) GS:ffff88888e980000(0000) knlGS:0000000000000000 CS: e030 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000000 CR3: 0000000103f50000 CR4: 0000000000050660 Call Trace: fc_rport_final_delete+0xec/0x1c0 [scsi_transport_fc e9142b03c2f4a15da538eb15a15c5b37fc11a87f] process_one_work+0x264/0x440 ? process_one_work+0x440/0x440 worker_thread+0x2d/0x3d0 ? process_one_work+0x440/0x440 kthread+0x154/0x180 ? set_kthread_struct+0x50/0x50 ret_from_fork+0x1f/0x30 drivers/scsi/lpfc/lpfc_hbadisc.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index 83d2b29ee2a6..e7dd5f90d6c4 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c