From patchwork Tue Jan 10 20:20:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 41630 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2952461wrt; Tue, 10 Jan 2023 12:23:13 -0800 (PST) X-Google-Smtp-Source: AMrXdXumOKF+Kb31MAkimTwvidhj3TqFsE3xpYPEkpe3ESqFn9b3wU1wW7nbAMdvndZwXT8+A5lc X-Received: by 2002:a17:906:7254:b0:7ad:bc7e:3ffd with SMTP id n20-20020a170906725400b007adbc7e3ffdmr61559945ejk.42.1673382192822; Tue, 10 Jan 2023 12:23:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673382192; cv=none; d=google.com; s=arc-20160816; b=lRGPFp+tHEV63ZSab5YZFOxfA1yebd6kMZ/4Fi9lbUsc2S+aHZVZ0NfFx9FE35isNn PtTC51gv1uSk+0ZmJ5OOj0ntFqxP9DFXqWRMTLgQGmOIhTE/DtMq7xvTcQe4TpmCfaqH ZmkesBmrsi90WkGcsRoYP0FWhrTLTSO+AZEWyAmmHetteSxPs4wS8vVY5n42LIk7QtTV 67jHqx+DFJi96BP8C7zVw3SRTtJVkLI1yiMTVuRhj0df3Aw4R8TIrf6Je2zJ2QN4jLno mwjA4/wc805XQUnnXYsO5ffZggo0ppZc2vh9jgEc9VVBS85gEIQ8zWKiJr6iEjjkIT9j ZPYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=Kw4TGnbymzBxgZsB9RHdKGCwqR4y1NuBrs0gA6uq7YE=; b=rYOCIHX5Z++Btyixr3jXKEuVgKWOHW4Ng8938U2Eq162lDHN8PkNKB/zHcs561RRUX TlSSKkPaC3yHTkULU/3UeGTQ9QzynndKeuglI0M9PvFpiD9dEO1ECRtQICvcEAlvp42s RRWUgNRVIixy7BwDdE9fVkVyz8VsY+IazCT13gEGCPsI1KS9u1tG3D/qff5Bx7PpFkjm XbbRJolRjY65Bn2/7MlH7mSrsl6GtrO9haHPjSNz150lBa5KOhCTKdc7E7SDKo2GDujY l2/Fq8maVvW/QktY5egItjfYjM6ZfbTmDsI11LHvCQcvpdTPV+D5LelGbYp/Z0JzH+sU iJtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=PkLGkBDZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dm3-20020a170907948300b007c16f74db39si12397368ejc.745.2023.01.10.12.22.43; Tue, 10 Jan 2023 12:23:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=PkLGkBDZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232024AbjAJUUY (ORCPT + 99 others); Tue, 10 Jan 2023 15:20:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231553AbjAJUUW (ORCPT ); Tue, 10 Jan 2023 15:20:22 -0500 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A36565A8AB for ; Tue, 10 Jan 2023 12:20:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1673382014; bh=3IN9oMdJEqlNBIK1U/bjP9YXRSbJh4/m3TFLBgmJQjI=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type; b=PkLGkBDZMDIMzc1ZUqgcyv2wtAU5J4WrlCj5Gt/uw9+WrxuWBhUiPXinVBOirqn4S 5vXM3auhPPhwgflkNf0oWVy97405s1+2SSOUEZhb6w93CiFlhCRX2mmnUomEyuzb4V 9ZtpT23PtPkFuM6QKRTLi1dPHuE+XeROjZ7lSecI= Received: by b-6.in.mailobj.net [192.168.90.16] with ESMTP via ip-206.mailobj.net [213.182.55.206] Tue, 10 Jan 2023 21:20:14 +0100 (CET) X-EA-Auth: KbkOyS25WULzAeG0UfhXEQVuLt1NKF3jwhnHNmxVSoeI5v0VIWxMywgam6RktIG0CCef3vfPkXKBPQpRHPbc2td67xmxw839 Date: Wed, 11 Jan 2023 01:50:06 +0530 From: Deepak R Varma To: Alain Volmat , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar Subject: [PATCH] drm/sti: Avoid full proxy f_ops for sti debug attributes Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754668406239046488?= X-GMAIL-MSGID: =?utf-8?q?1754668406239046488?= Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy factory file operations structure and function wrapping at runtime. As a replacement, a combination of DEFINE_DEBUGFS_ATTRIBUTE macro paired with debugfs_create_file_unsafe() is suggested to be used instead. The DEFINE_DEBUGFS_ATTRIBUTE utilises debugfs_file_get() and debugfs_file_put() wrappers to protect the original read and write function calls for the debug attributes. There is no need for any runtime proxy file operations to be managed by the debugfs core. Following coccicheck make command helped identify this change: make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- Note: Change cross compile tested using stm32_defconfig for arm drivers/gpu/drm/sti/sti_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c index ef6a4e63198f..c9be82043638 100644 --- a/drivers/gpu/drm/sti/sti_drv.c +++ b/drivers/gpu/drm/sti/sti_drv.c @@ -67,8 +67,8 @@ static int sti_drm_fps_set(void *data, u64 val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(sti_drm_fps_fops, - sti_drm_fps_get, sti_drm_fps_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(sti_drm_fps_fops, + sti_drm_fps_get, sti_drm_fps_set, "%llu\n"); static int sti_drm_fps_dbg_show(struct seq_file *s, void *data) { @@ -97,8 +97,8 @@ static void sti_drm_dbg_init(struct drm_minor *minor) ARRAY_SIZE(sti_drm_dbg_list), minor->debugfs_root, minor); - debugfs_create_file("fps_show", S_IRUGO | S_IWUSR, minor->debugfs_root, - minor->dev, &sti_drm_fps_fops); + debugfs_create_file_unsafe("fps_show", S_IRUGO | S_IWUSR, minor->debugfs_root, + minor->dev, &sti_drm_fps_fops); DRM_INFO("%s: debugfs installed\n", DRIVER_NAME); }