From patchwork Tue Jan 10 18:29:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 41577 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2907812wrt; Tue, 10 Jan 2023 10:37:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXs7GRslL2VG5zOrkbVWptxJ6jFz7OpTu+E+c17DDao3bGMdLZBsY0mnVG2NvKaRBuPNcgWM X-Received: by 2002:a17:907:c70b:b0:7c0:e535:13fd with SMTP id ty11-20020a170907c70b00b007c0e53513fdmr62178089ejc.70.1673375874332; Tue, 10 Jan 2023 10:37:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673375874; cv=none; d=google.com; s=arc-20160816; b=HT2JjpyteOvrpEtKJYHqs/TSmkIs8/GiMI0wv4jp7Y+RgwursyD45sMPkctX6nJjH3 23YN2ySHeKEe7AEDKcbecy3gqKqeBsp0Ns4PGjVCw2IhBtor8AhYRLKew9BIKT78RZeH L+1S9wrTUgU6+Q1PJQrNhZSgc6sNvRFWmTvtkaNZctl/+O1WjY4yIxIRJKtspbkYOyw7 UFfXRcLd7VpqNcLQ6UsF012edC71nb30rX1pF/I/9U9g0f6R59x51wjqVGxfxrntA5Bq jAcdKkVJS3FE6Hd158kfBw9pNbaB/7jS8q3+49+GN0iMS2bM/4KUzVDfot1bZQ0cW2Wr MMTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gn902KUwqDc7pjYonQQY6TBaypPnvoxfwMwZ3VcqdzA=; b=nW0C92xVZPVKTi/3m4oE0UYDQRj211bacIxOP3AuUu44qDrQ+lTIcTFzCu5h6KUYLb dqaOZDjLsfVTPApKXTpJT+6yn1Zihx74ZrMwSGDj/JWgio+KN4APjuDyL5J0krLZW6cv seXAoUf1ZwOCS0xBpg9PKxSMmLcVf4iBqQIDD3uhtQms++evvvWa9xOaJr51JF/oc40J 1X+DxyU8TotWbr/n4w7XMMvAdbU2UXRfRu2+XEo8EZvF4MYZaLDs8gtkcb8QFg+R6yyc rsaovnsZ76DQmVfx3UKyQ6ad+eLCHKA0GOr20jwKopms9/wznSfQa35Cjm6MAU3o9HbT Xktg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=BYQiFU30; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qb10-20020a1709077e8a00b0084c855eabfesi12588650ejc.175.2023.01.10.10.37.30; Tue, 10 Jan 2023 10:37:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=BYQiFU30; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239364AbjAJSfZ (ORCPT + 99 others); Tue, 10 Jan 2023 13:35:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239567AbjAJSeJ (ORCPT ); Tue, 10 Jan 2023 13:34:09 -0500 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF5FAA2AB8 for ; Tue, 10 Jan 2023 10:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1673375390; bh=miL+U54u+zbwiY1zJpyFrSycjgOcARyuIyOdsIcqAwg=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=BYQiFU30yqi3X9Qb4kRZ8o9LFNNvhMCAUgZ/MCb1uHXjZGWjvqwhsovnaKEOyrOdk 4Ed8rhTJtcn6oZXKpfH81pQmyeSqcnfapPAFm/fxpI2d/D0fJN55wyPq+gTwe6pjoP 7nIiumflzQDbVCQGmxksKZWRJR3j1Yc+FD9iw0IQ= Received: by b-4.in.mailobj.net [192.168.90.14] with ESMTP via ip-206.mailobj.net [213.182.55.206] Tue, 10 Jan 2023 19:29:49 +0100 (CET) X-EA-Auth: 2yCuNAG5h3cTxbwR5VlwuO7IDCj5y64ot8HtV0N6YfFg/GXhAXaQHiEkliEtmYzUP0x8v2nBHL0uNeYy54P+K5wul7dZ2llz Date: Tue, 10 Jan 2023 23:59:44 +0530 From: Deepak R Varma To: Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar Subject: [PATCH 1/2] drm/i915/gvt: Avoid full proxy f_ops for scan_nonprivbb debug attributes Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754661780880723268?= X-GMAIL-MSGID: =?utf-8?q?1754661780880723268?= Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy factory file operations structure and function wrapping at runtime. As a replacement, a combination of DEFINE_DEBUGFS_ATTRIBUTE macro paired with debugfs_create_file_unsafe() is suggested to be used instead. The DEFINE_DEBUGFS_ATTRIBUTE utilises debugfs_file_get() and debugfs_file_put() wrappers to protect the original read and write function calls for the debug attributes. There is no need for any runtime proxy file operations to be managed by the debugfs core. Following coccicheck make command helped identify this change: make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- drivers/gpu/drm/i915/gvt/debugfs.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/debugfs.c b/drivers/gpu/drm/i915/gvt/debugfs.c index 0616b73175f3..03f081c3d9a4 100644 --- a/drivers/gpu/drm/i915/gvt/debugfs.c +++ b/drivers/gpu/drm/i915/gvt/debugfs.c @@ -147,9 +147,9 @@ vgpu_scan_nonprivbb_set(void *data, u64 val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(vgpu_scan_nonprivbb_fops, - vgpu_scan_nonprivbb_get, vgpu_scan_nonprivbb_set, - "0x%llx\n"); +DEFINE_DEBUGFS_ATTRIBUTE(vgpu_scan_nonprivbb_fops, + vgpu_scan_nonprivbb_get, vgpu_scan_nonprivbb_set, + "0x%llx\n"); static int vgpu_status_get(void *data, u64 *val) { @@ -180,8 +180,8 @@ void intel_gvt_debugfs_add_vgpu(struct intel_vgpu *vgpu) debugfs_create_file("mmio_diff", 0444, vgpu->debugfs, vgpu, &vgpu_mmio_diff_fops); - debugfs_create_file("scan_nonprivbb", 0644, vgpu->debugfs, vgpu, - &vgpu_scan_nonprivbb_fops); + debugfs_create_file_unsafe("scan_nonprivbb", 0644, vgpu->debugfs, vgpu, + &vgpu_scan_nonprivbb_fops); debugfs_create_file("status", 0644, vgpu->debugfs, vgpu, &vgpu_status_fops); } From patchwork Tue Jan 10 18:30:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 41575 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2907321wrt; Tue, 10 Jan 2023 10:36:49 -0800 (PST) X-Google-Smtp-Source: AMrXdXt69cskr69UbU5VHhrPFuaFwraIRO3jbGEn9nIqFWpQTSMXPBvPF8NS85mh/3wc7fP+QQSS X-Received: by 2002:a17:907:b9d5:b0:81e:8dd4:51c3 with SMTP id xa21-20020a170907b9d500b0081e8dd451c3mr59510111ejc.76.1673375808884; Tue, 10 Jan 2023 10:36:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673375808; cv=none; d=google.com; s=arc-20160816; b=QQ0t97G5cPtyveV1ot31fxPZjyo+0v9tloQz8hmCn+Fxuw2F5iAiq7WxVHUsvkzlyM 5L8clAgfOlLWIfZvIANhjpWuoug6z80aB5LMJBccQslesFh1jBTOJ7f6Ko2TfqGfx3wP wBwP4Vv8ZhucgQg2UuHweuCpfQ2crggoFExJjiBRzRfGGpbYGW1Pn8+POV5JTbx0G0Cr oUj43d2VuQiPOpzSn+aZXpyDUQtic+2xQNik5H9xckKNvOeFdwrVPvsb0sF/6KQBg+eg P4bwjKyAzHA4Gw1lFTUBVoFJozlbCybgyEAudGQdwEFejcSHkTujMdCBeAIjM/6Ba3es ShOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=v3K1Od5QbbT2Fm3iJmb6uGl+1nQozgGbeU6bdQAygnI=; b=fdUEhz5DFop4Ck05kEV1k3OLxlUOGQ56qeGuB+nTeXc5JB70kdtxqLYzdZlAQv9mQ6 vel7CsKXDEPjK2FHQGK27RolvtEK+CEqKa732Iz9IjgZQaUE4V+CpuVFK3s4Ftc5To6m rMpzJvnYc+0NFYAZs0bwy+saFzMk5euqdX7EGky4C8IrxRfi31m14So+cfxsDzuqMzc/ dLlxQFeNfMDU2sGJM7gpnFhM2jylVhER8anMZrhxp36e80Ajo82nnRjLhiSV7VBi/OPR bNNi9utfUQ7SVA5/XrxBhBKLS2zOYtkmie2H53bf8QwrIro8uSMf8QmKAq273FtZhUgl OzwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=Fx46Ace3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s5-20020a17090699c500b007aa1aa8ca57si13921618ejn.859.2023.01.10.10.36.24; Tue, 10 Jan 2023 10:36:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=Fx46Ace3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238763AbjAJSf4 (ORCPT + 99 others); Tue, 10 Jan 2023 13:35:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239414AbjAJSfH (ORCPT ); Tue, 10 Jan 2023 13:35:07 -0500 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72FFC91527 for ; Tue, 10 Jan 2023 10:30:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1673375417; bh=zeINM58lZULSKsWBO+E3FvyueML1bzYkk7wY1wX8GAs=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=Fx46Ace37+NIuiH9XXbcE+8Pe9W9M/j+gw7TmHbb46v89m5LdhY817PGgxo/PV+8j pRbcb51clrhUbSWfpUfkG9Jt/2NI9y5XiGl4r6cW1HdgYGlOwv3xjLYTwnolD/sMmX EMEo2O1M4TFMlqxFzGNoFPeB9Y51aURWvH/+0iug= Received: by b-1.in.mailobj.net [192.168.90.11] with ESMTP via ip-206.mailobj.net [213.182.55.206] Tue, 10 Jan 2023 19:30:17 +0100 (CET) X-EA-Auth: Qm+Hre3tClJjXlDtBX1ONwmV81CboJoRE8Q7ml/AUlOahbgiUu7RKwBmdktw20/G9a+RDzgtq31NURLllH1/bKleLoR2wE8a Date: Wed, 11 Jan 2023 00:00:12 +0530 From: Deepak R Varma To: Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar Subject: [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes Message-ID: <188df08e0feba0cda2c92145f513dd4e57c6e6cf.1673375066.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754661712292173726?= X-GMAIL-MSGID: =?utf-8?q?1754661712292173726?= Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy factory file operations structure and function wrapping at runtime. As a replacement, a combination of DEFINE_DEBUGFS_ATTRIBUTE macro paired with debugfs_create_file_unsafe() is suggested to be used instead. The DEFINE_DEBUGFS_ATTRIBUTE utilises debugfs_file_get() and debugfs_file_put() wrappers to protect the original read and write function calls for the debug attributes. There is no need for any runtime proxy file operations to be managed by the debugfs core. Following coccicheck make command helped identify this change: make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma Reviewed-by: Rodrigo Vivi Acked-by: Zhenyu Wang --- drivers/gpu/drm/i915/gvt/debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/debugfs.c b/drivers/gpu/drm/i915/gvt/debugfs.c index 03f081c3d9a4..baccbf1761b7 100644 --- a/drivers/gpu/drm/i915/gvt/debugfs.c +++ b/drivers/gpu/drm/i915/gvt/debugfs.c @@ -165,7 +165,7 @@ static int vgpu_status_get(void *data, u64 *val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(vgpu_status_fops, vgpu_status_get, NULL, "0x%llx\n"); +DEFINE_DEBUGFS_ATTRIBUTE(vgpu_status_fops, vgpu_status_get, NULL, "0x%llx\n"); /** * intel_gvt_debugfs_add_vgpu - register debugfs entries for a vGPU @@ -182,8 +182,8 @@ void intel_gvt_debugfs_add_vgpu(struct intel_vgpu *vgpu) &vgpu_mmio_diff_fops); debugfs_create_file_unsafe("scan_nonprivbb", 0644, vgpu->debugfs, vgpu, &vgpu_scan_nonprivbb_fops); - debugfs_create_file("status", 0644, vgpu->debugfs, vgpu, - &vgpu_status_fops); + debugfs_create_file_unsafe("status", 0644, vgpu->debugfs, vgpu, + &vgpu_status_fops); } /**