From patchwork Wed Oct 12 17:29:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Andre Vieira (lists)" X-Patchwork-Id: 1965 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp2726550wrs; Wed, 12 Oct 2022 10:31:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7UjN5SGrhxmxvy+2A34A3ifjgp15sThLHufGNiTocjqd1xU2NURpP5c50xMu7V9QhjUVuV X-Received: by 2002:a17:906:9bf8:b0:78d:41aa:5eea with SMTP id de56-20020a1709069bf800b0078d41aa5eeamr22845933ejc.137.1665595907733; Wed, 12 Oct 2022 10:31:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665595907; cv=none; d=google.com; s=arc-20160816; b=OblJsaZf98MyJFfPVgFZwVGwysc+ghQi1ZGwyOsPwixgtfn79ZIvnWbeecP219/W+n klZTpFtehV1EUNshsIF/dPq/nqBXeNTOjt90m/HTC16x1R/iabdoi9vLD9cuxcyaVvVk OnZNpA+ZdberGV0qlWZ47yzOjoZuNQtZEyUYWcdai6OaxjYQ6+EOZoBIlxIlHJqq7ty+ iDdHh0AZcfftMD7D4f+SDZrWHblkqA6Sr+NVAYk8I2N9THTLQj9s6b6wqji4NnIQ8rw6 X5xi3x9J8QbWvIqrs70UX9WQN2RyjAMg6Kd0EJbo/tJpFTK49LLRpFuntpxZw7CFQiAh emeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :to:content-language:user-agent:mime-version:date:message-id :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=Q7QlmZMsXM5GC2lN9HJZDvmTXCeheAmP2aS24nN/EmA=; b=QEbuwwLs211WhdCZDw++j22wMqRfkDpe7KLfAtdaibw6hlQJs262mHiU4+7Dn4KeNw vbtD37k1ecCe/PJoIpnap/4dt1tCbId9XasQlO9zZHSgltmevIk1AyYnS1MVvSb1WGbg yqodwZesW6cCM14NGzoDQvINgUxN8T0q2i3GM69ZhFLO7b+O0a4xly3NWTpDdkpmvqYE U91gwQzDuhT/LA27TDXckJk3FFQN1WQ9pz2ZgnzdqswF2NCtT9b5mV32jTQFKPRizHdq 9xvwU85AKxRgWu4C/ufp/Byfajz/2KpVLkR48c8KSOZ9W/bURlCQ3L2WZCOjuJn9PilW hu3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=ac6dgJac; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id ee8-20020a056402290800b00450e1ffe3edsi14676687edb.382.2022.10.12.10.31.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 10:31:47 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=ac6dgJac; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 810693858401 for ; Wed, 12 Oct 2022 17:31:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 810693858401 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1665595906; bh=Q7QlmZMsXM5GC2lN9HJZDvmTXCeheAmP2aS24nN/EmA=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=ac6dgJacZDUk8cR7eiAqrqHkyD1G8oR6TCvk1jtQjobADXg7T2wAOnJx0IBMRUiyJ Ly6bN16qMtYHZqSKHYK6ho629VPfYlNBF9tWVphi4TDK6jJfRXryuPj8VMW1gxjc/V SAW7RNRvJdy1+3wCWH/NMTy6XPHvXGMxCw1eTLvg= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id D7DF23858D38 for ; Wed, 12 Oct 2022 17:30:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D7DF23858D38 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B51DD165C; Wed, 12 Oct 2022 10:30:50 -0700 (PDT) Received: from [10.57.1.129] (unknown [10.57.1.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 91CE43F766; Wed, 12 Oct 2022 10:30:43 -0700 (PDT) Message-ID: <3fd8eef5-213d-23bd-4bcd-de7157d2de18@arm.com> Date: Wed, 12 Oct 2022 18:29:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US To: "gcc-patches@gcc.gnu.org" Subject: vect: Don't pattern match BITFIELD_REF's of non-integrals [PR107226] X-Spam-Status: No, score=-19.1 required=5.0 tests=BAYES_00, BODY_8BITS, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Andre Vieira \(lists\) via Gcc-patches" From: "Andre Vieira (lists)" Reply-To: "Andre Vieira \(lists\)" Cc: Richard Sandiford , Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746503894454731025?= X-GMAIL-MSGID: =?utf-8?q?1746503894454731025?= Hi, The original patch supported matching the vect_recog_bitfield_ref_pattern for BITFIELD_REF's where the first operand didn't have a INTEGRAL_TYPE_P type. That means it would also match vectors, leading to regressions in targets that supported vectorization of those. Bootstrappend and regression tested on aarch64-none-linux-gnu and x86_64-pc-linux-gnu. gcc/ChangeLog:         PR tree-optimization/107226         * tree-vect-patterns.cc (vect_recog_bitfield_ref_pattern): Reject         BITFIELD_REF's with non integral typed first operands. diff --git a/gcc/tree-vect-patterns.cc b/gcc/tree-vect-patterns.cc index 0cc315d312667c05a27df4cdf435f0d0e6fd4a52..6afd57a50c4bcb5aec7ccca6e5dc069caa4a5a30 100644 --- a/gcc/tree-vect-patterns.cc +++ b/gcc/tree-vect-patterns.cc @@ -1913,6 +1913,7 @@ vect_recog_bitfield_ref_pattern (vec_info *vinfo, stmt_vec_info stmt_info, return NULL; if (!INTEGRAL_TYPE_P (TREE_TYPE (bf_ref)) + || !INTEGRAL_TYPE_P (TREE_TYPE (container)) || TYPE_MODE (TREE_TYPE (container)) == E_BLKmode) return NULL; @@ -1921,25 +1922,7 @@ vect_recog_bitfield_ref_pattern (vec_info *vinfo, stmt_vec_info stmt_info, tree ret = gimple_assign_lhs (first_stmt); tree ret_type = TREE_TYPE (ret); bool shift_first = true; - tree vectype; - - /* If the first operand of the BIT_FIELD_REF is not an INTEGER type, convert - it to one of the same width so we can perform the necessary masking and - shifting. */ - if (!INTEGRAL_TYPE_P (TREE_TYPE (container))) - { - unsigned HOST_WIDE_INT container_size = - tree_to_uhwi (TYPE_SIZE (TREE_TYPE (container))); - tree int_type = build_nonstandard_integer_type (container_size, true); - pattern_stmt - = gimple_build_assign (vect_recog_temp_ssa_var (int_type), - VIEW_CONVERT_EXPR, container); - vectype = get_vectype_for_scalar_type (vinfo, int_type); - container = gimple_assign_lhs (pattern_stmt); - append_pattern_def_seq (vinfo, stmt_info, pattern_stmt, vectype); - } - else - vectype = get_vectype_for_scalar_type (vinfo, TREE_TYPE (container)); + tree vectype = get_vectype_for_scalar_type (vinfo, TREE_TYPE (container)); /* We move the conversion earlier if the loaded type is smaller than the return type to enable the use of widening loads. */