From patchwork Tue Jan 10 16:18:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 41538 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2843696wrt; Tue, 10 Jan 2023 08:27:26 -0800 (PST) X-Google-Smtp-Source: AMrXdXtN9p31ZIzeQBJ/WvNW0f/Nyw6tMOLCKN7n6DmW/Bxh6iIu9C8Ggyp6LTVHPCy6zkTtUP94 X-Received: by 2002:a17:907:6281:b0:855:d58e:59 with SMTP id nd1-20020a170907628100b00855d58e0059mr5193626ejc.75.1673368046495; Tue, 10 Jan 2023 08:27:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673368046; cv=none; d=google.com; s=arc-20160816; b=CO5IDnyr2Zb3nKMFEv55N10Gm0Ca6jjHSphsLIeFKMfePcKtcJuejkyP9vm6U3aA2l yzmIdTHl04cU6zRjOQDIfy492tv5sguoHqVm8jfY2WlDK7iK6XS36D/nnBknJbWBflAk pqSnbmwgWaIIFAe/NOUGDMImod0wcBTrN5JhLr2f/76qvnpOwSWFDMtW2eJaz6DhxiPR DxOz4TvFSRkXZEfu0ZUP1nUpJ6ZR2b9dSV4pMOkLX4u5kLdE8io888M2EE0LBJNtVjra 1a7I3AQOAVvzQF9B559jA5fYoUJsMipoVlGY+YauTVn5IYD/iNLdWtvPbBWMPvuJhz04 OBzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=J7MvbGohPb9c5KuFVDOSy13hj72U3Wx/T4iJQbVeyfQ=; b=JHrAT8wtzazMMIjpRHerJrGaac/A1HR3bHaIDBJ92TuTnjeLvJqmsQ4xraxUX7QkBk aeEZcSl34I6hIINqStPKcn72z9LFoc7pegfZvcPJteWfx1QhA1cButPwM8tkLN6LIimB Wq2A3k/4JMsOMVgCErVIy63FZ6QOfm+fX4hzGN3ioJgM1P08+DwcdSpg6ci2D7uGCc18 ePYhuRl17GxzEauUeU3sYhTI/uCswEdRDIvrg+5bn3ZXc1fGatIoEnDiqJ6p+pFnSClJ zM07T+MESXOWACYncZ1c0ILoeK7ryDRS7bAYarLey3hTkUu8YuWK0ANuMdP41zUU8F+x LTDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="OdrCnAc/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne26-20020a1709077b9a00b0077d854aa10dsi14104678ejc.57.2023.01.10.08.27.03; Tue, 10 Jan 2023 08:27:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="OdrCnAc/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232845AbjAJQUN (ORCPT + 99 others); Tue, 10 Jan 2023 11:20:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238817AbjAJQTw (ORCPT ); Tue, 10 Jan 2023 11:19:52 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA8445E66E for ; Tue, 10 Jan 2023 08:18:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673367519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=J7MvbGohPb9c5KuFVDOSy13hj72U3Wx/T4iJQbVeyfQ=; b=OdrCnAc/xoN+c6IFH7V6iuwLFxA/use7KNLx6ZYm+G0e8MJtcgtIxszfzLb+Rca2Psvs5B 9xq0R0pyqPL7aoMGOFgpR0eQeiUcSoJL2mdS0zs7JBp/g/HhqBkr3OebU8to0IQyAURzpK NpesQ1HS52GlOuPZvGSXHxAA19kQI9A= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-147-wRUgykLgO7CO8_FnisU21g-1; Tue, 10 Jan 2023 11:18:37 -0500 X-MC-Unique: wRUgykLgO7CO8_FnisU21g-1 Received: by mail-qv1-f72.google.com with SMTP id on32-20020a05621444a000b005319444bd2fso7122251qvb.11 for ; Tue, 10 Jan 2023 08:18:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J7MvbGohPb9c5KuFVDOSy13hj72U3Wx/T4iJQbVeyfQ=; b=GaOmkEEnyaDBGzUsKPfbLYbdwxcpTzRVpxlEbSzkuZqHBL/YY1QzZa2wfF+WZUHsBA K/9j3JvCJRj2fV+sCGDB+g1mbJxaBHcRO/PxnvD4SPvTQ5aIDH5LnPfP97CX6HjZ0+Wd v3nJ/RQqigNUBdIH9zlZ0IN5EmjRA3V1Oi21ScZ4ewnbRFKcnJmRuCNSZyvqlexKUPxC IWp0hfJSiiu6IvjEdlhSp8Q2EEMYNXmMr5uaxiYMCmeqoB1XDpD835U7eah2VHUCsXzg zkQ//kK75JcavDBetcpgqgQaHEKr4Rfhodu0TrQ9GCv9mUWKsm9mAgPhw5+StE6Si+6A HxaQ== X-Gm-Message-State: AFqh2koRAEDGUIrIemZSqSkSl2myx0tHp5BEL0i4DcRJ7JYXc3dQyjJc 2XYi2DKMudPvvyOhTWoHlbeDn1zW1HpFaTbNl1+p3k5ToX68Pn46ww6pt80bB08kQZF55pUrPcP V9QjTPRuLnj0LkdnDBnrDReoJ X-Received: by 2002:a05:622a:4d06:b0:3a9:9217:9e6c with SMTP id fd6-20020a05622a4d0600b003a992179e6cmr109627041qtb.55.1673367516965; Tue, 10 Jan 2023 08:18:36 -0800 (PST) X-Received: by 2002:a05:622a:4d06:b0:3a9:9217:9e6c with SMTP id fd6-20020a05622a4d0600b003a992179e6cmr109626901qtb.55.1673367515311; Tue, 10 Jan 2023 08:18:35 -0800 (PST) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id t34-20020a05622a182200b003a527d29a41sm6190082qtc.75.2023.01.10.08.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 08:18:34 -0800 (PST) From: Tom Rix To: brijesh.singh@amd.com, thomas.lendacky@amd.com, john.allen@amd.com, herbert@gondor.apana.org.au, davem@davemloft.net, nathan@kernel.org, ndesaulniers@google.com, rientjes@google.com, marcorr@google.com, pgonda@google.com Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [PATCH] crypto: initialize error Date: Tue, 10 Jan 2023 11:18:31 -0500 Message-Id: <20230110161831.2625821-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754653572348499183?= X-GMAIL-MSGID: =?utf-8?q?1754653572348499183?= clang static analysis reports this problem drivers/crypto/ccp/sev-dev.c:1347:3: warning: 3rd function call argument is an uninitialized value [core.CallAndMessage] dev_err(sev->dev, "SEV: failed to INIT error %#x, rc %d\n", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ __sev_platform_init_locked() can return without setting the error parameter, causing the dev_err() to report a gargage value. Fixes: 3d725965f836 ("crypto: ccp - Add SEV_INIT_EX support") Signed-off-by: Tom Rix Reviewed-by: Peter Gonda --- drivers/crypto/ccp/sev-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c index 56998bc579d6..643cccc06a0b 100644 --- a/drivers/crypto/ccp/sev-dev.c +++ b/drivers/crypto/ccp/sev-dev.c @@ -1307,7 +1307,7 @@ EXPORT_SYMBOL_GPL(sev_issue_cmd_external_user); void sev_pci_init(void) { struct sev_device *sev = psp_master->sev_data; - int error, rc; + int error = 0, rc; if (!sev) return;