From patchwork Tue Jan 10 14:08:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 41492 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2767902wrt; Tue, 10 Jan 2023 06:11:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXv2Px5jzVBF7gBmltirXaXuVmVuPZ9AdYr1EOht4tkoZZNJHR8pwGp5wRj16L2MxVz0bGAB X-Received: by 2002:a17:90b:190:b0:228:c8aa:b111 with SMTP id t16-20020a17090b019000b00228c8aab111mr3697312pjs.25.1673359890515; Tue, 10 Jan 2023 06:11:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673359890; cv=none; d=google.com; s=arc-20160816; b=IboJoDqjDuFX4vnKA/g+fsE5ja/dGB45Iaenmb3WHqSKQZe8KtLvGsPNBjwSMp1F60 vRB2qAxA1wVwEuAehGqC8dd8D8yzMOwVv7p6Ydrjo7dc69T89RAf7RIdeIz+EOfQ21GO 91Z1JBg2DoKVXdevT8ThJb3PoE4LLzBPIwX6lNDe4dy3BGna74we7vVpOecmICjN9Wja RjTLmmAgCB1Yg1FgreCodXvFaWgBWu04JKC4pkHfTw6wy+dHt4nmkvQ87927rpLaNO0h pJFkBzuSpvtT/+u4fZe6hIw2oLgtgtpyvj2i/lh9MRxu0WRQDlSr9JnvVjTJIeB4vTD3 QJBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UeTXQP3Hn/pUyK21q9v5gYI+QfH4b+5MECVaJMlME9Y=; b=AUzEVOTBBtCqQRfwYJttNlUCkgeLxgT2R8QSUwIjukmZVO1Lrde/MA3PdENBgUljFi aFgdvfQ4aT3Bh68c7MWcj1LDg9b2mdeEt3Ia20iNsX1Xk7xjCr0K7vTySRJGYCk/EXSH dLAVfcLuwB6IzD5GXN60hmivn++1Lu2uYxdoAOpcK683XIO9dtvkUbJJ9prnOk8CZKnQ rJN1gYz5Y4G/rcHjDUhYb7wINl7tej22FpCjPzBEOUZ/85Or13TABb6lt6KETC88y5qv g90ZQjp5clFOdJlEFXEM0oZ6wS4Ul66SC09jfr2wHSakhiIqwtjTEAgjF76KQ2uN1iDg ewBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kGIN6TOD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t11-20020a17090a4e4b00b0020da3876a77si11118152pjl.119.2023.01.10.06.11.07; Tue, 10 Jan 2023 06:11:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kGIN6TOD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238184AbjAJOIq (ORCPT + 99 others); Tue, 10 Jan 2023 09:08:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238672AbjAJOIM (ORCPT ); Tue, 10 Jan 2023 09:08:12 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B759C8CBF4; Tue, 10 Jan 2023 06:08:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673359691; x=1704895691; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bZMrAv2zUwB2PF0XruHl6FSmCHCHKSqmQ7n3sGCcVCE=; b=kGIN6TODYLjZv+PTgpD+w8v6ynn1FUnFiU7XJFmhDxUSBC8C0p/n2KuU NiJF7LEj1ZzVgleLe0vaizsPgmAPQCiZttNJ84/e/I/QiDTYiX87NVlsS gw/PFn6QWOHKmwlRXv1XQRbFw1oqR2scW657JSfvJv0h74tPuutH/6uNw D20FXNZcT9wMTjeMkJ7oyaORF4qn6EBXOgumBJ+jtz1rFtnOzqRUVGNy1 veRU6Hv0WrvZ1UXdskaHvsiIiSqIIhxs96OgqgTydSuGWxAZ/6CGVq0mc JCPx3RUdpKh3zFFj9iK467Zn004eoZQjiygfiZNYAwFEBJs4fTDAe1Yyk A==; X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="303513595" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="303513595" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 06:07:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="725555663" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="725555663" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 10 Jan 2023 06:07:39 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id E1B31E1; Tue, 10 Jan 2023 16:08:12 +0200 (EET) From: Andy Shevchenko To: Rasmus Villemoes , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Cc: Alessandro Zummo , Alexandre Belloni , Jean Delvare , Guenter Roeck , Andy Shevchenko Subject: [PATCH v2 1/5] rtc: isl12022: Get rid of unneeded private struct isl12022 Date: Tue, 10 Jan 2023 16:08:02 +0200 Message-Id: <20230110140806.87432-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230110140806.87432-1-andriy.shevchenko@linux.intel.com> References: <20230110140806.87432-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754645020911086412?= X-GMAIL-MSGID: =?utf-8?q?1754645020911086412?= First of all, the struct rtc_device pointer is kept in the managed resources, no need to keep it outside (no users in the driver). Second, replace private struct isl12022 with a regmap. Signed-off-by: Andy Shevchenko Acked-by: Rasmus Villemoes --- drivers/rtc/rtc-isl12022.c | 56 ++++++++++++++------------------------ 1 file changed, 21 insertions(+), 35 deletions(-) diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c index a3b0de3393f5..44058fa27277 100644 --- a/drivers/rtc/rtc-isl12022.c +++ b/drivers/rtc/rtc-isl12022.c @@ -46,11 +46,6 @@ static struct i2c_driver isl12022_driver; -struct isl12022 { - struct rtc_device *rtc; - struct regmap *regmap; -}; - static umode_t isl12022_hwmon_is_visible(const void *data, enum hwmon_sensor_types type, u32 attr, int channel) @@ -67,8 +62,7 @@ static umode_t isl12022_hwmon_is_visible(const void *data, */ static int isl12022_hwmon_read_temp(struct device *dev, long *mC) { - struct isl12022 *isl12022 = dev_get_drvdata(dev); - struct regmap *regmap = isl12022->regmap; + struct regmap *regmap = dev_get_drvdata(dev); u8 temp_buf[2]; int temp, ret; @@ -115,23 +109,21 @@ static const struct hwmon_chip_info isl12022_hwmon_chip_info = { static void isl12022_hwmon_register(struct device *dev) { - struct isl12022 *isl12022; + struct regmap *regmap = dev_get_drvdata(dev); struct device *hwmon; int ret; if (!IS_REACHABLE(CONFIG_HWMON)) return; - isl12022 = dev_get_drvdata(dev); - - ret = regmap_update_bits(isl12022->regmap, ISL12022_REG_BETA, + ret = regmap_update_bits(regmap, ISL12022_REG_BETA, ISL12022_BETA_TSE, ISL12022_BETA_TSE); if (ret) { dev_warn(dev, "unable to enable temperature sensor\n"); return; } - hwmon = devm_hwmon_device_register_with_info(dev, "isl12022", isl12022, + hwmon = devm_hwmon_device_register_with_info(dev, "isl12022", regmap, &isl12022_hwmon_chip_info, NULL); if (IS_ERR(hwmon)) @@ -144,8 +136,7 @@ static void isl12022_hwmon_register(struct device *dev) */ static int isl12022_rtc_read_time(struct device *dev, struct rtc_time *tm) { - struct isl12022 *isl12022 = dev_get_drvdata(dev); - struct regmap *regmap = isl12022->regmap; + struct regmap *regmap = dev_get_drvdata(dev); uint8_t buf[ISL12022_REG_INT + 1]; int ret; @@ -190,8 +181,7 @@ static int isl12022_rtc_read_time(struct device *dev, struct rtc_time *tm) static int isl12022_rtc_set_time(struct device *dev, struct rtc_time *tm) { - struct isl12022 *isl12022 = dev_get_drvdata(dev); - struct regmap *regmap = isl12022->regmap; + struct regmap *regmap = dev_get_drvdata(dev); int ret; uint8_t buf[ISL12022_REG_DW + 1]; @@ -218,8 +208,7 @@ static int isl12022_rtc_set_time(struct device *dev, struct rtc_time *tm) buf[ISL12022_REG_DW] = tm->tm_wday & 0x07; - return regmap_bulk_write(isl12022->regmap, ISL12022_REG_SC, - buf, sizeof(buf)); + return regmap_bulk_write(regmap, ISL12022_REG_SC, buf, sizeof(buf)); } static const struct rtc_class_ops isl12022_rtc_ops = { @@ -235,34 +224,31 @@ static const struct regmap_config regmap_config = { static int isl12022_probe(struct i2c_client *client) { - struct isl12022 *isl12022; + struct rtc_device *rtc; + struct regmap *regmap; if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return -ENODEV; - isl12022 = devm_kzalloc(&client->dev, sizeof(struct isl12022), - GFP_KERNEL); - if (!isl12022) - return -ENOMEM; - dev_set_drvdata(&client->dev, isl12022); - - isl12022->regmap = devm_regmap_init_i2c(client, ®map_config); - if (IS_ERR(isl12022->regmap)) { + regmap = devm_regmap_init_i2c(client, ®map_config); + if (IS_ERR(regmap)) { dev_err(&client->dev, "regmap allocation failed\n"); - return PTR_ERR(isl12022->regmap); + return PTR_ERR(regmap); } + dev_set_drvdata(&client->dev, regmap); + isl12022_hwmon_register(&client->dev); - isl12022->rtc = devm_rtc_allocate_device(&client->dev); - if (IS_ERR(isl12022->rtc)) - return PTR_ERR(isl12022->rtc); + rtc = devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - isl12022->rtc->ops = &isl12022_rtc_ops; - isl12022->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - isl12022->rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->ops = &isl12022_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; - return devm_rtc_register_device(isl12022->rtc); + return devm_rtc_register_device(rtc); } #ifdef CONFIG_OF From patchwork Tue Jan 10 14:08:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 41494 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2768179wrt; Tue, 10 Jan 2023 06:11:56 -0800 (PST) X-Google-Smtp-Source: AMrXdXtwfJekfgvAG2521loe1elugkLWBQPlbPR7WwCBJFQGwPv6cOJ+YJvYQRzPYWzKKFN5iSCE X-Received: by 2002:a17:90a:7acf:b0:227:24d0:41b9 with SMTP id b15-20020a17090a7acf00b0022724d041b9mr4347374pjl.26.1673359915898; Tue, 10 Jan 2023 06:11:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673359915; cv=none; d=google.com; s=arc-20160816; b=Oo/RYtD+r6rtQs2X5qnbnOTMOYCImOO0eza8IL46UYQ/jLTdgrAIvFoqGpVd6VPrhn vt1Y0DFxTFV6YqTfYdfv1U+Ftdb8cZfhE+xwDIL7CTgaW0jr0UyJnqr4d9qjAyYT5oX7 /aPpgBS0ehrBhg2805OlgoANDz4ES7KnWui2RHvu388FkV10zivaVgsrUzc1LiM4/sjP 1YWYnsRll5EfCqrbJiw0fz092ydAzdUN2OHdHOJlrRU6ygPm+ebka/DiTj3P4Gf7Yp7F pmDYEX3sNccTJtoGSh2lcoVSV9WO27QHa0Yc6ryoBWdpgec9XtUjgtz1Q0Zwy2uO5WIj PdpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Mmg395XjO5PMp/18NQ5CyDFnYqGI3WrW7Qu0UsRQc3A=; b=v2HV2hjqWxPFqMgO95fIz/1tvUAHg0e0Z2OKT+rK1hPXiw4pMclrhu1vjrBLgzarzx 6d1riM6z3/XvItB/xe5jxMwcM2sIbHxPYlJS/7NNnUlLIp2AFYnSyDavyhBqn14MjhVe jdXlxhIX9ky0ofLzgrP9zDngIGzty6fEjxIkoP05qXHke36Jip5XQx1nO+Jq+OWSrC39 EmxwnPFh7y3EMH/tdH2/UE6HoOQ6pCqPyBTYyIJ6sSoQmvKbvuGFrJRS5XXKsz97trAA fJHQu7hwfvNV5ci04+BfGmLgjUrB2vy2LulQMlfNMmBZ6GHcmIzKqo00V9ACQGEHj0RO pQhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iuPOA6Oi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id me5-20020a17090b17c500b002268e9e9b97si3812154pjb.31.2023.01.10.06.11.39; Tue, 10 Jan 2023 06:11:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iuPOA6Oi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238620AbjAJOI5 (ORCPT + 99 others); Tue, 10 Jan 2023 09:08:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238668AbjAJOIM (ORCPT ); Tue, 10 Jan 2023 09:08:12 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A8523C38C; Tue, 10 Jan 2023 06:08:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673359691; x=1704895691; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=k3cvIiiipTOOOJMkBjXRIczi8x3kZeinL1bpJ1JiSWA=; b=iuPOA6Oico/UR5QcKxLppKjC5FrLlKFV+8MniAbPnhMwi5wnrapIapB0 qwwzVz9xGgNr0aAjGXKr+Zm981C8bhsX6YCC2tYOq2bwtdLa4y2u0qEAJ NIx87KVvBFblkeGvr+cs7LHnBPMa5McUInVMjN8ljoGaSNjhTvrGgif+T egcrcrCDKkAU/J3psEW5QWvPOdxXKisqhhXro01FTT7seYrJ5K8HbG3Ct 5vG/+3BMJnRjEjcgPe5WXIwP1nbPR7jJOtaKkuCb0qtvirTCoKPIqTMK1 v4OFGThikhwpZYcijwfD4BAlREFv/3VsosA7JowM5JaAaaXLHW7mpl7sx g==; X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="303513589" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="303513589" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 06:07:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="725555661" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="725555661" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 10 Jan 2023 06:07:39 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id F19D91A3; Tue, 10 Jan 2023 16:08:12 +0200 (EET) From: Andy Shevchenko To: Rasmus Villemoes , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Cc: Alessandro Zummo , Alexandre Belloni , Jean Delvare , Guenter Roeck , Andy Shevchenko Subject: [PATCH v2 2/5] rtc: isl12022: Explicitly use __le16 type for ISL12022_REG_TEMP_L Date: Tue, 10 Jan 2023 16:08:03 +0200 Message-Id: <20230110140806.87432-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230110140806.87432-1-andriy.shevchenko@linux.intel.com> References: <20230110140806.87432-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754645047110501445?= X-GMAIL-MSGID: =?utf-8?q?1754645047110501445?= We are reading 10-bit value in a 16-bit register in LE format. Make this explicit by using __le16 type for it and corresponding conversion function. Signed-off-by: Andy Shevchenko Acked-by: Rasmus Villemoes --- drivers/rtc/rtc-isl12022.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c index 44058fa27277..bf1aa6f6560d 100644 --- a/drivers/rtc/rtc-isl12022.c +++ b/drivers/rtc/rtc-isl12022.c @@ -19,6 +19,8 @@ #include #include +#include + /* ISL register offsets */ #define ISL12022_REG_SC 0x00 #define ISL12022_REG_MN 0x01 @@ -63,17 +65,16 @@ static umode_t isl12022_hwmon_is_visible(const void *data, static int isl12022_hwmon_read_temp(struct device *dev, long *mC) { struct regmap *regmap = dev_get_drvdata(dev); - u8 temp_buf[2]; int temp, ret; + __le16 buf; - ret = regmap_bulk_read(regmap, ISL12022_REG_TEMP_L, - temp_buf, sizeof(temp_buf)); + ret = regmap_bulk_read(regmap, ISL12022_REG_TEMP_L, &buf, sizeof(buf)); if (ret) return ret; /* * Temperature is represented as a 10-bit number, unit half-Kelvins. */ - temp = (temp_buf[1] << 8) | temp_buf[0]; + temp = le16_to_cpu(buf); temp *= 500; temp -= 273000; From patchwork Tue Jan 10 14:08:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 41491 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2767448wrt; Tue, 10 Jan 2023 06:10:44 -0800 (PST) X-Google-Smtp-Source: AMrXdXuv30hctWLzMQUULhgjR7E98qSCdPaRoIJt1c5NWUIfsKQtjbx5zfp+wnGPxbOVegrYcbOs X-Received: by 2002:a17:906:abc6:b0:7ad:d835:e822 with SMTP id kq6-20020a170906abc600b007add835e822mr61899096ejb.42.1673359844254; Tue, 10 Jan 2023 06:10:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673359844; cv=none; d=google.com; s=arc-20160816; b=DNuVZybFzUeXCd++7zGDw+f/YxNa60S5gUj3P0S8KfNEM0NRWwDSMMuMgQ88v1rvZZ mvUDb3vWRDGtGI3UMu83R8MQGJCrt9JDdKJ/gg1Q1iR9EZAtddL30z4HEUUvqgPi2D3V lVxycbaR11NAax5amxUnT4rB8PMHHjesgXM/ZEh8H/dED3pg/ZDtBrCSZtavMSMxEv4K MI8T4Ux3rnPj6nWcjz5N2/QS2Mhk1xZRsaEYGHE8UwJFPiwnt9b02dXUtDbw1Knh4BHR 13+ASvpntdEUwObp1VbhTnfrV236RxRKGpztNWu/Td1ul6ouI6dE6ms56QOkwtSFdwoo Ewdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PzOGsUSE5nx0USVwzLxfBguJdcAlROsRCowhvYiZyXQ=; b=M58xKnyBdJ4QYNad+RIszMMUFFf6t3n9jqw2S7eRa8Mr6ys94N4zSKvP3auYYaqZI4 l/HD2ndjgnAyVDubipMSUf0MbNNNNyhJiklbKf0ZcDBTN1BVNzbM5kDqPvvQxLpdplg4 racovjB6AXyFnpX0fe2S6Lq7A4XFebW+RYrEo/FQQ4Rlhvjcccf02r/ILsU4lUrR/lHI 1wot7VSQIloe/Psw/0iNnqrlL/GFM0ZZVbvGwghnS+wEciH1CxFL41nBm5Q2w+x8ZQSa 0MUC40E8mARA068n8sYglIX82S5dAtAC/UR+FbfvscpmO68P2/4+2oPCaHlfQ9Gb9brW SXSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NbDDbR8i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id eo6-20020a056402530600b00482efc40d58si11430067edb.400.2023.01.10.06.10.09; Tue, 10 Jan 2023 06:10:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NbDDbR8i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232356AbjAJOH7 (ORCPT + 99 others); Tue, 10 Jan 2023 09:07:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238655AbjAJOHm (ORCPT ); Tue, 10 Jan 2023 09:07:42 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 291163FC83; Tue, 10 Jan 2023 06:07:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673359662; x=1704895662; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4eiyGTWXX+oD7HoJjkMNpYlz3/ZKnnaK5/dHNcnJkPA=; b=NbDDbR8iE534INn82Hz0vTgz0DWeEBxa9uJcVtPOpHXUhP9NeD3NE3qZ nXH3qnYx9oJL9Pw6MeAiZ2DiOs+SVJAmykHtXnVHgfcvrblN4a5B10Ggw c6NVhLbf2BAsKlPdXkTouiknofwOdelf7ZJf8L4LKQbdzS2O18E1DcBtf SQI8K5hoHM68gDqAKX4VU2umq/EK6tKSy27qogRlRPBD77CkTCjbaFOKZ M+wcDSZEXPJCOkMNyopqcx7gLM3kEVXVJWgVavgX2L+s+s90n1i2MKrmu nTmAENI8cMPFcHAIB0khak3v4UsmeriOGufEXrjP3fHFy9MfajuIlm8AB Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="325156487" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="325156487" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 06:07:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="606971782" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="606971782" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga003.jf.intel.com with ESMTP; 10 Jan 2023 06:07:39 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 048AA31D; Tue, 10 Jan 2023 16:08:13 +0200 (EET) From: Andy Shevchenko To: Rasmus Villemoes , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Cc: Alessandro Zummo , Alexandre Belloni , Jean Delvare , Guenter Roeck , Andy Shevchenko Subject: [PATCH v2 3/5] rtc: isl12022: Drop unneeded OF guards and of_match_ptr() Date: Tue, 10 Jan 2023 16:08:04 +0200 Message-Id: <20230110140806.87432-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230110140806.87432-1-andriy.shevchenko@linux.intel.com> References: <20230110140806.87432-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754644972140882086?= X-GMAIL-MSGID: =?utf-8?q?1754644972140882086?= Drop unneeded OF guards and of_match_ptr(). This allows use of the driver with other types of firmware such as ACPI PRP0001 based probing. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-isl12022.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c index bf1aa6f6560d..77b4763f2a70 100644 --- a/drivers/rtc/rtc-isl12022.c +++ b/drivers/rtc/rtc-isl12022.c @@ -14,8 +14,6 @@ #include #include #include -#include -#include #include #include @@ -46,8 +44,6 @@ #define ISL12022_BETA_TSE (1 << 7) -static struct i2c_driver isl12022_driver; - static umode_t isl12022_hwmon_is_visible(const void *data, enum hwmon_sensor_types type, u32 attr, int channel) @@ -252,14 +248,12 @@ static int isl12022_probe(struct i2c_client *client) return devm_rtc_register_device(rtc); } -#ifdef CONFIG_OF static const struct of_device_id isl12022_dt_match[] = { { .compatible = "isl,isl12022" }, /* for backward compat., don't use */ { .compatible = "isil,isl12022" }, { }, }; MODULE_DEVICE_TABLE(of, isl12022_dt_match); -#endif static const struct i2c_device_id isl12022_id[] = { { "isl12022", 0 }, @@ -270,9 +264,7 @@ MODULE_DEVICE_TABLE(i2c, isl12022_id); static struct i2c_driver isl12022_driver = { .driver = { .name = "rtc-isl12022", -#ifdef CONFIG_OF - .of_match_table = of_match_ptr(isl12022_dt_match), -#endif + .of_match_table = isl12022_dt_match, }, .probe_new = isl12022_probe, .id_table = isl12022_id, From patchwork Tue Jan 10 14:08:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 41495 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2768344wrt; Tue, 10 Jan 2023 06:12:12 -0800 (PST) X-Google-Smtp-Source: AMrXdXuHOVo1yJcaRVnt8svRhs5DyxbPsp2CbohRnlVq38R8b6FahdDaOW2C7sNh2k3soVwTrYFy X-Received: by 2002:a17:906:c795:b0:84d:45ff:d283 with SMTP id cw21-20020a170906c79500b0084d45ffd283mr6815697ejb.72.1673359932483; Tue, 10 Jan 2023 06:12:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673359932; cv=none; d=google.com; s=arc-20160816; b=Xr7Wu4NA35kRYQ3PJZWsNpmspn7r1cL3gcqSoxjA4OGc5UtF0lHct6rxdWVPMmbj2J 54ThnOqzs81cbDoS2iAw1FU8gKKPXwv2IYixatyw4jgeMoRTN8aXsAYdnv+snQ4jL3Y+ lSMYUANHnYqSI7avt3CL+yCMycc5PE53lAY2FLUPOo1Ljy9MmX+ZZqC1iXcOugpcOhkx IlXKbuis3/3ttt8mGKDfJ2YDa46DxUqRFptv3qyaoG2f+BkJQv2xRiRTyMy4TAom4lCK vyeoslVd1TvIuzmGU6/cvXpgRL4vnbpRPVNzbv9r/g+lxZQOMzA0OcCXo/+LbZyVVvkB BI7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zJKQt0cy/gLJqcw1PL0yT/fG2/sXkcAnFMtJ0K0nGWM=; b=MzFxcsNpPDlGnrO7qjjTUrPPP5JWNUmSW8Zb7NaupFBcEsd4/jukrRP+QGdmnO+iWH yu0MZaCFhMsT1H1WLdzDVUYSvVfXPqMa4882ggNGqZnxe05j8J34l48dScafq7nQltSR 28qplJVCTujWAhLaqZ0fLT/vGFqoDV/ah6qCGtQrmhs5YWShkxMnKYUxscoL4YWs7AaF 2zl2TzyYdzWW0NsSXPyfXi5PO2TFY/BerJLCxHlLn8er/tr+vrp6+V3OGlhaR3d4NAZD DJB5RnpaRG8wb82xdGilCwpzqbasr0cpUEQw5pprHOIe6ADzQnyGjGQeM6FExUvgckIh dqwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=I9QAyZYu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sh42-20020a1709076eaa00b007820aa60dc3si10920429ejc.74.2023.01.10.06.11.46; Tue, 10 Jan 2023 06:12:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=I9QAyZYu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233134AbjAJOJG (ORCPT + 99 others); Tue, 10 Jan 2023 09:09:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238663AbjAJOIL (ORCPT ); Tue, 10 Jan 2023 09:08:11 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F7768CBE5; Tue, 10 Jan 2023 06:08:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673359690; x=1704895690; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/W8mB5CAUSKdgh4t9azmzmb5WV1al8YW28UpUk33I4Q=; b=I9QAyZYuqdLhy83alIrBBYvwuBWe++oloKXQ5Kd1xW53btF1T4RDsqzP KudknnZpHFQgRBpvVsGj94jtnD+wEYiZ7AA9IHCSXQcM3jodBwwPp7+69 DjbjkENR/Uhe8YgBoWGe9SJezWTTSA01c35rt9gXG4RuYf/oMnEcotUzz ndbGHdLpF5QrVIc9SVVHMtyYNHBC9Lhv0wd0+emI0IL2v5oiOSgQUMS9M fcaDo+jEE2TaBjtv1dbOWeZBxkWPOadn0LfzmyeEb3aqrqOPweK0nHNOC Z9CoERCBqluqYqqc9lGiaXcg5YYHOyZqKOqfw0FOtXzBBRGQ7g5FCZ+9d Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="303513579" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="303513579" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 06:07:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="725555662" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="725555662" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 10 Jan 2023 06:07:39 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 0BA2F330; Tue, 10 Jan 2023 16:08:13 +0200 (EET) From: Andy Shevchenko To: Rasmus Villemoes , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Cc: Alessandro Zummo , Alexandre Belloni , Jean Delvare , Guenter Roeck , Andy Shevchenko Subject: [PATCH v2 4/5] rtc: isl12022: Join string literals back Date: Tue, 10 Jan 2023 16:08:05 +0200 Message-Id: <20230110140806.87432-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230110140806.87432-1-andriy.shevchenko@linux.intel.com> References: <20230110140806.87432-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754645064866331529?= X-GMAIL-MSGID: =?utf-8?q?1754645064866331529?= For easy grepping on debug purposes join string literals back in the messages. While at it, drop __func__ parameter from unique enough dev_dbg() message as Dynamic Debug can retrieve this at run time. Signed-off-by: Andy Shevchenko Acked-by: Rasmus Villemoes --- drivers/rtc/rtc-isl12022.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c index 77b4763f2a70..ee38c5067ea8 100644 --- a/drivers/rtc/rtc-isl12022.c +++ b/drivers/rtc/rtc-isl12022.c @@ -143,16 +143,12 @@ static int isl12022_rtc_read_time(struct device *dev, struct rtc_time *tm) if (buf[ISL12022_REG_SR] & (ISL12022_SR_LBAT85 | ISL12022_SR_LBAT75)) { dev_warn(dev, - "voltage dropped below %u%%, " - "date and time is not reliable.\n", + "voltage dropped below %u%%, date and time is not reliable.\n", buf[ISL12022_REG_SR] & ISL12022_SR_LBAT85 ? 85 : 75); } dev_dbg(dev, - "%s: raw data is sec=%02x, min=%02x, hr=%02x, " - "mday=%02x, mon=%02x, year=%02x, wday=%02x, " - "sr=%02x, int=%02x", - __func__, + "raw data is sec=%02x, min=%02x, hr=%02x, mday=%02x, mon=%02x, year=%02x, wday=%02x, sr=%02x, int=%02x", buf[ISL12022_REG_SC], buf[ISL12022_REG_MN], buf[ISL12022_REG_HR], From patchwork Tue Jan 10 14:08:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 41493 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2767914wrt; Tue, 10 Jan 2023 06:11:32 -0800 (PST) X-Google-Smtp-Source: AMrXdXstS/mIWZLucFz7SIAgSplZqdd+llCY1nypX4RROYkCT5i7WZ+jkAJfwB0eMxa/RYUs6NRd X-Received: by 2002:a17:90a:7605:b0:227:22d1:5947 with SMTP id s5-20020a17090a760500b0022722d15947mr5082096pjk.45.1673359892642; Tue, 10 Jan 2023 06:11:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673359892; cv=none; d=google.com; s=arc-20160816; b=uGizEq03PYHvpz9Z6NzLU3W1VoB6MXjzL7vi2gPtNJsED80+1/tcaUrbHOesgx8VcE lkbU3vJ//W1i438SdIa+2TXY4FP8ZMKznjDmhZe0Mx6/cUraKit0Dsoe8d8nBjKJIhw9 tB8+dCGwpo+OTJBTaKKD3bhmu4IQTX6PjQyONSGd4qstE+4I0AYTzvTqmfMvwEejChYh oaCnWfbI7BmuTkG5onAzz5H4Y32JQ5EFo4RBSC4ljaQUa/xwNs21Uad/ZMX0oBFnd/Fs Zbz+an3KGfEFk1N26grDDzz9UatyK4DPBuN6hn9Yi4ARoPTaKpjYDLrFPEqRuADey+P8 oAKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wX9KCM6IUoFTHeP/6oToP6jWXTpvfo20nvqn+lW76MI=; b=FgZ4WCxyHNjzvZs9MJ7w1G5NzpwojpPnYwiStsKqUzhUeDRVuddIK85ripZqArssZZ OG+6loR6nKwxwsi2DEepuNrPsdI8MbCmEUO8hL96+AxaRd8a49t2H5aBSZUayWNd5nhu 6a/BC1lJ9nGHKvC/0n29PPaZNuJAl6UOhpYcRQXAWXe5L+qTOiqlVoe3khX9fhb1RFSz 49cjHze5uP5C7j46b9BH79uSgSnWeilQJsHf+9+vkPqD4SkErNN2QnC2yJJghhD+v+cp 0/eD/ZCf13ls02ILI7yZJ85RpO2SZC+/dIObmHtbKU/WfZvg9QI80at0GVRB2weDxhip k9ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=l75mJ+HL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kx3-20020a17090b228300b00225eb9af940si14858368pjb.183.2023.01.10.06.11.09; Tue, 10 Jan 2023 06:11:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=l75mJ+HL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238493AbjAJOIu (ORCPT + 99 others); Tue, 10 Jan 2023 09:08:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238673AbjAJOIN (ORCPT ); Tue, 10 Jan 2023 09:08:13 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B8F58CBE2; Tue, 10 Jan 2023 06:08:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673359692; x=1704895692; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4NOTfNW4jDLP34KQ7vuObhZRGJ9+73gybtn8mNZS7J4=; b=l75mJ+HL+1N2aIBmgFij+XfJj7/rOdqwPDjQSdzj5HuHm3qyIbXu5WMe 1+zMSJAoOOOGfd8ebRFXOxIEmIXfH5kvSygF2+7VznVX+/JCPzvpdbCiz wxYw7x8x/UNuid5qmR/zppUH+C77Foc6A67p4YRAgVxgXPagCXRozr7cX t3yFFkkysCj6IKgLRSxYFLmLpIsQiw0Wd2S7Nm+mlHBl40ypILSGSEQl/ Yqtds/g5TjgHuGQLvSCKjq+xls188IPjzdL9s4lYGYUMp2qGX3GKB4lje v/VOKmb1kD82hzOqsRyF/PIQwc3VRnKqENkqswcuE+pkPQEULViHS61RB A==; X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="303513607" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="303513607" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 06:07:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="725555694" X-IronPort-AV: E=Sophos;i="5.96,315,1665471600"; d="scan'208";a="725555694" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 10 Jan 2023 06:07:42 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 125EB4E3; Tue, 10 Jan 2023 16:08:13 +0200 (EET) From: Andy Shevchenko To: Rasmus Villemoes , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Cc: Alessandro Zummo , Alexandre Belloni , Jean Delvare , Guenter Roeck , Andy Shevchenko Subject: [PATCH v2 5/5] rtc: isl12022: sort header inclusion alphabetically Date: Tue, 10 Jan 2023 16:08:06 +0200 Message-Id: <20230110140806.87432-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230110140806.87432-1-andriy.shevchenko@linux.intel.com> References: <20230110140806.87432-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754645022729034704?= X-GMAIL-MSGID: =?utf-8?q?1754645022729034704?= Sort header inclusion alphabetically for better maintenance. Signed-off-by: Andy Shevchenko Acked-by: Rasmus Villemoes --- drivers/rtc/rtc-isl12022.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c index ee38c5067ea8..e68a79b5e00e 100644 --- a/drivers/rtc/rtc-isl12022.c +++ b/drivers/rtc/rtc-isl12022.c @@ -8,14 +8,14 @@ * by Alessandro Zummo . */ -#include #include -#include -#include -#include #include -#include #include +#include +#include +#include +#include +#include #include