From patchwork Tue Jan 10 13:08:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yicong Yang X-Patchwork-Id: 41457 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2737797wrt; Tue, 10 Jan 2023 05:13:05 -0800 (PST) X-Google-Smtp-Source: AMrXdXsBf+o+6eXodEBpHYlcF9aoBbYzPIP1fbYn7rW3wi0Ex+pMZyTf6j2Bql2YRDb8x5q4cTPw X-Received: by 2002:a17:906:4e43:b0:84d:3fa7:12d7 with SMTP id g3-20020a1709064e4300b0084d3fa712d7mr9084636ejw.21.1673356385245; Tue, 10 Jan 2023 05:13:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673356385; cv=none; d=google.com; s=arc-20160816; b=x9XwWQaCXRAm2Md5psCf6Qfw2y9tl8D1i8u4yKvt0WwJJfKevN6z8oPcEi3QGl1FM0 aZxu/lKhYv/nsETnA9H8yBuEQKT9iZkgNJVQ1H3HBHgejamEUA9/26BiWkgivrMSrNPc nC2+3S8sp5DtWOkF1hII9UJmZ4TOkqDt4PkkDRX8yHaVoKlMCulaWqz9kw9+Pyi0u0qu GHRhoqbhFX5pTZndOLWEsRsDdr+KA6/JVrlBSjohDHK9gfR1bGwuntjAhwrNtGI0Fj3/ tewlvywWVWGhs2Z7NB2luPZFTvq0+Z0Mdji+oa5KnOVo15dyRdw5auSLSd+zI3TaqNGW 14kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=SxPjtRiN/ORo0Kmg1hFN81eAUNlstbqKddNqKcEwtAc=; b=MRNtg1cfbP50RQjsk9U93qoclNMryOqL9VMQ7qot++VtwRy2xR9KgEYPo8NPFevdzx KEzQiXhvF1ppmV2uZrnBP3UhN9EEYAhYmfImIkIlXol6S1bm6ZvnFjUJG5Ga9S5RvLI0 6hosA9KfUdTfAkz5fuEONGnsGHobGr9RqEk5N/QU1FlIoW6f9ywUoXK58IA6XjtpSPD9 XYYoxlU2s6JPFvqcIUs2U0nzPWhds9rSe1mkzx7WcYYbn2rSbO+ZWt6J+f3toO9hwVgV 7zoCLfsWjjqhOTQegUmomc8o8rkDOGus2ea7PQikcyGmvkdXCIr8dJZ2k7Wilx39CTrL sNPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa11-20020a1709076d0b00b007c841b8fa31si13156613ejc.629.2023.01.10.05.12.41; Tue, 10 Jan 2023 05:13:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233345AbjAJNJz (ORCPT + 99 others); Tue, 10 Jan 2023 08:09:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238615AbjAJNJk (ORCPT ); Tue, 10 Jan 2023 08:09:40 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D31FB6ECBD; Tue, 10 Jan 2023 05:09:13 -0800 (PST) Received: from canpemm500009.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NrrhN4xkHzJrDt; Tue, 10 Jan 2023 21:07:48 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 10 Jan 2023 21:09:05 +0800 From: Yicong Yang To: , , , CC: , , , , , Yicong Yang , Jonathan Cameron Subject: [PATCH v2 1/2] hwtracing: hisi_ptt: Only add the supported devices to the filters list Date: Tue, 10 Jan 2023 21:08:32 +0800 Message-ID: <20230110130833.53474-1-yangyicong@huawei.com> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754641345011554440?= X-GMAIL-MSGID: =?utf-8?q?1754641345011554440?= From: Yicong Yang The PTT device can only support the devices on the same PCIe core, within BDF range [lower_bdf, upper_bdf]. It's not correct to assume the devices on the root bus are from the same PCIe core, there are cases that root ports from different PCIe core are sharing the same bus. So add the checking when initialize the filters list. Fixes: ff0de066b463 ("hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device") Signed-off-by: Yicong Yang Reviewed-by: Jonathan Cameron --- Change since v1: - Add tags from Jonathan Link: https://lore.kernel.org/linux-pci/20221122120209.25682-1-yangyicong@huawei.com/raw drivers/hwtracing/ptt/hisi_ptt.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c index 5d5526aa60c4..30f1525639b5 100644 --- a/drivers/hwtracing/ptt/hisi_ptt.c +++ b/drivers/hwtracing/ptt/hisi_ptt.c @@ -356,8 +356,18 @@ static int hisi_ptt_register_irq(struct hisi_ptt *hisi_ptt) static int hisi_ptt_init_filters(struct pci_dev *pdev, void *data) { + struct pci_dev *root_port = pcie_find_root_port(pdev); struct hisi_ptt_filter_desc *filter; struct hisi_ptt *hisi_ptt = data; + u32 port_devid; + + if (!root_port) + return 0; + + port_devid = PCI_DEVID(root_port->bus->number, root_port->devfn); + if (port_devid < hisi_ptt->lower_bdf || + port_devid > hisi_ptt->upper_bdf) + return 0; /* * We won't fail the probe if filter allocation failed here. The filters From patchwork Tue Jan 10 13:08:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yicong Yang X-Patchwork-Id: 41456 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2737796wrt; Tue, 10 Jan 2023 05:13:05 -0800 (PST) X-Google-Smtp-Source: AMrXdXuVB8VkesXL/MtXBB6rU0AD3z3TTUrETy21/4LSxIUsTe0nFxgr120uqG0h4lCZWH28m55n X-Received: by 2002:a17:907:6e15:b0:7c0:fb3d:11a6 with SMTP id sd21-20020a1709076e1500b007c0fb3d11a6mr74331708ejc.38.1673356385102; Tue, 10 Jan 2023 05:13:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673356385; cv=none; d=google.com; s=arc-20160816; b=exau19NlSmxQYm97ndi0AAliJMTYL455liD1HKBmP+G9bD4SbUk2DMlkrSf6vVQ5jy KaPOoIU85Qr6qmaY2KD5Kbql7TZIGArUX9RIpZs8KGoIKqWGtTgDCYOcT8lJX1qjwdb6 ZWR5dwsKynb/tXSqR7wff692Sp0c/RPUlbjamc603UyyROszmKRH2r9yGh0ijamKrQgH 7i9K/gT/rZQ3UGfvHKtnmWPkFMH6xsvCWBFpb4eldH6XzuR5/xcma6FnWCTZOyTIULUG aEVvMtf8V4fXeZqRY1qXsMwJSJycS6wbALrzkDqdlUi1GwW2d/lb0Mx5leouIeepRNct utCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=b2G6wzOM3rG8faibUwNWmKJFHRXSFtzTGS0Ny1wQdA8=; b=j7GtQyMxqu+Rfol74N24jPCK4k72qdUAlinO0pmZtb7MnNR4tcKeIdC9h+j4EFbsOO geolFtd8Ta9sq/N/bTP7BxcAo6M5z4u6Hx1Wb4sMYNDoAelObNjHv1EevEehyYORKWQl dwCFQRwjJqObk2HYoSXd3NTZFsolrQlPKMwbbYPFk9X1rbyfHisetSdsuL++JxIPJjmo Nfr5CR6zq560G68OfOfhaPQCVd9/gwW4jcbS8cZfBgCo9UzPQdhkBGrQbwLoRGHfKUKP Ss6U9Z6rgy41UhByfQigDMAkBOsD6VaxoYXUVCkIY+RrfeoJ/HYCNOvKh589FoSJBVpk 7M7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k26-20020aa7d8da000000b0048bed17d7d9si10781738eds.8.2023.01.10.05.12.41; Tue, 10 Jan 2023 05:13:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238417AbjAJNJ6 (ORCPT + 99 others); Tue, 10 Jan 2023 08:09:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238617AbjAJNJk (ORCPT ); Tue, 10 Jan 2023 08:09:40 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C514C6F94B; Tue, 10 Jan 2023 05:09:23 -0800 (PST) Received: from canpemm500009.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Nrrh53jjqzRqtw; Tue, 10 Jan 2023 21:07:33 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 10 Jan 2023 21:09:14 +0800 From: Yicong Yang To: , , , CC: , , , , , Yicong Yang , Jonathan Cameron Subject: [PATCH v2 2/2] MAINTAINERS: Update the entries for HiSilicon PTT device driver Date: Tue, 10 Jan 2023 21:08:33 +0800 Message-ID: <20230110130833.53474-2-yangyicong@huawei.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20230110130833.53474-1-yangyicong@huawei.com> References: <20230110130833.53474-1-yangyicong@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754641344807186356?= X-GMAIL-MSGID: =?utf-8?q?1754641344807186356?= From: Yicong Yang Add missing entries for the perf userspace part of this driver. Also add Jonathan as the maintainer for his expertise on this driver and PCIe stuffs. Signed-off-by: Yicong Yang Acked-by: Jonathan Cameron --- Change since v1: - Add tag from Jonathan Link: https://lore.kernel.org/linux-pci/20221122120209.25682-2-yangyicong@huawei.com/ MAINTAINERS | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a36df9ed283d..0cfd358da378 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9375,11 +9375,15 @@ F: drivers/perf/hisilicon/hns3_pmu.c HISILICON PTT DRIVER M: Yicong Yang +M: Jonathan Cameron L: linux-kernel@vger.kernel.org S: Maintained F: Documentation/ABI/testing/sysfs-devices-hisi_ptt F: Documentation/trace/hisi-ptt.rst F: drivers/hwtracing/ptt/ +F: tools/perf/arch/arm64/util/hisi-ptt.c +F: tools/perf/util/hisi-ptt* +F: tools/perf/util/hisi-ptt-decoder/* HISILICON QM DRIVER M: Weili Qian