From patchwork Sun Jan 8 16:28:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 40525 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1768929wrt; Sun, 8 Jan 2023 08:30:29 -0800 (PST) X-Google-Smtp-Source: AMrXdXu95tFh8MHHGS7g1kd35bkUCILbqiq83p+s48XwZG6iNipoUhpxuhY4A5WWAJibX/t05UYk X-Received: by 2002:a05:6a00:e8d:b0:580:c223:90e9 with SMTP id bo13-20020a056a000e8d00b00580c22390e9mr53970142pfb.6.1673195428819; Sun, 08 Jan 2023 08:30:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673195428; cv=none; d=google.com; s=arc-20160816; b=EfeMTnxFvzYxadewMrtEAojdEALzzfhnd6FgQCBTOefcMXVDg06e5GxQpvyC/XlfIE t4iUfKo5vAXPiWfnSRz/otzTI5oSEfQq/zLjy7giZXAnpMpSvSLTj/IhN9vzffjtoWQM +fJkdjV9NVqwL2NF8LMM7Lucp3ufa3vO/h4g3TLVoQPht52+X3ChpZqozzAk9BvCGOcD qN5N1w3u6A5ESJIrHXKDk/93isGPb47erAAXNV1NFAnqkQl4nR6Yk9eWhs1QoUbEZ+S2 AmSeNOXlQsCnhRwda+zS2aL0jb57+1irNGQj+QECtkSn0Dqt3uDbzA0qurOYUxmEZMue 2YbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=Qdpfqc8wYvCnXHYRBqC9nBGHujUBghRRJ6PDZalP6VM=; b=Ljvm9ZEA61IcRFsVYRdoYohZzDgafh91WukZrum85WawwA5o1L5ZAs6YX/7DH4pQ7c 2XGWvF0lL7DOiqKdbe18pazlz+IuY7lSdQAXZuObRBXGhy193DQCvddOnSJesLeDgftT 2aFgqlNd7A6PpIXiYHg+KTlbBL6wYWgPLqRe4oJSXUm6dv+KMXruuOaTgi2PzTSZKzEc r/eXhrSItDRxJFHnHiXe+zd/SQO7MJHgYI+dS8HJ2J9Pj4wA79H2k6gb41/NLbAmc8GU TKF4rZtcPDq9qXr4R6eSZVvV2oB9+t/N6y92elQyfeeCnOSoltfriqVucMhqZzAWMTMj /iZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=KBhSLm0H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c8-20020aa78c08000000b005786897553bsi6969158pfd.39.2023.01.08.08.30.15; Sun, 08 Jan 2023 08:30:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=KBhSLm0H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234897AbjAHQ3Q (ORCPT + 99 others); Sun, 8 Jan 2023 11:29:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234911AbjAHQ3N (ORCPT ); Sun, 8 Jan 2023 11:29:13 -0500 Received: from msg-4.mailo.com (msg-4.mailo.com [213.182.54.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D91459FE0; Sun, 8 Jan 2023 08:29:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1673195336; bh=3tCq7DRIRkJTLbdjKV6gP++U0oYYC0TWrEsd3ZKpEU4=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type; b=KBhSLm0HH2jhGgyH/gtvMHnhnuyw2vmFTcCbU8xMLmJpr6CLa+i2+FHtfSKyrpgxU rZzwmRZW97s+QlwzJw+aofqRk9AhZ5l41cOXAHW4kU9XrV7LArCZwfaB/bkBNuWIfA Jh8Awvj3wd2vEOVdCOZWhptWu9DPegJvaKRse2QY= Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sun, 8 Jan 2023 17:28:56 +0100 (CET) X-EA-Auth: WXvDAjjwuLqpyOTH6avyGjsi3RNEzYCUpX0Cbj/7dwRDF+CtlaXdIhtiLmLfBJn422sz3zAWdjDHgvJdmjnPVhYz3pncpjMd Date: Sun, 8 Jan 2023 21:58:51 +0530 From: Deepak R Varma To: Brian King , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar Subject: [PATCH v2] scsi: ipr: Convert ipr_probe_ioa_part2 as void Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754468200405080517?= X-GMAIL-MSGID: =?utf-8?q?1754472569644510231?= Convert function ipr_probe_ioa_part2() to return void instead of int since the current implementation always returns 0 to the caller. The transformation also eliminates the dead code when calling ipr_probe_ioa_part2() function. Issue identified using returnvar Coccinelle semantic patch. Signed-off-by: Deepak R Varma Acked-by: Brian King --- Changes in v2: - retain and update Return value comment in function documentation drivers/scsi/ipr.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) -- 2.34.1 diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c index 2022ffb45041..dfb759fbbd87 100644 --- a/drivers/scsi/ipr.c +++ b/drivers/scsi/ipr.c @@ -9505,11 +9505,10 @@ static pci_ers_result_t ipr_pci_error_detected(struct pci_dev *pdev, * This function takes care of initilizing the adapter to the point * where it can accept new commands. * Return value: - * 0 on success / -EIO on failure + * none **/ -static int ipr_probe_ioa_part2(struct ipr_ioa_cfg *ioa_cfg) +static void ipr_probe_ioa_part2(struct ipr_ioa_cfg *ioa_cfg) { - int rc = 0; unsigned long host_lock_flags = 0; ENTER; @@ -9525,7 +9524,6 @@ static int ipr_probe_ioa_part2(struct ipr_ioa_cfg *ioa_cfg) spin_unlock_irqrestore(ioa_cfg->host->host_lock, host_lock_flags); LEAVE; - return rc; } /** @@ -10568,12 +10566,7 @@ static int ipr_probe(struct pci_dev *pdev, const struct pci_device_id *dev_id) return rc; ioa_cfg = pci_get_drvdata(pdev); - rc = ipr_probe_ioa_part2(ioa_cfg); - - if (rc) { - __ipr_remove(pdev); - return rc; - } + ipr_probe_ioa_part2(ioa_cfg); rc = scsi_add_host(ioa_cfg->host, &pdev->dev);