From patchwork Sun Jan 8 02:12:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 40467 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1529830wrt; Sat, 7 Jan 2023 18:13:29 -0800 (PST) X-Google-Smtp-Source: AMrXdXs7y3OL/zKb3uJtkdRLpYnNWIoiXJ9jdIFZLpL1+PpFVEAIGZ7AbiRDoBtvt0tx2bTLuGj3 X-Received: by 2002:a05:6a20:1e51:b0:b2:2e66:5482 with SMTP id cy17-20020a056a201e5100b000b22e665482mr65056555pzb.7.1673144009337; Sat, 07 Jan 2023 18:13:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673144009; cv=none; d=google.com; s=arc-20160816; b=Nie0dF7sGQ4AOcGkICCkmkRdCvOR9lGOt1btj+gjPoXuiVg3RIG0P0qLwqN6Iaoqg8 ehSmOkykCepKMmlyAGRgIFZKL1xRMSSizJrZTWWCQ94jWtYY4wVW5tAvAc8ucbc4TdqK DeGGGhEwJja2CS3RweFQK2rNq+a2ZJrXQwiPBtT26wd/58/G19+3PZ8d4t6pJsj9H1EY Rq9zx18gVykTklGXDSQqUO82lZrX9hHsIQPp0Eg73sbIlWF9HpnUlUh0wurQGaEbYUoy MnEYngJJjCwbRRulVDhw9J4HGFWceimD3q7yUKfy1tNtC+cRyzhPhCD10Dg/BHxbNfrX oTxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Lma7iRko69ZPpeW5xrn6KMqpGCw11zniVvr/dJegD0Q=; b=AfNk4I3qW0wIykNrk5Gri2xHyYxD7V5if1FQTzFTzKRacHCQS0tCMljVanEYYJ3zJZ WGTWcV/UpPlq6iwFYslA5Er4EG8K2WKUvagGbUJf+B+UoWWrJpLpUm6p3AmBvy9JhiHZ Y7vS0o2FZTiQdEkKNXQtRmCiQ1sxCR6io6mfhoL3xEztym4BaqRrjkHDPPM1vBRkDoYA j5qoKN3lYAfKbVfaqAHSfBYhs2D4avDstkEaZKtZ+Gv2WZtrSWiYeycscuMAHzKAoT3m EIyc+Z1jYZqUZY4uSivcpVWfRsbZgaTdRtBEHz+irJCsiUKNYWYmgl94cebEE0Waz8h4 sUbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=a8N02rIf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t203-20020a635fd4000000b00478701e57c8si5854819pgb.807.2023.01.07.18.13.16; Sat, 07 Jan 2023 18:13:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=a8N02rIf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232204AbjAHCM2 (ORCPT + 99 others); Sat, 7 Jan 2023 21:12:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232106AbjAHCMZ (ORCPT ); Sat, 7 Jan 2023 21:12:25 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BBB215F02; Sat, 7 Jan 2023 18:12:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=Lma7iRko69ZPpeW5xrn6KMqpGCw11zniVvr/dJegD0Q=; b=a8N02rIfT7KykuX+7Xs0Up/JV0 P56+5z3gyWyUG/JcsolpKVzPnqT02M2l4Un+4yHhAWQf9oSVOHzJ4zOgnIe86xsg96ah1QiXT0t3S RTq5fxAmJjZEZc2XHB3EYI6dqHNx3tLU60wFOhPnWYZudM1SY1Uhk5Agcbrgf4FfuMgXzsPejw+ut liLmGDIw0EHZGQuoWZiY6LigcDB4nXvnpq+8jKuPyaZm3YTKtM9+ufcNukOGmrwBhU8XnWQFSoHSp Q182LUdfObJh7sJKFTOQWJs7OZLrU5HxxerxES952WwgL40ZztozDGLA7zZ7TOoEWUs4lbYoVvuxR vbln4wQQ==; Received: from [2601:1c2:d80:3110::a2e7] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pELAa-00Aq0G-D6; Sun, 08 Jan 2023 02:12:20 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Waiman Long , Zefan Li , Tejun Heo , Johannes Weiner , cgroups@vger.kernel.org Subject: [PATCH] cgroup/cpuset: fix a few kernel-doc warnings & coding style Date: Sat, 7 Jan 2023 18:12:17 -0800 Message-Id: <20230108021217.15491-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754418652897282023?= X-GMAIL-MSGID: =?utf-8?q?1754418652897282023?= Fix kernel-doc notation warnings: kernel/cgroup/cpuset.c:1309: warning: Excess function parameter 'cpuset' description in 'update_parent_subparts_cpumask' kernel/cgroup/cpuset.c:3909: warning: expecting prototype for cpuset_mem_spread_node(). Prototype was for cpuset_spread_node() instead Also drop a blank line before EXPORT_SYMBOL_GPL() to be consistent with kernel coding style. Signed-off-by: Randy Dunlap Cc: Waiman Long Cc: Zefan Li Cc: Tejun Heo Cc: Johannes Weiner Cc: cgroups@vger.kernel.org --- kernel/cgroup/cpuset.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff -- a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -1267,7 +1267,7 @@ static int update_flag(cpuset_flagbits_t int turning_on); /** * update_parent_subparts_cpumask - update subparts_cpus mask of parent cpuset - * @cpuset: The cpuset that requests change in partition root state + * @cs: The cpuset that requests change in partition root state * @cmd: Partition root state change command * @newmask: Optional new cpumask for partcmd_update * @tmp: Temporary addmask and delmask @@ -3879,8 +3879,7 @@ bool __cpuset_node_allowed(int node, gfp } /** - * cpuset_mem_spread_node() - On which node to begin search for a file page - * cpuset_slab_spread_node() - On which node to begin search for a slab page + * cpuset_spread_node() - On which node to begin search for a page * * If a task is marked PF_SPREAD_PAGE or PF_SPREAD_SLAB (as for * tasks in a cpuset with is_spread_page or is_spread_slab set), @@ -3904,12 +3903,14 @@ bool __cpuset_node_allowed(int node, gfp * is passed an offline node, it will fall back to the local node. * See kmem_cache_alloc_node(). */ - static int cpuset_spread_node(int *rotor) { return *rotor = next_node_in(*rotor, current->mems_allowed); } +/** + * cpuset_mem_spread_node() - On which node to begin search for a file page + */ int cpuset_mem_spread_node(void) { if (current->cpuset_mem_spread_rotor == NUMA_NO_NODE) @@ -3919,6 +3920,9 @@ int cpuset_mem_spread_node(void) return cpuset_spread_node(¤t->cpuset_mem_spread_rotor); } +/** + * cpuset_slab_spread_node() - On which node to begin search for a slab page + */ int cpuset_slab_spread_node(void) { if (current->cpuset_slab_spread_rotor == NUMA_NO_NODE) @@ -3927,7 +3931,6 @@ int cpuset_slab_spread_node(void) return cpuset_spread_node(¤t->cpuset_slab_spread_rotor); } - EXPORT_SYMBOL_GPL(cpuset_mem_spread_node); /**