From patchwork Fri Jan 6 16:48:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Kitt X-Patchwork-Id: 40207 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp930077wrt; Fri, 6 Jan 2023 09:12:18 -0800 (PST) X-Google-Smtp-Source: AMrXdXvAJR6BBbEPqm/Nm+i/d4bVSbYW2Stl/l2Il1tLhuAzWqG/vq3hIy3LxrqHvk7RwVMam+5y X-Received: by 2002:a17:902:a981:b0:187:403c:7a3b with SMTP id bh1-20020a170902a98100b00187403c7a3bmr49736879plb.69.1673025137881; Fri, 06 Jan 2023 09:12:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673025137; cv=none; d=google.com; s=arc-20160816; b=sUWRMPvAkqGdCBwQWL5Pzj54tW+VpZ5vtWp6WFgZIzhGbCn0cw56HmTyw4VtI4GpW1 r+lxrEJmz8nICsMf7X0tZ0Kai0Sk/v54oifqj6qget6rqHVfMv1Q/gzSykE/6KQUFnQi XL1q5gjhNJk+3OR4XUMJZL1u5fBuvI/7SITYOYfL5pBOQOrltvrL1SZwikNTJGlUSHnp +8WX8801ueopncIBnD1XFckenyPdmHcVR8w1Zv0y3y6qtGo0icHGdnW047SK87WJOFKC MWoPChT/CKjxDkp33N4tmWCmcwlzGQ9nGAsJ7XXCru6UA557o3DEvdyhI9fcRqFqFFWi xUXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=tDH5VldQyZ5Yva2mCa6GxzBhNmE81O7JsOP/ynC/AHw=; b=YypAP1dThoLSFQOYMN/niEmMEAEhHFVlLoBOcSxkMG0M02IsVXUNnNLi5chAI9R92y LYbG+o+k/J/TYeDJMWF6IdC7tW1T6gvFHy8v3qjR9Q0IZQ7oMiuJL6X6RuCyiEDq3BCn Ia1ibHdbY/2B66ePdDO9tHx7QIStY7zS8F7tB7JXImm+5GUeX98/NbBiQm4dJO2Uo1Zk dEWtE9BeznL3xqLIP5ugqk33Z7ejjqbiIGr7D3vjgV0ypxIhpo85qmNjcp58ghzg9ifd PlAvvnBcwf2TJa+XDuW9cUwA9kJn24ZF3TjD4Eg6sqtK/FVq/vpf71qZspAfkHuFEZF+ EFHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o17-20020a170902779100b00186ab03eebfsi1322079pll.418.2023.01.06.09.12.04; Fri, 06 Jan 2023 09:12:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbjAFRHq (ORCPT + 99 others); Fri, 6 Jan 2023 12:07:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230085AbjAFRHo (ORCPT ); Fri, 6 Jan 2023 12:07:44 -0500 X-Greylist: delayed 1057 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 06 Jan 2023 09:07:40 PST Received: from 19.mo582.mail-out.ovh.net (19.mo582.mail-out.ovh.net [188.165.56.177]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F5B5F8 for ; Fri, 6 Jan 2023 09:07:40 -0800 (PST) Received: from director9.ghost.mail-out.ovh.net (unknown [10.109.143.72]) by mo582.mail-out.ovh.net (Postfix) with ESMTP id AF6232622D for ; Fri, 6 Jan 2023 16:49:58 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-dkv5l (unknown [10.110.171.46]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id C0B041FF00; Fri, 6 Jan 2023 16:49:57 +0000 (UTC) Received: from sk2.org ([37.59.142.107]) by ghost-submission-6684bf9d7b-dkv5l with ESMTPSA id KI4TJzVRuGOnAQEAwhnnFg (envelope-from ); Fri, 06 Jan 2023 16:49:57 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-107S0018fb2c2a3-f80b-4d71-80ed-2036c37f7c47, 9FE29456621203A27B372E1E0503D45BE0167874) smtp.auth=steve@sk2.org X-OVh-ClientIp: 82.65.25.201 From: Stephen Kitt To: Lee Jones , Daniel Thompson , Jingoo Han Cc: Sam Ravnborg , Stephen Kitt , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 1/4] backlight: aat2870: Use backlight helper Date: Fri, 6 Jan 2023 17:48:52 +0100 Message-Id: <20230106164856.1453819-2-steve@sk2.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Ovh-Tracer-Id: 5851864767681496795 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkedtgdelgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefuthgvphhhvghnucfmihhtthcuoehsthgvvhgvsehskhdvrdhorhhgqeenucggtffrrghtthgvrhhnpeelgeetueejffejfeejvefhtddufeejgfetleegtddukeelieelvddvteduveejtdenucfkphepuddvjedrtddrtddruddpfeejrdehledrudegvddruddtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehsthgvvhgvsehskhdvrdhorhhgqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdpoffvtefjohhsthepmhhoheekvddpmhhouggvpehsmhhtphhouhht X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754294007077843854?= X-GMAIL-MSGID: =?utf-8?q?1754294007077843854?= Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes. Signed-off-by: Stephen Kitt Reviewed-by: Sam Ravnborg Reviewed-by: Daniel Thompson --- drivers/video/backlight/aat2870_bl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/backlight/aat2870_bl.c b/drivers/video/backlight/aat2870_bl.c index a7af9adafad6..1cbb303e9c88 100644 --- a/drivers/video/backlight/aat2870_bl.c +++ b/drivers/video/backlight/aat2870_bl.c @@ -59,7 +59,7 @@ static int aat2870_bl_update_status(struct backlight_device *bd) struct aat2870_bl_driver_data *aat2870_bl = bl_get_data(bd); struct aat2870_data *aat2870 = dev_get_drvdata(aat2870_bl->pdev->dev.parent); - int brightness = bd->props.brightness; + int brightness = backlight_get_brightness(bd); int ret; if ((brightness < 0) || (bd->props.max_brightness < brightness)) { @@ -70,11 +70,6 @@ static int aat2870_bl_update_status(struct backlight_device *bd) dev_dbg(&bd->dev, "brightness=%d, power=%d, state=%d\n", bd->props.brightness, bd->props.power, bd->props.state); - if ((bd->props.power != FB_BLANK_UNBLANK) || - (bd->props.state & BL_CORE_FBBLANK) || - (bd->props.state & BL_CORE_SUSPENDED)) - brightness = 0; - ret = aat2870->write(aat2870, AAT2870_BLM, (u8)aat2870_brightness(aat2870_bl, brightness)); if (ret < 0) From patchwork Fri Jan 6 16:48:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Kitt X-Patchwork-Id: 40278 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1084226wrt; Fri, 6 Jan 2023 16:01:20 -0800 (PST) X-Google-Smtp-Source: AMrXdXsvjJdc4Y210Ugnsdv7zi5dnvCXVoIfNi5Q2NP1V2roykqaIDa5HvUPv7cj4GPEWmu/JNp9 X-Received: by 2002:a17:90a:5994:b0:226:ae12:444d with SMTP id l20-20020a17090a599400b00226ae12444dmr12001156pji.43.1673049679958; Fri, 06 Jan 2023 16:01:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673049679; cv=none; d=google.com; s=arc-20160816; b=a5dO9X7Mn2bDn3PfGXT2S8+awIFmyepJfSNNsgbJSaFxmDp+1U+UlO9Y0pg6gBiDRG ZDL2UuPvHU3cDXaLS1nuZo/gUiE0NPWLa6aZO2M+E9RLkkU9z+nAduVugdan6zTAEY2u ppTPMz7XgEqcvl8Vp81PjyIihYMAMRToJHa5Vb2REIHZF4CFcacppSejIAD8SHmxAC/R OW10muu50WRMrLFWig3ctHvJO0WokmRCdajXM+oBos3hDbGrY5Jz0SYxbs8/KcTT2FdS Jh+Hrcv2iAyJr9D47XBnwTi5TGlbbgqzyp55HrqaT375pjnL8TZmPsrnICHwH3SjPsqu PdUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=MQ96qZz3YLpiKAEhsqpjZCyVKVw55aOz2bvmrCPIhPo=; b=ow5OuFo3Ovz05Y1XDtgvNTm/Xc0831jCihtbI5reJ6ijXGVxEJNuQzVmvNOiHaKvBK Jc6+H4trAank7VTDnmFfpiX84ZHQEVtuUoxSjS0AooBjQjHEurpoQLX4L00eFa1SCtir tL0D9EsaftOOH8kwbFaRekiWtYSN5x2b8vElml5gdDWHMk++zHyxueS7mWYWUOzgE7SR /x03XkxmZu46/OYKHZzeQCNtupWHZ69jrgh2UaOcsq3dIBRiiBchL+RoDHBjzodhEDn1 uXfH+CH5Ew8bN7ySAz+OdAO/11d/UqH2dSCACfgKTXxPFDtMdDp/dUjm+b7uZwP7ZQ8L WGXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v135-20020a63618d000000b004acf6fb7c81si1317825pgb.4.2023.01.06.16.01.05; Fri, 06 Jan 2023 16:01:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236614AbjAGAAE (ORCPT + 99 others); Fri, 6 Jan 2023 19:00:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236676AbjAFX72 (ORCPT ); Fri, 6 Jan 2023 18:59:28 -0500 X-Greylist: delayed 25756 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 06 Jan 2023 15:59:17 PST Received: from 20.mo584.mail-out.ovh.net (20.mo584.mail-out.ovh.net [46.105.33.73]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE4FB1BC9E for ; Fri, 6 Jan 2023 15:59:17 -0800 (PST) Received: from director9.ghost.mail-out.ovh.net (unknown [10.109.143.136]) by mo584.mail-out.ovh.net (Postfix) with ESMTP id AE40A23444 for ; Fri, 6 Jan 2023 16:49:59 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-dkv5l (unknown [10.110.171.46]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 0C2171FE9B; Fri, 6 Jan 2023 16:49:59 +0000 (UTC) Received: from sk2.org ([37.59.142.107]) by ghost-submission-6684bf9d7b-dkv5l with ESMTPSA id eB+zADdRuGOnAQEAwhnnFg (envelope-from ); Fri, 06 Jan 2023 16:49:59 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-107S00109038e94-ae10-4a84-be5c-29fce71eaa6f, 9FE29456621203A27B372E1E0503D45BE0167874) smtp.auth=steve@sk2.org X-OVh-ClientIp: 82.65.25.201 From: Stephen Kitt To: Lee Jones , Daniel Thompson , Jingoo Han Cc: Sam Ravnborg , Stephen Kitt , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 2/4] backlight: arcxcnn: Use backlight helper Date: Fri, 6 Jan 2023 17:48:53 +0100 Message-Id: <20230106164856.1453819-3-steve@sk2.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Ovh-Tracer-Id: 5852146243471509211 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkedtgdelhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefuthgvphhhvghnucfmihhtthcuoehsthgvvhgvsehskhdvrdhorhhgqeenucggtffrrghtthgvrhhnpeelgeetueejffejfeejvefhtddufeejgfetleegtddukeelieelvddvteduveejtdenucfkphepuddvjedrtddrtddruddpfeejrdehledrudegvddruddtjeenucevlhhushhtvghrufhiiigvpedvnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehsthgvvhgvsehskhdvrdhorhhgqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdpoffvtefjohhsthepmhhoheekgedpmhhouggvpehsmhhtphhouhht X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754296193092262787?= X-GMAIL-MSGID: =?utf-8?q?1754319741164125614?= Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes. Signed-off-by: Stephen Kitt Reviewed-by: Daniel Thompson --- drivers/video/backlight/arcxcnn_bl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/video/backlight/arcxcnn_bl.c b/drivers/video/backlight/arcxcnn_bl.c index 555b036643fb..e610d7a1d13d 100644 --- a/drivers/video/backlight/arcxcnn_bl.c +++ b/drivers/video/backlight/arcxcnn_bl.c @@ -130,12 +130,9 @@ static int arcxcnn_set_brightness(struct arcxcnn *lp, u32 brightness) static int arcxcnn_bl_update_status(struct backlight_device *bl) { struct arcxcnn *lp = bl_get_data(bl); - u32 brightness = bl->props.brightness; + u32 brightness = backlight_get_brightness(bl); int ret; - if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK)) - brightness = 0; - ret = arcxcnn_set_brightness(lp, brightness); if (ret) return ret; From patchwork Fri Jan 6 16:48:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Kitt X-Patchwork-Id: 40203 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp922831wrt; Fri, 6 Jan 2023 09:00:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXsLzm0czT2NRpaM2ykLqHJDyf4/JAVc5QgjDtDjHUwX5QJOv1br8k7kwU6IkAn23mAXTwXl X-Received: by 2002:a17:906:eda2:b0:7c0:cee0:2f55 with SMTP id sa2-20020a170906eda200b007c0cee02f55mr50248993ejb.28.1673024421640; Fri, 06 Jan 2023 09:00:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673024421; cv=none; d=google.com; s=arc-20160816; b=E3LvHkbaAntvlZQC3THPg1R8LnMnRsnMKkMmRsG8bSoT9/FymcbrOPCfc3OrEIp0Fw F2pO6qLSSMa29BmHDHsG+SKeVsaLE33W35yt76/ctHk4hZ0Qf8Pzv9aFxEh/h/7gtNvK +Dn2CkgNDrm9wDGg4CXD8QrNyetcrbb7HQWopJAksl3k6gKJ6dU28U/wuTrzFLCvDlyT 4HEb5MA3fQI53+D+UV5+iE5MLU90lWJWODrI8vDBn4urrScq2nDHSSBeea1x9Zk32t57 muv3Bp6l83Z/n5o6snd0/Z/iuMH2iLmQ07wCaB7ZcNMv1wntI6guLKLDXeO+UHq+zT0b aTnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=8u7YHe7l+BOEFV6VazqEy5E870w7Bqa7fqDPDtu4vvU=; b=a4HbG3kWYM9rNwYeexE10mS7AwbQKoVyip9f+uAx7cA+NKFQLOPz89pi1+3CN2vkV3 yC+Inc0tF7U7HgQoEHJ2FN7m/UO7P+Yff7RqsRo5HmjB/LC7JSGG3JSh8jKAnVbHlSzo n8wCfcHOks5xAYfNssiSsjWZqrCby1p9m4E91fO1qMWXsST8Fn8jONraqalCjAxIHDMT jfgw7gbdC0fU0MVHN/c1pbFH6W1cxZzxLOuQTQip2AmhXyvfUIWyX9xhMiyGWB+E2C30 Z0fBkuXaSSOQ6EsBZ+EgW59l2JMlTQyU/rHwxzUevXrQgucxsT0RPWcR2CnaPqB5cAfB mOhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc18-20020a1709078a1200b007acbac0871csi1892014ejc.420.2023.01.06.08.59.56; Fri, 06 Jan 2023 09:00:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234279AbjAFQ5S (ORCPT + 99 others); Fri, 6 Jan 2023 11:57:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233967AbjAFQ5Q (ORCPT ); Fri, 6 Jan 2023 11:57:16 -0500 X-Greylist: delayed 7777 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 06 Jan 2023 08:57:14 PST Received: from 7.mo575.mail-out.ovh.net (7.mo575.mail-out.ovh.net [46.105.63.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E510B7A38F for ; Fri, 6 Jan 2023 08:57:14 -0800 (PST) Received: from director9.ghost.mail-out.ovh.net (unknown [10.108.20.16]) by mo575.mail-out.ovh.net (Postfix) with ESMTP id D0A07259FB for ; Fri, 6 Jan 2023 16:50:00 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-dkv5l (unknown [10.110.171.46]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 130501FEBF; Fri, 6 Jan 2023 16:50:00 +0000 (UTC) Received: from sk2.org ([37.59.142.107]) by ghost-submission-6684bf9d7b-dkv5l with ESMTPSA id 6P5cAjhRuGOnAQEAwhnnFg (envelope-from ); Fri, 06 Jan 2023 16:50:00 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-107S0011a1aef4d-84f6-4e9b-be06-f9755663a738, 9FE29456621203A27B372E1E0503D45BE0167874) smtp.auth=steve@sk2.org X-OVh-ClientIp: 82.65.25.201 From: Stephen Kitt To: Lee Jones , Daniel Thompson , Jingoo Han Cc: Sam Ravnborg , Stephen Kitt , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 3/4] backlight: ipaq_micro: Use backlight helper Date: Fri, 6 Jan 2023 17:48:54 +0100 Message-Id: <20230106164856.1453819-4-steve@sk2.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Ovh-Tracer-Id: 5852427716709222107 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkedtgdelhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefuthgvphhhvghnucfmihhtthcuoehsthgvvhgvsehskhdvrdhorhhgqeenucggtffrrghtthgvrhhnpeelgeetueejffejfeejvefhtddufeejgfetleegtddukeelieelvddvteduveejtdenucfkphepuddvjedrtddrtddruddpfeejrdehledrudegvddruddtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehsthgvvhgvsehskhdvrdhorhhgqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdpoffvtefjohhsthepmhhoheejhedpmhhouggvpehsmhhtphhouhht X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754293255842931328?= X-GMAIL-MSGID: =?utf-8?q?1754293255842931328?= Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes. Signed-off-by: Stephen Kitt Reviewed-by: Sam Ravnborg Reviewed-by: Daniel Thompson --- drivers/video/backlight/ipaq_micro_bl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/backlight/ipaq_micro_bl.c b/drivers/video/backlight/ipaq_micro_bl.c index 85b16cc82878..f595b8c8cbb2 100644 --- a/drivers/video/backlight/ipaq_micro_bl.c +++ b/drivers/video/backlight/ipaq_micro_bl.c @@ -16,17 +16,12 @@ static int micro_bl_update_status(struct backlight_device *bd) { struct ipaq_micro *micro = dev_get_drvdata(&bd->dev); - int intensity = bd->props.brightness; + int intensity = backlight_get_brightness(bd); struct ipaq_micro_msg msg = { .id = MSG_BACKLIGHT, .tx_len = 3, }; - if (bd->props.power != FB_BLANK_UNBLANK) - intensity = 0; - if (bd->props.state & (BL_CORE_FBBLANK | BL_CORE_SUSPENDED)) - intensity = 0; - /* * Message format: * Byte 0: backlight instance (usually 1) From patchwork Fri Jan 6 16:48:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Kitt X-Patchwork-Id: 40212 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp938453wrt; Fri, 6 Jan 2023 09:30:24 -0800 (PST) X-Google-Smtp-Source: AMrXdXvoQN6IcBuGo0AdSAxMSSDrDCtnIUOTnxXtNLOyMAkJFfmfTZyEr2oveXbCmMZRamMROgKa X-Received: by 2002:a05:6a20:c196:b0:b2:36a6:d7b4 with SMTP id bg22-20020a056a20c19600b000b236a6d7b4mr71275035pzb.27.1673026224629; Fri, 06 Jan 2023 09:30:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673026224; cv=none; d=google.com; s=arc-20160816; b=W+h0qG4u7v3nq+XAyGMqJlko/ule/Xuf/9/mNYM7OYn7btZUebmAeQqwbON5vdkwQK hAljYLKEyxvMaPkbOCXrMqaD2P5cUG/tpgX/rTPK8yFP7w7tgD8IaItnqunqgHlYoBWA FjhkCZYZ4lZSHYVVdgoJgAoALSL9a1GiOWnLePnZY9hnJLN21sP6FCeNnHg5QQWuYe55 eYJCAGU0y0ArktBxxKW42wH5nXcSbeS9iPNzvIz4+vIwZvaVDvkO9c+zkxBAo5Id5MTW 7xLdSL5FhDr4148y/wfv7tkf2DqD0REVTZoIwdAi4/Be7MT7Cejuuo7cSwxleJ9QrHKz BqLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=NYvEY5oPZriG4aXFzU5eiHpboLMN63j/WjdfYJARggo=; b=MvYg+NbmOMdY7ktYxY/rEW+4HneG6G6KcN60ayq/8pW63pCOVK0crQ2HD0JnRHHkY6 zghxHPHm1rCZ2UIHn2lyP+3ohh/8VdTNiEe2BdG+uwLCqDm196AbFspSlGdybp2R23+z 7jNTVrr0tNyxgUmsrJm6q9XrjY52WsNwB+SKulGGgJz4QUa7vojn1igMrybSgKA+Z96m MERBZjt4C7fKjwGyD2rVSrmIwBev7g2wuLtkG3SAcFdpPndnHYL9nrhbuS5DWRidpNQQ zNeOaFNpp4FX8wQMXI3j6FT+SVAbkVT5FaHrKOTJeUGsW3+d/fcwn9QQla4clBk+7JWK c/4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j20-20020a635514000000b0049694f10986si1868683pgb.697.2023.01.06.09.30.11; Fri, 06 Jan 2023 09:30:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231307AbjAFR1f (ORCPT + 99 others); Fri, 6 Jan 2023 12:27:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbjAFR1d (ORCPT ); Fri, 6 Jan 2023 12:27:33 -0500 X-Greylist: delayed 1201 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 06 Jan 2023 09:27:30 PST Received: from 6.mo582.mail-out.ovh.net (6.mo582.mail-out.ovh.net [87.98.177.69]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 613047D9D5 for ; Fri, 6 Jan 2023 09:27:30 -0800 (PST) Received: from director9.ghost.mail-out.ovh.net (unknown [10.109.143.24]) by mo582.mail-out.ovh.net (Postfix) with ESMTP id EF2F326240 for ; Fri, 6 Jan 2023 16:50:01 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-dkv5l (unknown [10.110.171.46]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 34F0B1FE9B; Fri, 6 Jan 2023 16:50:01 +0000 (UTC) Received: from sk2.org ([37.59.142.107]) by ghost-submission-6684bf9d7b-dkv5l with ESMTPSA id 4GNNCjlRuGOnAQEAwhnnFg (envelope-from ); Fri, 06 Jan 2023 16:50:01 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-107S00126819975-9ec8-4c29-9bdd-5acdba6470ab, 9FE29456621203A27B372E1E0503D45BE0167874) smtp.auth=steve@sk2.org X-OVh-ClientIp: 82.65.25.201 From: Stephen Kitt To: Lee Jones , Daniel Thompson , Jingoo Han Cc: Sam Ravnborg , Stephen Kitt , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 4/4] backlight: tosa: Use backlight helper Date: Fri, 6 Jan 2023 17:48:55 +0100 Message-Id: <20230106164856.1453819-5-steve@sk2.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Ovh-Tracer-Id: 5852709192662877915 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkedtgdelgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefuthgvphhhvghnucfmihhtthcuoehsthgvvhgvsehskhdvrdhorhhgqeenucggtffrrghtthgvrhhnpeelgeetueejffejfeejvefhtddufeejgfetleegtddukeelieelvddvteduveejtdenucfkphepuddvjedrtddrtddruddpfeejrdehledrudegvddruddtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehsthgvvhgvsehskhdvrdhorhhgqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdpoffvtefjohhsthepmhhoheekvddpmhhouggvpehsmhhtphhouhht X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754295146009728822?= X-GMAIL-MSGID: =?utf-8?q?1754295146009728822?= Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes. Signed-off-by: Stephen Kitt Reviewed-by: Sam Ravnborg Reviewed-by: Daniel Thompson --- drivers/video/backlight/tosa_bl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/backlight/tosa_bl.c b/drivers/video/backlight/tosa_bl.c index 77b71f6c19b5..e338b1f00f6a 100644 --- a/drivers/video/backlight/tosa_bl.c +++ b/drivers/video/backlight/tosa_bl.c @@ -50,13 +50,8 @@ static void tosa_bl_set_backlight(struct tosa_bl_data *data, int brightness) static int tosa_bl_update_status(struct backlight_device *dev) { - struct backlight_properties *props = &dev->props; struct tosa_bl_data *data = bl_get_data(dev); - int power = max(props->power, props->fb_blank); - int brightness = props->brightness; - - if (power) - brightness = 0; + int brightness = backlight_get_brightness(dev); tosa_bl_set_backlight(data, brightness);