From patchwork Thu Jan 5 22:05:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 39808 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp516007wrt; Thu, 5 Jan 2023 14:07:56 -0800 (PST) X-Google-Smtp-Source: AMrXdXtryJL8dGuMjSCmyIB3SlA5RyHzhKVujY7OLBRrN1+vEUMiTpp8zEEprWXZWUmXFT1aPs4S X-Received: by 2002:a17:90b:4acf:b0:225:cece:c629 with SMTP id mh15-20020a17090b4acf00b00225cecec629mr45766765pjb.46.1672956475846; Thu, 05 Jan 2023 14:07:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672956475; cv=none; d=google.com; s=arc-20160816; b=SS0MO3UzRd6aSWuuZFOF4gzDoe/fJagJOlthOg8VBtDMcgNfBTvQ+gRK7hvRky20Fq gumnK9AU5NhZbrgROO/fGQM6KL8lCMBguoJtWOu11KM7HoYT5UWsNku/7tDDjJVXhkPa XW31oPjamVHfXZrUHSna6B/ZwskTvW5yeTKxt1bAsnKdUVuVU/9aGgZ14jSvDUBqsrfd 4tRVIoDkwZ6DvAcRVucl8xIVrtCWriRBmYEhjvhvsapQNGMyiOQn/kF0l44I4mCrs17+ 0pHWk3DJCxcMucAxkIQAC4bV1wrSssEwutlXN6c4ALRpaRQGUsPKxS9ppelj9RlNtPaE HENQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=i0/OIItYBQ/LlamHWRG1HEEnT7hNf+TYeSra86z2Brk=; b=wx2+Sfb16heW+2Z/bjFHGNYwp2wpZCaEtfnNRt3MLOTUB6mb4R+iB9aOwxY9MAAmLf ROQWBZXJNV8YWFtfc7YWBUd40FY1zvklYPa/UTssiS2x4gCH6vsD1S5FtyWiN3R0QQtq US8NeUxrIEEKMIsf2kc+8JTelOaEy6MZFho1Bf3W6oH92kWahAoY+ZS51bBh2AS5MwHC unIdd+9SMCDjfvpVyCSDK8TKcdxKojha8AhLJGR3JSBf/2c6ZFJi6hLwTOX1icc3UGNM +RPnLOQx5fabKiRbZtc1+vDkR3nGnkwCogChuyjljSWedsu90Ionus3MBeEuiwGca9zL 86pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=n17TPVVS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oc9-20020a17090b1c0900b00213dce992c1si3425271pjb.7.2023.01.05.14.07.43; Thu, 05 Jan 2023 14:07:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=n17TPVVS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234829AbjAEWGC (ORCPT + 99 others); Thu, 5 Jan 2023 17:06:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230051AbjAEWF7 (ORCPT ); Thu, 5 Jan 2023 17:05:59 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 904B667BDE for ; Thu, 5 Jan 2023 14:05:58 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id n4so40792526plp.1 for ; Thu, 05 Jan 2023 14:05:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=i0/OIItYBQ/LlamHWRG1HEEnT7hNf+TYeSra86z2Brk=; b=n17TPVVS1e2+dMewRwQT9JLjefS/KUc5ZVmrEI1WOq5QkmJ50L1qSqxkhaSsV6MTQ2 4hevybSckxzqEsyHlbyTi1GSnO0O1zU6GYEE32TLUxf6O0/C90pHetdon1VdWIG2iAmS D2fCgtrf4REMUzfaViVtvgb801e8zm2NOH1p4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i0/OIItYBQ/LlamHWRG1HEEnT7hNf+TYeSra86z2Brk=; b=ErItm1BGtDbEqF683Eh2oWRN5T/vP7vS+GWUxL0e6gyEsjKiC/VicQI0mChfy64pXZ 046QgjUgVg4djMYijbAd542aIDYNHmGpgiLWdeySlZkY17GQenFtuercsgGXOz5NriXQ 3LcS5gNx1Ga1mkL+MbNX/3HLqgjtUZnn8qxGcsSgRlNcYq+rMrsb4ViMTGoJeou6c+MO hPc+GHXF0vZQGkSdw2Xsw4WjbjvhhrnmxyVNFI/5KnWQrqow5+H4xckv+lqOBlIytE15 DcdM0ZVy2ETJVz+20Ov88sE0BnT6dox6kRnm5bog/fAW+ca2wuhEZuxoQmbRTZWzoT0W gdtw== X-Gm-Message-State: AFqh2krDaDSuI84pTQg0qmkeInHN/XbUY//uMeY4lMlc87ubH1fyvZnh oSqTixErgrB3yjDhGf7h2jf3Mg== X-Received: by 2002:a17:90b:1982:b0:225:dd16:ac4c with SMTP id mv2-20020a17090b198200b00225dd16ac4cmr41992901pjb.16.1672956358083; Thu, 05 Jan 2023 14:05:58 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id nk11-20020a17090b194b00b002260e8357ebsm1783940pjb.30.2023.01.05.14.05.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 14:05:57 -0800 (PST) From: Kees Cook To: Greg Kroah-Hartman Cc: Kees Cook , Jiri Slaby , Daniel Vetter , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Helge Deller , "Gustavo A. R. Silva" , Sebastian Andrzej Siewior , Yangxi Xiang , Xuezhi Zhang , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH] vt: Replace 0-length array with flexible array Date: Thu, 5 Jan 2023 14:05:54 -0800 Message-Id: <20230105220549.never.529-kees@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1610; h=from:subject:message-id; bh=Im+HeJ/SO6Toyppy5KpgHX9hERrzzsgMNzvw49e/BTo=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBjt0nCsbc0ES+bQDV6h54nWAMiR7Gq/Yffsw1Fi4TK jGnACIKJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCY7dJwgAKCRCJcvTf3G3AJqP8D/ 9UJlCMIrUP9OoXPNQpu4gIfQFD5U8Q7jpgxyTFazZOIaTy26tsA+lzq7Km9fPuyhTMf6OyL4ckcbXy US7oVq9Yb6Eni7ObGQ6abcFggGecWExjUreo343sDnhuJgHzO0woOAAaJXl9KAmL7vN8/IIVH7TSXx ouywWAndl2uVohwkBVMIR9bZfK9LKkFDT5VS1s3kVPWeS6j6aC3y8mwrboUUNDRGm0Bn19IA02cw8E te9ySMkQ9AclS4jQAexHHsqufU6KD2lf4Cyhhks2OkOuggiuMxfT4TJXa3yLbZMhjJ7B1iaWiKQ8LS Lr0uyF/6x8WcWXt1wP4PZrHWCWbUCPa5LwD6UQTlKRJUMd+WQtSUuVBjNlNjPT+1g4Ia4QK/LRkSJI 0M6waWvvV6jtH6n2WWM31zRydnhgYhiEuHTVoke+Y7T4luJcFyI17qzx2Fc3oEQEltZ+cmIllispVE +r/d7+pUEWImYZNZKGPODiUUMVjTh8euwxrpROsm8bDmoHvuEZwNB3Ql2doo5D7WRYw7YgjUx7Ko+T 0qT3zcpOfmBgIxB8aKhOFWrEMpkRH/6mThA1/NKm+hOLY/HcP/8awJ7RBr/SVl88HnyaNKyby3iSgB DLZyHIvquZHbm4EVMFa5J/JzA/KkVoe9oin/UrhKR5CZaB3GQVA7gHZ8M+FQ== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754222009663516814?= X-GMAIL-MSGID: =?utf-8?q?1754222009663516814?= Zero-length arrays are deprecated[1]. Replace struct uni_screen's "lines" 0-length array with a flexible array. Detected with GCC 13, using -fstrict-flex-arrays=3: ../drivers/tty/vt/vt.c: In function 'vc_uniscr_copy_area': ../drivers/tty/vt/vt.c:488:48: warning: array subscript dst_row is outside array bounds of 'char32_t *[0]' {aka 'unsigned int *[]'} [-Warray-bounds=] 488 | char32_t *dst_line = dst->lines[dst_row]; | ~~~~~~~~~~^~~~~~~~~ ../drivers/tty/vt/vt.c:335:19: note: while referencing 'lines' 335 | char32_t *lines[0]; | ^~~~~ [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Daniel Vetter Cc: "Ilpo Järvinen" Cc: Helge Deller Cc: "Gustavo A. R. Silva" Signed-off-by: Kees Cook --- drivers/tty/vt/vt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index 981d2bfcf9a5..b1445f00f616 100644 --- a/drivers/tty/vt/vt.c +++ b/drivers/tty/vt/vt.c @@ -332,7 +332,7 @@ typedef uint32_t char32_t; * scrolling only implies some pointer shuffling. */ struct uni_screen { - char32_t *lines[0]; + DECLARE_FLEX_ARRAY(char32_t *, lines); }; static struct uni_screen *vc_uniscr_alloc(unsigned int cols, unsigned int rows)