From patchwork Thu Jan 5 21:19:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 39798 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp501149wrt; Thu, 5 Jan 2023 13:21:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXsd4plQmaq96O6Xc24KTbsiqOGQPHC16fNlH5RDGWh4DtkugCX4i9VnEkyTf27/55qLKTfA X-Received: by 2002:a17:906:c2c9:b0:7b2:c227:126d with SMTP id ch9-20020a170906c2c900b007b2c227126dmr45707813ejb.20.1672953714697; Thu, 05 Jan 2023 13:21:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672953714; cv=none; d=google.com; s=arc-20160816; b=lUQHYBn8V8AvopvRTcrFKV0XQFLs6szekGFUm1TcwlQ+vrl2PbIa3FRHS2gfsrGfZ3 XSlFv6d2k8VWI+u1JksoUs10GZ6EgvrkTq/GwGK8hsusFq1qI2swD9w355NyUadYjSFz mf9N1nxGZanaeNTCmhaSgnDN1MFJp/fox4ATxphphgO1Ul+Za5kzaVOhFjlLUvxKfzMn o2Ky9WnYQvQ3VlT4h0HJz65PC2GfGlwldXlfCRdIcA4y5PpOV4v93cBP1Q+1d06liK+n xF5YLIOUnvYZQPLoQx2FofRhjXvl0KSRcsoRkG+mH/xUMoMlZIEojrV780h2HvR23cQE vO3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=dr6WuGFgn3lsUzUTklOx1mec9m003HYE8pI42id0om0=; b=a/Nf7kahVHDoUeGK4BXtFY4ZKm3SEsv3255JY4yjU7spWUcxCgK6KnuGVIGTwMYgkg advsjg9BrQGiaQfVS8zezlygRx6Owbxmy8CYH6a7ZSd+RvnyLGlMU6Fk9KmiHCGLXiw4 f5Mkdc8dH0d0CBDWc2zBd6n54G1qfI0aEFR0mslty6Xazcw+tVDlvb6gt9dJaIXxZfn3 FjYqhshQx+shsbpe5cjdlhMpGbn0qs3IcoyyCOvAjerlRc6Wt1sqt83TK4RrWdarIYzI ZBXT1n+Az33xy+TCpttecWfXqHVX1GG9N0I80bvDjOq+ToQw78lxRx1RTwSjYnZ0AOBt qGcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Ow9K/wEZ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o19-20020a170906975300b007c18334dfc6si33872950ejy.292.2023.01.05.13.21.30; Thu, 05 Jan 2023 13:21:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Ow9K/wEZ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235656AbjAEVU2 (ORCPT + 99 others); Thu, 5 Jan 2023 16:20:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235701AbjAEVUM (ORCPT ); Thu, 5 Jan 2023 16:20:12 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9964F60861 for ; Thu, 5 Jan 2023 13:19:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672953559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=dr6WuGFgn3lsUzUTklOx1mec9m003HYE8pI42id0om0=; b=Ow9K/wEZs5J9178IkCkXursCmIH2Qq7Ci/g9l9JWnnAQjcEx78HL/JlqDAa52lRBwQ3uSn bmwDECFlvxNahNYy5Ec0yvksFTs4MwNOt3jXsdG3dlEt5ZULqQo9R5XkcC4l5UnOob4xBq dWysKxQjBmBQd6/f0oZhlR4m+I6pu4g= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-477-n4cBn491OM69vaiduoZq6g-1; Thu, 05 Jan 2023 16:19:18 -0500 X-MC-Unique: n4cBn491OM69vaiduoZq6g-1 Received: by mail-qv1-f72.google.com with SMTP id cx11-20020a056214188b00b00531cacde854so5804058qvb.6 for ; Thu, 05 Jan 2023 13:19:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dr6WuGFgn3lsUzUTklOx1mec9m003HYE8pI42id0om0=; b=4xUH3nQnkX/P452B9AoeRDW1nmbRq6nh09mBxCWHYuGghLYR/0LkbPomNUOup8CGsT 1CwMcPCmzBsne2tRglg8hUib3HjalELKwgG+l2RuSI7b6M/RWaxu0CJashvfPeM7r/7I ltn4U+CLcPwBUiSOr7p+WC3XOpU0Di8ehLa5XBDzT/MqwzoGk/osGENzohD/wjGN0FLr pP8kw/Re1dQQn2MheC3jKlknikC6UBYj4DBkol0aZApXopl16jx/uoCKP3ew+s/cBhSc VkgDLrYGfj8gkeRdeKuYzSDkZ0eI5I3feRHDFzVMcB7KfTm9gdbLLk0n1ywvGc7c3Hun Rsmg== X-Gm-Message-State: AFqh2kocImkG7IasVtM/fK18z0+JU5nLudhlVyQt4huvdAgnJXMCHEiG +yyov2b17pQ+bfYfqeWzIbHRaC0y0YtuUZuE9CtATUrH6YfKZgYVw0p4pc+i43kWe0NgAq5+4KY uiKBdTEk7zSK56s/fW+Vl5t24 X-Received: by 2002:ad4:5362:0:b0:520:f8fa:5ad8 with SMTP id e2-20020ad45362000000b00520f8fa5ad8mr64600719qvv.17.1672953558072; Thu, 05 Jan 2023 13:19:18 -0800 (PST) X-Received: by 2002:ad4:5362:0:b0:520:f8fa:5ad8 with SMTP id e2-20020ad45362000000b00520f8fa5ad8mr64600701qvv.17.1672953557847; Thu, 05 Jan 2023 13:19:17 -0800 (PST) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id y17-20020a05620a25d100b00705377347b9sm11643264qko.70.2023.01.05.13.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 13:19:17 -0800 (PST) From: Tom Rix To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, nathan@kernel.org, ndesaulniers@google.com, Vijendar.Mukunda@amd.com, Syed.SabaKareem@amd.com Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [PATCH] ASoC: amd: Return ENODEV if acp63 is not found. Date: Thu, 5 Jan 2023 16:19:12 -0500 Message-Id: <20230105211912.824250-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754219113827791795?= X-GMAIL-MSGID: =?utf-8?q?1754219113827791795?= The clang build fails with sound/soc/amd/ps/pci-ps.c:218:2: error: variable 'ret' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized] default: ^~~~~~~ When no device is found -ENODEV should be returned. A switch with a single case is overkill, change to if-else. Fixes: 1d325cdaf7a2 ("ASoC: amd: ps: refactor platform device creation logic") Signed-off-by: Tom Rix --- sound/soc/amd/ps/pci-ps.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c index 401cfd0036be..cba8800ab4ea 100644 --- a/sound/soc/amd/ps/pci-ps.c +++ b/sound/soc/amd/ps/pci-ps.c @@ -205,8 +205,7 @@ static int create_acp63_platform_devs(struct pci_dev *pci, struct acp63_dev_data memset(&pdevinfo, 0, sizeof(pdevinfo)); } - switch (adata->pdev_mask) { - case ACP63_PDM_DEV_MASK: + if (adata->pdev_mask == ACP63_PDM_DEV_MASK) { adata->pdm_dev_index = 0; acp63_fill_platform_dev_info(&pdevinfo[0], parent, NULL, "acp_ps_pdm_dma", 0, adata->res, 1, NULL, 0); @@ -214,8 +213,8 @@ static int create_acp63_platform_devs(struct pci_dev *pci, struct acp63_dev_data 0, NULL, 0, NULL, 0); acp63_fill_platform_dev_info(&pdevinfo[2], parent, NULL, "acp_ps_mach", 0, NULL, 0, NULL, 0); - break; - default: + } else { + ret = -ENODEV; dev_dbg(&pci->dev, "No PDM devices found\n"); goto de_init; }