From patchwork Thu Jan 5 21:05:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fangrui Song X-Patchwork-Id: 39795 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp495744wrt; Thu, 5 Jan 2023 13:05:55 -0800 (PST) X-Google-Smtp-Source: AMrXdXspDHfn45wdGstbdMuupjD5W6iGlVNx6mUlveHflgrqBPL5TVhpHf3eH/JT/1x73oJCd6K0 X-Received: by 2002:a17:907:c712:b0:7bd:6372:fdb4 with SMTP id ty18-20020a170907c71200b007bd6372fdb4mr62531163ejc.41.1672952755797; Thu, 05 Jan 2023 13:05:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672952755; cv=none; d=google.com; s=arc-20160816; b=d4YESYeCcnAwnKyv168uyDsYS0C+Z/peI0I8pSGJcgbedr+9/t5JAO66AKIg3fN+xP gjC9J91LVQE24267UgQ8am66OavKkEYtM2KYJmAuzxjbNO26t+Hrv/oAcQKP3LbGbDSg UFnWFd6bNmfnVkBjvyPWAK8Et/zQEctZ4Ga4lKAmyNVUc/fAaojxB7fC4iTi1ajn4brs uSBXQMv01+1vg+Ppyfgw8EZqgr8Z32S6FoQpWaGZl6rO8PPXThDAYu9yxaZ5RYs/d/zR mFxDX9IMK4YJXLq9/R2Yg1pWYnRrHW5QgEfvJpkHLGCDe/donwAwTGpF4cnYS9b9pjBu /3Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:cc:to:subject :message-id:mime-version:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=/7IwxJ1HaxM3rsqRVCWOK3btFPfm5CRCmX3FcSF9F18=; b=br/2TI+W5h1lFjI/TBxo64k+ekkseEvuMFeDz62iaRgVDljSWNj2b/dv9eGTXM2R5o 6cu0qOqFdp2z+a1Q423OWZq9c2j3QKK3UBDanbVgXVl9E1yiVRwu2kqRAYKMTbqPg5U6 DvcH9JYTL65XC/npL/cZYvKFFBYgmlfo4TMJ5W7ogymM9Nq2WG9R4NrvU3Cai6G0lAaX 8WjUdWEDUjVKUDD/ptf5QkmA+6+JnUlhKGe1IRAtTztXMoyjVdMA0W/uzq50+Gnbd7zY GhPnM1q+oQ+t7s/wWqg5d71BCQtnc0msAIbT6fhEbhKEGyZymNSrTXjp51LRybN/SRUl Z52g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=Ak2XPUAh; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id mp3-20020a1709071b0300b0082372aef3b7si33322800ejc.305.2023.01.05.13.05.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 13:05:55 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=Ak2XPUAh; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 919603858C74 for ; Thu, 5 Jan 2023 21:05:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 919603858C74 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1672952754; bh=/7IwxJ1HaxM3rsqRVCWOK3btFPfm5CRCmX3FcSF9F18=; h=Date:Subject:To:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=Ak2XPUAhX1woR64LTyvB1dQU4qR4liXnK5zesaV11bFvY7K5duQjToZdOoH36hS/O NUiAn9UeBhHm82Svsjjv92OSyrOGl6ZbZ+RNwuwnmNREHayg5LCa/5F5mTlbl0ukYx 35Xf+BOndKitPr88DwBSwt3++0BNzgB38f6rKaOs= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by sourceware.org (Postfix) with ESMTPS id A11F73858D39 for ; Thu, 5 Jan 2023 21:05:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A11F73858D39 Received: by mail-yb1-xb49.google.com with SMTP id e12-20020a25500c000000b007b48c520262so3563067ybb.14 for ; Thu, 05 Jan 2023 13:05:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/7IwxJ1HaxM3rsqRVCWOK3btFPfm5CRCmX3FcSF9F18=; b=qZ36OJEj+DDopsiOPDATO/caFcsyCYdG/GuCm1PbU+ygnzHpZjcYsCyol38WPzYhMR KENZQfHBYiw/oTyUjBBIVj2olzZAHRNCTjb3ziCvlo1i5FUvqgI8r7mc7JbmnwJ6+f1g Z1PqcO8WEdLbVxhhKBfvlB4Ns3Kf1PMfPv80fBxoS1Jn18wBk89gnKOY6G9ncXVTNSo+ 46+1OT2iz2ETWfZVtmOX+hIVNGffg7tI26dsUOF4Go19W3uIME195OWzbk1Z5jp/Y+4l 44vGtM0sGD78ypTgmlLjI85ljWA04DOG6Q5q7NfocbaTTgNe82u03q+kYT804fydtcRv tkHg== X-Gm-Message-State: AFqh2kqeZ09KDToX7TuOWgDVuqXO1Kr+zmtG9MrrG/lrfvUiZ5GcoaAd qmpEixYokl2JU29ZRv4NvQZQDoeOGx8Z/nYYaf2d0DmBJctw7wR4bY+zNU2B2TrlFdnDzcdkVwM gOI46V5CQd8Uwi9meve0cmVlkKSQUEyyy78kykbfizBZSmJIR2eM/CuDpX8ntvWLK5w== X-Received: from maskray.svl.corp.google.com ([2620:15c:2d3:205:c2de:536f:e9be:ca87]) (user=maskray job=sendgmr) by 2002:a25:69c5:0:b0:7ae:5e48:380e with SMTP id e188-20020a2569c5000000b007ae5e48380emr1060112ybc.596.1672952745988; Thu, 05 Jan 2023 13:05:45 -0800 (PST) Date: Thu, 5 Jan 2023 13:05:42 -0800 Mime-Version: 1.0 Message-ID: <20230105210542.3573076-1-maskray@google.com> Subject: [PATCH] ld: Allow R_X86_64_GOTPCREL for call *__tls_get_addr@GOTPCREL(%rip) To: binutils@sourceware.org Cc: Fangrui Song X-Spam-Status: No, score=-20.0 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Fangrui Song via Binutils From: Fangrui Song Reply-To: Fangrui Song Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754218109228991872?= X-GMAIL-MSGID: =?utf-8?q?1754218109228991872?= _Thread_local int a; int main() { return a; } % gcc -fno-plt -fpic a.c -fuse-ld=bfd -Wa,-mrelax-relocations=no /usr/bin/ld.bfd: /tmp/ccSSBgrg.o: TLS transition from R_X86_64_TLSGD to R_X86_64_GOTTPOFF against `a' at 0xd in section `.text' failed /usr/bin/ld.bfd: failed to set dynamic section sizes: bad value collect2: error: ld returned 1 exit status This commit fixes the issue. PR ld/24784 * bfd/elf64-x86-64.c (elf_x86_64_check_tls_transition): Allow R_X86_64_GOTPCREL. --- bfd/elf64-x86-64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bfd/elf64-x86-64.c b/bfd/elf64-x86-64.c index 914f82d0151..095fe2e0fe6 100644 --- a/bfd/elf64-x86-64.c +++ b/bfd/elf64-x86-64.c @@ -1241,7 +1241,7 @@ elf_x86_64_check_tls_transition (bfd *abfd, if (largepic) return r_type == R_X86_64_PLTOFF64; else if (indirect_call) - return r_type == R_X86_64_GOTPCRELX; + return (r_type == R_X86_64_GOTPCRELX || r_type == R_X86_64_GOTPCREL); else return (r_type == R_X86_64_PC32 || r_type == R_X86_64_PLT32); }