From patchwork Mon Jan 2 11:41:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 38097 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4122447wrt; Mon, 2 Jan 2023 03:43:58 -0800 (PST) X-Google-Smtp-Source: AMrXdXtF4b6O9sZbarPvC25aExU9au4VdTfQKYNyUU+zFRQInPOhZEVnNiModQdfCdMUeqJgz28s X-Received: by 2002:a62:506:0:b0:56c:7216:fbc6 with SMTP id 6-20020a620506000000b0056c7216fbc6mr41285373pff.30.1672659838295; Mon, 02 Jan 2023 03:43:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672659838; cv=none; d=google.com; s=arc-20160816; b=yF3y/4MNfWfV/eeDlIvqFIt81ad4ibysgVGfBlBFfKw74OnEE0PW9P2N9f2aLjMtiv RrNkXKGIMRy3amnPKBGUcBsGev92fz6dgZdw0VXLu5O9+5SExdjacHOjCv7GtOHpALhN nO9DCijg5GQ5JwiShKep6HP3Nk5qp/8w3olLJ6trJAlIMsli0/7nla8F5LEq3E+HI4T5 JptkU0fhV5R7F+A2vm6CqqPpTGjgYx1aS32gjzC46pcRUfdOsP9+EtdLSWw+o+CbkP6H zq3Gszjd4/9w/zHNG7VHvxYo3R6OW3GcM8/a/bu91cgh5FjD45/ltw6vP1OoBo7mSXXD UJEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ot07odIMBdi99ZptGGtgBesy1j3BRGxC/hcJ0N+TCxs=; b=GdvJjsIBHjIRd3DbqAeTgMovEHrnmltDXZ+DzXCzTnxoYGL1XxoDVDscA0O2Ximy31 R5EFYJ1SpRiDN/NYVNPQwIV4fIW97g+KSbQeAfPl7B6XaLtLeLmk5eKY5eVB7ROXrmxI v+Qrf/DfZB+yc/LLJXNoDW+60O9Xjs4fJeHVciQGMCiuXesU1MzyCLXyxGYTnqPl3xE4 StgLwPc8akZdn3ySy6TSjomcxma9Gncri1z3blYc2B8ec85Fq0mQCyTbGavANgAZPQRX MyeqE4nUkK5MJIhPX2juXUjmhNd3mqFZTzVwEii/NbPLuf2eWkuaaFLJXulxhrjcTunG P/3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ROrZRy6C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j67-20020a625546000000b00577c17000e1si26999171pfb.280.2023.01.02.03.43.45; Mon, 02 Jan 2023 03:43:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ROrZRy6C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232785AbjABLmJ (ORCPT + 99 others); Mon, 2 Jan 2023 06:42:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232686AbjABLmA (ORCPT ); Mon, 2 Jan 2023 06:42:00 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD59EE92 for ; Mon, 2 Jan 2023 03:41:58 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id j17so31759325lfr.3 for ; Mon, 02 Jan 2023 03:41:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ot07odIMBdi99ZptGGtgBesy1j3BRGxC/hcJ0N+TCxs=; b=ROrZRy6C2QbxPLI+6Vx8HBTPv6HMBgAkapWo4sNLlX5XPiqHt6cS/4G2lfiTCCQmUj pGJ0nRz91ehp4Po8Du+hLVqytJyUgi90OkhcfIv0jKwYu4ZfVVt8MxDUZmQH5FORMLSW 67wHSUpVcnXxIT0LsIhhTdu3JD/UxQ9HrbZc7Ep98ixE7tTtP3o7Xw3OSIqwMNjnf9jH ZlJ3UOr7X3M/fcDlNiUneZk2HyBMw6rLHFMI1zFTWVsIrRxzWj/XJ21W8o9WqBpcVnl9 HcUGI6MVNFYOGKxf9p4soTjaWJKwHlvEhG+4qPrFw+/9Cz+vQ16xPrV/AjN/u1Fezuvk SHvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ot07odIMBdi99ZptGGtgBesy1j3BRGxC/hcJ0N+TCxs=; b=2BHo2WcrNS94lE1RkdQISZYYuNfGWTkyFbQuIt2fppTgEWewQrhCRjZPEx2QA3WaTk jmcp8N4/dgMerrP5pyu8H1XDJgTLt8ec8Eycn584keqE71x4ltoxWp36BKs3golOS4q+ M88kqYBXZ+KGt3MFG+9psl2P6IQRlLsjeMfO0kMCj+N4UppGO7ynvGPlbvlJVQ8zSyyN JIoHWU60myzO9Vpj6OwAVKaZ2VCzu/UHiy3vmYwusbNU6MF7rUAz1YCCRxdcl6RUDkSX THYUBICLsNJvVLjQNh8Y92XaX7/S3DgitVQJaomt7raYs/rySmzLZlIY1kxoious+T91 nEhA== X-Gm-Message-State: AFqh2kq/Iph/WOG3aOFB/+SBxt4/9IRH6T7J9OnJpq7TMJtReKbggNZH zkqqmjYy4RGluS8G9IZPT5hLdQ== X-Received: by 2002:a19:f517:0:b0:4c3:35b3:9a0e with SMTP id j23-20020a19f517000000b004c335b39a0emr9440867lfb.56.1672659717229; Mon, 02 Jan 2023 03:41:57 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c20-20020ac24154000000b0048a8c907fe9sm4356397lfi.167.2023.01.02.03.41.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 03:41:56 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/8] ASoC: codecs: wsa883x: Simplify &pdev->dev in probe Date: Mon, 2 Jan 2023 12:41:45 +0100 Message-Id: <20230102114152.297305-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753910962591517698?= X-GMAIL-MSGID: =?utf-8?q?1753910962591517698?= The probe already stores pointer to &pdev->dev, so use it to make the code a bit easier to read. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wsa883x.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c index 966ba4909204..8d69ed340e83 100644 --- a/sound/soc/codecs/wsa883x.c +++ b/sound/soc/codecs/wsa883x.c @@ -1375,7 +1375,7 @@ static int wsa883x_probe(struct sdw_slave *pdev, struct device *dev = &pdev->dev; int ret; - wsa883x = devm_kzalloc(&pdev->dev, sizeof(*wsa883x), GFP_KERNEL); + wsa883x = devm_kzalloc(dev, sizeof(*wsa883x), GFP_KERNEL); if (!wsa883x) return -ENOMEM; @@ -1388,17 +1388,17 @@ static int wsa883x_probe(struct sdw_slave *pdev, if (ret) return dev_err_probe(dev, ret, "Failed to enable vdd regulator\n"); - wsa883x->sd_n = devm_gpiod_get_optional(&pdev->dev, "powerdown", + wsa883x->sd_n = devm_gpiod_get_optional(dev, "powerdown", GPIOD_FLAGS_BIT_NONEXCLUSIVE | GPIOD_OUT_HIGH); if (IS_ERR(wsa883x->sd_n)) { - ret = dev_err_probe(&pdev->dev, PTR_ERR(wsa883x->sd_n), + ret = dev_err_probe(dev, PTR_ERR(wsa883x->sd_n), "Shutdown Control GPIO not found\n"); goto err; } - dev_set_drvdata(&pdev->dev, wsa883x); + dev_set_drvdata(dev, wsa883x); wsa883x->slave = pdev; - wsa883x->dev = &pdev->dev; + wsa883x->dev = dev; wsa883x->sconfig.ch_count = 1; wsa883x->sconfig.bps = 1; wsa883x->sconfig.direction = SDW_DATA_DIR_RX; @@ -1413,7 +1413,7 @@ static int wsa883x_probe(struct sdw_slave *pdev, wsa883x->regmap = devm_regmap_init_sdw(pdev, &wsa883x_regmap_config); if (IS_ERR(wsa883x->regmap)) { gpiod_direction_output(wsa883x->sd_n, 1); - ret = dev_err_probe(&pdev->dev, PTR_ERR(wsa883x->regmap), + ret = dev_err_probe(dev, PTR_ERR(wsa883x->regmap), "regmap_init failed\n"); goto err; } @@ -1423,7 +1423,7 @@ static int wsa883x_probe(struct sdw_slave *pdev, pm_runtime_set_active(dev); pm_runtime_enable(dev); - ret = devm_snd_soc_register_component(&pdev->dev, + ret = devm_snd_soc_register_component(dev, &wsa883x_component_drv, wsa883x_dais, ARRAY_SIZE(wsa883x_dais)); From patchwork Mon Jan 2 11:41:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 38098 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4122488wrt; Mon, 2 Jan 2023 03:44:06 -0800 (PST) X-Google-Smtp-Source: AMrXdXtaFsPziMu61FXLrWuJ0nadVTylxyRhGt3fN1JYn42vhrng6UAbPkznQlE/+f/3bET3kMFQ X-Received: by 2002:a05:6a20:2da1:b0:af:ee05:f483 with SMTP id bf33-20020a056a202da100b000afee05f483mr40137119pzb.7.1672659846137; Mon, 02 Jan 2023 03:44:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672659846; cv=none; d=google.com; s=arc-20160816; b=RExEL1zozRR/1JkwYeebvL2GFGqLEO7YlIXZT/zbAtbr4l4vW47pKwlw79xzgl7Wrg kuPBf+MZhSOcUhijWgkZsd7GcROooSOQ4CNgLi8+cU0N0fW2rCH+ntEjGfweS8WpT7Q0 /ctnbHbeXNvRfu/BZ53G7vbpibUeLlwAQwiDWe7vDx2jYjjHX/tUEupp40ZOxXZwKVgL eH5opj0nUeeMXUaAxAH/WoZ/AjKT5oW3n5SEesJRKxPGSnAFFDtsBH49fTYYvEmsO1vJ 6YRa1AGnjwLXaYoR0TWg1tIMfZ5fShsrBgFaZfiRub+QeONpsP+UGtSLs+0k7blByVUv zYNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=l5BQ+1OykJNJsHs5tcaOG30ml/uGVrBU87LMcPdV8zM=; b=s+mESNMQmpYcc9jdSSf0A5P9UhX0SVL0v/seb+EvOd+7oLSEz73dn6MDpjvp812Xti v1j6ORLtQuMTBOXOEEgrtLeIfI8LyBSAOIKUNoqDENxe0uUkSZCuLOsnvFmArS4MI0uR 4iXVTLytgYhyaVDWAOUrHVG6U3bmJ7jmeEx3YPqBojdukE5uiBzZpYSmPGeamAtaIpUJ 687VOx2oPp4FmKAebca01dPN48lCzwH1EnW02w0MDTV1bRcTad+fFbGpzHpGzbjCCsoY KDmkByBf0p4L1U2avhOjJyubN/dF1nwsgplB1WZRA7MPcBYTJvf/wGIEKEswc5iDBzLY Ym0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="fRM/fxDl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o13-20020a634e4d000000b00478bc014a29si30047246pgl.43.2023.01.02.03.43.53; Mon, 02 Jan 2023 03:44:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="fRM/fxDl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232877AbjABLmO (ORCPT + 99 others); Mon, 2 Jan 2023 06:42:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232741AbjABLmB (ORCPT ); Mon, 2 Jan 2023 06:42:01 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11DA2EBB for ; Mon, 2 Jan 2023 03:42:00 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id p36so41230634lfa.12 for ; Mon, 02 Jan 2023 03:41:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=l5BQ+1OykJNJsHs5tcaOG30ml/uGVrBU87LMcPdV8zM=; b=fRM/fxDlUALu6ECRXeB8H4JGEENdHMfeVFBr4nnIjeAV1DMReAGdy+VQmFSBnoxrR4 +fM6gGKxZuiN0uc1VijxgzkEIL5/4JpW/istSlmPsEsVOrtRIP71t0tzyJpfv1Mzwt0D 6P0SryFFkmoz9JUo24GfQq8H/ULD/8LvMiFqiM6KQeIU1uqbtpSsM0fmRB4cI5mh42Vt mm6aOywOIBYU5dhjUDkfq1Hkkue6jP/8lsP04XOxCReEqu1S+8P4vXFZjk9iZ37AgMvw EoiWOjGMXnPhRiEp8nIThcy7mPCsvoj5UlJHSK1OAVs3b6bxqw/AmrsBmAo19cHgym40 Tg7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l5BQ+1OykJNJsHs5tcaOG30ml/uGVrBU87LMcPdV8zM=; b=nH07dT1wyENIU3tOFBbY+2KMaYLj+KLHdzXsBLfLRm7dHwDk4VdXWiHwVsTQw7014z Boc5vT5uaTOvrdEcze3TO0P1LiNujxaFBiKSTdTfyEnsqO6yridi03xHAeUxqez5h5j6 dnSCmZANQjVsfssjTGTTuoXPPoRH9/p7NB91HYdE29f1WFlLBOVntumr/gj2PprGGiA4 swuLwDxNpN6qN+jtMBSe8jSs3FsHozfL6ZAjoG2bAWA1epjZ8hX1zGetG8OjS212FSmL dL+v02agmNOoiQD8/4cWNeKvz3FV4TN8RsIy6DhNVopwHH6wW2X8W4sczIoBkz308rd4 qoGg== X-Gm-Message-State: AFqh2krhGoa7mK2ccBHWglle9iMYz1ZO1tT9NzL+2ZrRLFUdcsuJSL/N nAJ3DiAt9P2d9yxKulAVKjsmhw== X-Received: by 2002:a05:6512:b0c:b0:4b5:97cf:8f1a with SMTP id w12-20020a0565120b0c00b004b597cf8f1amr13379095lfu.40.1672659718470; Mon, 02 Jan 2023 03:41:58 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c20-20020ac24154000000b0048a8c907fe9sm4356397lfi.167.2023.01.02.03.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 03:41:58 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/8] ASoC: codecs: wsa881x: Simplify &pdev->dev in probe Date: Mon, 2 Jan 2023 12:41:46 +0100 Message-Id: <20230102114152.297305-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230102114152.297305-1-krzysztof.kozlowski@linaro.org> References: <20230102114152.297305-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753910970643604991?= X-GMAIL-MSGID: =?utf-8?q?1753910970643604991?= The probe already stores pointer to &pdev->dev, so use it to make the code a bit easier to read. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wsa881x.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c index 6c8b1db649b8..cd7be55f6a89 100644 --- a/sound/soc/codecs/wsa881x.c +++ b/sound/soc/codecs/wsa881x.c @@ -1113,20 +1113,20 @@ static int wsa881x_probe(struct sdw_slave *pdev, struct wsa881x_priv *wsa881x; struct device *dev = &pdev->dev; - wsa881x = devm_kzalloc(&pdev->dev, sizeof(*wsa881x), GFP_KERNEL); + wsa881x = devm_kzalloc(dev, sizeof(*wsa881x), GFP_KERNEL); if (!wsa881x) return -ENOMEM; - wsa881x->sd_n = devm_gpiod_get_optional(&pdev->dev, "powerdown", + wsa881x->sd_n = devm_gpiod_get_optional(dev, "powerdown", GPIOD_FLAGS_BIT_NONEXCLUSIVE); if (IS_ERR(wsa881x->sd_n)) { dev_err(&pdev->dev, "Shutdown Control GPIO not found\n"); return PTR_ERR(wsa881x->sd_n); } - dev_set_drvdata(&pdev->dev, wsa881x); + dev_set_drvdata(dev, wsa881x); wsa881x->slave = pdev; - wsa881x->dev = &pdev->dev; + wsa881x->dev = dev; wsa881x->sconfig.ch_count = 1; wsa881x->sconfig.bps = 1; wsa881x->sconfig.frame_rate = 48000; @@ -1149,7 +1149,7 @@ static int wsa881x_probe(struct sdw_slave *pdev, pm_runtime_set_active(dev); pm_runtime_enable(dev); - return devm_snd_soc_register_component(&pdev->dev, + return devm_snd_soc_register_component(dev, &wsa881x_component_drv, wsa881x_dais, ARRAY_SIZE(wsa881x_dais)); From patchwork Mon Jan 2 11:41:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 38099 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4122542wrt; Mon, 2 Jan 2023 03:44:19 -0800 (PST) X-Google-Smtp-Source: AMrXdXtWDKUneyixjOCfAaRa9+6OBNMRibCqbxFz9bkY2GxAKKvofsWd4LwuydHH7mIELBEVgcq4 X-Received: by 2002:a05:6a20:43a5:b0:af:6d40:9883 with SMTP id i37-20020a056a2043a500b000af6d409883mr53248921pzl.18.1672659859569; Mon, 02 Jan 2023 03:44:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672659859; cv=none; d=google.com; s=arc-20160816; b=ccgBqdIoE1PbqNSFmTkZY8veu5ZPD/GywXrwHA6H3vxzsQi+tL9hhoxYAfoTtcCxky zvYo6zdPv6QO4sJ9Hvmtoo0j3unMMgSNn/wNOOUh3Pk3XXklQrWUbCt/7gYJ7wk0+NV0 sLEuN2f0lSAZF4I/o0K9iMSpCAj31/j0dp+qlUUfFTADnF/0IW55kTVJ8U0D7Itdf+zT WKZGfjS72+XUM8Vwq+WAJ+zZ6gjnbx9AA1ihlECMEcrh/VKl4VsrZcm+q1z0M6/Ld9E3 bR99zcCcT//tB1M1etOpB/xJ/lWmeuQFu3ISdqSdChekfv6sHO4+PEh7aI1uYl22bGOr TDxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=d3ISjc0HqFZLXSFtXhlmeBjb8PLOBicDWq3ocAujh1c=; b=tyVo/RopxKyUe64pGqb3rqgNWM7KnixC7DAkdXOnuuYuGF6eJ1+rK0/EgquF7PTcQX VxLSTSl9we7gmZ/2qeaewUuO0f47NppN1lfz/oBW5OlyZb+8LSqjkGueVSfOrWMMj+JW e9QQ1HUG/fE281/PCCmAHHwToQe+3IbXy585AHw3B8HtB8MPk+h/0QS4Yn2/OQvIQ6i4 /0uUxaWs2JGzIQykRIJ+y3VdMPnEe97R+5wqXDu+grVLZ4k9ZNk3AIagbfupq88LJkOE 5Op6CzwxV+tMer7V9zu6n1tCo5eexjCRPDWckyiBPmOye+TVslzwQN0n058iNoPHGKF4 58rA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GK4P+qO5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d31-20020a630e1f000000b00479018afb14si29641669pgl.49.2023.01.02.03.44.07; Mon, 02 Jan 2023 03:44:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GK4P+qO5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232889AbjABLmY (ORCPT + 99 others); Mon, 2 Jan 2023 06:42:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232792AbjABLmC (ORCPT ); Mon, 2 Jan 2023 06:42:02 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42443F14 for ; Mon, 2 Jan 2023 03:42:01 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id bp15so41232257lfb.13 for ; Mon, 02 Jan 2023 03:42:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d3ISjc0HqFZLXSFtXhlmeBjb8PLOBicDWq3ocAujh1c=; b=GK4P+qO5a7tUHbIu3KBEzJQf+LXCryVD3sQnn0/7NhmYDIr3J7AYo+OB/fW8fZRrBg aA7rscY8x7m82EAsVDetQNaiAXOuNr+95LtYickbCC2H/l1964yv+w+s32rhWGfywqcJ 0vtSPyK9cxBxBJd972wcNTeNZZ11+frK8GIHZ4HgeDMWkyQwLJieUypa9+gXiOLZC2wZ Rj4Pdeh8UUaYaF5msURa97gdfPBDbM0VVBi1r1FEydq+7V7Rqrd78iPbDyF+uzDP1mfu dvqc7v539aBZBsQxIkEuFKfT+F0WYZdn4VHA7b94NHfrpAuebipeb+h+RwMjqOP6v4Yz VJeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d3ISjc0HqFZLXSFtXhlmeBjb8PLOBicDWq3ocAujh1c=; b=kxQi+P3XKNUUltRPyEjKQiKaZ6thl0PEPEy6wBcuuvq8e0xvYC3ifsOuvvYwJx5bGp HuOtIcTVzbkboXv7spCSWQA33yw9He5c16TMnSXSYPhQP1GrlVn3Ule9HZMLzKWMT/4E xKWTFja4wqnl+7RLoYGKwO/xq1UmKrKvguTtxcxK1JUXwVewvhxeKv/nYr9D4c/UWuv8 7Dt8fv8t02duYCzJgDQI+KUFVFFeqblvET88iw1s0m3xwtlshApHV4gIfn9pF/bBUU/6 HEAqkGkRj0oeOfkgwZiJEIb62oRnjpHWDj3DSPJ5LQ4l2FZie8zX1/vCYeLpDQqMwGcx YtwQ== X-Gm-Message-State: AFqh2kosj3LqZKnfY5OGQbVeD1Nbbn464tJzWdJhOXIj+L/dUUuvz3qV Bay9iI15rcw5v67CND6gxms52Q== X-Received: by 2002:a05:6512:4005:b0:4b5:9183:5ad0 with SMTP id br5-20020a056512400500b004b591835ad0mr14368017lfb.63.1672659719657; Mon, 02 Jan 2023 03:41:59 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c20-20020ac24154000000b0048a8c907fe9sm4356397lfi.167.2023.01.02.03.41.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 03:41:59 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Cc: Krzysztof Kozlowski Subject: [PATCH 3/8] ASoC: codecs: wsa881x: Simplify with dev_err_probe Date: Mon, 2 Jan 2023 12:41:47 +0100 Message-Id: <20230102114152.297305-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230102114152.297305-1-krzysztof.kozlowski@linaro.org> References: <20230102114152.297305-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753910984802647367?= X-GMAIL-MSGID: =?utf-8?q?1753910984802647367?= Code can be a bit simpler with dev_err_probe(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wsa881x.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c index cd7be55f6a89..6df9c48f42bf 100644 --- a/sound/soc/codecs/wsa881x.c +++ b/sound/soc/codecs/wsa881x.c @@ -1119,10 +1119,9 @@ static int wsa881x_probe(struct sdw_slave *pdev, wsa881x->sd_n = devm_gpiod_get_optional(dev, "powerdown", GPIOD_FLAGS_BIT_NONEXCLUSIVE); - if (IS_ERR(wsa881x->sd_n)) { - dev_err(&pdev->dev, "Shutdown Control GPIO not found\n"); - return PTR_ERR(wsa881x->sd_n); - } + if (IS_ERR(wsa881x->sd_n)) + return dev_err_probe(dev, PTR_ERR(wsa881x->sd_n), + "Shutdown Control GPIO not found\n"); dev_set_drvdata(dev, wsa881x); wsa881x->slave = pdev; @@ -1138,10 +1137,8 @@ static int wsa881x_probe(struct sdw_slave *pdev, gpiod_direction_output(wsa881x->sd_n, 1); wsa881x->regmap = devm_regmap_init_sdw(pdev, &wsa881x_regmap_config); - if (IS_ERR(wsa881x->regmap)) { - dev_err(&pdev->dev, "regmap_init failed\n"); - return PTR_ERR(wsa881x->regmap); - } + if (IS_ERR(wsa881x->regmap)) + return dev_err_probe(dev, PTR_ERR(wsa881x->regmap), "regmap_init failed\n"); pm_runtime_set_autosuspend_delay(dev, 3000); pm_runtime_use_autosuspend(dev); From patchwork Mon Jan 2 11:41:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 38104 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4122794wrt; Mon, 2 Jan 2023 03:45:09 -0800 (PST) X-Google-Smtp-Source: AMrXdXvVC6Vt/4BHwQOG7Y8jaYUTAxfQSWZQQMiKqEHMkrrTyfEhry0SklTGRS2yQn95cxi/O14t X-Received: by 2002:a17:907:d306:b0:84c:95c7:3036 with SMTP id vg6-20020a170907d30600b0084c95c73036mr11787174ejc.5.1672659909399; Mon, 02 Jan 2023 03:45:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672659909; cv=none; d=google.com; s=arc-20160816; b=AG7r5hF9wB0Y5qWbV+3jeYReeZqfypLkMTx4zOEGPqAsa3nNhM0DJ14btBK1kul4Xn 5bHRtIhfx+wauWVMpnMmBcOxWQVo3S32A9vI6WW7Bx8ouXo6/YPwfzrkkO4KNI7VU1Y3 U69oeAZ0Lq/UyMjXgJmy5wriTlo6YN910++2D8GCs6cEA57oqpUq806DUMBqpdReiF2F z4X+dyv9uKQcmYZ3f5mrbW0IUDnrIKu1ZUONRNi2+vD5Z9Jl8+w0ILdJZLPgtpige2bF rjZhyIP7ypjuqJQVaL3XDQ/6Ri39qM/0xdi49MDtf0cH0aY99o1gUtwh0uSv0ZFYJraf KNzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yMNnSXj/QiOhqHsI5QRJCgQgDJelef4FSyVTSnv9aFE=; b=EVFHPdTsK/FKQZ5g6hSSGYfqmdBcNkzn++SaGf5lBKe+HfzoVD6oT8hckvnZ6dgAhD V2La5WU33M++tm+TftTDtBhlfnHmYAkVbDr8M6jQUgTh1mOOsSy91ODJByjXiX45yGRD XxLYiHWBy8W6R18jNVKG0dztLiFSb41zhUae6YO41yvxzOLO4dO179vyHJwNT1vTpxus S8gGqIDtkhDTvZiGWtk09lpycijIUdmbgqHHwKfmoq/V/s0besqci5lE0PMs/b+SJLjE IdnwVTVfVRVA3uZ7HCe70rAvnRHL7BUyQgUbRmrZysaxS5blRbXsxJs/WRT+GrE1qcPt +irA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HasjY8J8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i13-20020a1709064fcd00b00812e75e5254si26922367ejw.326.2023.01.02.03.44.46; Mon, 02 Jan 2023 03:45:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HasjY8J8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230196AbjABLmS (ORCPT + 99 others); Mon, 2 Jan 2023 06:42:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232808AbjABLmC (ORCPT ); Mon, 2 Jan 2023 06:42:02 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47087F18 for ; Mon, 2 Jan 2023 03:42:01 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id bt23so24592678lfb.5 for ; Mon, 02 Jan 2023 03:42:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yMNnSXj/QiOhqHsI5QRJCgQgDJelef4FSyVTSnv9aFE=; b=HasjY8J87SavHdaA7R8pq2SIcm1kxvmhAxkPBIP9ffbBrJqjq1tpRAeRfF5WdMCKGA 4FMQ7jY0j26hnr9NMhpYHH4gfWmLsey/y5sp19xoS5ru3/P7GQu2NTv7VIQbos+76TZC 1rZ2Kv1caFFXXhuAKCM/DAJ+mjONC+Qa9nZqHoNXoyjJQzy160WBDmmwJPvoJ4W9wzIE QmopCkZwnK5nS8EELiWsGe7wYOZD59GYSdKH0d+LbAWkdWb33uJPwY8jAxtxvQmXsR2n LxnY489R2f+mUii7e55hjHxsdb85JE4MLHWjLZwIpC/GPjoPZ9hMgpEIyoRsFi5o6HUq 9nAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yMNnSXj/QiOhqHsI5QRJCgQgDJelef4FSyVTSnv9aFE=; b=RMfE8zAER8cKh2+gSOkuGPKc3V26VA1IjcYfRNGisCFt7cCgUpmKuTssgZZ1E4ymyZ DQYXsx2Zl+GtKBLy/9+Lrzy/QN4bYX9r591l+WEALKIGes9cYUTDIYcor+Ta9wN5jnYE zT7XDxxgBF8HCGZWGeNq55LERKRleS1ajKEolsvUkxoNkb/jyYAD5aXIbUzx2P3TlaDd j7OrJBuBypdkEYGZ6RiAbtco7mZtlrgwH3dBhtqkmDNRVkZD9meA/HyneFChnI8Lpcvr KlESt7NO0mJysC9QDWJLYKic7nKTgvTNybev/OauIELY2Ln44PC2dFJdwF29uyTqzXaS 1ABA== X-Gm-Message-State: AFqh2kobYJdcaeNRr1EpsaUB4qAGDgDGO6/MFSOq+V+zsYp7UjynPVaL RKSwzLuA7EhGvpVcV+LFJG6ILA== X-Received: by 2002:ac2:43cf:0:b0:4b5:aa85:3874 with SMTP id u15-20020ac243cf000000b004b5aa853874mr12567219lfl.68.1672659720767; Mon, 02 Jan 2023 03:42:00 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c20-20020ac24154000000b0048a8c907fe9sm4356397lfi.167.2023.01.02.03.41.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 03:42:00 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Cc: Krzysztof Kozlowski Subject: [PATCH 4/8] ASoC: codecs: wsa881x: Use proper shutdown GPIO polarity Date: Mon, 2 Jan 2023 12:41:48 +0100 Message-Id: <20230102114152.297305-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230102114152.297305-1-krzysztof.kozlowski@linaro.org> References: <20230102114152.297305-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753911036970135214?= X-GMAIL-MSGID: =?utf-8?q?1753911036970135214?= The shutdown GPIO is active low (SD_N), but this depends on actual board layout. Linux drivers should only care about logical state, where high (1) means shutdown and low (0) means do not shutdown. Invert the GPIO to match logical value while preserving backwards DTB compatibility. It is not possible to detect whether ACTIVE_HIGH flag in DTB is because it is an old DTB (using incorrect flag) or it is a new DTB with a correct hardware pin polarity description. Therefore the solution prioritizes backwards compatibility while relying on relevant DTS being upstreamed. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wsa881x.c | 33 +++++++++++++++++++++++++++++---- 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c index 6df9c48f42bf..7a5d31483cfc 100644 --- a/sound/soc/codecs/wsa881x.c +++ b/sound/soc/codecs/wsa881x.c @@ -679,6 +679,11 @@ struct wsa881x_priv { struct sdw_stream_runtime *sruntime; struct sdw_port_config port_config[WSA881X_MAX_SWR_PORTS]; struct gpio_desc *sd_n; + /* + * Logical state for SD_N GPIO: high for shutdown, low for enable. + * For backwards compatibility. + */ + unsigned int sd_n_val; int version; int active_ports; bool port_prepared[WSA881X_MAX_SWR_PORTS]; @@ -1123,6 +1128,26 @@ static int wsa881x_probe(struct sdw_slave *pdev, return dev_err_probe(dev, PTR_ERR(wsa881x->sd_n), "Shutdown Control GPIO not found\n"); + /* + * Backwards compatibility work-around. + * + * The SD_N GPIO is active low, however upstream DTS used always active + * high. Changing the flag in driver and DTS will break backwards + * compatibility, so add a simple value inversion to work with both old + * and new DTS. + * + * This won't work properly with DTS using the flags properly in cases: + * 1. Old DTS with proper ACTIVE_LOW, however such case was broken + * before as the driver required the active high. + * 2. New DTS with proper ACTIVE_HIGH (intended), which is rare case + * (not existing upstream) but possible. This is the price of + * backwards compatibility, therefore this hack should be removed at + * some point. + */ + wsa881x->sd_n_val = gpiod_is_active_low(wsa881x->sd_n); + if (!wsa881x->sd_n_val) + dev_warn(dev, "Using ACTIVE_HIGH for shutdown GPIO. Your DTB might be outdated or you use unsupported configuration for the GPIO."); + dev_set_drvdata(dev, wsa881x); wsa881x->slave = pdev; wsa881x->dev = dev; @@ -1134,7 +1159,7 @@ static int wsa881x_probe(struct sdw_slave *pdev, pdev->prop.sink_ports = GENMASK(WSA881X_MAX_SWR_PORTS, 0); pdev->prop.sink_dpn_prop = wsa_sink_dpn_prop; pdev->prop.scp_int1_mask = SDW_SCP_INT1_BUS_CLASH | SDW_SCP_INT1_PARITY; - gpiod_direction_output(wsa881x->sd_n, 1); + gpiod_direction_output(wsa881x->sd_n, !wsa881x->sd_n_val); wsa881x->regmap = devm_regmap_init_sdw(pdev, &wsa881x_regmap_config); if (IS_ERR(wsa881x->regmap)) @@ -1157,7 +1182,7 @@ static int __maybe_unused wsa881x_runtime_suspend(struct device *dev) struct regmap *regmap = dev_get_regmap(dev, NULL); struct wsa881x_priv *wsa881x = dev_get_drvdata(dev); - gpiod_direction_output(wsa881x->sd_n, 0); + gpiod_direction_output(wsa881x->sd_n, wsa881x->sd_n_val); regcache_cache_only(regmap, true); regcache_mark_dirty(regmap); @@ -1172,13 +1197,13 @@ static int __maybe_unused wsa881x_runtime_resume(struct device *dev) struct wsa881x_priv *wsa881x = dev_get_drvdata(dev); unsigned long time; - gpiod_direction_output(wsa881x->sd_n, 1); + gpiod_direction_output(wsa881x->sd_n, !wsa881x->sd_n_val); time = wait_for_completion_timeout(&slave->initialization_complete, msecs_to_jiffies(WSA881X_PROBE_TIMEOUT)); if (!time) { dev_err(dev, "Initialization not complete, timed out\n"); - gpiod_direction_output(wsa881x->sd_n, 0); + gpiod_direction_output(wsa881x->sd_n, wsa881x->sd_n_val); return -ETIMEDOUT; } From patchwork Mon Jan 2 11:41:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 38101 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4122603wrt; Mon, 2 Jan 2023 03:44:35 -0800 (PST) X-Google-Smtp-Source: AMrXdXtkkKFSBSSLPpjuFagJpE0jxVbIrZ8MgLwGbOBAfS23EtM0Qhip/EO97cy8FbPqZF3ySIJw X-Received: by 2002:a17:906:c79a:b0:83d:9588:2ed4 with SMTP id cw26-20020a170906c79a00b0083d95882ed4mr31057540ejb.68.1672659874894; Mon, 02 Jan 2023 03:44:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672659874; cv=none; d=google.com; s=arc-20160816; b=QKUJYdX81+lZHJyxLUJjhVrNosWRrQvzI9q5OMiOztIwRsMA1anJ0mmgvlCpgNeLdV 0d2JJZ35lic/Mni+tG85HvrJQs5bwbah6e9qe0qYu0OnfXXGtRdCLdNNphcGQV1OLLVk c3BgZLcu8DBk+1Q7LcJbywFc1Ug3imb7CaiiT28yXXVqWcf8SRoa3b+2tF4+d3cdF4lg 6/4c1O7cVUkZfB1iPO1VEFFTS+b4FLy7J7vtoLxRWi03kW44spy/vzEvuecyocgDsPnZ Gelh8Mz6L8MISCxENZJsGL2v7jQO3dwHqH4pw99zx3CZy/+B8a6nH2ukslK+2dr7+eHq Z7/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DFU9bGFCZAQ4eLz1sLnNYm1aOcmTTJdAlfZrDIj/g7Q=; b=iHJMUNuwlch79H9vGqPh4fMs8ruiAtYzqExJqtKDKgP+gxDPr2nQvdsas7HqQjrp+v Kn3MpWMrdZyYEdG4AJhwyd0g/doeeRSndKSGffsz88Fwlm0z+mq82SgybEexW9GDYbm5 +DPDN6Ryiq/NBuAjRey+4l+/fggKuxNkbJ/VLiitInqH/XyZjQ/UzjMSExndUmr8XJRH 5wv5LHtbYoT+m6Xa6exTP5OviHp1Zei+i9B8X1E1Z7V5J3WZWKLl8M3tZtWEByIKf/YL uV73mo/1NeFpAfZWVO1SVq8yFyXoHDHp+8cFQgqVQumoZYPlyji6wCdPG1xQNr+xzBO/ YYVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=A3bjAiUW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr17-20020a170907721100b007e494438499si26005037ejc.166.2023.01.02.03.44.10; Mon, 02 Jan 2023 03:44:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=A3bjAiUW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232853AbjABLm2 (ORCPT + 99 others); Mon, 2 Jan 2023 06:42:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232855AbjABLmE (ORCPT ); Mon, 2 Jan 2023 06:42:04 -0500 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B904EF0D for ; Mon, 2 Jan 2023 03:42:03 -0800 (PST) Received: by mail-lj1-x236.google.com with SMTP id p2so13254460ljn.7 for ; Mon, 02 Jan 2023 03:42:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DFU9bGFCZAQ4eLz1sLnNYm1aOcmTTJdAlfZrDIj/g7Q=; b=A3bjAiUWya/xZ0diRWE5yhrbPaolWEfSBNiTHT+PTnFaDdZfa6Fw1MqqqS2WfEBbVU hwoLb9aP/0r5F8DV0wo9CcyqAIWXWMSY7CaXRnCaxPobzkC12Q/xj0pVb8/SPNwXR6Ge 9QqCeye/rbd5a2C9i7E++QaV2H9KtHRZhIe5FqJYxjK07+g7GPJns913GKdwbDF6m6kH zWLT8h4t3Ki0vMQcgRpVbu/naTjx5JTcvnTrT9Ijo1iZbjh0HSt7jLs6357IYGVdKOMG q8CKCWhdzzI+t7/sufVgFF0biouhOZAQ11D85X9Udd+2NXW+AoeAcNM1aJxcslNpTzhE TfhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DFU9bGFCZAQ4eLz1sLnNYm1aOcmTTJdAlfZrDIj/g7Q=; b=Ct9m1qFgfBcsDI5+f96UUPq6pcS+/U8cONyXHXcrTvL8XmtYbPtVArj5amfZSAZlyK dE2rLRtFHTKZhXpNloh+cQxDWlkEJc13lwUpgD6AbuEqo1kos5Y8UbCCrNT7dMmZyA6W 8iK4LLRkobcs+i/svCwqiHxnhK9Ol1X3lKJhvD4+EKFG4Bika2dyu3fxVU9o5MMA+zqf nV1oEQUZCdl+KLqNWeNkpgoKtms3AA1GrFqYczrfPGX2hFLG9YYMj7aJevriKX4uadAg xarceIQ7XXynFTboKga6pABPkxzQeahFFQMztcTB/KJTo0FCf8GazcKCkzjYE+v5rYfM qSOQ== X-Gm-Message-State: AFqh2koUYtnNVvKAfY3MmcolmT52IhqkCr0Tcyr1n+dZJvl9efh3u4YW hSSxmlZLnIqolP6OW65XFR7pAg== X-Received: by 2002:a2e:a54d:0:b0:27f:c95e:7619 with SMTP id e13-20020a2ea54d000000b0027fc95e7619mr7240352ljn.13.1672659722099; Mon, 02 Jan 2023 03:42:02 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c20-20020ac24154000000b0048a8c907fe9sm4356397lfi.167.2023.01.02.03.42.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 03:42:01 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Cc: Krzysztof Kozlowski Subject: [PATCH 5/8] arm64: dts: qcom: sdm850-lenovo-yoga-c630: Use proper WSA881x shutdown GPIO polarity Date: Mon, 2 Jan 2023 12:41:49 +0100 Message-Id: <20230102114152.297305-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230102114152.297305-1-krzysztof.kozlowski@linaro.org> References: <20230102114152.297305-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753911001414119166?= X-GMAIL-MSGID: =?utf-8?q?1753911001414119166?= The WSA881x shutdown GPIO is active low (SD_N), but Linux driver assumed DTS always comes with active high. Since Linux drivers were updated to handle proper flag, correct the DTS. The change is not backwards compatible with older Linux kernel. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts index f32b7445f7c9..25d167cb5e7f 100644 --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts @@ -788,7 +788,7 @@ swm: swm@c85 { left_spkr: speaker@0,3 { compatible = "sdw10217211000"; reg = <0 3>; - powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>; + powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_LOW>; #thermal-sensor-cells = <0>; sound-name-prefix = "SpkrLeft"; #sound-dai-cells = <0>; @@ -796,7 +796,7 @@ left_spkr: speaker@0,3 { right_spkr: speaker@0,4 { compatible = "sdw10217211000"; - powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>; + powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_LOW>; reg = <0 4>; #thermal-sensor-cells = <0>; sound-name-prefix = "SpkrRight"; From patchwork Mon Jan 2 11:41:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 38100 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4122560wrt; Mon, 2 Jan 2023 03:44:25 -0800 (PST) X-Google-Smtp-Source: AMrXdXtU55HUpxz1aKgvekp7Q8akErY8OtOBvZDEcvthb3dnk/F2N5GZCbL/KduTlsiY4HbFLlB1 X-Received: by 2002:a62:6483:0:b0:577:7cfb:a896 with SMTP id y125-20020a626483000000b005777cfba896mr37143481pfb.31.1672659865522; Mon, 02 Jan 2023 03:44:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672659865; cv=none; d=google.com; s=arc-20160816; b=U7qvYIUSOx3Gk19HczHGIfs12ZefBUKFtXVrnNjKE0VlIL/Sd30Pw6V6Lb25Y1ca5h mVNdXHupP7zbq83AvLKk7ypiz/zBVSukoI0FCj/BBU6ygD+gkquJOdPvBfYYYjtiIlLZ eKu8J0Cq7G0rHQMO5bvqwLA7R70Q91ZVhyOzZ4WflwQrdCydPJ5nSXz5QODEuOkhFZZ7 pE1Iw+DSIlCSsP/rrHQxH+WAMpSkH7aQkcRg2VbeEomOfOXXaOBkXdba409AsJ6MTNQl hjZjB+nwIoR86VOJH4o98e7+cDIJ39A8JSPqiWtw6v+tkv6dFYFsDM5RWbnWsUUkrI+G bmhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=M7DFtOEQGDvLwuUrCQkDtvWR1xrXOtoaEkWgZ64uacE=; b=WHQ3tYl6kXEv7wC2xChBfYCXg/0n8NyLihmA50bhWaN0vniBk9Caeb0aOetmXcXjPw x0b2ONg8Wj7MLn5mAXx80eAD0cIbrUkQqi4RlQvjjcCjTLIV5TSDvUFPou2M0AXldIj+ GG2bdZuAlvS5mtZ41OrKhyvwKkLvmb3870gXafwmVjNeP5Ou4bDDrFGYcEQD6ItxNBfQ QNins7gY0xH5ccCsIIjIWvujPTMBcxE1hMN7de7fcQ38bLmPVkfeJrwWjgAmN2tTvQrh /N41NSozhykPgOCyH/NwlawQ2NUkp5Bot4hgPqq9KiyI2p0Lt/9JkK7Toc04lVX4iU4E ePog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pAESxmZq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f65-20020a625144000000b005750d19295esi27009488pfb.369.2023.01.02.03.44.14; Mon, 02 Jan 2023 03:44:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pAESxmZq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232855AbjABLmb (ORCPT + 99 others); Mon, 2 Jan 2023 06:42:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232870AbjABLmF (ORCPT ); Mon, 2 Jan 2023 06:42:05 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7FD3F66 for ; Mon, 2 Jan 2023 03:42:03 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id bf43so41252217lfb.6 for ; Mon, 02 Jan 2023 03:42:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M7DFtOEQGDvLwuUrCQkDtvWR1xrXOtoaEkWgZ64uacE=; b=pAESxmZqzAulg8x3sh2OZEaZmiaXyD7bnR4gfS0oPCHgWp7B9PaNXpAl2QtI4rLYjB 2CavhcZ5REDROwzAIu0bJwpx60tFdY6w+H1KNuXe418nv5U7R7ZBGe68tsBJjzQJpOTA c9y5j3H9QzHDJkuIcdKK0wCB7+xONDKBiqa7btuO41Vw+stxTM7gtUMo+yuyMidqm5c1 dg7cycmzXZJTHUfmFqCmXHlnY4U2BVO23JVM6Phd/N8DBhEEK56DL1Xv+Jj1GOaVujoq Q4IUTCWRrp0yv+Y+bQMpU7AvL8Kg+vOe85MwXs0l0vIXf04nRstEVdb2aHUNJyfHVMzy IAfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M7DFtOEQGDvLwuUrCQkDtvWR1xrXOtoaEkWgZ64uacE=; b=ouTt94Vha+R1tH7J3qkS3kQGcqAjdvczw/X6v1h3+AqaaK68dPD0QK/PpDxfVWicBq 0p0Mp1jGSFcjDz8FKPx1ZpmAKCr35PJeZ5sXTD7QcfckBDntWswlCcXpvaEO1uWdxBux pLOwcO6wM5SL5PRBGdMn3AJ8ybR9h/7BRoFiN1vXa9ihrooaH7MJkCiPdZkauQlei6Ed YbWpJ9qg52rzKhOlr507KrVmqqV0onNgz+bECVvq/xOTB4OcoqkV8lpT6/3IsMsBqOzY qLczXC6WdHRchAsAe9//+hMIKfaRJct1/oqBCXUGBn1p60EY4Gb+r8wq9X4DGOJQ4hy1 r1Ng== X-Gm-Message-State: AFqh2krlBgnkJnBZAwPQnEKvD7k6pNws44MxdIcDNQ3zzwfBQ8KsAlVA eajIP/luEBrB1rwIWmlw54fC3A== X-Received: by 2002:a05:6512:3d0a:b0:4a4:68b7:d65c with SMTP id d10-20020a0565123d0a00b004a468b7d65cmr12398011lfv.67.1672659723363; Mon, 02 Jan 2023 03:42:03 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c20-20020ac24154000000b0048a8c907fe9sm4356397lfi.167.2023.01.02.03.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 03:42:02 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Cc: Krzysztof Kozlowski Subject: [PATCH 6/8] arm64: dts: qcom: sdm850-samsung-w737: Use proper WSA881x shutdown GPIO polarity Date: Mon, 2 Jan 2023 12:41:50 +0100 Message-Id: <20230102114152.297305-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230102114152.297305-1-krzysztof.kozlowski@linaro.org> References: <20230102114152.297305-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753910990969188676?= X-GMAIL-MSGID: =?utf-8?q?1753910990969188676?= The WSA881x shutdown GPIO is active low (SD_N), but Linux driver assumed DTS always comes with active high. Since Linux drivers were updated to handle proper flag, correct the DTS. The change is not backwards compatible with older Linux kernel. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts index daca1e0ad62a..1980080fffa7 100644 --- a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts +++ b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts @@ -720,7 +720,7 @@ swm: swm@c85 { left_spkr: speaker@0,3 { compatible = "sdw10217211000"; reg = <0 3>; - powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>; + powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_LOW>; #thermal-sensor-cells = <0>; sound-name-prefix = "SpkrLeft"; #sound-dai-cells = <0>; @@ -728,7 +728,7 @@ left_spkr: speaker@0,3 { right_spkr: speaker@0,4 { compatible = "sdw10217211000"; - powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>; + powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_LOW>; reg = <0 4>; #thermal-sensor-cells = <0>; sound-name-prefix = "SpkrRight"; From patchwork Mon Jan 2 11:41:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 38102 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4122634wrt; Mon, 2 Jan 2023 03:44:39 -0800 (PST) X-Google-Smtp-Source: AMrXdXuQZCl6gW+6DWbwxhOr0oQnUTK6tHXXmI6uOyEi9eg/lgc8c5yynaakU9EiqHjKoYZ+mGQi X-Received: by 2002:a17:902:f145:b0:192:48cb:3429 with SMTP id d5-20020a170902f14500b0019248cb3429mr39061874plb.67.1672659878770; Mon, 02 Jan 2023 03:44:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672659878; cv=none; d=google.com; s=arc-20160816; b=ITdARel2iKkRz3bsb+2tJ8sx08SUn/ZwaNIZODt7Kthi/pWVUq2e2Zn6m+X+yr1WhI 0F4hYQEYls83Gy+ONz9rIwGA/AKaiB7eJnP6VCa+RbpKH42gppnI8OTSV6s3J3azSuDO XTbcdLmROPpJ2E5Pdi/9ngQ7I9WvxaFs9XvHvuHAlgxTKZDIZnBLHbKBibXNBNbxGmtl 5kUtABJmBqFTouXFzlZXJBdzzmU2I6dlJA4N0zF8WXYUrNB4DUO0hi8SFwI9vqNUNDw4 2bAA/4vtin81CFOFhmD+L5kWF/ROCWaBf2ciE5+1cq5k3/GLIC94LW+Z2DtLhD02LPI7 thMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=s0DGttLpYO77MEtgPKeJIho/3p0G8MvI4IyRdGCB7vI=; b=e274zBbTmDXdB5sKPjSj4lccD4I0xwZb6ccZXJSDqnVhT+5UnAAHLgcCLF2XPJ9o4K xwI8AJguNPUPpT5n9+VOFgwJ+YGQ22Q2M3H9nl/zRE5ehHBPcO+MCREQIWIqsO1PBEz6 8YGkNzKHEy9k7G0fOoWRqTEDqEKmUDesAJW09BlcL9Z3RcypVgO9Gahq61mtOzqgFgSW 1Mz6t6S5CwFJsz+0dyy9cMobo7nJhRVF27NNSlSRPzyJwwcuusb83E99hEaBgGtEu6dy SatZ0+U4PTy1PjxRdM8v+Hk+S7MXmg1DHq/eD2/eI+qJ4LyOTH1oiZYHGJatUvmged7U cjMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zqwcpag5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b14-20020a170902650e00b00188a7401d89si28195147plk.481.2023.01.02.03.44.27; Mon, 02 Jan 2023 03:44:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zqwcpag5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232531AbjABLmh (ORCPT + 99 others); Mon, 2 Jan 2023 06:42:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232930AbjABLmH (ORCPT ); Mon, 2 Jan 2023 06:42:07 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4911DE86 for ; Mon, 2 Jan 2023 03:42:06 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id y25so41247382lfa.9 for ; Mon, 02 Jan 2023 03:42:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s0DGttLpYO77MEtgPKeJIho/3p0G8MvI4IyRdGCB7vI=; b=zqwcpag510R0I1O97o6VuVZ7eDegAgifXOQ6W3qLAzENOo8o5qW4rN02gCLAL6dCsu 2up8OZSLUB52nq77A6YT/Cn8+3bwlzh65dK0BuXJ/yf9BbkmocISqvy3/YFOz5PN0ms3 LNBJAao0LkVySQAdAqQTKxYPoz8Bti1VKoKKN691D6hEVgX5JHjhncSMwWmYt41eueFp Bkr+iuNDg1KfXAjvSJem4BQmHAiTMKQEMofOWgGFfvukDZKK2efqVXZcDzHPq1C+bjIC 9ou629mojNGDu9SLn1cOVK3U5kv/bx2gUXOSMvBHnPfs6F385ErLc81fHO7dR8ezmH+3 16ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s0DGttLpYO77MEtgPKeJIho/3p0G8MvI4IyRdGCB7vI=; b=UqfCP29xn2W6mkQ6Mk3ZLqlIACs1puoc4VLN06u/1aRqpywmv1pYAVqwuu8rWSZNC8 eCz/YyNXNtuVFmQoiUwtl/Joud3ghDEgKTX43DXqKNhWPgvn6bARx69hq52s+/b8mPr6 Uglbfcun5DFLde/mE7OtGbNcHIzqj1P1a27Dwg3v3wTsAQqb/k0sZJmit6gqSYHfp+yL 6Xy4noOi4krmaLNSAZQ+wpDxBkEV4Ed0GARZHrc3RPm+OGNpfEvaODkCkQCji5UFU9RB Om7B5Hz9LqjcBAEcgjimtC1dmg3HuOhuoTbinJYBPMOC4ApFvIMibgK+95ka8/YfVe3F CxVw== X-Gm-Message-State: AFqh2kqMslgeTa6MJaedvgePB6+hngs4VVdGTIkwxGwEPXdTQ1FLgypX pOljR/bDfood/R/P7bq3YCFqXw== X-Received: by 2002:a05:6512:3f19:b0:4cb:780:813a with SMTP id y25-20020a0565123f1900b004cb0780813amr8558425lfa.13.1672659724660; Mon, 02 Jan 2023 03:42:04 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c20-20020ac24154000000b0048a8c907fe9sm4356397lfi.167.2023.01.02.03.42.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 03:42:04 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Cc: Krzysztof Kozlowski Subject: [PATCH 7/8] arm64: dts: qcom: sm8250-mtp: Use proper WSA881x shutdown GPIO polarity Date: Mon, 2 Jan 2023 12:41:51 +0100 Message-Id: <20230102114152.297305-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230102114152.297305-1-krzysztof.kozlowski@linaro.org> References: <20230102114152.297305-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753911004770481310?= X-GMAIL-MSGID: =?utf-8?q?1753911004770481310?= The WSA881x shutdown GPIO is active low (SD_N), but Linux driver assumed DTS always comes with active high. Since Linux drivers were updated to handle proper flag, correct the DTS. The change is not backwards compatible with older Linux kernel. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm8250-mtp.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts index 3ed8c84e25b8..f3669c1a311e 100644 --- a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts @@ -760,7 +760,7 @@ &swr0 { left_spkr: speaker@0,3 { compatible = "sdw10217211000"; reg = <0 3>; - powerdown-gpios = <&tlmm 26 GPIO_ACTIVE_HIGH>; + powerdown-gpios = <&tlmm 26 GPIO_ACTIVE_LOW>; #thermal-sensor-cells = <0>; sound-name-prefix = "SpkrLeft"; #sound-dai-cells = <0>; @@ -769,7 +769,7 @@ left_spkr: speaker@0,3 { right_spkr: speaker@0,4 { compatible = "sdw10217211000"; reg = <0 4>; - powerdown-gpios = <&tlmm 127 GPIO_ACTIVE_HIGH>; + powerdown-gpios = <&tlmm 127 GPIO_ACTIVE_LOW>; #thermal-sensor-cells = <0>; sound-name-prefix = "SpkrRight"; #sound-dai-cells = <0>; From patchwork Mon Jan 2 11:41:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 38103 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4122687wrt; Mon, 2 Jan 2023 03:44:48 -0800 (PST) X-Google-Smtp-Source: AMrXdXsF9f0298569w6kT5Bc5qFoTqaqn7CVJO4wSeP4mOKR5yFeqIrDbNh5vyhrOKwMe32Pulpl X-Received: by 2002:a05:6a20:6704:b0:a3:d847:c776 with SMTP id q4-20020a056a20670400b000a3d847c776mr39983741pzh.0.1672659888339; Mon, 02 Jan 2023 03:44:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672659888; cv=none; d=google.com; s=arc-20160816; b=Hm860CVOKBt+pMd3IR1CAnPLsQi2bp12yxd/hYyY9otLDCquxgm/UrC75WZjJHcLIq Z1HZaG1bycWYylF+2HhjozygrNzkcqHy7cxuYOlpmTxTMgl6hnp/q8NdqBqTnN9kV2KT LKDN5MuXYC8Uolb5C37LqsoIwBa9WsBoIQ/lyTzRG/SucuthYI+VnkfLtShWk+loMOlR +ROmKA8qO03YwL6NjesD9DeW0w/tVzzYli6glZr7vS/PXQBwmUwn/ahVhkGgduJOSafO 70A4eybqJywrj7z4j5PnZZW/oe+qoEWE+FeYTDB/wdlABWhCbyg0wnhulwoZpt6dAzJy GmzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qhbiyazKqrVG6CgQo0Lo7FTo8Pu36wyTx9eEnoPfuPs=; b=RZHNUC8AtV+BWh6C8MNA2Jw+DMC93Y87YjHrlylUkJ2Sd5Z+KX3UyvCV1YnKPbW7oU 7JhuczbZppsrQQj1/tMWt2N0OZrflXIOpWjo9+5pr6efRBZlNACyCXMkhA6NcYKu0yYa vVhKs1I8pV8ZdULvCLQ92q9MpXX3lFzcrV5E4QV85K9d8i7kkLMvKHF4WXvtXcWa09sB zvYK2V9lY+EQTtVRkrDoumT91ARmagST3LDT4tNnyte3W0sq4qGyJgJs79BxloJ/gzx5 Dm575J/KAzVItFd6Vnu50P2U6x0nRaLo/ALc6IKsgOAdUSrg3ybJkqjaFWQ6v4YfZ9AC DBZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KPenZeSb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 35-20020a631863000000b00477257f2f01si29386770pgy.339.2023.01.02.03.44.36; Mon, 02 Jan 2023 03:44:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KPenZeSb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232752AbjABLmj (ORCPT + 99 others); Mon, 2 Jan 2023 06:42:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232956AbjABLmI (ORCPT ); Mon, 2 Jan 2023 06:42:08 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 751F5F0D for ; Mon, 2 Jan 2023 03:42:06 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id p36so41230970lfa.12 for ; Mon, 02 Jan 2023 03:42:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qhbiyazKqrVG6CgQo0Lo7FTo8Pu36wyTx9eEnoPfuPs=; b=KPenZeSbjXIiU2I1mwvFnabRBJSzvy4GXBXa8vjN1r0VIuumtfAXVFLeumSTbBxbFD qCghJbdlfn+GmQ3dym2GQW7cIVES2d/hQp6ItUTb8Ib2i/Oi4WvLcbd3dIePeuA37MNg xxn8dFloOYzWkWHGCQ7dNNmrV+Q1noZsHqwrvwK583jCFzVSz9i775OMzFIjmVk0Hto4 8qzd9AIYtReGsWFxqfoP2MDYnbdHkqdhIzUE5Bbl33F5pHvh6KRUn3gtCAyvfChJM3Cz +DtCECE6eZINTvzzrEEd+dTDTTrGcuNwIt8dIBYve1T7Dem4fFREPLPQcq7VS1IF5htf nQxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qhbiyazKqrVG6CgQo0Lo7FTo8Pu36wyTx9eEnoPfuPs=; b=QhH/qoxcZnoEN0aNy3fptDKhDEK5XDyevn4zaq7U9GxGL2PpQbE4fW9hGvXyEiu/bh lt4fFB0k5QHnxJU7ijksw80hry5YY/8ewSTb/1X6x++svZRaYt17rK86/jef4HoaPpRY kd3/mjcb7lafDX/XY25pjz2zU5z/UkgbHNpVaLoLGnrM9S+RU6MlR0/2tkFw4V2s8Usu l0XqAOW1vdheKGvOQK7xCqjF4W+5Nk01lV/VsJyL34XYt0pyg0Xa6vHQ9+PZNvJnME3C U/soGYkymysH4DzRiEMFqqsrsG8J2nqUmt3Lkr84z0jLrWLHuxgjesbNbUx+PTx2vhxu vSPg== X-Gm-Message-State: AFqh2kpmp4EnaVPz0dGISDtgwTOQ8CD5o0+mDKx0kOLrkjfdYSgTQnXY GRvrHlbsJ2pZ2gFkZ0/LzoCSTQ== X-Received: by 2002:ac2:599d:0:b0:4b5:b8a9:b42c with SMTP id w29-20020ac2599d000000b004b5b8a9b42cmr10424407lfn.17.1672659725890; Mon, 02 Jan 2023 03:42:05 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c20-20020ac24154000000b0048a8c907fe9sm4356397lfi.167.2023.01.02.03.42.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 03:42:05 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Cc: Krzysztof Kozlowski Subject: [PATCH 8/8] arm64: dts: qcom: qrb5165-rb5: Use proper WSA881x shutdown GPIO polarity Date: Mon, 2 Jan 2023 12:41:52 +0100 Message-Id: <20230102114152.297305-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230102114152.297305-1-krzysztof.kozlowski@linaro.org> References: <20230102114152.297305-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753911014929902275?= X-GMAIL-MSGID: =?utf-8?q?1753911014929902275?= The WSA881x shutdown GPIO is active low (SD_N), but Linux driver assumed DTS always comes with active high. Since Linux drivers were updated to handle proper flag, correct the DTS. The change is not backwards compatible with older Linux kernel. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts index 8c64cb060e21..5c510d59c054 100644 --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts @@ -1010,7 +1010,7 @@ &swr0 { left_spkr: speaker@0,3 { compatible = "sdw10217211000"; reg = <0 3>; - powerdown-gpios = <&tlmm 130 GPIO_ACTIVE_HIGH>; + powerdown-gpios = <&tlmm 130 GPIO_ACTIVE_LOW>; #thermal-sensor-cells = <0>; sound-name-prefix = "SpkrLeft"; #sound-dai-cells = <0>; @@ -1019,7 +1019,7 @@ left_spkr: speaker@0,3 { right_spkr: speaker@0,4 { compatible = "sdw10217211000"; reg = <0 4>; - powerdown-gpios = <&tlmm 130 GPIO_ACTIVE_HIGH>; + powerdown-gpios = <&tlmm 130 GPIO_ACTIVE_LOW>; #thermal-sensor-cells = <0>; sound-name-prefix = "SpkrRight"; #sound-dai-cells = <0>;