From patchwork Thu Dec 29 16:40:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 37446 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2490528wrt; Thu, 29 Dec 2022 08:44:34 -0800 (PST) X-Google-Smtp-Source: AMrXdXsjMC6AyZurAOxjipTfpnv1NzWk8TEpIpWBvcrmjqfz0/DWH6Z3d701lP561kIrPaLgmiz0 X-Received: by 2002:a17:902:8ec7:b0:192:52d6:7fc7 with SMTP id x7-20020a1709028ec700b0019252d67fc7mr27995208plo.63.1672332274645; Thu, 29 Dec 2022 08:44:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672332274; cv=none; d=google.com; s=arc-20160816; b=b9LqHSu/VIfzMsTOuakeFSqQw+pXCtRJBY/AcxUwUDJW85rtmOx0hXHPproHZpv40A HVNQGsZ+6W48AausZH2my2ZL2fIZvC2zE4QKQdsKdh/qV0CzO+oiqZa+odvd/f8ayVP+ pQAwQvghnl0feU9zNJii6sWiaMtcVe8JBmJqjTTNVc48A5FTGjCb5Lm4HJcnjO3+bor3 gTUSExX5YOOPqjT5Xo6ZUIkm+yfSE5U86pPm3EX79+kv//l5CHk7/mtIp5KyRjtwQ7Lp 1Bh9SsriuPzmd0t3/Ck3hH+I5YwI4MGfMNHYX3ODLThtYkKai1e6Vqt6249TyZzlLRRe E8sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=tzCYnkSXa1e5jyrDt4wYjR1XASYwDDuOd8wscs2Y04E=; b=Uws8EpKYXzFBmG0ucaJX8lyO2N0MRIkckc12U9mRaivSDjhK/v4rj30h4hDDdj17Xo ZLI/CVvmYCEnqvmoyMl2djvRZc0LJv4oKKgdV7/xVgn/nQJ0d4CVVsNDg+0jlxekiYyf mjJ6KybSHB+sj51Jf+Qo5rWpSL5AgWusLoNx0mTR3TJHu4FQU0d+zcc9TTvsnF2mAP/h Kc43w930Y0e7cdw7FOhUvsxeqP6UjJyZwA/+rZbhZKBG1CZo8xIma3ymy8Jln2wENdfk 06bMcJSUt/1m5sdifsnxDeYgHtkx2kYmOp/oULgVEGGnV/c6FaXSeaSlQwFl5D+d9Jyg Dkag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=HJ1S10xO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z20-20020a1709028f9400b00183243c7a2dsi18272612plo.406.2022.12.29.08.44.21; Thu, 29 Dec 2022 08:44:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=HJ1S10xO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233387AbiL2Qlz (ORCPT + 99 others); Thu, 29 Dec 2022 11:41:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233666AbiL2Qlv (ORCPT ); Thu, 29 Dec 2022 11:41:51 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.215]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7F913B1E6 for ; Thu, 29 Dec 2022 08:41:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=tzCYn kSXa1e5jyrDt4wYjR1XASYwDDuOd8wscs2Y04E=; b=HJ1S10xOVVOEyFWN+GmwO Axjm1zniYJEjEANk7/YxnVRt3dg4I4hwn3ozC0bxK8895YzbwXLbmuepHLR7L1YF RND4kWk3LRDdCYZnk5dsj2HCuA6UnmRlxLJt5ROzpi9qOxRFy22x2chKTzNC66VX GKjIxoXyzltkFtZzFufphw= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g2-1 (Coremail) with SMTP id _____wAnRQL+wq1j1rN9AA--.49187S2; Fri, 30 Dec 2022 00:40:31 +0800 (CST) From: Zheng Wang To: dhowells@redhat.com Cc: marc.dionne@auristor.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, alex000young@gmail.com, security@kernel.org, Zheng Wang Subject: [PATCH] afs: Fix poential UAF in afs_make_call Date: Fri, 30 Dec 2022 00:40:29 +0800 Message-Id: <20221229164029.3009754-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wAnRQL+wq1j1rN9AA--.49187S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Jr1UJryfZw45Xw1fCFyfWFg_yoW3twc_C3 42gryvk345WF1ak3WSgF4ay3yIga1UWFs5Kr4ftFWSqa45Aw17Cw1v9r1vyFn8Wr48Kr98 JrsFgFyDCryIgjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRZucM3UUUUU== X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiXAbmU1Xl5PpoLQAAsE X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753567486889037707?= X-GMAIL-MSGID: =?utf-8?q?1753567486889037707?= There is a function call : afs_fs_get_capabilities calls afs_make_call, in afs_make_call, if error occurs in rxrpc_kernel_send_data, it will call afs_put_call twice, which will free the call. And the access of call->state will trigger a use-after-free bug. Signed-off-by: Zheng Wang --- fs/afs/rxrpc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/afs/rxrpc.c b/fs/afs/rxrpc.c index c62939e5ea1f..4871210c4b81 100644 --- a/fs/afs/rxrpc.c +++ b/fs/afs/rxrpc.c @@ -422,8 +422,7 @@ void afs_make_call(struct afs_addr_cursor *ac, struct afs_call *call, gfp_t gfp) call->rxcall = NULL; } if (call->async) { - if (cancel_work_sync(&call->async_work)) - afs_put_call(call); + cancel_work_sync(&call->async_work); afs_put_call(call); }