From patchwork Tue Dec 27 08:00:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 36784 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1281313wrt; Tue, 27 Dec 2022 00:17:01 -0800 (PST) X-Google-Smtp-Source: AMrXdXtKxWyMmzS1fudrl2hUZqQyTZB55yaRwTNCBqCFFCzEHjeWgwtMDg7H+LqVT47aj2tWDKhg X-Received: by 2002:a17:906:c2cb:b0:842:32e9:f1e9 with SMTP id ch11-20020a170906c2cb00b0084232e9f1e9mr13614975ejb.69.1672129021617; Tue, 27 Dec 2022 00:17:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672129021; cv=none; d=google.com; s=arc-20160816; b=gTIfZPdsvxHAFuo22k5I9xt74bIrxUXzNWBvqG2Tgvd11rHbyypPwX/3XeWweECT8F xwvWLUmS/8LGWjN6sB3nyGi2JOAibMn4wkeug3hxMn6RWvPPoFLg3pq/YOG2c0sya6U6 n/t3Rc2Q+gYbWfu3JDGaUxp+LRRuprHGNFvYOZOXfipSucV4fNqskdCdk0j18OG+gJwn eXQ4aaxgKHIXjxBXStXY3WM5PUdu6ewzOvFC/O8RuVTt61uDZ+Wk0giWRO15EA1jgSpV M5+uCNZGxP5DkaobGIiZw6AVego2btHucPJmAuaoQCMESbAh+BgPWffJU+IIBy9i2bZU ZiKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=BEBRi7o7havXJLgq4Lhd4ZqFEDBVoqgePGRsV7KOwsM=; b=lqC5u+FXOKvYg3Ux3EZWWaXiAyCsp/eHosSmBt8ipCWkhQPUUCot5uodRFb+cACo8V tdcKUGDHK57+6iUpUHzMoI2TBC1WzlJDDPxcY1utLEotzQ1Z+IukZWYjXd9m1Nrs3IJB CDMyep+IwaGTdWfz7wJ039UL5arI200hZ4hlI43A2A7wMbMQmYteDUs0ucZ45l0tWGab xMEBYP8kJUxvCxwcqAK63t9i4GNq43GlIknetsAG1+hJcj5fzvcF/phItubmDWmP2MS6 LE+4NnkYo0RT9txM8dqcBYDPczXfV05OqKpLF4cj0rWHMpdun+P2e7qsPkjPX3EZ38Ea vvTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=QxVY8yjo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hz4-20020a1709072ce400b007c163a17f44si10890994ejc.995.2022.12.27.00.16.37; Tue, 27 Dec 2022 00:17:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=QxVY8yjo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229825AbiL0IBW (ORCPT + 99 others); Tue, 27 Dec 2022 03:01:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229614AbiL0IBT (ORCPT ); Tue, 27 Dec 2022 03:01:19 -0500 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44628114F for ; Tue, 27 Dec 2022 00:01:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1672128061; bh=L7owGmbT1ZxgBvi6fbS8mXVWDglqw6W6df4BA5PYtMM=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type; b=QxVY8yjoKzb0OTh6OmIxWa+uJk9lbvdtIva6tG/qKJiCZplp9WSDt6le7+JUI+CnL FFs4xPIeVx42lFD3oov338vMc6A6DtGnSXp5zpDA6+RSIJwgiz4vs1aQTtwSZRT700 3PUVumlKzgM2VxuTq1ewiY3ZdkGCGj7dzhY+i73k= Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP via ip-206.mailobj.net [213.182.55.206] Tue, 27 Dec 2022 09:01:01 +0100 (CET) X-EA-Auth: 055MqznYGGdxPOOuTU1LvLH5vLFB+IXYkeGlM26BeEaHaWLHphe/AO32mkbpjHKL2tQxrFN4WIgzNiFSMaanFHsHZ6uFhWf9 Date: Tue, 27 Dec 2022 13:30:53 +0530 From: Deepak R Varma To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar , Deepak R Varma Subject: [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753354360996867594?= X-GMAIL-MSGID: =?utf-8?q?1753354360996867594?= Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy factory file operations structure and function wrapping at runtime. As a replacement, a combination of DEFINE_DEBUGFS_ATTRIBUTE macro paired with debugfs_create_file_unsafe() is suggested to be used instead. The DEFINE_DEBUGFS_ATTRIBUTE utilises debugfs_file_get() and debugfs_file_put() wrappers to protect the original read and write function calls for the debug attributes. There is no need for any runtime proxy file operations to be managed by the debugfs core. This Change is reported by the debugfs_simple_attr.cocci Coccinelle semantic patch. Signed-off-by: Deepak R Varma Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/display/intel_fbc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.34.1 diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c index b5ee5ea0d010..4b481e2f908b 100644 --- a/drivers/gpu/drm/i915/display/intel_fbc.c +++ b/drivers/gpu/drm/i915/display/intel_fbc.c @@ -1809,10 +1809,10 @@ static int intel_fbc_debugfs_false_color_set(void *data, u64 val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(intel_fbc_debugfs_false_color_fops, - intel_fbc_debugfs_false_color_get, - intel_fbc_debugfs_false_color_set, - "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(intel_fbc_debugfs_false_color_fops, + intel_fbc_debugfs_false_color_get, + intel_fbc_debugfs_false_color_set, + "%llu\n"); static void intel_fbc_debugfs_add(struct intel_fbc *fbc, struct dentry *parent) @@ -1821,8 +1821,8 @@ static void intel_fbc_debugfs_add(struct intel_fbc *fbc, fbc, &intel_fbc_debugfs_status_fops); if (fbc->funcs->set_false_color) - debugfs_create_file("i915_fbc_false_color", 0644, parent, - fbc, &intel_fbc_debugfs_false_color_fops); + debugfs_create_file_unsafe("i915_fbc_false_color", 0644, parent, + fbc, &intel_fbc_debugfs_false_color_fops); } void intel_fbc_crtc_debugfs_add(struct intel_crtc *crtc)