From patchwork Mon Dec 26 21:46:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 36706 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1102414wrt; Mon, 26 Dec 2022 13:48:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXufetHqpa+4tdidFi/N50EKz55rCTtHM14+G7CYPs5pbXmxxBW0DC5kJ47SoEOjFdoY/rPI X-Received: by 2002:a05:6a20:8e10:b0:a4:a73e:d1e2 with SMTP id y16-20020a056a208e1000b000a4a73ed1e2mr30132461pzj.57.1672091294033; Mon, 26 Dec 2022 13:48:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672091294; cv=none; d=google.com; s=arc-20160816; b=Itlj8YjA6qwNQjbBDqXoM9+jBYpLm/hLTnscS8Y758lVwTvTdqpX7kimXoNMJvIqlc hN2bvk2XHS5qNQQCBHBzOFM+yMwYWj8HcuBl/y+zN89c/HccKz821kgYVpoS3b/NeF0n tW7qMZFu2JdlHF6EU9fiv0CUi1JGCgLGrppWoAy8ejJq1oTHoIpYLcPawS6MDdqQ0wI8 jO28NalGkW0/IFfCJoAVSp7IrfO4GrLG3piefAAW8qxMWW2UiQDB0lW/VAvX8lpU25AT brzsAIfpHpR7Mk+brhsC+T7CMbq2q9rdDOsf4tJdVex99Up7FcValf4PR88LjyRJbTB0 towQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=rKsradsR1qNIDtKy7iZzhnI6sTf0ohOoWP+lvLxzTq4=; b=aLZhUG4RrqEyUaha8h5EYTCvCGwMzCpx/BNTiDSfQf3OTFSk/PT6xrbW2GuVYsq2tt 3Odz1Q6Oul5kJD5MzV667Q/3Gdo+4OiK+4QU36FoDSjzeCLiuZ1UBxBeZl1oSaRUM71L 9U4jidNiYHBZwQglwjlVHYwQbJp9Yj5w/kTAEKHwns8Ywa8xTSnzF5J+8PQkBUH/szf0 q1fLHyvByXeVfMvh3V2SiTSq+rwMuIrYPsJm9FldM5wprFQjMrSTuSu9YFTsjFKwj8JX 2FZTSbnShpTMNS2tXUOswKwdUtAoefo2lwoOjOyYSiW8nInazepuCn+trC20zQ/ihRiF jC8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vZQ+UoSh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v64-20020a638943000000b00477e0e4d2fbsi12329566pgd.412.2022.12.26.13.47.58; Mon, 26 Dec 2022 13:48:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vZQ+UoSh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232340AbiLZVq6 (ORCPT + 99 others); Mon, 26 Dec 2022 16:46:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229614AbiLZVq5 (ORCPT ); Mon, 26 Dec 2022 16:46:57 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74D4010D3; Mon, 26 Dec 2022 13:46:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=rKsradsR1qNIDtKy7iZzhnI6sTf0ohOoWP+lvLxzTq4=; b=vZQ+UoShfOG3nPX/VfYIFRRGqS I9jlRS5DOX6pcGT1fgJnZ37IkuhjsH+a1cA3uCVAQw4IHt+cW0rpk6W/iVapO8LmXXUV9DB6XdJQu Ah6FppWhkefWF/IQAsIqQnk4ljiKppQiWjEkx+VbL8Jk/TOjgm7O9LA4zGXzwY1U3Wy6pKCrIrHMd p/D/Ov5JX7ZM+78S6uaPF7Z1CxNG/UHV5UTnMwxBKsmct1pd9DwTuS8G5+GPfanmN3E2uEQ97Gun9 IzOUKP7C2ZO01N0wKzzTIlEmfid3Tjx1Epj/Zta4A0UAB6g+g0q7VtTN8GDiRWVMVscHi+wpNU8I1 9g8uOq/g==; Received: from [2601:1c2:d80:3110::a2e7] (helo=casper.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1p9vJD-007YPp-PO; Mon, 26 Dec 2022 21:47:00 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Benjamin Tissoires , Jiri Kosina , Basavaraj Natikar , linux-input@vger.kernel.org Subject: [PATCH -next] HID: amd-sfh-hid: also depends on INPUT Date: Mon, 26 Dec 2022 13:46:44 -0800 Message-Id: <20221226214644.17339-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753314800575957144?= X-GMAIL-MSGID: =?utf-8?q?1753314800575957144?= AMD_SFH_HUB selects HID, which depends on INPUT, but since 'select' does not follow any dependency chains, AMD_SFH_HUB should also depend on INPUT. Fixes multiple kconfig warnings and 90+ build errors (samples): WARNING: unmet direct dependencies detected for HID Depends on [m]: HID_SUPPORT [=y] && INPUT [=m] Selected by [y]: - AMD_SFH_HID [=y] && HID_SUPPORT [=y] && (X86_64 || COMPILE_TEST [=y]) && PCI [=y] Selected by [m]: - I2C_HID_CORE [=m] && HID_SUPPORT [=y] - USB_HID [=m] && HID_SUPPORT [=y] && USB [=y] && INPUT [=m] WARNING: unmet direct dependencies detected for INPUT_VIVALDIFMAP Depends on [m]: INPUT [=m] Selected by [y]: - HID_VIVALDI [=y] && HID_SUPPORT [=y] && HID [=y] WARNING: unmet direct dependencies detected for INPUT_FF_MEMLESS Depends on [m]: INPUT [=m] Selected by [y]: ERROR: modpost: "input_ff_create_memless" [drivers/hid/hid-logitech.ko] undefined! ERROR: modpost: "input_ff_create_memless" [drivers/hid/hid-mf.ko] undefined! ERROR: modpost: "input_ff_create_memless" [drivers/input/misc/gpio-vibra.ko] undefined! ERROR: modpost: "input_ff_create_memless" [drivers/input/misc/regulator-haptic.ko] undefined! riscv64-linux/bin/riscv64-linux-ld: hid-input.c:(.text+0x77e): undefined reference to `input_event' riscv64-linux/bin/riscv64-linux-ld: hid-input.c:(.text+0xac2): undefined reference to `input_allocate_device' riscv64-linux/bin/riscv64-linux-ld: hid-input.c:(.text+0xba8): undefined reference to `input_free_device' riscv64-linux/bin/riscv64-linux-ld: hid-input.c:(.text+0xf4c): undefined reference to `input_scancode_to_scalar' Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation") Fixes: 7e41b2e9776d ("HID: force HID depending on INPUT") Signed-off-by: Randy Dunlap Cc: Benjamin Tissoires Cc: Jiri Kosina Cc: Basavaraj Natikar Cc: linux-input@vger.kernel.org --- drivers/hid/amd-sfh-hid/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -- a/drivers/hid/amd-sfh-hid/Kconfig b/drivers/hid/amd-sfh-hid/Kconfig --- a/drivers/hid/amd-sfh-hid/Kconfig +++ b/drivers/hid/amd-sfh-hid/Kconfig @@ -1,10 +1,11 @@ # SPDX-License-Identifier: GPL-2.0-or-later menu "AMD SFH HID Support" depends on X86_64 || COMPILE_TEST - depends on PCI + depends on PCI && INPUT config AMD_SFH_HID tristate "AMD Sensor Fusion Hub" + depends on INPUT select HID help If you say yes to this option, support will be included for the