From patchwork Wed Oct 5 04:23:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 1711 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp429804wrs; Tue, 4 Oct 2022 21:23:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Gqw/ZqnVtL9SctmQRqQP/ZigQlbbnapZ/J1MKqCZ7BJ8Xb5AT5l+GYTCM2zO2hCjHScJ9 X-Received: by 2002:a17:907:94ce:b0:78c:6795:d545 with SMTP id dn14-20020a17090794ce00b0078c6795d545mr8352188ejc.530.1664943810794; Tue, 04 Oct 2022 21:23:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664943810; cv=none; d=google.com; s=arc-20160816; b=WeipKIjKmO5+8Orsb74IRX6T46kkYY09DZ902cHvv5pspjhd0OI4t0f9plMEgWbVf8 e+KjBZwkWne3U9WwaM4tXvXqLE8/BrahRJT8fqpxPTGFHJhEIDe5K+NSZ0J5ip81g4sS Xl9ABGs7KnolX3aDc5CyzCXOEV+aQFGMONZNoOTOoZ91S24cp9WJUOcDUSCpkRHW4fmq em5/sV5OBwQJIAiLxmPFZGDsaAvBTzKPHnRXb/917ra1S16Kb77RGPQCaSaNaWAF+StG J1qaigBbwEvsaJ0ENhCFlQhCbUvEOEcIVE/t+OggEm5+1v4fcJZTvWuqQRj4qoUKe+/0 ujPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=1UPybI7aqXzIhXv9nLnlhQIWdgJn9AW2nyvKyRNhEms=; b=aFwzOFEOx/wTh+mGQOjCco3moYZZ/FY+lxNfPEwU/u6po6oWJo6IZAE/KlGSlWXYZE 2lSP00ueGRabXurQINwZeJF8XezA0oWbbCoYZsBe8zeL3kUoBw8hU9WE52BLIrEVlnc9 B2phwfMEvPWmj74Aqva32x4jMty+SCxTF8t/MK5p28prNOWgR8/ANI42N1W5FGryow8Q vu7yHOpEyMOzPxQyeRqxDBY6Cqu8aEbAjfMjNXQ5v08wx/L9zrid3hBnLH08P1dhwx0n eRkJ45seDw7eM7tNUTYLdSejBcQC93mvDsve1R2tQhDnSKXY5CTVHm0hwCAUNlnI47Lz pMfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b="L//7jpdG"; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id cr11-20020a170906d54b00b00783602ab27bsi12802701ejc.33.2022.10.04.21.23.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 21:23:30 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b="L//7jpdG"; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3FB323858C2C for ; Wed, 5 Oct 2022 04:23:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3FB323858C2C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664943809; bh=1UPybI7aqXzIhXv9nLnlhQIWdgJn9AW2nyvKyRNhEms=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=L//7jpdGC0WIIP7P/ncyGK1otWAMoFhI+zUe2CPVOoOJgkZSK1dyKo6WnksdXrSrv 8OdLOggSchRtz46YJEXSvX2sinoNxbWMXTEfLlj6eRdgdUU6mqTEg7SAYlcIzrmcxC cTfrm/YnakgyGvIh3NjmyxYXA28a3PBWjMsGYSb4= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id B86F03858294 for ; Wed, 5 Oct 2022 04:23:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B86F03858294 Received: by mail-pf1-x42a.google.com with SMTP id w191so5431104pfc.5 for ; Tue, 04 Oct 2022 21:23:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=1UPybI7aqXzIhXv9nLnlhQIWdgJn9AW2nyvKyRNhEms=; b=3TYRQu58Q90+cdLQiDhkXOeCnjrd772Aki5rnLcto2Vtl23ZmtjGaqVhJPju+/NbQR GAiVEjs2Rys9ehCMU41k8n30PbPQxGhRH7+hHWNq7CkvVcr1bnKgPUO8t9bJA3WUQinL ti8Ri+y0jCdCjmGy9sb8nZOOhIj7t+p0cYrBGbhvA7K0F3mOgDbz8hSUjRDQ/lAdjjg2 NTO5hxd/ZuAB1Qyfjw08Re3yFHVRTBSEfDlXhZ/KgBgITCad8tLolARV2MgUjE0qvb5u h2v5VYBBejOiQVTIZRi5BVRSoFGUF67j12+DlU0t66ysn+lJCMDcnXb2787ijHF0Q5bF 1sRw== X-Gm-Message-State: ACrzQf1Qg0Bf8zvD2C94iSxdT+ad54YClED+qsfCN59qnZ0+7xYUzOCn FojdybAgLuAT6f0ORMYBEWPpH7oWejQ= X-Received: by 2002:a63:194b:0:b0:457:7295:8de0 with SMTP id 11-20020a63194b000000b0045772958de0mr3181139pgz.612.1664943798113; Tue, 04 Oct 2022 21:23:18 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id e126-20020a621e84000000b005360da6b26bsm10063901pfe.159.2022.10.04.21.23.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 21:23:17 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 3049F114311D; Wed, 5 Oct 2022 14:53:15 +1030 (ACDT) Date: Wed, 5 Oct 2022 14:53:15 +1030 To: binutils@sourceware.org Subject: PR29647, objdump -S looping Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3036.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1745820121261995161?= X-GMAIL-MSGID: =?utf-8?q?1745820121261995161?= Fuzzed input with this in .debug_line [0x0000003b] Special opcode 115: advance Address by 8 to 0x401180 and Line by -2 to -1 PR 29647 * objdump.c (print_line): Don't decrement line number here.. (dump_lines): ..do so here instead, ensuring loop terminates. diff --git a/binutils/objdump.c b/binutils/objdump.c index 6610906f83e..f7b4695c3e8 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -2069,7 +2069,6 @@ print_line (struct print_file_list *p, unsigned int linenum) const char *l; size_t len; - --linenum; if (linenum >= p->maxline) return; l = p->linemap [linenum]; @@ -2088,7 +2087,9 @@ dump_lines (struct print_file_list *p, unsigned int start, unsigned int end) { if (p->map == NULL) return; - while (start <= end) + if (start != 0) + --start; + while (start < end) { print_line (p, start); start++;